rjmccall added a comment.
In https://reviews.llvm.org/D26196#593741, @yaxunl wrote:
> >> It seems the casting from a pointer to different address space is not
> >> affected by this change. When a null pointer is casted to different
> >> address space, it is casted the same way as an ordinary po
coby created this revision.
coby added reviewers: m_zuckerman, rnk, myatsina.
coby added a subscriber: cfe-commits.
coby set the repository for this revision to rL LLVM.
(I|G)CC will adjust a missing size qualifier on an indirect memory reference
according to a certain logic, which is presented o
Author: logan
Date: Sun Nov 13 08:42:15 2016
New Revision: 286759
URL: http://llvm.org/viewvc/llvm-project?rev=286759&view=rev
Log:
[CMake] Fix libc++abi arm build w/o libunwind.
This commit fixes libc++abi build when LLVM unwinder (libunwind_llvm) is
not enabled.
This commit fixes the problem b
logan closed this revision.
logan added a comment.
Thanks. Committed as https://reviews.llvm.org/rL286759.
https://reviews.llvm.org/D24082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: logan
Date: Sun Nov 13 08:44:41 2016
New Revision: 286760
URL: http://llvm.org/viewvc/llvm-project?rev=286760&view=rev
Log:
arm: Fix ttype encoding assertion failure.
GCC 4.7 or newer emits 0x90 (indirect | pcrel) as the ttype encoding.
This would hit an assertion in cxa_personality.cpp.
logan closed this revision.
logan added a comment.
Thanks for reviewing. Committed as https://reviews.llvm.org/rL286760.
https://reviews.llvm.org/D24085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
k-wisniewski created this revision.
k-wisniewski added reviewers: dergachev.a, dcoughlin, zaks.anna.
k-wisniewski added a subscriber: cfe-commits.
Hi,
I've been working on a checker that uses RegionChanges interface and needed to
access to LocationContext. Another change is an easy way to obtai
k-wisniewski created this revision.
k-wisniewski added reviewers: zaks.anna, dcoughlin, dergachev.a.
k-wisniewski added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
This is the very first version of a checker that aims to find cases of infinite
recursion. It relies on Add Locati
Author: ericwf
Date: Sun Nov 13 13:54:31 2016
New Revision: 286774
URL: http://llvm.org/viewvc/llvm-project?rev=286774&view=rev
Log:
Fix PR30979 - tuple is constructible from move_only const&
Modified:
libcxx/trunk/include/tuple
libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnst
Author: ericwf
Date: Sun Nov 13 14:43:50 2016
New Revision: 286779
URL: http://llvm.org/viewvc/llvm-project?rev=286779&view=rev
Log:
Implement LWG 2770 - Make tuple_size defined for all T
Modified:
libcxx/trunk/include/__tuple
libcxx/trunk/include/tuple
libcxx/trunk/test/std/utilitie
EricWF created this revision.
EricWF added reviewers: mclow.lists, chandlerc.
EricWF added a subscriber: cfe-commits.
The title says it all.
I just want to check that we agree on the general direction of this patch.
Specifically that libc++ should be free to apply `no_discard` where we feel
app
chandlerc added a comment.
I think we want dedicated macros to disable each added [[nodiscard]]. The
reason is that as you add each one, users will have to roll out cleanups for
the new warnings. This may be hard to do quickly and cause problems updating
libc++ for users with -Werror in their b
Author: ericwf
Date: Sun Nov 13 16:27:00 2016
New Revision: 286783
URL: http://llvm.org/viewvc/llvm-project?rev=286783&view=rev
Log:
Fix GCC libc++abi build
Modified:
libcxxabi/trunk/CMakeLists.txt
libcxxabi/trunk/test/lit.site.cfg.in
Modified: libcxxabi/trunk/CMakeLists.txt
URL:
http:/
Author: ericwf
Date: Sun Nov 13 16:27:00 2016
New Revision: 286783
URL: http://llvm.org/viewvc/llvm-project?rev=286783&view=rev
Log:
Fix GCC libc++abi build
Modified:
libcxx/trunk/CMakeLists.txt
libcxx/trunk/test/libcxx/compiler.py
libcxx/trunk/test/libcxx/test/config.py
libcxx/tr
Author: ericwf
Date: Sun Nov 13 17:00:30 2016
New Revision: 286784
URL: http://llvm.org/viewvc/llvm-project?rev=286784&view=rev
Log:
Add docs for use-configurable libc++ features
Modified:
libcxx/trunk/docs/UsingLibcxx.rst
Modified: libcxx/trunk/docs/UsingLibcxx.rst
URL:
http://llvm.org/vie
Friendly ping. Any further thoughts on this suggested warning?
On Sat, Nov 5, 2016 at 1:48 PM Manuel Klimek wrote:
> +richard
>
> On Fri, Oct 14, 2016 at 10:18 AM Joshua Hurwitz via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> See attached.
>
> Returning a bool from main is a special c
teemperor planned changes to this revision.
teemperor added a comment.
- I ran all real-world tests (sqlite, etc.) before rebasing to trunk. I'm not
100% confident that I correctly merged everything, so I'll rerun them just in
case. The normal clang test-suite passes, so it looks good.
https:/
teemperor updated the summary for this revision.
teemperor updated this revision to Diff 77759.
teemperor added a comment.
- Rebased patch to the current trunk state.
- Replaced runtime polymorphism with templates.
- Constraint interface now only has one method signature.
https://reviews.llvm.or
mclow.lists added a comment.
In https://reviews.llvm.org/D26596#593948, @chandlerc wrote:
> I think we want dedicated macros to disable each added [[nodiscard]].
My concern here is that I expect that there will be a lot of these.
Off the top of my head, I can name:
- Every smart pointer's `get
mclow.lists added a comment.
Note: I'm not unsympathetic to the situation that Chandler describes; I just
don't want to manage a potentially unbounded (but probably more than 20) set of
macros.
https://reviews.llvm.org/D26596
___
cfe-commits maili
EricWF retitled this revision from "[RFC] Add _LIBCPP_NO_DISCARD and apply it
to unique_ptr::release()" to "[RFC] Add _LIBCPP_NO_DISCARD and apply it to
`Container::empty()`, `unique_ptr::release()`, and `Lockable::try_lock()` ".
EricWF updated the summary for this revision.
EricWF updated this
EricWF updated this revision to Diff 77761.
EricWF added a comment.
- Add missing newlines in added tests.
https://reviews.llvm.org/D26596
Files:
docs/UsingLibcxx.rst
include/__config
include/__mutex_base
include/forward_list
include/list
include/map
include/memory
include/mutex
EricWF updated this revision to Diff 77762.
EricWF added a comment.
- Apply no-discard to `string_view::empty()` and friends.
- Fix discarded use of `unique_ptr::release()` within libc++.
https://reviews.llvm.org/D26596
Files:
docs/UsingLibcxx.rst
include/__config
include/__hash_table
i
EricWF updated this revision to Diff 77763.
EricWF added a comment.
- Fix even more instances of `unique_ptr::release()` with a discarded value.
Hopefully this is the last of them.
https://reviews.llvm.org/D26596
Files:
docs/UsingLibcxx.rst
include/__config
include/__hash_table
include
EricWF updated this revision to Diff 77764.
EricWF added a comment.
- Fix tests containing discarded values.
- Fix two more instances of discarded `unique_ptr::release()` in the headers.
https://reviews.llvm.org/D26596
Files:
docs/UsingLibcxx.rst
include/__config
include/__hash_table
in
nemanjai added inline comments.
Comment at: lib/Headers/altivec.h:11908
+#define vec_extract4b(__a, __b)
\
+ vec_reve((vector unsigned long long)
\
+__builtin_vsx_xxextractuw
Author: compnerd
Date: Sun Nov 13 19:55:54 2016
New Revision: 286788
URL: http://llvm.org/viewvc/llvm-project?rev=286788&view=rev
Log:
__cxa_demangle: ensure that we have a mangled symbol
Ensure that we have a mangled symbol before attempting to demangle it. We would
previously treat any input a
nemanjai added inline comments.
Comment at: lib/Headers/altivec.h:314
+ vector signed int __carry = __c & __mask;
+ return vec_add(vec_add(__a, __b), __mask);
+}
I don't understand why we're adding `__mask` to the sum of `__a` and `__b`.
Shouldn't that be `__c
Author: ericwf
Date: Sun Nov 13 20:51:30 2016
New Revision: 286791
URL: http://llvm.org/viewvc/llvm-project?rev=286791&view=rev
Log:
Fix CMake set syntax
Modified:
libcxx/trunk/lib/abi/CMakeLists.txt
Modified: libcxx/trunk/lib/abi/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/libc
Author: ericwf
Date: Sun Nov 13 21:03:13 2016
New Revision: 286792
URL: http://llvm.org/viewvc/llvm-project?rev=286792&view=rev
Log:
Fix ABI configuration detection on OS X
Modified:
libcxx/trunk/lib/abi/CMakeLists.txt
Modified: libcxx/trunk/lib/abi/CMakeLists.txt
URL:
http://llvm.org/viewv
Author: compnerd
Date: Sun Nov 13 21:07:47 2016
New Revision: 286793
URL: http://llvm.org/viewvc/llvm-project?rev=286793&view=rev
Log:
__cxa_demangle: allow demangling invocation blocks
The block invocation function uses an extension where the prefix is ___Z
as opposed to _Z. This should make th
faisalv removed rL LLVM as the repository for this revision.
faisalv updated this revision to Diff 77767.
faisalv marked 4 inline comments as done.
faisalv added a comment.
Addressed Aaron's requests regarding improving formatting and assert messages.
Thanks!
https://reviews.llvm.org/D22997
Fi
EricWF updated this revision to Diff 77769.
EricWF added a comment.
- Add `[[no_discard]]` to various smart pointer observers including `get()` and
`operator*()`.
https://reviews.llvm.org/D26596
Files:
docs/UsingLibcxx.rst
include/__config
include/__hash_table
include/__mutex_base
in
Author: ericwf
Date: Mon Nov 14 01:03:50 2016
New Revision: 286796
URL: http://llvm.org/viewvc/llvm-project?rev=286796&view=rev
Log:
Add explicit (void) cast to result of unique_ptr::release()
Modified:
cfe/trunk/tools/libclang/CIndex.cpp
Modified: cfe/trunk/tools/libclang/CIndex.cpp
URL:
h
34 matches
Mail list logo
