NoQ updated this revision to Diff 76641.
NoQ added a comment.
Try out a completely different approach which was also suggested by Anna.
Allow providing multiple variants of summaries for each function identifier,
with different type specifications and branches. This way we preserve type
checks
nkakuev created this revision.
nkakuev added reviewers: alexfh, mgehre.
nkakuev added a subscriber: cfe-commits.
When clang-tidy suppresses a warning, ignored by NOLINT, it doesn't suppress
related notes. This leads to an assertion/crash, as described in this bug:
https://llvm.org/bugs/show_bug.
malcolm.parsons updated this revision to Diff 76642.
malcolm.parsons added a comment.
clang-format
https://reviews.llvm.org/D26206
Files:
lib/ARCMigrate/FileRemapper.cpp
lib/CodeGen/CGObjCGNU.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Driver.cpp
lib/Driver/Job.cpp
lib/Driver/Tools.cp
zaks.anna updated this revision to Diff 76643.
zaks.anna added a comment.
Addressed the review comments.
I also added ObjC +initialize method to the list because TSan does not observe
the guaranteed synchronization between +initialize and initial object accesses.
https://reviews.llvm.org/D2585
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D26189
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
mboehme updated this revision to Diff 76655.
mboehme added a comment.
- Responses to reviewer comments
https://reviews.llvm.org/D26041
Files:
clang-tidy/misc/UseAfterMoveCheck.cpp
docs/clang-tidy/checks/misc-use-after-move.rst
test/clang-tidy/misc-use-after-move.cpp
Index: test/clang-tid
zaks.anna added a comment.
Please, explain what variants are for in comments.
https://reviews.llvm.org/D25940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme marked 4 inline comments as done.
mboehme added a comment.
Please take another look.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:467
+StringRef getName(const NamedDecl *ND) {
+ if (!ND->getIdentifier())
+return StringRef();
aaron.ballman wrot
Author: pcc
Date: Tue Nov 1 19:08:19 2016
New Revision: 285773
URL: http://llvm.org/viewvc/llvm-project?rev=285773&view=rev
Log:
Bitcode: Change reader interface to take memory buffers.
As proposed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-October/106595.html
This change also f
rsmith added inline comments.
Comment at: include/clang/AST/ExprCXX.h:4256
+/// is dependent.
+class CoawaitDependentExpr : public Expr {
+ SourceLocation KeywordLoc;
Rename -> `DependentCoawaitExpr`, to match our other `Dependent*Expr` classes.
==
Author: eugenezelenko
Date: Tue Nov 1 19:43:23 2016
New Revision: 285778
URL: http://llvm.org/viewvc/llvm-project?rev=285778&view=rev
Log:
[Documentation] Clang-tidy readability-redundant-declaration consistency.
Release notes checks order and consistent Clang-tidy
readability-redundant-declara
Author: rsmith
Date: Tue Nov 1 19:47:52 2016
New Revision: 285779
URL: http://llvm.org/viewvc/llvm-project?rev=285779&view=rev
Log:
More forcibly resolve exception specifications when checking a function
redeclaration in C++1z mode. We need the exception specification in order for
the function's
jordan_rose created this revision.
jordan_rose added reviewers: doug.gregor, rsmith.
jordan_rose added a subscriber: cfe-commits.
jordan_rose set the repository for this revision to rL LLVM.
Previously the following code would warn on the use of `T`:
template
struct X {
typedef T *type;
jordan_rose created this revision.
jordan_rose added reviewers: doug.gregor, rsmith.
jordan_rose added a subscriber: cfe-commits.
jordan_rose set the repository for this revision to rL LLVM.
jordan_rose added dependencies: D26226: Don't require nullability on template
parameters in typedefs., D258
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D26197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Thanks.
https://reviews.llvm.org/D24085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
On 10/30/16 01:57, Brad Smith via cfe-commits wrote:
On 10/25/16 19:34, Brad Smith via cfe-commits wrote:
On 10/18/16 22:13, Brad Smith via cfe-commits wrote:
On Fri, Oct 14, 2016 at 09:47:17PM -0400, Brad Smith via cfe-commits
wrote:
On Fri, Oct 14, 2016 at 05:59:54PM -, Ed Maste via cfe-
EricWF created this revision.
EricWF added a reviewer: rsmith.
EricWF added a subscriber: cfe-commits.
[expr.cast.static] states:
> 3. A glvalue of type “cv1 T1” can be cast to type “rvalue reference to cv2
> T2” if “cv2 T2” is reference-compatible with “cv1 T1”. The result refers to
> the obje
Author: ericwf
Date: Tue Nov 1 22:57:34 2016
New Revision: 285786
URL: http://llvm.org/viewvc/llvm-project?rev=285786&view=rev
Log:
Fix __libcpp_is_constructible for source types with explicit conversion
operators.
Previously __libcpp_is_constructible checked the validity of reference
construct
Author: ericwf
Date: Wed Nov 2 00:08:58 2016
New Revision: 285788
URL: http://llvm.org/viewvc/llvm-project?rev=285788&view=rev
Log:
Fix GCC test failure caused by manually defining _LIBCPP_HAS_NO_VARIADICS
Modified:
libcxx/trunk/include/type_traits
Modified: libcxx/trunk/include/type_traits
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
Seem fine; I'd rename the "FIXME" to a "Note" unless you're going to pass a
flag to Type::canHaveNullability to say how to classify dependent types.
Repository:
rL LLVM
https://r
101 - 121 of 121 matches
Mail list logo
