erikjv updated the summary for this revision.
erikjv updated this revision to Diff 75836.
https://reviews.llvm.org/D25939
Files:
lib/Lex/PPDirectives.cpp
Index: lib/Lex/PPDirectives.cpp
===
--- lib/Lex/PPDirectives.cpp
+++ lib/Le
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D25939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285180: PP: Remove unused parameters from methods (authored
by erikjv).
Changed prior to commit:
https://reviews.llvm.org/D25938?vs=75693&id=75837#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
Author: erikjv
Date: Wed Oct 26 03:52:41 2016
New Revision: 285180
URL: http://llvm.org/viewvc/llvm-project?rev=285180&view=rev
Log:
PP: Remove unused parameters from methods
NFC
Differential Revision: http://reviews.llvm.org/D25938
Modified:
cfe/trunk/include/clang/Lex/Preprocessor.h
c
malcolm.parsons added inline comments.
Comment at: include/clang/AST/TypeLoc.h:533
+} else {
+ BuiltinRange.setBegin(std::min(Range.getBegin(),
BuiltinRange.getBegin()));
+ BuiltinRange.setEnd(std::max(Range.getEnd(), BuiltinRange.getEnd()));
aaron
Author: erikjv
Date: Wed Oct 26 04:58:31 2016
New Revision: 285182
URL: http://llvm.org/viewvc/llvm-project?rev=285182&view=rev
Log:
[PP] Replace some uses of unsigned with size_t
All values are returned by a method as size_t, and subsequently passed
to functions taking a size_t, or used where a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285182: [PP] Replace some uses of unsigned with size_t
(authored by erikjv).
Changed prior to commit:
https://reviews.llvm.org/D25939?vs=75836&id=75841#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: vvassilev
Date: Wed Oct 26 05:24:29 2016
New Revision: 285184
URL: http://llvm.org/viewvc/llvm-project?rev=285184&view=rev
Log:
[modules] PR28812: Modules can return duplicate field decls.
If two modules contain duplicate class definitions the lookup result can contain
more than 2 element
erikjv created this revision.
erikjv added a reviewer: bkramer.
erikjv added a subscriber: cfe-commits.
https://reviews.llvm.org/D25981
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/Pragma.cpp
Index: lib/Lex/Pragma.cpp
===
--
erikjv created this revision.
erikjv added a reviewer: bkramer.
erikjv added a subscriber: cfe-commits.
Herald added subscribers: anna, nemanjai.
While in the area, also change some unsigned variables to size_t, and
introduce an LLVM_FALLTHROUGH instead of a comment stating that.
https://reviews
Author: erikjv
Date: Wed Oct 26 06:46:10 2016
New Revision: 285188
URL: http://llvm.org/viewvc/llvm-project?rev=285188&view=rev
Log:
[PP] Remove another unused parameter
Differential Revision: http://reviews.llvm.org/D25981
Modified:
cfe/trunk/include/clang/Lex/Preprocessor.h
cfe/trunk/l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285188: [PP] Remove another unused parameter (authored by
erikjv).
Changed prior to commit:
https://reviews.llvm.org/D25981?vs=75850&id=75853#toc
Repository:
rL LLVM
https://reviews.llvm.org/D25981
bkramer added inline comments.
Comment at: lib/Lex/PPLexerChange.cpp:43
"Top level include stack isn't our primary lexer?");
- for (unsigned i = 1, e = IncludeMacroStack.size(); i != e; ++i)
-if (IsFileLexer(IncludeMacroStack[i]))
+ for (const IncludeStackInfo &IS
Author: abpostelnicu
Date: Wed Oct 26 02:44:51 2016
New Revision: 285178
URL: http://llvm.org/viewvc/llvm-project?rev=285178&view=rev
Log:
Bug 28065 - clang-format incorrectly aligns backslash.
Modified:
cfe/trunk/lib/Format/WhitespaceManager.cpp
cfe/trunk/unittests/Format/FormatTest.cpp
erikjv updated this revision to Diff 75854.
erikjv marked an inline comment as done.
https://reviews.llvm.org/D25982
Files:
lib/Lex/PPCaching.cpp
lib/Lex/PPLexerChange.cpp
lib/Lex/PPMacroExpansion.cpp
lib/Lex/Pragma.cpp
lib/Lex/TokenConcatenation.cpp
lib/Lex/TokenLexer.cpp
Index: lib
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
sammccall created this revision.
sammccall added a reviewer: bkramer.
sammccall added subscribers: cfe-commits, rsmith.
Extend lifetime of ExceptionTypeStorage, as it is referenced by
CanonicalEPI and used outside the block (ExceptionSpec.Exceptions is an
ArrayRef)
https://reviews.llvm.org/D259
Author: d0k
Date: Wed Oct 26 07:51:45 2016
New Revision: 285192
URL: http://llvm.org/viewvc/llvm-project?rev=285192&view=rev
Log:
Fix use-after-scope in ASTContext.
Extend lifetime of ExceptionTypeStorage, as it is referenced by
CanonicalEPI and used outside the block (ExceptionSpec.Exceptions is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285192: Fix use-after-scope in ASTContext. (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D25983?vs=75860&id=75865#toc
Repository:
rL LLVM
https://reviews.llvm.org/D25983
Files
ABataev added inline comments.
Comment at: lib/Driver/ToolChain.cpp:553-559
+ // "platform" is only used in tests to override CLANG_DEFAULT_CXX_STDLIB
+ if (LibName == "libc++")
+return ToolChain::CST_Libcxx;
+ else if (LibName == "libstdc++")
+return ToolChain::CST_Li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285193: [PP] Replace some index based for loops with range
based ones (authored by erikjv).
Changed prior to commit:
https://reviews.llvm.org/D25982?vs=75854&id=75867#toc
Repository:
rL LLVM
https:/
Author: erikjv
Date: Wed Oct 26 08:06:13 2016
New Revision: 285193
URL: http://llvm.org/viewvc/llvm-project?rev=285193&view=rev
Log:
[PP] Replace some index based for loops with range based ones
While in the area, also change some unsigned variables to size_t, and
introduce an LLVM_FALLTHROUGH in
v.g.vassilev removed rL LLVM as the repository for this revision.
v.g.vassilev updated this revision to Diff 75868.
v.g.vassilev added a comment.
Add another triple we use.
https://reviews.llvm.org/D25604
Files:
lib/Driver/ToolChains.cpp
Index: lib/Driver/ToolChains.cpp
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChain.cpp:553-559
+ // "platform" is only used in tests to override CLANG_DEFAULT_CXX_STDLIB
+ if (LibName == "libc++")
+return ToolChain::CST_Libcxx;
+ else if (LibName == "libstdc++")
+return ToolChain::CST_L
baloghadamsoftware updated this revision to Diff 75875.
baloghadamsoftware added a comment.
Updated according to the comments. Also fixed a bug and moved access check to
pre-call instead of post-call.
https://reviews.llvm.org/D25660
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
xazax.hun created this revision.
xazax.hun added reviewers: zaks.anna, NoQ, a.sidorin, dcoughlin.
xazax.hun added subscribers: cfe-commits, dkrupp, o.gyorgy, szepet.
xazax.hun set the repository for this revision to rL LLVM.
This patch adds a new option to export an optimistic basic block coverage
arphaman updated this revision to Diff 75877.
arphaman added a comment.
The updated patch incorporates John's suggestions into code.
Repository:
rL LLVM
https://reviews.llvm.org/D25937
Files:
lib/Sema/SemaDecl.cpp
test/SemaCXX/warn-everthing.cpp
test/SemaCXX/warn-unused-variables.cpp
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:195
+auto Param = State->getLValue(P, LCtx);
+auto Arg = State->getSVal(CE->getArg(idx++), LCtx->getParent());
+const auto *Pos = getIteratorPosition(State, Ar
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D22374#575579, @NoQ wrote:
> Ping!~ Did my idea sound completely wrong to you? :)
>
> Does https://reviews.llvm.org/D25660 depend on this patch? And/or did you
> find another workaround?
>
> upd.: I also thought that this deserves m
erikjv created this revision.
erikjv added a reviewer: bkramer.
erikjv added a subscriber: cfe-commits.
r276653 suppressed the pragma once warning when generating a PCH file.
This patch extends that to any main file for which clang is told (with
the -x option) that it's a header file. It will also
erikjv created this revision.
erikjv added a reviewer: bkramer.
erikjv added a subscriber: cfe-commits.
If we pass a header to libclang, e.g. because it's open in an editor in
an IDE, warnings about unused const vars are not useful: other files
that include the header might use those constants. So
malcolm.parsons created this revision.
malcolm.parsons added reviewers: klimek, jdennett, alexfh.
malcolm.parsons added a subscriber: cfe-commits.
The matcher
varDecl(hasDescendant(
callExpr(hasDeclaration(functionDecl(unless(isNoThrow()))
didn't match calls from default arguments because
arphaman created this revision.
arphaman added reviewers: aaron.ballman, jordan_rose.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch adds an `objc_subclassing_restricted` attribute into clang. This
attribute acts similarly to 'final'
AlexeySotkin updated this revision to Diff 75893.
AlexeySotkin added a comment.
Setting UnnamedAddr to Global
https://reviews.llvm.org/D25305
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGenOpenCL/private-array-initialization.cl
Index: test/CodeGenOpenCL/private-array-initialization.cl
AlexeySotkin added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
Anastasia wrote:
> AlexeySo
thakis added a comment.
Erik, are you planning on adding the later phases soon? At the moment, due to
this patch, clang emits "enclose 'setAllowsAutomaticWindowTabbing:' in an
@available check to silence this warning" but then errors out when trying to
use @available. This is proving to be conf
Author: cbieneman
Date: Wed Oct 26 10:41:38 2016
New Revision: 285206
URL: http://llvm.org/viewvc/llvm-project?rev=285206&view=rev
Log:
[CMake] Adding example distribution CMake cache files
These cache file are provided as an example of how to set up simple multi-stage
CMake builds. I have a bat
Hi Nico,
All that is left for the diagnostic to make sense it CodeGen support for
@available, which is something I’m working on now. I should have a patch up for
it in a couple days. I suppose it was a mistake to mention upgrading to
something that doesn’t work yet, if this is an inconvenience f
erichkeane updated this revision to Diff 75903.
erichkeane added a comment.
Corrected Decoration settings to match the soon-to-be-updated spec.
https://reviews.llvm.org/D25204
Files:
include/clang-c/Index.h
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDoc
arphaman created this revision.
arphaman added a reviewer: aaron.ballman.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch adds a bit of documentation for the `transparent_union` attribute.
Repository:
rL LLVM
https://reviews.llvm.
erichkeane added a comment.
After much debate, the architects have agreed to change the "Decoration"
section to the following.
The next patch does these, so I'm ready for continued review. Thanks for your
patience!
-Erich
__regcall Decoration
Names of functions that use __regcall are decorate
tstellarAMD added a comment.
LGTM.
https://reviews.llvm.org/D25920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sebpop removed rL LLVM as the repository for this revision.
sebpop updated this revision to Diff 75908.
sebpop added a comment.
The patch also implements the idea that Marshall proposed in:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161010/173780.html
> I have an idea; it involves
sebpop marked 2 inline comments as done.
sebpop added inline comments.
Comment at: libcxx/include/memory:3802
+{
+ return __libcpp_atomic_add(&t, 1, _AO_Relaxed);
+}
EricWF wrote:
> Why add `increment` and `decrement` at all? Just manually inline
> `__libcpp_at
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285211: AMDGPU: Add missing ISA versions gfx7.x.x and 8.x.x.
(authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D25920?vs=75627&id=75912#toc
Repository:
rL LLVM
https://reviews.
Author: yaxunl
Date: Wed Oct 26 11:40:21 2016
New Revision: 285211
URL: http://llvm.org/viewvc/llvm-project?rev=285211&view=rev
Log:
AMDGPU: Add missing ISA versions gfx7.x.x and 8.x.x.
Patch by Laurent Morichetti.
Differential Revision: https://reviews.llvm.org/D25920
Modified:
cfe/trunk/l
rnk added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1263
+On x86 targets, this attribute changes the calling convention to
+__regcall convention. This convention aims to pass as many arguments
+as possible in registers. It also tries to utilize registers for th
jordan_rose added a comment.
Looks good from my end.
Repository:
rL LLVM
https://reviews.llvm.org/D25993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Please add a line testing the nested-array case to warn-unused-variables.cpp,
but with that, LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D25937
__
hiraditya updated this revision to Diff 75915.
hiraditya added a comment.
Added macro to keep the definition of destructor of basic_string in string.cpp
https://reviews.llvm.org/D25624
Files:
libcxx/include/string
libcxx/src/string.cpp
Index: libcxx/src/string.cpp
Anastasia accepted this revision.
Anastasia added a comment.
LGTM! Thanks!
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
If you're working on it, let's just wait for that :-)
On Wed, Oct 26, 2016 at 12:01 PM, Erik Pilkington wrote:
> Hi Nico,
> All that is left for the diagnostic to make sense it CodeGen support for
> @available, which is something I’m working on now. I should have a patch up
> for it in a couple
manmanren accepted this revision.
manmanren added a reviewer: manmanren.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Manman
Repository:
rL LLVM
https://reviews.llvm.org/D25993
___
cfe-commits mailing list
cf
Author: caseycarter
Date: Wed Oct 26 12:22:25 2016
New Revision: 285213
URL: http://llvm.org/viewvc/llvm-project?rev=285213&view=rev
Log:
Silence unused parameter warnings in archetypes.hpp
Reviewed at: https://reviews.llvm.org/D25958
Modified:
libcxx/trunk/test/support/archetypes.hpp
Modif
aaron.ballman requested changes to this revision.
aaron.ballman added inline comments.
This revision now requires changes to proceed.
Comment at: include/clang/Basic/Attr.td:1291
+ let Subjects = SubjectList<[ObjCInterface], ErrorDiag>;
+ let Documentation = [Undocumented];
+}
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:433
Out << Prefix;
+
mangleName(D);
Please remove this stray newline.
Comment at: lib/CodeGen/TargetInfo.cpp:
+ if (classifyArgumentType(FD->getType(),
+
erichkeane marked 8 inline comments as done.
erichkeane added a comment.
New diff coming that fixes Reid & David's comments
https://reviews.llvm.org/D25204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
erichkeane updated this revision to Diff 75919.
https://reviews.llvm.org/D25204
Files:
include/clang-c/Index.h
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/Specifiers.h
include/clang/Basic/TokenKinds.def
lib/AST/Expr.cpp
chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.
Please add a stub tree and tests. You can find similar tests for other Linux
distros in 'tests/Driver'.
https://reviews.llvm.org/D25604
Author: nemanjai
Date: Wed Oct 26 13:25:45 2016
New Revision: 285218
URL: http://llvm.org/viewvc/llvm-project?rev=285218&view=rev
Log:
[PPC] Implement vector reverse elements builtins (vec_reve)
This patch corresponds to review https://reviews.llvm.org/D25906.
Committing on behalf of Tony Jiang.
syzaara created this revision.
syzaara added reviewers: nemanjai, kbarton, amehsan, sfertile, jtony, lei.
syzaara added subscribers: cfe-commits, echristo.
Implement builtins for prototypes:
signed int vec_cntlz_lsbb (vector signed char);
signed int vec_cntlz_lsbb (vector unsigned char);
signed in
aaron.ballman added a comment.
clang-tidy/cert/.LimitedRandomnessCheck.cpp.swo was added and should not have
been; also, there's one minor issue with the diagnostic wording that is still
outstanding.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:35
+ diag(MatchedDec
xazax.hun removed rL LLVM as the repository for this revision.
xazax.hun updated this revision to Diff 75923.
https://reviews.llvm.org/D25985
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/ExprEngine.cpp
test/
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:26
+ unless(hasAnyTemplateArgument(refersToType(voidType(,
+ hasAnyName("::std::plus", "::std::minus", "::std::multiplies",
+ "::std::divides", "::s
CaseyCarter closed this revision.
CaseyCarter added a comment.
Committed as r285213.
https://reviews.llvm.org/D25958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nemanjai
Date: Wed Oct 26 14:27:11 2016
New Revision: 285229
URL: http://llvm.org/viewvc/llvm-project?rev=285229&view=rev
Log:
[PowerPC] Implement vector_insert_exp builtins - clang portion
This patch corresponds to review https://reviews.llvm.org/D25956.
Committing on behalf of Zaara Sye
mclow.lists added inline comments.
Comment at: src/cxa_personality.cpp:363
+ "Unexpected TTypeEncoding");
(void)ttypeEncoding;
logan wrote:
> mclow.lists wrote:
> > It's not clear to me how this accomplishes what you want.
> > You're looking for
rsmith added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:2061-2062
+ auto Builder = Diag(R.getNameLoc(), diagnostic) << Name;
+ if (Name.isIdentifier())
+Builder << SourceRange(R.getNameLoc());
return true;
I'm indifferent on this change: I don't
CaseyCarter created this revision.
CaseyCarter added reviewers: EricWF, mclow.lists.
CaseyCarter added a subscriber: cfe-commits.
CaseyCarter set the repository for this revision to rL LLVM.
Cleanup nonportable behavior in tests for `std::any`
Fixes MS issues 63, 64, and 65.
test/std/utilities/a
CaseyCarter added inline comments.
Comment at: test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp:36
+using DecayTag = std::decay_t;
+static_assert(!std::is_constructible::value, "");
+}
I'm generously calling this a "libc++ extension." From my i
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2509
+to suppress specific clang-tidy warnings. They can be attached to a scope,
+statement or type. The ``[[gsl::suppress]]`` is an alias of
``[[clang::suppress]]``
+which is intended to be used fo
erikjv added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:2061-2062
+ auto Builder = Diag(R.getNameLoc(), diagnostic) << Name;
+ if (Name.isIdentifier())
+Builder << SourceRange(R.getNameLoc());
return true;
rsmith wrote:
> I'm indifferent on this
rsmith added inline comments.
Comment at: include/clang/Lex/Preprocessor.h:283-286
+ Off = 0,
+ Recording = 1,
+ Replaying = 2,
+ Done = 3
What's the difference between the `Off` and `Done` states? They seem to be the
same to me?
==
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:74
+ if (Construct) {
+checkConstruct(SM, Construct, Type, New);
Can elide the braces for the `if` and `else`.
Comment at: clang-tidy/modernize/M
EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.
Comment at: test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp:1
+//===--===//
+//
--
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D25992
___
cfe-commits mailing list
cfe-commits@lists
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for the improved docs!
Repository:
rL LLVM
https://reviews.llvm.org/D25995
___
cfe-commits mailing list
cfe-comm
CaseyCarter removed rL LLVM as the repository for this revision.
CaseyCarter updated this revision to Diff 75936.
CaseyCarter added a comment.
Cleanup nonportable behavior in tests for `std::any`
Fixes MS issues 63, 64, and 65.
test/std/utilities/any/any.class/any.cons/move.pass.cpp:
- "Moves a
CaseyCarter marked 2 inline comments as done.
CaseyCarter added a comment.
DecayTag destroyed.
https://reviews.llvm.org/D26007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: caseycarter
Date: Wed Oct 26 15:18:13 2016
New Revision: 285234
URL: http://llvm.org/viewvc/llvm-project?rev=285234&view=rev
Log:
Cleanup nonportable behavior in tests for std::any
Fixes MS issues 63, 64, and 65.
test/std/utilities/any/any.class/any.cons/move.pass.cpp:
* "Moves are alway
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285234: Cleanup nonportable behavior in tests for std::any
(authored by CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D26007?vs=75936&id=75938#toc
Repository:
rL LLVM
https://revie
EricWF added inline comments.
Comment at: test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp:36
+using DecayTag = std::decay_t;
+static_assert(!std::is_constructible::value, "");
+}
CaseyCarter wrote:
> I'm generously calling this a "libc++ exten
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. I appreciate the doc for each of the magic numbers.
https://reviews.llvm.org/D25483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: malcolm.parsons
Date: Wed Oct 26 15:39:54 2016
New Revision: 285239
URL: http://llvm.org/viewvc/llvm-project?rev=285239&view=rev
Log:
[RecursiveASTVisitor] Visit the implicit expression of a CXXDefaultArgExpr
Summary:
The matcher
varDecl(hasDescendant(
callExpr(hasDeclaration(function
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285239: [RecursiveASTVisitor] Visit the implicit expression
of a CXXDefaultArgExpr (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D25992?vs=75899&id=75944#toc
Reposito
beanz added a comment.
@mgorny, I don't think LLVMgold qualifies as a runtime in the traditional
sense. It more closely aligns with the tools vended by LLVM even though it is a
shared library not an executable.
Runtime libraries are specifically libraries that products of clang are linked
agai
jlebar added a comment.
Hi, Samuel.
This change introduced a new crash / assertion failure in the driver.
$ echo | llvm-run clang -emit-llvm -c -x cuda - -o /dev/null
Before this patch, we get an error (perhaps not as helpful as we might want,
but still):
clang-3.8: error: cannot specify
mgorny added a comment.
In https://reviews.llvm.org/D23754#580268, @beanz wrote:
> @mgorny, I don't think LLVMgold qualifies as a runtime in the traditional
> sense. It more closely aligns with the tools vended by LLVM even though it is
> a shared library not an executable.
>
> Runtime librarie
zaks.anna added a comment.
Please, add multi-file tests and tests where a line is covered more than once.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:262
+
+static void dumpCoverageInfo(llvm::SmallVectorImpl &Path,
+ SourceManager &SM) {
-
malcolm.parsons updated this revision to Diff 75947.
malcolm.parsons added a comment.
Remove braces.
Use Twine.
https://reviews.llvm.org/D25898
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tidy/modernize/MakeSmartPtrCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/moderni
joerg added a comment.
Can we please avoid adding more (pseudo) keywords in the double-underscore name
space? Those tend to be used a lot by existing libc implementations and
existing attribute cases like __strong and __weak have created enough trouble.
https://reviews.llvm.org/D25204
_
sfantao added a comment.
Hi Justin
Thanks for letting me know. I'm looking into it.
Thanks again,
Samuel
Repository:
rL LLVM
https://reviews.llvm.org/D18172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:274
+if (Invalid)
+ continue;
+std::ofstream OutFile(FilePath.c_str());
zaks.anna wrote:
> Would it be better to break if the buffer is invalid?
> Should this be hois
malcolm.parsons updated this revision to Diff 75951.
malcolm.parsons added a comment.
Add more tests.
https://reviews.llvm.org/D25925
Files:
clang-tidy/cert/StaticObjectExceptionCheck.cpp
docs/clang-tidy/checks/cert-err58-cpp.rst
test/clang-tidy/cert-static-object-exception.cpp
Index: te
falho updated this revision to Diff 75935.
falho marked an inline comment as done.
falho added a comment.
removed semicolon, and replaced it with a comma that only appears in .cpp
diagnostics
test cases corrected according to this
removed junk .swo file
https://reviews.llvm.org/D22346
Files:
aaron.ballman added a comment.
In https://reviews.llvm.org/D22346#580242, @falho wrote:
> removed semicolon, and replaced it with a comma that only appears in .cpp
> diagnostics
The semicolon was the correct punctuator to use, but thank you for moving it
into the cpp message.
> test cases co
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D25925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D21840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D21843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
ahatanak updated this revision to Diff 75956.
ahatanak added a comment.
Add the variable to the list of potential captures only if it's declared
outside of the lambda expression. I don't think we need to check that the
variable is declared outside of the lambda because
getStackIndexOfNearestEnc
1 - 100 of 138 matches
Mail list logo
