[PATCH] D25844: [Sema][ObjC] Warn about implicitly autoreleasing indirect parameters that are captured by blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL285031: [Sema][ObjC] Warn about implicitly autoreleasing out-parameters captured (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D25844?vs=75442&id=75650#toc Repository: rL

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

tra updated this revision to Diff 75652. tra marked an inline comment as done. tra added a comment. Addressed remaining nits. https://reviews.llvm.org/D25809 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaDecl.cpp lib/Sem

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

tra added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:791 + CUDAFunctionTarget NewTarget = IdentifyCUDATarget(NewFD); + for (auto OldND : Previous) { +FunctionDecl *OldFD = OldND->getAsFunction(); jlebar wrote: > tra wrote: > > jlebar wrote: > > > If

Re: [libcxx] r249738 - Split out of .

> Sure, go ahead. I committed in r284797 and r284801 (libcxx). There's one minor issue I've found: the changes for the builtins affecting non submodule local visibility broke current users of plain "-fmodules" against our frameworks in public SDKs, in 10.11 & 10.12. I've attached a patch to work a

[PATCH] D25838: [Basic] Support 32-bit x86 and ARM targets for Fuchsia

rsmith accepted this revision. rsmith added a comment. "Instantiate all the templates" all_the_things "with all the types" Repository: rL LLVM https://reviews.llvm

Re: r285027 - Fix test on non-X86 platforms

The test is validating pointer size as well, so it is failing on 32 bits right now. I could try to differentiate some of the check and have them work on both size, but I can’t verify that the runtime works (I don’t have a 32 bits runtime). — Mehdi > On Oct 24, 2016, at 2:48 PM, Craig Topper

r285037 - Link clangCodeGen with clangAnalysis required after r284990.

Author: tra Date: Mon Oct 24 17:52:39 2016 New Revision: 285037 URL: http://llvm.org/viewvc/llvm-project?rev=285037&view=rev Log: Link clangCodeGen with clangAnalysis required after r284990. Fixes build break for configurations that use shared libraries. Modified: cfe/trunk/lib/CodeGen/CMake

[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]

tra added a comment. CodeGen's CMakeLists.txt needs to be updated to link with clangAnalysis now, otherwise it breaks builds that use shared libraries. Fixed in r285037. diff --git a/lib/CodeGen/CMakeLists.txt b/lib/CodeGen/CMakeLists.txt index f5d5d69..9cf34f6 100644 --- a/lib/CodeGen/CMa

[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]

mehdi_amini added a comment. @bkramer : is it an OK dependency to add from a clang point of view? Or should I refactor the patch to avoid introducing it? Repository: rL LLVM https://reviews.llvm.org/D25888 ___ cfe-commits mailing list cfe-commit

r285038 - [Basic] Support 32-bit x86 and ARM targets for Fuchsia

Author: phosek Date: Mon Oct 24 17:55:57 2016 New Revision: 285038 URL: http://llvm.org/viewvc/llvm-project?rev=285038&view=rev Log: [Basic] Support 32-bit x86 and ARM targets for Fuchsia Fuchsia has experimental support for 32-bit x86 and ARM targets, add them to the list of supported targets.

[PATCH] D25838: [Basic] Support 32-bit x86 and ARM targets for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL285038: [Basic] Support 32-bit x86 and ARM targets for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D25838?vs=75496&id=75656#toc Repository: rL LLVM https://review

Re: [libcxx] r249738 - Split out of .

On Mon, Oct 24, 2016 at 3:30 PM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > > Sure, go ahead. > > I committed in r284797 and r284801 (libcxx). There's one minor issue > I've found: the changes for the builtins affecting non submodule local > visibility broke current users of plain "-f

[PATCH] D25928: [cfi] Enable cfi-icall on ARM and AArch64.

eugenis created this revision. eugenis added a reviewer: pcc. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson. Backend support added in https://reviews.llvm.org/D25927

Re: r285027 - Fix test on non-X86 platforms

Hi Mehdi, it's also failing on aarch64: http://lab.llvm.org:8011/builders/clang-cmake-aarch64-42vma/builds/47 And current build was still red. Not to mention all arm bots. Maybe reverting and trying offline next time. I can help you with arm environments, if you need. Cheers, Renato On 24 Oct

[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

rsmith added a comment. In https://reviews.llvm.org/D25817#576276, @arphaman wrote: > This code does perform recovery, but the constructed AST for the destructor > calls is different from the AST that would have been constructed if the code > was correct: we still end up building the pseudo des

r285042 - Add dependency from clangCodeGen to clangAnalysis

Author: mehdi_amini Date: Mon Oct 24 18:38:32 2016 New Revision: 285042 URL: http://llvm.org/viewvc/llvm-project?rev=285042&view=rev Log: Add dependency from clangCodeGen to clangAnalysis This is unbreaking the build with shared library after r285019. Modified: cfe/trunk/lib/CodeGen/CMakeLis

r285041 - test/CodeGen/builtins.c: reinstate #ifdef __x86_64__ around __builtin_longjmp

Author: mehdi_amini Date: Mon Oct 24 18:38:24 2016 New Revision: 285041 URL: http://llvm.org/viewvc/llvm-project?rev=285041&view=rev Log: test/CodeGen/builtins.c: reinstate #ifdef __x86_64__ around __builtin_longjmp Unadvertently removed in r285019 Modified: cfe/trunk/test/CodeGen/builtins.c

Re: [libcxx] r249738 - Split out of .

On Mon, Oct 24, 2016 at 4:17 PM, Richard Smith wrote: > On Mon, Oct 24, 2016 at 3:30 PM, Bruno Cardoso Lopes > wrote: >> >> > Sure, go ahead. >> >> I committed in r284797 and r284801 (libcxx). There's one minor issue >> I've found: the changes for the builtins affecting non submodule local >> vis

[PATCH] D21508: Make friend function template definition available if class is instantiated.

rsmith added a comment. The model that the C++ standard seems to have settled on is that a friend function declaration that's instantiated from a definition is considered to be a definition, even if we've not instantiated its body yet. I think we should try to directly implement that rule. =

[PATCH] D25909: [analyzer] MacOSXApiChecker: Disallow dispatch_once predicates on heap and in ivars.

zaks.anna added a comment. Looks good overall! https://reviews.llvm.org/D25909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Minor nit below. Thanks for iterating so much on this! Anna. Comment at: test/Analysis/number-object-conversion.cpp:46 +#ifdef PEDANTIC + if (p) {} // expected-warnin

r285047 - Fix handling of %% format specifier in os_log builtins.

Author: mehdi_amini Date: Mon Oct 24 19:48:48 2016 New Revision: 285047 URL: http://llvm.org/viewvc/llvm-project?rev=285047&view=rev Log: Fix handling of %% format specifier in os_log builtins. Returning `false` was stopping the parsing of further arguments, which wasn't intended. Modified:

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

mehdi_amini created this revision. mehdi_amini added a reviewer: dexonsmith. mehdi_amini added a subscriber: cfe-commits. We're only doing it with -flto currently, however it never "hurt" to pass it, and users that are linking without -flto can get in trouble if one of the dependency (a static lib

<    1   2