tra updated this revision to Diff 75511.
tra marked 5 inline comments as done.
tra added a comment.
addressed jlebar's comments.
https://reviews.llvm.org/D25845
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaCUDA.cpp
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaTemplate.cpp
test/SemaCUDA/fun
mehdi_amini added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:951
Init = ParseInitializer();
+ Init = Actions.CorrectDelayedTyposInExpr(Init.get());
What happens when there is no typo correction to apply?
https://reviews.llvm.o
tra added inline comments.
Comment at: include/clang/Sema/Sema.h:9396
+ CUDAFunctionTarget IdentifyCUDATarget(const FunctionDecl *D,
+bool IgnoreImplicitHDAttr = false);
CUDAFunctionTarget IdentifyCUDATarget(const AttributeList *Attr);
jlebar added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5628
case AttributeList::AT_CUDAHost:
-handleSimpleAttributeWithExclusions(S, D,
- Attr);
+if (!D->hasAttr())
+ handleSimpleAtt
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added inline comments.
Comment at: lib/Sema/SemaCUDA.cpp:87
+
+ if ((HasHostAttr && HasDeviceAttr) || ForceCUDAHostDeviceDepth > 0)
+return CFT_HostDevice;
jlebar wrote:
> Checking ForceCUDAHostDeviceDepth here is...yeah. Especially because the
> other
tra updated this revision to Diff 75515.
tra marked 5 inline comments as done.
tra added a comment.
addressed jlebar's comments.
https://reviews.llvm.org/D25809
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaCUDA.cpp
lib/Sema/SemaDecl.cpp
lib/
tra updated this revision to Diff 75516.
tra added a comment.
removed pragma check from IdentifyCUDATarget for real.
https://reviews.llvm.org/D25809
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaCUDA.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaOve
phosek added a comment.
@EricWF is this fine with you?
Repository:
rL LLVM
https://reviews.llvm.org/D25491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:951
Init = ParseInitializer();
+ Init = Actions.CorrectDelayedTyposInExpr(Init.get());
mehdi_amini wrote:
> What happens when there is no typo correction to apply?
If the
Author: rsmith
Date: Fri Oct 21 20:32:19 2016
New Revision: 284905
URL: http://llvm.org/viewvc/llvm-project?rev=284905&view=rev
Log:
[c++1z] P0012R1: Implement a few remaining pieces: downgrade diagnostic for
mismatched dynamic exception specifications in expressions from an error to a
warning, si
Author: rsmith
Date: Fri Oct 21 20:32:45 2016
New Revision: 284906
URL: http://llvm.org/viewvc/llvm-project?rev=284906&view=rev
Log:
Add another testcase missed from r284905.
Added:
cfe/trunk/test/CXX/dcl.decl/dcl.init/dcl.init.ref/p4.cpp
Added: cfe/trunk/test/CXX/dcl.decl/dcl.init/dcl.init.
Author: rsmith
Date: Fri Oct 21 20:35:34 2016
New Revision: 284907
URL: http://llvm.org/viewvc/llvm-project?rev=284907&view=rev
Log:
Mark P0012R1 as "Partial" since it's now substantially complete.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://l
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: CMakeLists.txt:331
+ # not a constexpr in C++11 but is in C++14, so we use C++14 with musl.
+ set(LIBCXX_STANDARD_VER c++14)
+endif()
Thi
jlebar accepted this revision.
jlebar added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaCUDA.cpp:87
+
+ if ((HasHostAttr && HasDeviceAttr) || ForceCUDAHostDeviceDepth > 0)
+return CFT_HostDevice;
tra wrote:
> jl
mgrang created this revision.
mgrang added reviewers: hans, mkuper, rengolin.
mgrang added a subscriber: cfe-commits.
mgrang added a project: clang-c.
https://reviews.llvm.org/D25893
Files:
test/CodeGen/ms-mm-align.c
test/CodeGen/windows-on-arm-stack-probe-size.c
Index: test/CodeGen/windows
majnemer created this revision.
majnemer added reviewers: rnk, pcc.
majnemer added a subscriber: cfe-commits.
getClassAtVTableLocation hunts through virtual bases without using the
MDC layout which is indicative of a bug.
Instead, reuse the getVFPtrOffsets machinery to calculate which
subobject w
majnemer added a comment.
You could use `llvm::any_of` instead of `std::any_of`.
Comment at: clang/include/clang/Analysis/Analyses/OSLog.h:84-86
+ result |= 0x01;
+if (getIsPublic())
+ result |= 0x02;
IsPublic/IsPrivate instead of magic numbers?
mehdi_amini updated this revision to Diff 75524.
mehdi_amini added a comment.
Address David's feedback. Thanks David!
https://reviews.llvm.org/D25888
Files:
clang/include/clang/Analysis/Analyses/FormatString.h
clang/include/clang/Analysis/Analyses/OSLog.h
clang/include/clang/Basic/Builtin
majnemer added inline comments.
Comment at: clang/include/clang/Analysis/Analyses/OSLog.h:117-129
+return std::any_of(
+Items.begin(), Items.end(),
+[](const OSLogBufferItem &item) { return item.getIsPrivate(); });
+ }
+
+ bool getHasPublicItems() const {
+
101 - 120 of 120 matches
Mail list logo
