rogfer01 updated this revision to Diff 75395.
rogfer01 added a comment.
Mark comment as TODO
https://reviews.llvm.org/D23657
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaChecking.cpp
test/Sema/address-packed.c
Index: test/Sema/address-packed.c
===
Author: rengolin
Date: Fri Oct 21 03:03:49 2016
New Revision: 284811
URL: http://llvm.org/viewvc/llvm-project?rev=284811&view=rev
Log:
Revert "DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type'
rules."
This reverts commit r284800, as it failed all ARM/AArch64 bots.
Removed:
On 21 October 2016 at 03:36, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Thu Oct 20 21:36:37 2016
> New Revision: 284800
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284800&view=rev
> Log:
> DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules.
Hi Richa
sdardis created this revision.
sdardis added subscribers: rnk, bruno, ahatanak, cfe-commits.
Herald added a reviewer: vkalintiris.
This patch teaches clang to perform implicit scalar to vector conversions
when one of the operands to a binary vector expression is a scalar like GCC.
The scalar is i
arphaman updated this revision to Diff 75403.
arphaman added a comment.
The updated patch improves error handling and adds a test for the fixit.
> If we issue a fixit we should recover as-if the code was written with the
> fixit in. Does this code do that? (can we test it? I know we test some fi
sepavloff updated this revision to Diff 75404.
sepavloff added a comment.
Addressed reviewr's notes.
https://reviews.llvm.org/D25816
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/cxx0x-initialize
Author: d0k
Date: Fri Oct 21 05:19:37 2016
New Revision: 284815
URL: http://llvm.org/viewvc/llvm-project?rev=284815&view=rev
Log:
Remove non-existing file from modulemap.
This picked up a builtin header if it happened to be available.
Modified:
cfe/trunk/test/Modules/Inputs/libc-libcxx/sysr
sepavloff marked 5 inline comments as done.
sepavloff added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1762
def err_init_incomplete_type : Error<"initialization of incomplete type %0">;
+def err_list_init_in_parens : Error<"list-initializer for non-c
arphaman updated this revision to Diff 75405.
arphaman added a comment.
Fix a typo in the fixit test.
Repository:
rL LLVM
https://reviews.llvm.org/D25817
Files:
lib/Sema/SemaExprCXX.cpp
test/CXX/special/class.dtor/p10-0x.cpp
test/FixIt/fixit.cpp
test/SemaCXX/pseudo-destructors.cpp
I
arphaman updated this revision to Diff 75408.
arphaman marked an inline comment as done.
arphaman added a comment.
The updated patch includes positive test cases.
Repository:
rL LLVM
https://reviews.llvm.org/D25820
Files:
lib/Sema/SemaChecking.cpp
test/SemaObjC/format-strings-objc.m
In
arphaman added a subscriber: rsmith.
arphaman added a comment.
LGTM, I added Richard in case he has something to add.
> I chose to retain current clang behavior and reject questionable code. GCC
> patch that introduced this message explains using warning by some
> uncertainty, 5 years passed, I
sepavloff added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4231
+const CXXConstructorDecl *Constructor = nullptr;
+if (const ConstructorUsingShadowDecl *CSD =
+dyn_cast(ND)) {
Use `auto` here. Type of `CSD` is clear from `dy
NoQ updated this revision to Diff 75411.
NoQ marked 5 inline comments as done.
NoQ added a comment.
Address review comments. Add the forgotten tests.
https://reviews.llvm.org/D25731
Files:
lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp
test/Analysis/number-object-conversion.c
NoQ marked an inline comment as done.
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp:149
BugReporter &BR) const {
MatchFinder F;
Callback CB(this, BR, AM.getAnalysisD
arphaman added a comment.
In https://reviews.llvm.org/D25777#575564, @rjmccall wrote:
> The fact that this bug only arises when performing a *second* instantiation
> suggests that there's a deeper bug here, because template instantiation is
> not supposed to modify the pattern AST. In this cas
arphaman updated this revision to Diff 75414.
arphaman added a comment.
The updated patch addresses John's comment by modifying the
`DesignatedInitExpr` re-creation logic.
Repository:
rL LLVM
https://reviews.llvm.org/D25777
Files:
lib/Sema/TreeTransform.h
test/SemaCXX/designated-initial
sammccall added a comment.
> I don't know the history behind the desired dependencies, I'll let others
> comment whether this is OK, but my guess it that it depends on the tradeoff,
> it's hard to justify 3 new deps for a change that is supposed to be simple.
> How hard is to implement this wit
mgorny created this revision.
mgorny added reviewers: bruno, bkramer, rafael.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: beanz.
Add a set of unit tests for the DetectDistro() function in Driver. Make
the function itself (and the enum) visible in the library for the tests.
bkramer added a comment.
In https://reviews.llvm.org/D25311#574806, @bruno wrote:
> I don't know the history behind the desired dependencies, I'll let others
> comment whether this is OK, but my guess it that it depends on the tradeoff,
> it's hard to justify 3 new deps for a change that is sup
erikjv created this revision.
erikjv added reviewers: bkramer, klimek.
erikjv added a subscriber: cfe-commits.
For the purpose of highlighting in an IDE.
https://reviews.llvm.org/D25871
Files:
lib/Lex/PPDirectives.cpp
test/Preprocessor/missing-include-range-check.h
Index: test/Preprocesso
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Nice. Thanks!
https://reviews.llvm.org/D25870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
erikjv created this revision.
erikjv added reviewers: bkramer, klimek.
erikjv added a subscriber: cfe-commits.
Warnings generated by -Wdocumentation-unknown-command did only have a
start location, not a full source range. This resulted in only the
"carret" being show in messages, and IDEs highligh
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D25871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
jhen updated this revision to Diff 75430.
jhen added a comment.
- Early exit if not Failure.ShouldFix
https://reviews.llvm.org/D25450
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming.cpp
Index: test/clang-tidy/readability-identifier-nami
jhen marked an inline comment as done.
jhen added inline comments.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:654
+ RangeIsEntirelyWithinMacroArgument || !RangeContainsMacroExpansion;
+ Failure.ShouldFix = Failure.ShouldFix && RangeCanBeFixed;
}
-
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D25450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D25820
___
cfe-comm
malcolm.parsons added inline comments.
Comment at: include/clang/AST/TypeLoc.h:533
+} else {
+ BuiltinRange.setBegin(std::min(Range.getBegin(),
BuiltinRange.getBegin()));
+ BuiltinRange.setEnd(std::max(Range.getEnd(), BuiltinRange.getEnd()));
aaron
aaron.ballman added inline comments.
Comment at: include/clang/AST/TypeLoc.h:533
+} else {
+ BuiltinRange.setBegin(std::min(Range.getBegin(),
BuiltinRange.getBegin()));
+ BuiltinRange.setEnd(std::max(Range.getEnd(), BuiltinRange.getEnd()));
malcolm
jlebar added a comment.
Is it not possible to write a testcase for this?
https://reviews.llvm.org/D25796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with two minor nits.
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:102
+ SpecialMemberFunctionKind Kind
jlebar added a comment.
Hi, friendly ping? This trivial patch is the only blocker remaining before I
can land https://reviews.llvm.org/D25648, which is the first part of my Grand
Set Refactoring (see mail to llvm-dev about a week ago).
Repository:
rL LLVM
https://reviews.llvm.org/D25647
bkramer added inline comments.
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103
+ auto &Members = ClassWithSpecialMembers[ID];
+ if (find(Members, Kind) == Members.end()) Members.push_back(Kind);
+}
jle
jlebar added a comment.
Thank you very much for the review!
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103
+ auto &Members = ClassWithSpecialMembers[ID];
+ if (find(Members, Kind) == Members.end()) Members.push_back(Kin
jlebar added a comment.
Thank you very much for the review!
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103
+ auto &Members = ClassWithSpecialMembers[ID];
+ if (find(Members, Kind) == Members.end()) Members.push_back(Kin
twoh updated this revision to Diff 75441.
twoh marked an inline comment as done.
twoh added a comment.
Addressing comments from @sepavloff. Thanks!
https://reviews.llvm.org/D23765
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/cxx11-crashes.cpp
Index: test/SemaCXX/cxx11-crashes.cpp
Author: rnk
Date: Fri Oct 21 11:09:20 2016
New Revision: 284836
URL: http://llvm.org/viewvc/llvm-project?rev=284836&view=rev
Log:
Remove unnecessary x86 backend requirements from OpenMP tests
Clang can generate LLVM IR for x86 without a registered x86 backend.
Modified:
cfe/trunk/test/OpenMP
jlebar updated this revision to Diff 75443.
jlebar marked 5 inline comments as done.
jlebar added a comment.
Adjust formatting, write out type of 'auto'.
https://reviews.llvm.org/D25647
Files:
clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp
clang-tools-extra/c
jlebar added inline comments.
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103
+ auto &Members = ClassWithSpecialMembers[ID];
+ if (find(Members, Kind) == Members.end()) Members.push_back(Kind);
+}
jleb
ahatanak updated this revision to Diff 75442.
ahatanak marked an inline comment as done.
ahatanak added a comment.
Improve warning messages.
https://reviews.llvm.org/D25844
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
te
ahatanak added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:8044
// the vector element type and splat.
- // FIXME: this should also work for regular vector types as supported in GCC.
- if (!RHSVecType && isa(LHSVecType)) {
+ if (!RHSVecType && isa(LHSVecType)) {
jlebar added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:2596
- QualType FnType = Context.getFunctionType(Return, Params, EPI);
- FunctionDecl *Alloc =
-FunctionDecl::Create(Context, GlobalCtx, SourceLocation(),
- SourceLocation(), Name,
ahatanak added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:8044
// the vector element type and splat.
- // FIXME: this should also work for regular vector types as supported in GCC.
- if (!RHSVecType && isa(LHSVecType)) {
+ if (!RHSVecType && isa(LHSVecType)) {
zaks.anna added inline comments.
Comment at: test/Analysis/number-object-conversion.c:14
+ if (p) {} // expected-warning{{Converting 'CFNumberRef' to a plain boolean
value for branching; please compare the pointer to NULL instead to suppress
this warning}}
+ if (!p) {} // exp
NoQ updated this revision to Diff 75446.
NoQ added a comment.
Herald added a subscriber: modocache.
Update the domain-specific language for function specs/summaries.
https://reviews.llvm.org/D20811
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLis
Author: tra
Date: Fri Oct 21 12:15:46 2016
New Revision: 284843
URL: http://llvm.org/viewvc/llvm-project?rev=284843&view=rev
Log:
Removed unused function argument. NFC.
Differential Revision: https://reviews.llvm.org/D25839
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe/trunk/lib/Sema
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284843: Removed unused function argument. NFC. (authored by
tra).
Changed prior to commit:
https://reviews.llvm.org/D25839?vs=75339&id=75447#toc
Repository:
rL LLVM
https://reviews.llvm.org/D25839
inglorion added a comment.
We also need https://reviews.llvm.org/D25578 in before this can land.
https://reviews.llvm.org/D25579
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin accepted this revision.
dcoughlin added a comment.
This looks great!
Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:694
+INVALIDATION_APPROACH(EvalCallAsPure))
+ CASE // Is certainly uppercase.
+ARGUMENT_CONDITION(ARG_N
Thanks Ben!
On Fri, Oct 21, 2016 at 3:19 AM, Benjamin Kramer via cfe-commits
wrote:
> Author: d0k
> Date: Fri Oct 21 05:19:37 2016
> New Revision: 284815
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284815&view=rev
> Log:
> Remove non-existing file from modulemap.
>
> This picked up a builtin
rSerge updated this revision to Diff 75452.
rSerge added a comment.
I had to add the root directories `a` and `b` manually, as I couldn't find an
`svn diff` argument for that.
The code file `Tools.cpp` was run via `clang-format`, then just my changes were
copy-pasted.
2 tests have been added to
jlebar added inline comments.
Comment at: test/SemaCUDA/function-template-overload.cu:62
+template constexpr T overload_ce_implicit_hd(T a) { return a+1; }
+// expected-note@-1 3 {{candidate template ignored: target attributes do not
match}}
+
Oh, I didn't know
zaks.anna created this revision.
zaks.anna added reviewers: dcoughlin, NoQ.
zaks.anna added subscribers: cfe-commits, rgov.
This patch contains 2 improvements to the CFNumber checker:
- Checking of CFNumberGetValue misuse.
- Treating all CFNumber API misuse errors as non-fatal. (Previously we tre
Author: d0k
Date: Fri Oct 21 13:55:07 2016
New Revision: 284856
URL: http://llvm.org/viewvc/llvm-project?rev=284856&view=rev
Log:
Remove move constructors that are identical to the generated default move ctor.
Modified:
cfe/trunk/include/clang/Analysis/Analyses/Consumed.h
cfe/trunk/includ
tra updated this revision to Diff 75462.
tra added a comment.
Addressed jlebar's comments.
https://reviews.llvm.org/D25796
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCUDA/overloaded-delete.cu
Index: test/SemaCUDA/overloaded-delete.cu
==
Author: hokein
Date: Fri Oct 21 14:26:43 2016
New Revision: 284859
URL: http://llvm.org/viewvc/llvm-project?rev=284859&view=rev
Log:
[clang-move] Support moving template class forward declarations.
Modified:
clang-tools-extra/trunk/clang-move/ClangMove.cpp
clang-tools-extra/trunk/unittest
On Tue, Oct 4, 2016 at 11:43 AM, Matt Gingell wrote:
> Hi Richard,
>
> Thanks for your analysis.
>
> This patch is intended to mitigate use-after-free bugs. In that context a
> “define strict behavior for invalid pointer values” we could deploy in
> production code would be very useful. Maybe cal
jlebar accepted this revision.
jlebar added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaExprCXX.cpp:2596
- QualType FnType = Context.getFunctionType(Return, Params, EPI);
- FunctionDecl *Alloc =
-FunctionDecl::Create(Context,
dcoughlin added inline comments.
Comment at: test/Analysis/CFNumber.c:39
+ unsigned char scalar = 0;
+ CFNumberGetValue(x, kCFNumberSInt16Type, &scalar); // expected-warning{{A
CFNumber object that represents a 16 bit integer is used to initialize an 8 bit
integer. 8 bits of
Author: jlebar
Date: Fri Oct 21 15:08:52 2016
New Revision: 284869
URL: http://llvm.org/viewvc/llvm-project?rev=284869&view=rev
Log:
[CUDA] Use FunctionDeclAndLoc for the Sema::LocsWithCUDACallDiags hashtable.
Summary: NFC
Reviewers: rnk
Subscribers: cfe-commits
Differential Revision: https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284869: [CUDA] Use FunctionDeclAndLoc for the
Sema::LocsWithCUDACallDiags hashtable. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25797?vs=75231&id=75474#toc
Repository:
r
Author: jlebar
Date: Fri Oct 21 15:13:39 2016
New Revision: 284873
URL: http://llvm.org/viewvc/llvm-project?rev=284873&view=rev
Log:
[clang-tidy] Don't use a SmallSetVector of an enum.
Summary:
This doesn't work after converting SmallSetVector to use DenseSet.
Instead we can just use a SmallVect
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284873: [clang-tidy] Don't use a SmallSetVector of an enum.
(authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25647?vs=75443&id=75478#toc
Repository:
rL LLVM
https://reviews.l
jlebar added a comment.
Thank you for the reviews, everyone!
Repository:
rL LLVM
https://reviews.llvm.org/D25647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vvassilev
Date: Fri Oct 21 15:30:30 2016
New Revision: 284877
URL: http://llvm.org/viewvc/llvm-project?rev=284877&view=rev
Log:
Remove accidentally checked in assert.
Thanks to Manman for spotting this.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.
On 21/10/16 00:19, Manman wrote:
On Oct 19, 2016, at 4:19 AM, Vassil Vassilev via cfe-commits
wrote:
Author: vvassilev
Date: Wed Oct 19 06:19:30 2016
New Revision: 284577
URL: http://llvm.org/viewvc/llvm-project?rev=284577&view=rev
Log:
[modules] Do not report missing definitions of demoted c
jlebar added a comment.
> This patch changes the way we match target attributes of base template vs
> attributes used in explicit instantiation or specialization so that only
> explicitly specified attributes are considered.
Another question about this: When we have something inside of the
for
Author: tra
Date: Fri Oct 21 15:34:05 2016
New Revision: 284879
URL: http://llvm.org/viewvc/llvm-project?rev=284879&view=rev
Log:
Declare H and H new/delete.
Modified:
cfe/trunk/lib/Sema/SemaExprCXX.cpp
cfe/trunk/test/SemaCUDA/overloaded-delete.cu
Modified: cfe/trunk/lib/Sema/SemaExprCXX
Author: timshen
Date: Fri Oct 21 15:41:47 2016
New Revision: 284881
URL: http://llvm.org/viewvc/llvm-project?rev=284881&view=rev
Log:
[libcxx] Support std::regex_constants::match_not_null
Summary: Fixes PR21597.
Reviewers: mclow.lists, EricWF
Subscribers: cfe-commits
Differential Revision: htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284881: [libcxx] Support
std::regex_constants::match_not_null (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D25595?vs=75186&id=75480#toc
Repository:
rL LLVM
https://review
tra updated this revision to Diff 75482.
tra added a comment.
Added a comment explaining expected constexpr function template matching
behavior.
https://reviews.llvm.org/D25845
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaCUDA.cpp
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaTemplate.cpp
Author: jlebar
Date: Fri Oct 21 15:50:47 2016
New Revision: 284882
URL: http://llvm.org/viewvc/llvm-project?rev=284882&view=rev
Log:
[CUDA] Simplify some repeated diagnostic expectations in CUDA tests.
Instead of repeating the diagnostic, use "expected-note N".
Test-only change.
Modified:
c
tra added a comment.
In https://reviews.llvm.org/D25845#576819, @jlebar wrote:
> > This patch changes the way we match target attributes of base template vs
> > attributes used in explicit instantiation or specialization so that only
> > explicitly specified attributes are considered.
>
> Anoth
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284885: [Sema] Store a SourceRange for multi-token builtin
types (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D25363?vs=74975&id=75485#toc
Repository:
rL LLVM
htt
Author: malcolm.parsons
Date: Fri Oct 21 16:13:56 2016
New Revision: 284885
URL: http://llvm.org/viewvc/llvm-project?rev=284885&view=rev
Log:
[Sema] Store a SourceRange for multi-token builtin types
Summary:
clang-tidy's modernize-use-auto check uses the SourceRange of a
TypeLoc when replacing th
dcoughlin added a comment.
LGTM!
https://reviews.llvm.org/D25876
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna updated this revision to Diff 75488.
zaks.anna added a comment.
Address comments from Devin.
https://reviews.llvm.org/D25876
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp
test/Analysis/CFNumber.c
Index: test/A
rnk created this revision.
rnk added reviewers: rsmith, rtrieu.
rnk added a subscriber: cfe-commits.
The code pattern used to implement the token rewriting hack doesn't
interact well with token caching in the pre-processor. As a result,
clang would crash on 'int f(::(id));' while doing a tenative
pcc updated this revision to Diff 75493.
pcc added a comment.
Refresh
https://reviews.llvm.org/D22296
Files:
clang/include/clang/AST/VTableBuilder.h
clang/lib/AST/VTableBuilder.cpp
clang/lib/CodeGen/CGCXX.cpp
clang/lib/CodeGen/CGVTT.cpp
clang/lib/CodeGen/CGVTables.cpp
clang/lib/Code
pcc updated this revision to Diff 75494.
pcc added a comment.
Refresh
https://reviews.llvm.org/D24431
Files:
clang/lib/CodeGen/CGVTT.cpp
clang/lib/CodeGen/ItaniumCXXABI.cpp
clang/test/CodeGenCXX/const-init-cxx11.cpp
clang/test/CodeGenCXX/constructor-init.cpp
clang/test/CodeGenCXX/copy
Author: jlebar
Date: Fri Oct 21 16:45:01 2016
New Revision: 284887
URL: http://llvm.org/viewvc/llvm-project?rev=284887&view=rev
Log:
Switch SmallSetVector to use DenseSet when it overflows its inline space.
Summary:
SetVector already used DenseSet, but SmallSetVector used std::set. This
leads to
Author: rsmith
Date: Fri Oct 21 16:50:28 2016
New Revision: 284888
URL: http://llvm.org/viewvc/llvm-project?rev=284888&view=rev
Log:
Remove 'misc-pointer-and-integral-operation' clang-tidy check. The only cases
it detects are ill-formed (some per C++ core issue 1512, others always have
been).
Rem
On Fri, Oct 21, 2016 at 1:13 AM, Renato Golin
wrote:
> On 21 October 2016 at 03:36, Richard Smith via cfe-commits
> wrote:
> > Author: rsmith
> > Date: Thu Oct 20 21:36:37 2016
> > New Revision: 284800
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=284800&view=rev
> > Log:
> > DR583, DR151
Author: rsmith
Date: Fri Oct 21 17:00:42 2016
New Revision: 284890
URL: http://llvm.org/viewvc/llvm-project?rev=284890&view=rev
Log:
DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules.
This has two significant effects:
1) Direct relational comparisons between null pointer
phosek retitled this revision from "[Fuchsia] Support for additional
architectures" to "[Fuchsia] Support for 32-bit architectures".
phosek updated the summary for this revision.
phosek updated this revision to Diff 75496.
Repository:
rL LLVM
https://reviews.llvm.org/D25838
Files:
lib/Basic
rsmith added a comment.
Can you also remove the corresponding diagnostic?
Comment at: lib/Parse/ParseExprCXX.cpp:73-75
PP.EnterToken(ColonToken);
if (!AtDigraph)
PP.EnterToken(DigraphToken);
This seems to mess up the cached token buffer in the same w
jlebar added a comment.
To close the loop, we talked about this IRL, and I agree this is the most sane
option we can come up with. The user-facing principle is that the signatures
of function template specializations must match. We consider CUDA attributes
to be part of the function's signatu
jlebar added inline comments.
Comment at: include/clang/Sema/Sema.h:9396
+ CUDAFunctionTarget IdentifyCUDATarget(const FunctionDecl *D,
+bool IgnoreImplicitHDAttr = false);
CUDAFunctionTarget IdentifyCUDATarget(const AttributeList *Attr
Author: eugenezelenko
Date: Fri Oct 21 17:35:58 2016
New Revision: 284894
URL: http://llvm.org/viewvc/llvm-project?rev=284894&view=rev
Log:
[Release notes] Mention removed Clang-tidy misc-pointer-and-integral-operation
check
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified:
jlebar added inline comments.
Comment at: lib/Sema/SemaCUDA.cpp:87
+
+ if ((HasHostAttr && HasDeviceAttr) || ForceCUDAHostDeviceDepth > 0)
+return CFT_HostDevice;
Checking ForceCUDAHostDeviceDepth here is...yeah. Especially because the other
overload of th
rnk added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:73-75
PP.EnterToken(ColonToken);
if (!AtDigraph)
PP.EnterToken(DigraphToken);
rsmith wrote:
> This seems to mess up the cached token buffer in the same way; it's a little
> surprising w
jlebar added inline comments.
Comment at: test/SemaCUDA/function-template-overload.cu:44
+// explicitly specialize or instantiate function tempaltes.
+template <> __host__ HType overload_hd(int a);
+// expected-error@-1 {{no function template matches function template
specializa
Author: rsmith
Date: Fri Oct 21 18:01:55 2016
New Revision: 284895
URL: http://llvm.org/viewvc/llvm-project?rev=284895&view=rev
Log:
Remove unnecessary distinction between Ref_Compatible and
Ref_Compatible_With_Added_Qualification. We always treated these two values the
same way.
Modified:
cf
jlebar added a comment.
Friendly ping. This assert breaks basically all cuda compilation on certain
libstdc++ versions. If this change is wrong, I sort of urgently need to figure
out the right thing.
https://reviews.llvm.org/D25640
___
cfe-commi
Author: mren
Date: Fri Oct 21 18:27:37 2016
New Revision: 284897
URL: http://llvm.org/viewvc/llvm-project?rev=284897&view=rev
Log:
Module: improve the diagnostic message for include of non-modular header.
Emit the actual path to the non-modular include.
rdar://28897010
Modified:
cfe/trunk/i
rnk updated this revision to Diff 75509.
rnk added a comment.
- Remove unused diagnostic
https://reviews.llvm.org/D25882
Files:
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Parse/Parser.h
lib/Parse/ParseExprCXX.cpp
test/Parser/colon-colon-parentheses.cpp
Index: test/Parser
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284899: Module: correctly set the module file kind when
emitting file_modified. (authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D25806?vs=75326&id=75510#toc
Repository:
rL LLVM
Author: mren
Date: Fri Oct 21 18:35:03 2016
New Revision: 284899
URL: http://llvm.org/viewvc/llvm-project?rev=284899&view=rev
Log:
Module: correctly set the module file kind when emitting file_modified.
rdar://28503343
Differential Revision: http://reviews.llvm.org/D25806
Added:
cfe/trunk/t
mehdi_amini created this revision.
mehdi_amini added a reviewer: bkramer.
mehdi_amini added a subscriber: cfe-commits.
Herald added subscribers: modocache, mgorny, beanz.
These new builtins support a mechanism for logging OS events, using a
printf-like format string to specify the layout of data i
ahatanak added a comment.
ping
https://reviews.llvm.org/D25206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 120 matches
Mail list logo
