r284781 - Revert "Disable swiftcall test on windows: More brutal way to appease windows bots"

2016-10-20 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Oct 20 16:17:28 2016 New Revision: 284781 URL: http://llvm.org/viewvc/llvm-project?rev=284781&view=rev Log: Revert "Disable swiftcall test on windows: More brutal way to appease windows bots" This reverts commit r284174. The tests pass for me locally. It must have been a 20

r284782 - [clang] Remove FileEntry copy-constructor

2016-10-20 Thread Alexander Shaposhnikov via cfe-commits
Author: alexshap Date: Thu Oct 20 16:20:35 2016 New Revision: 284782 URL: http://llvm.org/viewvc/llvm-project?rev=284782&view=rev Log: [clang] Remove FileEntry copy-constructor Code cleanup: address FIXME in the file include/clang/Basic/FileManager.h and remove copy-constructor of the class File

[PATCH] D22712: Remove FileEntry copy-constructor

2016-10-20 Thread Alexander Shaposhnikov via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284782: [clang] Remove FileEntry copy-constructor (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D22712?vs=65187&id=75356#toc Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D24954: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

2016-10-20 Thread Michał Górny via cfe-commits
mgorny retitled this revision from "[ToolChains] Disable OpenSUSE rules for SLES10" to "[Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older". mgorny updated the summary for this revision. mgorny updated this revision to Diff 75357. https://reviews.llvm.org/D24954 Files: lib/Driver/T

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

2016-10-20 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp:111 + QualType ObjT = (IsCpp || IsObjC) + ? Obj->getType().getCanonicalType().getUnqualifiedType() + : Obj->getType(); ---

[PATCH] D24954: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

2016-10-20 Thread Michał Górny via cfe-commits
mgorny marked 3 inline comments as done. mgorny added a comment. I think I've addressed all your concerns now. https://reviews.llvm.org/D24954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

r284785 - Re-commit r284753, reverted in r284778, with a fix for PR30749.

2016-10-20 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Oct 20 16:53:09 2016 New Revision: 284785 URL: http://llvm.org/viewvc/llvm-project?rev=284785&view=rev Log: Re-commit r284753, reverted in r284778, with a fix for PR30749. Original commit message: [c++1z] Teach composite pointer type computation how to compute the compos

Re: r284577 - [modules] Do not report missing definitions of demoted constexpr variable templates.

2016-10-20 Thread Manman via cfe-commits
> On Oct 19, 2016, at 4:19 AM, Vassil Vassilev via cfe-commits > wrote: > > Author: vvassilev > Date: Wed Oct 19 06:19:30 2016 > New Revision: 284577 > > URL: http://llvm.org/viewvc/llvm-project?rev=284577&view=rev > Log: > [modules] Do not report missing definitions of demoted constexpr varia

r284793 - Remove 24 instances of 'REQUIRES: shell'

2016-10-20 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Oct 20 18:11:45 2016 New Revision: 284793 URL: http://llvm.org/viewvc/llvm-project?rev=284793&view=rev Log: Remove 24 instances of 'REQUIRES: shell' Tests fall into one of the following categories: - The requirement was unnecessary - Additional quoting was required for bac

RE: r284777 - Fix off-by-one error in PPCaching.cpp token annotation assertion

2016-10-20 Thread Yung, Douglas via cfe-commits
Hi Reid, Just a heads up that the test you added fails if the compiler defaults to a different C++ standard. Our internal version defaults to c++11, and the test fails because the error "expected ';' after top level declarator" is not emitted. Douglas Yung > -Original Message- > From:

RE: r284793 - Remove 24 instances of 'REQUIRES: shell'

2016-10-20 Thread Robinson, Paul via cfe-commits
> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Reid Kleckner via cfe-commits > Sent: Thursday, October 20, 2016 4:12 PM > To: cfe-commits@lists.llvm.org > Subject: r284793 - Remove 24 instances of 'REQUIRES: shell' > > Author: rnk > Dat

r284794 - Revert 9 changes from r284793, they still fail on some bots

2016-10-20 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Oct 20 18:30:39 2016 New Revision: 284794 URL: http://llvm.org/viewvc/llvm-project?rev=284794&view=rev Log: Revert 9 changes from r284793, they still fail on some bots Modified: cfe/trunk/test/Driver/rewrite-map-in-diagnostics.c cfe/trunk/test/OpenMP/task_firstprivat

Re: r284793 - Remove 24 instances of 'REQUIRES: shell'

2016-10-20 Thread Reid Kleckner via cfe-commits
On Thu, Oct 20, 2016 at 4:38 PM, Robinson, Paul wrote: > Is there any expectation that they _should_ (eventually) work on Windows? > Yes, LLVM is a cross-platform project, and there is an expectation that developers will attempt to write portable code. It seems like there is some dependence in t

[PATCH] D25842: [clang] Limit clang test to ARM and AArch64 only

2016-10-20 Thread Mandeep Singh Grang via cfe-commits
mgrang retitled this revision from "[clang] Limit clang test to ARM only" to "[clang] Limit clang test to ARM and AArch64 only". mgrang updated the summary for this revision. mgrang updated this revision to Diff 75368. mgrang added a comment. Test limited only to ARM and AArch64. https://review

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

2016-10-20 Thread Bob Haarman via cfe-commits
inglorion updated this revision to Diff 75367. inglorion added a comment. Updated to track the latest state of https://reviews.llvm.org/D25578 https://reviews.llvm.org/D25579 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-ms-vbase.cpp Index: test/

Buildbot numbers for the week of 10/2/2016 - 10/8/2016

2016-10-20 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 10/2/2016 - 10/8/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 10/9/2016 - 10/15/2016

2016-10-20 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the last week of 10/9/2016 - 10/15/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[PATCH] D25850: [WIP] Accept nullability annotations (_Nullable) on array parameters

2016-10-20 Thread Jordan Rose via cfe-commits
jordan_rose created this revision. jordan_rose added reviewers: aprantl, doug.gregor. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. Last year Apple added new qualifiers to pointer types: `_Nullable`, `_Nonnull`, and `_Null_unspecified`.

[PATCH] D25851: [libcxx] [test] Fix unreferenced formal parameter warnings.

2016-10-20 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix unreferenced formal parameter warnings. Found by MSVC as usual. https://reviews.llvm.org/D25851 Files: test/std/utilities/optional/optional.object/optional.object.ctor

[PATCH] D25852: [libcxx] [test] Fix shadow warnings.

2016-10-20 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix shadow warnings. This variable was scoped incorrectly, found by MSVC. https://reviews.llvm.org/D25852 Files: test/std/utilities/optional/optional.object/optional.objec

[PATCH] D25853: [libcxx] [test] Fix non-Standard make_from_tuple() tests.

2016-10-20 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. The Standard doesn't depict make_from_tuple() as conditionally noexcept. Mark these tests as libcxx-specific. https://reviews.llvm.org/D25853 Files: test/std/utilities/tup

[PATCH] D25857: [tsan] Introduce a function attribute to disable TSan checking at run time

2016-10-20 Thread Anna Zaks via cfe-commits
zaks.anna created this revision. zaks.anna added reviewers: kcc, kubabrecka, dvyukov. zaks.anna added a subscriber: cfe-commits. This introduces a function annotation that disables TSan checking for the function at run time. The benefit over __attribute__((no_sanitize("thread"))) is that the acc

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

2016-10-20 Thread Bob Haarman via cfe-commits
inglorion updated this revision to Diff 75381. inglorion added a comment. Use insert's return value to save a set lookup, and use CanonicalDeclPtr https://reviews.llvm.org/D25579 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-ms-vbase.cpp Index: t

r284797 - [Modules] Add 'no_undeclared_includes' module map attribute

2016-10-20 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Thu Oct 20 20:41:56 2016 New Revision: 284797 URL: http://llvm.org/viewvc/llvm-project?rev=284797&view=rev Log: [Modules] Add 'no_undeclared_includes' module map attribute The 'no_undeclared_includes' attribute should be used in a module to tell that only non-modular headers a

r284798 - [Driver][Darwin] Pass -no_deduplicate to ld64

2016-10-20 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Thu Oct 20 20:49:14 2016 New Revision: 284798 URL: http://llvm.org/viewvc/llvm-project?rev=284798&view=rev Log: [Driver][Darwin] Pass -no_deduplicate to ld64 Recent versions of ld64 run a deduplicate pass, which is on by default. Disable the pass by using -no_deduplicate in ce

r284800 - DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules.

2016-10-20 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Oct 20 21:36:37 2016 New Revision: 284800 URL: http://llvm.org/viewvc/llvm-project?rev=284800&view=rev Log: DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules. This has two significant effects: 1) Direct relational comparisons between null pointer

[PATCH] D25850: [WIP] Accept nullability annotations (_Nullable) on array parameters

2016-10-20 Thread Richard Smith via cfe-commits
rsmith added a comment. This generally makes sense to me. `_Nonnull` in this position seems very similar to `static` (which typically also implies non-nullness). Comment at: lib/CodeGen/CGDebugInfo.cpp:2493-2499 case Type::Adjusted: - case Type::Decayed: + case Type::Deca

[libcxx] r284801 - [ModuleMap] Add more module entries to cover some non modular headers

2016-10-20 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Thu Oct 20 22:14:27 2016 New Revision: 284801 URL: http://llvm.org/viewvc/llvm-project?rev=284801&view=rev Log: [ModuleMap] Add more module entries to cover some non modular headers These modules are necessary on Darwin to allow modules with 'no_undeclared_includes' (introduce

r284802 - Don't try to use !Previous.empty() as a proxy for "Is this a redeclaration?" --

2016-10-20 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Oct 20 22:15:03 2016 New Revision: 284802 URL: http://llvm.org/viewvc/llvm-project?rev=284802&view=rev Log: Don't try to use !Previous.empty() as a proxy for "Is this a redeclaration?" -- we don't collapse that down to a single entry if it's not a redeclaration. Instead, s

[PATCH] D23765: Fix for clang PR 29087

2016-10-20 Thread Taewook Oh via cfe-commits
twoh added a comment. ping https://reviews.llvm.org/D23765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25675: clang-format: [JS] Fix template string ASI.

2016-10-20 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added inline comments. This revision is now accepted and ready to land. Comment at: unittests/Format/FormatTestJS.cpp:1280 +TEST_F(FormatTestJS, TemplateStringASI) { + verifyFormat("var x = `hello${world}`;", "var x = `hello${\n" +

[PATCH] D25844: [Sema][ObjC] Warn about implicitly autoreleasing indirect parameters that are captured by blocks

2016-10-20 Thread John McCall via cfe-commits
rjmccall added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5080 +def note_explicit_ownership_qualification : Note< + "explicitly specify ownership qualification">; + How about: warning: block captures an autoreleasing out-parameter,

[PATCH] D25675: clang-format: [JS] Fix template string ASI.

2016-10-20 Thread Martin Probst via cfe-commits
mprobst marked an inline comment as done. mprobst added inline comments. Comment at: unittests/Format/FormatTestJS.cpp:1280 +TEST_F(FormatTestJS, TemplateStringASI) { + verifyFormat("var x = `hello${world}`;", "var x = `hello${\n" + "

r284807 - clang-format: [JS] Fix template string ASI.

2016-10-20 Thread Martin Probst via cfe-commits
Author: mprobst Date: Fri Oct 21 00:11:38 2016 New Revision: 284807 URL: http://llvm.org/viewvc/llvm-project?rev=284807&view=rev Log: clang-format: [JS] Fix template string ASI. Summary: Previously, automatic semicolon insertion would add an unwrapped line when a template string contained a line

[PATCH] D25675: clang-format: [JS] Fix template string ASI.

2016-10-20 Thread Martin Probst via cfe-commits
This revision was automatically updated to reflect the committed changes. mprobst marked an inline comment as done. Closed by commit rL284807: clang-format: [JS] Fix template string ASI. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D25675?vs=74837&id=75390#toc Repos

<    1   2