Author: vedantk
Date: Wed Oct 19 15:53:16 2016
New Revision: 284642
URL: http://llvm.org/viewvc/llvm-project?rev=284642&view=rev
Log:
[ubsan] Drop dependency on a 64-bit arch in a test (NFC)
This should fix:
http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/46184
Modified:
cfe/
jlebar marked 2 inline comments as done.
jlebar added a comment.
I'm going to submit this and send a patch to reuse FunctionDeclAndLoc. But I'm
happy to add a comment about the note as well.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6707
+def note_called_
jlebar marked 2 inline comments as done.
jlebar added a comment.
Thank you for the review, Reid.
https://reviews.llvm.org/D25704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jlebar
Date: Wed Oct 19 16:03:38 2016
New Revision: 284643
URL: http://llvm.org/viewvc/llvm-project?rev=284643&view=rev
Log:
[CUDA] Emit errors for wrong-side calls made on the same line as non-wrong-side
calls.
Summary:
This fixes two related bugs:
1) Previously, if you had a non-wrong
Author: jlebar
Date: Wed Oct 19 16:03:42 2016
New Revision: 284644
URL: http://llvm.org/viewvc/llvm-project?rev=284644&view=rev
Log:
[AST] Add CanonicalDeclPtr.
Summary:
CanonicalDeclPtr is just like a T*, except it calls
T::getCanonicalDecl() on construction.
This is useful as the key in a "set
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284644: [AST] Add CanonicalDeclPtr. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25703?vs=74911&id=75222#toc
Repository:
rL LLVM
https://reviews.llvm.org/D25703
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284643: [CUDA] Emit errors for wrong-side calls made on the
same line as non-wrong-side… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25702?vs=74910&id=75220#toc
Repository:
efriedma created this revision.
efriedma added a reviewer: dblaikie.
efriedma added a subscriber: cfe-commits.
efriedma set the repository for this revision to rL LLVM.
Fixes regression from r279445.
Repository:
rL LLVM
https://reviews.llvm.org/D25793
Files:
lib/CodeGen/CGDebugInfo.cpp
t
Author: cbieneman
Date: Wed Oct 19 16:12:04 2016
New Revision: 284646
URL: http://llvm.org/viewvc/llvm-project?rev=284646&view=rev
Log:
[CMake] Support thin LTO in PGO CMake cache
This allows you to set PGO_INSTRUMENT_LTO=Thin and have it work correctly.
Modified:
cfe/trunk/cmake/caches/PGO.
dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2183-2185
+ if (VAT->getSizeExpr()) {
+llvm::APSInt V;
+if (VAT->getSizeExpr()->EvaluateAsInt(V, CGM.getC
Author: jlebar
Date: Wed Oct 19 16:15:01 2016
New Revision: 284647
URL: http://llvm.org/viewvc/llvm-project?rev=284647&view=rev
Log:
[CUDA] When we emit an error that might have been deferred, also print a
callstack.
Summary:
Previously, when you did something not allowed in a host+device functi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284647: [CUDA] When we emit an error that might have been
deferred, also print a… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25704?vs=75178&id=75226#toc
Repository:
rL L
bruno added a comment.
Thanks for looking into this. It's a nice FixIt to have.
I don't see any dep cycle; clangFormat depends on clangToolingCore, which also
depends clangRewrite, which means there are going to be 3 new dependencies for
libSema in the end: clangToolingCore, clangRewrite and cl
Author: cbieneman
Date: Wed Oct 19 16:18:48 2016
New Revision: 284648
URL: http://llvm.org/viewvc/llvm-project?rev=284648&view=rev
Log:
[CMake] Add clang-bootstrap-deps target
Having this target allows other parts of the build system to add to the
bootstrap dependencies without needing to be def
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3903
+if (!Data.split('.').first.getAsInteger(10, MajorVersion)) {
+ switch (MajorVersion) {
+case 5:
clang-format the `switch`: `case`'s should be aligned with it.
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
Implicit functions are treated as if they were __host__ __device__ and clang
does not allow overloading
those with __host__ or __device__ variants.
In order for users to provide their own standard allo
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added a subscriber: cfe-commits.
NFC
https://reviews.llvm.org/D25797
Files:
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaCUDA.cpp
Index: clang/lib/Sema/SemaCUDA.cpp
===
manmanren added a comment.
It makes sense to rebuild the expression when a field designator stores a
FieldDecl.
Thanks for working on this!
Manman
Comment at: lib/Sema/TreeTransform.h:8926
D.getFieldLoc()));
+ if (D.getFiel
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284651: DebugInfo: use uint32_t for alignment variables.
(authored by vleschuk).
Changed prior to commit:
https://reviews.llvm.org/D25621?vs=75143&id=75241#toc
Repository:
rL LLVM
https://reviews.ll
Author: vleschuk
Date: Wed Oct 19 17:11:07 2016
New Revision: 284651
URL: http://llvm.org/viewvc/llvm-project?rev=284651&view=rev
Log:
DebugInfo: use uint32_t for alignment variables.
LLVM now uses uint32_t for DebugInfo alignment for space efficiency,
in this patch we change frontend DebugInfo-r
Author: efriedma
Date: Wed Oct 19 17:16:32 2016
New Revision: 284652
URL: http://llvm.org/viewvc/llvm-project?rev=284652&view=rev
Log:
Don't crash generating debug info for VLA in function prototype.
Fixes regression from r279445.
Differential Revision: https://reviews.llvm.org/D25793
Modified
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284652: Don't crash generating debug info for VLA in
function prototype. (authored by efriedma).
Changed prior to commit:
https://reviews.llvm.org/D25793?vs=75219&id=75243#toc
Repository:
rL LLVM
ht
Author: rsmith
Date: Wed Oct 19 17:18:42 2016
New Revision: 284653
URL: http://llvm.org/viewvc/llvm-project?rev=284653&view=rev
Log:
Add optimization to sizeof...(X) handling: if none of parameter pack X's
corresponding arguments are unexpanded pack expansions, we can compute the
result without su
On Wed, Oct 19, 2016 at 2:04 PM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hans
> Date: Wed Oct 19 13:04:27 2016
> New Revision: 284624
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284624&view=rev
> Log:
> MS ABI: Fix assert when generating virtual function c
elsteveogrande added a comment.
ping - seems I'm unable to commit this myself. Thanks!
https://reviews.llvm.org/D25153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma added a comment.
Ping
https://reviews.llvm.org/D24378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mgottesman
Date: Wed Oct 19 17:46:06 2016
New Revision: 284658
URL: http://llvm.org/viewvc/llvm-project?rev=284658&view=rev
Log:
[cmake] Follow LLVM's lead in creating exported tool targets for clang tools.
This is needed by downstream projects such as swift to get proper cmake
dependency
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, Oct 19, 2016 at 3:38 PM, David Majnemer
wrote:
>
>
> On Wed, Oct 19, 2016 at 2:04 PM, Hans Wennborg via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: hans
>> Date: Wed Oct 19 13:04:27 2016
>> New Revision: 284624
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=284624&
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D25595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Thanks, looks good with some nits
Comment at: lib/CodeGen/CGDebugInfo.cpp:1397
const auto *Base =
cast(BI.getType()->getAs()->getDecl());
rnk wrote
Author: rnk
Date: Wed Oct 19 18:39:55 2016
New Revision: 284667
URL: http://llvm.org/viewvc/llvm-project?rev=284667&view=rev
Log:
Use noexcept instead of LLVM_NOEXCEPT now that all compilers support it
Modified:
cfe/trunk/include/clang/AST/Attr.h
cfe/trunk/include/clang/AST/Stmt.h
cfe
Author: rsmith
Date: Wed Oct 19 18:47:37 2016
New Revision: 284669
URL: http://llvm.org/viewvc/llvm-project?rev=284669&view=rev
Log:
Extend hack to work around bad exception specifications for 'swap' members to
also cover libstdc++'s std::__debug::array and std::__profile::array.
Modified:
cf
Sunil_Srivastava added a comment.
ping
https://reviews.llvm.org/D22057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren created this revision.
manmanren added reviewers: bruno, rsmith, benlangmuir.
manmanren added a subscriber: cfe-commits.
I don't quite like the if statement in the patch, but given that
ASTReader::Error and DelayedDiagnostic only take strings, it is hard to just
change err_fe_pch_file_
Author: rsmith
Date: Wed Oct 19 19:01:36 2016
New Revision: 284673
URL: http://llvm.org/viewvc/llvm-project?rev=284673&view=rev
Log:
Fix crash on noreturn conversion in unprototyped function type. Thanks to Keith
Walker for spotting the bug.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
c
On Wed, Oct 19, 2016 at 5:05 PM, Manman Ren wrote:
> manmanren created this revision.
> manmanren added reviewers: bruno, rsmith, benlangmuir.
> manmanren added a subscriber: cfe-commits.
>
> I don't quite like the if statement in the patch, but given that
> ASTReader::Error and DelayedDiagnostic
srhines added a comment.
This looks good to me, but I would prefer if one of the more experienced Clang
folks could officially LGTM this. Thanks.
https://reviews.llvm.org/D24010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: vleschuk
Date: Wed Oct 19 19:13:19 2016
New Revision: 284679
URL: http://llvm.org/viewvc/llvm-project?rev=284679&view=rev
Log:
DebugInfo: pass alignment value only if it was forced
Preparation to implement DW_AT_alignment support:
- We pass non-zero align value to DIBuilder only when ali
tra created this revision.
tra added reviewers: jlebar, rsmith.
tra added a subscriber: cfe-commits.
Current behavior:
- __host__ __device__ (HD) functions are considered to be redeclarations of
`__host__` (H) of `__device__` (D) functions with same signature.
- Target attributes are not taken i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284679: DebugInfo: pass alignment value only if it was
forced (authored by vleschuk).
Changed prior to commit:
https://reviews.llvm.org/D24426?vs=74686&id=75261#toc
Repository:
rL LLVM
https://revie
Author: vleschuk
Date: Wed Oct 19 19:37:07 2016
New Revision: 284683
URL: http://llvm.org/viewvc/llvm-project?rev=284683&view=rev
Log:
Upgrade debug-info-vla test: we do not pass default alignment now
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-vla.cpp
Modified: cfe/trunk/test/CodeGenCXX/
Author: rsmith
Date: Wed Oct 19 19:55:15 2016
New Revision: 284684
URL: http://llvm.org/viewvc/llvm-project?rev=284684&view=rev
Log:
PR26276: Fix detection of non-cast-expressions as operands of fold-expressions.
Modified:
cfe/trunk/include/clang/AST/ExprCXX.h
cfe/trunk/lib/AST/ExprCXX.cp
Author: rsmith
Date: Wed Oct 19 20:20:00 2016
New Revision: 284685
URL: http://llvm.org/viewvc/llvm-project?rev=284685&view=rev
Log:
Refactor and simplify Sema::FindCompositePointerType. No functionality change
intended.
Modified:
cfe/trunk/lib/Sema/SemaExprCXX.cpp
Modified: cfe/trunk/lib/S
kparzysz created this revision.
kparzysz added a reviewer: EricWF.
kparzysz added a subscriber: cfe-commits.
kparzysz set the repository for this revision to rL LLVM.
The characters like '\xDA' or '\xFA' are not valid representations of anything
in UTF-8, so toupper and tolower return the charact
Author: epilk
Date: Wed Oct 19 21:46:22 2016
New Revision: 284690
URL: http://llvm.org/viewvc/llvm-project?rev=284690&view=rev
Log:
Replace uses of LLVM_FUNCTION_NAME with __func__, this was macro was removed
from llvm/Support in r284681
Modified:
cfe/trunk/tools/libclang/CIndexHigh.cpp
Author: ericwf
Date: Wed Oct 19 22:31:07 2016
New Revision: 284691
URL: http://llvm.org/viewvc/llvm-project?rev=284691&view=rev
Log:
Attempt to workaround XPASS for aligned allocation tests
Modified:
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align
Brad Smith wrote:
> On Fri, Oct 14, 2016 at 09:47:17PM -0400, Brad Smith via cfe-commits wrote:
> > On Fri, Oct 14, 2016 at 05:59:54PM -, Ed Maste via cfe-commits wrote:
> > > Author: emaste
> > > Date: Fri Oct 14 12:59:53 2016
> > > New Revision: 284256
> > >
> > > URL: http://llvm.org/viewvc
EricWF added a comment.
Seems like we should figure out why these pass on ToT OS X.
Repository:
rL LLVM
https://reviews.llvm.org/D25811
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
craig.topper added inline comments.
Comment at: lib/Headers/avx512vbmivlintrin.h:225
static __inline__ __m256i __DEFAULT_FN_ATTRS
-_mm256_maskz_multishift_epi64_epi8 (__mmask32 __M, __m256i __X, __m256i __Y)
+_mm256_maskz_multishift_epi64_epi8 (__mmask8 __M, __m256i __X, __m256i
vsk created this revision.
vsk added reviewers: rjmccall, pcc.
vsk added a subscriber: cfe-commits.
If we see a virtual method call to Base::foo() but can infer that the
object is an instance of Derived, and that 'foo' is marked 'final' in
Derived, we can devirtualize the call to Derived::foo().
I think this breaks windows bot:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/30745/steps/build%20clang%20lld/logs/stdio
C:\PROGRA~2\MICROS~1.0\VC\bin\AMD64_~2\cl.exe /nologo /TP
-DCLANG_ENABLE_ARCMT -DCLANG_ENABLE_OBJC_REWRITER
-DCLANG_ENABLE_STATIC_ANALYZER -DGTEST_HAS_RTTI=0 -D
101 - 152 of 152 matches
Mail list logo
