kromanenkov added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:2314
{
+ // Return to fulfil assert condition
+ if (location.getAs())
NoQ wrote:
> Hmm. Why would anybody try to load anything from a plain pointer-to-member,
> rather than
ahatanak added a comment.
There are two overloaded functions of CodeGenFunction::EmitScalarInit. Are you
suggesting we fold both of them into EmitStoreThroughLValue and remove them?
https://reviews.llvm.org/D25547
___
cfe-commits mailing list
cfe-c
Apologies for the breakage. I investigated and it turns out my open-source
checkout does not build clang-tidy. I have checked out llvm into ~/llvm,
clang into ~/llvm/tools/clang and clang-extra-tools into
~/llvm/tools/clang/tools/extra.
In ~/llvm-build I run cmake ../llvm && make -j 32 and it doesn
inglorion updated this revision to Diff 74733.
inglorion added a comment.
@rnk's comments (thanks!)
- Converted SeenTypes to a DenseSet.
- Switched to getCodeGenOpts().EmitCodeView to check if we should emit the
extra records.
- Switched to using SeenTypes.count(...) != 0 to check if we've seen
Author: rsmith
Date: Fri Oct 14 14:51:36 2016
New Revision: 284271
URL: http://llvm.org/viewvc/llvm-project?rev=284271&view=rev
Log:
[linux] When pre-reserving stack pages to work around broken address space
layout for PIE binaries, ask the OS how much stack space is already in use to
avoid stack
inglorion updated this revision to Diff 74734.
inglorion added a comment.
- Removed unused header.
https://reviews.llvm.org/D25579
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGenCXX/debug-info-ms-vbase.cpp
Index: test/CodeGenCXX/debug-info-ms-vbase.cpp
=
Author: dougk
Date: Fri Oct 14 14:55:09 2016
New Revision: 284272
URL: http://llvm.org/viewvc/llvm-project?rev=284272&view=rev
Log:
Implement no_sanitize_address for global vars
Modified:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/tr
bruno added a comment.
One possible reason: remove_dots is called upon a path with a leading "..",
which then gets appended in front of another path to form the absolute path.
I'm taking a look right now to try to figure out if there's any code path that
might lead to this.
https://reviews.ll
kparzysz added a comment.
dbgs showed that the path components were `.. target hexagon include`.
The paths are constructed in lib/Driver/ToolChains.cpp, many are based on
"getHexagonTargetDir".
https://reviews.llvm.org/D25597
___
cfe-commits mailin
jbangert removed rL LLVM as the repository for this revision.
jbangert updated this revision to Diff 74737.
Herald added subscribers: mgorny, beanz.
https://reviews.llvm.org/D24997
Files:
clang-tidy/utils/ASTUtils.cpp
clang-tidy/utils/ASTUtils.h
clang-tidy/utils/CMakeLists.txt
clang-tidy/
I figured out make clang-tidy. Compiles now (the typedef was the wrong way
around, and i never noticed because make with the default target continued
to work).
Updated the diff.
On Fri, Oct 14, 2016 at 12:49 PM Julian Bangert wrote:
> Apologies for the breakage. I investigated and it turns out
Hi Haojian,
On 14 October 2016 at 06:01, Haojian Wu via cfe-commits
wrote:
> + std::string GuardName(FileName);
> + if (IsHeader) {
> +std::replace(GuardName.begin(), GuardName.end(), '/', '_');
> +std::replace(GuardName.begin(), GuardName.end(), '.', '_');
> +std::replace(GuardName
bruno added a comment.
Krzysztof, do you have a backtrace that you can paste here or point me to the
buidbot stderr log? There's no point in looking for relative paths inside the
VFS, it would be nice if we fix the root cause here.
https://reviews.llvm.org/D25597
___
rjmccall added a comment.
Sorry, no, just the one that takes an llvm::Value* instead of an Expr*.
https://reviews.llvm.org/D25547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dlkreitz
Date: Fri Oct 14 15:44:33 2016
New Revision: 284278
URL: http://llvm.org/viewvc/llvm-project?rev=284278&view=rev
Log:
Define Contiki OS toolchain
Patch by Michael LeMay
Differential revision: http://reviews.llvm.org/D19854
Modified:
cfe/trunk/lib/Driver/Driver.cpp
cfe/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284278: Define Contiki OS toolchain (authored by dlkreitz).
Changed prior to commit:
https://reviews.llvm.org/D19854?vs=70076&id=74741#toc
Repository:
rL LLVM
https://reviews.llvm.org/D19854
Files:
kparzysz added a comment.
Right on entry to the asserting function:
(gdb) where
#0 0x752b9870 in (anonymous
namespace)::RedirectingFileSystem::lookupPath(llvm::sys::path::const_iterator,
llvm::sys::path::const_iterator, (anonymous namespace)::Entry*) () from
/w/bld/up/bin/../lib/l
kparzysz added a comment.
The `..:target:hexagon:include:` is debug code printing all the path
components, separated by :.
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
erik.pilkington updated this revision to Diff 74738.
erik.pilkington added a comment.
This new patch renames `DelayedDiagnostic::DeprecationData` to
`DelayedDiagnostic::AvailabilityData`, because now that it can hold information
about deprecated, unavailable, and partial diagnostics.
Thanks,
Eri
Hi Nico,
Could you give me more information about the compiler your using?
/Eric
On Fri, Oct 14, 2016 at 1:21 PM, Nico Weber wrote:
> This is breaking tests for me:
>
> Unexpected Passing Tests (4):
> libc++ :: std/language.support/support.dynamic/new.delete/new.delete.
> array/new_align_v
Author: davidsh
Date: Fri Oct 14 15:43:37 2016
New Revision: 284277
URL: http://llvm.org/viewvc/llvm-project?rev=284277&view=rev
Log:
__builtin_fpclassify missing one int parameter
Patch by Tania Albarghouthi.
Differential Revision: https://reviews.llvm.org/D25480
Modified:
cfe/trunk/inclu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284277: __builtin_fpclassify missing one int parameter
(authored by davidsh).
Changed prior to commit:
https://reviews.llvm.org/D25480?vs=74377&id=74740#toc
Repository:
rL LLVM
https://reviews.llvm.
UBSAN may not be replacing the function, but it is doing something weird at
the codegen level. I looked into this a while ago but never sorted it out.
Either way I'll clarify the comments and add the missing reset() calls.
Unfortunately the tests still fail in the same way.
On Fri, Oct 14, 2016 a
Author: ericwf
Date: Fri Oct 14 16:30:35 2016
New Revision: 284282
URL: http://llvm.org/viewvc/llvm-project?rev=284282&view=rev
Log:
Clarify XFAIL comments
Modified:
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp
li
joerg added a comment.
It seems like on-stack arrays still don't work?
#include
struct test {
uint32_t x;
} __attribute__((__packed__));
int main(void) {
struct test __attribute__((__aligned__(4))) a[4];
uint32_t *p32;
p32 = &a[0].x;
}
https://reviews.llvm.org/D
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Manman
Repository:
rL LLVM
https://reviews.llvm.org/D25519
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: rsmith
Date: Fri Oct 14 16:41:24 2016
New Revision: 284284
URL: http://llvm.org/viewvc/llvm-project?rev=284284&view=rev
Log:
Reinstate r284008 reverted in r284081, with two fixes:
1) Merge and demote variable definitions when we find a redefinition in
MergeVarDecls, not only when we find
rsmith added a comment.
I reverted this in r284081, and relanded with fixes described here as r284284.
Comment at: lib/Sema/SemaDecl.cpp:9712
+
+ // Demote the newly parsed definition to a fake declaration.
+ if (!VDecl->isThisDeclarationADemotedDefinition())
Author: arnolds
Date: Fri Oct 14 16:55:56 2016
New Revision: 284285
URL: http://llvm.org/viewvc/llvm-project?rev=284285&view=rev
Log:
Add more swift calling convention tests
Modified:
cfe/trunk/test/CodeGen/64bit-swiftcall.c
cfe/trunk/test/CodeGen/arm-swiftcall.c
Modified: cfe/trunk/test
On Fri, Oct 14, 2016 at 11:44 AM, Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
> Hi Richard,
>
> I have a patch on top of your suggested patch from a year ago, that
> break the cyclic dependency we're seeing, with this (and a few changes
> to the SDK) we can bootstrap clang with submodule
Oh, I have another idea: could it be that you're also turning some
optimization on when UBSan is enabled? Note that the operator new/operator
delete pair is elidable in each of these tests, and Clang will remove the
calls when compiling with optimizations enabled.
On Fri, Oct 14, 2016 at 2:38 PM,
Oh, I have another idea: could it be that you're also turning some
optimization on when UBSan is enabled? Note that the operator new/operator
delete pair is elidable in each of these tests, and Clang will remove the
calls when compiling with optimizations enabled.
That's it. The UBSAN tests build
Author: compnerd
Date: Fri Oct 14 17:25:46 2016
New Revision: 284288
URL: http://llvm.org/viewvc/llvm-project?rev=284288&view=rev
Log:
Sema: honour dllexport in itanium more faithfully
Although the itanium environment uses the itanium layout for C++, treat the
dllexport semantics more similarly t
Hello everyone,
LLVM buildmaster will be updated and restarted after 5 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, Oct 14, 2016 at 3:34 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Oh, I have another idea: could it be that you're also turning some
> optimization on when UBSan is enabled? Note that the operator new/operator
> delete pair is elidable in each of these tests, an
Author: ericwf
Date: Fri Oct 14 17:47:08 2016
New Revision: 284289
URL: http://llvm.org/viewvc/llvm-project?rev=284289&view=rev
Log:
Prevent new/delete replacement tests from being optimized away.
Modified:
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/de
Thanks Richard. I've fixed the tests in r284289.
On Fri, Oct 14, 2016 at 4:40 PM, Richard Smith
wrote:
> On Fri, Oct 14, 2016 at 3:34 PM, Eric Fiselier via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Oh, I have another idea: could it be that you're also turning some
>> optimization o
Author: alexshap
Date: Fri Oct 14 18:16:25 2016
New Revision: 284291
URL: http://llvm.org/viewvc/llvm-project?rev=284291&view=rev
Log:
[clang-move] Use cl::list for the list of names
This diff replaces manual parsing of the comma-separated list of names with
cl::list and cl::CommaSeparated.
Test
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284291: [clang-move] Use cl::list for the list of names
(authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D25586?vs=74599&id=74749#toc
Repository:
rL LLVM
https://reviews.llv
vitalybuka added a comment.
This change breaks
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/25625/steps/build%2032-bit%20symbolizer%20for%20compiler_rt_build/logs/stdio
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
vitalybuka added a comment.
So there is:
- Looking for __cxa_thread_atexit_impl in c
- Looking for __cxa_thread_atexit_impl in c - not found
and libcxx is configured with -DLIBCXX_ENABLE_THREADS=OFF
https://reviews.llvm.org/D24864
___
cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284293: [Coverage] Support for C++17 if initializers
(authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D25572?vs=74559&id=74753#toc
Repository:
rL LLVM
https://reviews.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284292: [Coverage] Support for C++17 switch initializers
(authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D25539?vs=74552&id=74752#toc
Repository:
rL LLVM
https://reviews.llv
Author: vedantk
Date: Fri Oct 14 18:38:13 2016
New Revision: 284292
URL: http://llvm.org/viewvc/llvm-project?rev=284292&view=rev
Log:
[Coverage] Support for C++17 switch initializers
Differential Revision: https://reviews.llvm.org/D25539
Added:
cfe/trunk/test/CoverageMapping/switch.cpp
Author: vedantk
Date: Fri Oct 14 18:38:16 2016
New Revision: 284293
URL: http://llvm.org/viewvc/llvm-project?rev=284293&view=rev
Log:
[Coverage] Support for C++17 if initializers
Differential Revision: https://reviews.llvm.org/D25572
Added:
cfe/trunk/test/CoverageMapping/if.cpp
- copie
rmaprath added a comment.
In https://reviews.llvm.org/D24864#570924, @vitalybuka wrote:
> So there is:
>
> - Looking for __cxa_thread_atexit_impl in c
> - Looking for __cxa_thread_atexit_impl in c - not found
>
> and libcxx is configured with -DLIBCXX_ENABLE_THREADS=OFF
I think, the problem h
vitalybuka added a comment.
Maybe?
- if (UNIX AND NOT (APPLE OR CYGWIN))
+ if (LIBCXXABI_ENABLE_THREADS AND UNIX AND NOT (APPLE OR CYGWIN))
list(APPEND LIBCXXABI_SOURCES cxa_thread_atexit.cpp)
endif()
https://reviews.llvm.org/D24864
___
cfe-co
rmaprath added a comment.
In https://reviews.llvm.org/D24864#570935, @vitalybuka wrote:
> Maybe?
>
> - if (UNIX AND NOT (APPLE OR CYGWIN))
> + if (LIBCXXABI_ENABLE_THREADS AND UNIX AND NOT (APPLE OR CYGWIN))
> list(APPEND LIBCXXABI_SOURCES cxa_thread_atexit.cpp)
> endif()
>
Yes!
I was
sebpop accepted this revision.
sebpop added a reviewer: sebpop.
sebpop added a comment.
This revision is now accepted and ready to land.
This got approved in the past review.
Let's commit it now that the clang bug was fixed.
Thanks Aditya for keeping track of this.
https://reviews.llvm.org/D2562
Author: vitalybuka
Date: Fri Oct 14 18:51:41 2016
New Revision: 284294
URL: http://llvm.org/viewvc/llvm-project?rev=284294&view=rev
Log:
Don't compile cxa_thread_atexit.cpp with -DLIBCXX_ENABLE_THREADS=OFF
Reviewers: rmaprath
Subscribers: beanz, mgorny
Differential Revision: https://reviews.llv
vitalybuka added a comment.
Thanks, done https://reviews.llvm.org/D25636
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
Has the fix been merged into the 3.9 branch? Does re-adding this attribute mean
that Clang 4.0 is required to build LLVM w/ libc++?
https://reviews.llvm.org/D25624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
rmaprath added a comment.
In https://reviews.llvm.org/D24864#570954, @vitalybuka wrote:
> Thanks, done https://reviews.llvm.org/D25636
Thanks for the fix!
/ Asiri
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llv
sebpop added a comment.
If I remember correctly, we pushed the fix after 3.9 was released.
Could you please explain the problem of requiring trunk LLVM to build trunk
libcxx?
https://reviews.llvm.org/D25624
___
cfe-commits mailing list
cfe-commits@
Author: vitalybuka
Date: Fri Oct 14 19:02:20 2016
New Revision: 284295
URL: http://llvm.org/viewvc/llvm-project?rev=284295&view=rev
Log:
Fix typo in comment
Modified:
libcxxabi/trunk/src/cxa_thread_atexit.cpp
Modified: libcxxabi/trunk/src/cxa_thread_atexit.cpp
URL:
http://llvm.org/viewvc/ll
tmsriram retitled this revision from "New clang option -mpiecopyrelocs to
indicate support for linker copy relocations when linking as PIE" to "New clang
option -mpie-copy-relocationss to indicate support for linker copy relocations
when linking as PIE".
tmsriram updated the summary for this rev
ahatanak updated this revision to Diff 74760.
ahatanak added a comment.
Fold EmitScalarInit into EmitStoreThroughLValue and remove EmitScalarInit.
I don't think ElementType in EmitObjCCollectionLiteral has a lifetime
qualifier, so it should be safe to call EmitStoreThroughLValue instead of
Emit
phosek added a comment.
Ping, do you have any other comments?
Repository:
rL LLVM
https://reviews.llvm.org/D25491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Looks that somehow the current directory doesn't exit anymore OR it's non empty
but only contains spaces or something like that. Besides the snippet below,
RedirectingFileSystem::lookupPath(llvm::Twine const&) also calls `makeAbsolute`
before `remove_dots`. Can you try to
On Fri, Oct 14, 2016 at 05:59:54PM -, Ed Maste via cfe-commits wrote:
> Author: emaste
> Date: Fri Oct 14 12:59:53 2016
> New Revision: 284256
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284256&view=rev
> Log:
> Link static PIE programs against rcrt0.o on OpenBSD
>
> Patch by Stefan Kemp
Author: rsmith
Date: Fri Oct 14 20:59:52 2016
New Revision: 284300
URL: http://llvm.org/viewvc/llvm-project?rev=284300&view=rev
Log:
Disable a silly GCC diagnostic for combining a scanf length specifier with the
'*' specifier. Apparently the GNU folks want to discourage self-documenting
code.
Mod
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:1650
+}
+
switch (Lifetime) {
I think you can fold this a bit more. :) You have exactly the same switch
statement below, and several of the cases are identical; for the others, you
can
jlebar created this revision.
jlebar added reviewers: rsmith, tra.
jlebar added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
In CUDA compilation, we call isInlineDefinitionExternallyVisible (via
getGVALinkageForFunction) on functions while parsing their definitions.
At the poin
101 - 163 of 163 matches
Mail list logo
