timshen created this revision.
timshen added reviewers: mclow.lists, EricWF.
timshen added a subscriber: cfe-commits.
Fixes PR21597.
https://reviews.llvm.org/D25595
Files:
libcxx/include/regex
libcxx/test/std/re/re.alg/re.alg.search/pr21597.pass.cpp
Index: libcxx/test/std/re/re.alg/re.alg
Author: ericwf
Date: Fri Oct 14 02:19:52 2016
New Revision: 284209
URL: http://llvm.org/viewvc/llvm-project?rev=284209&view=rev
Log:
Add void_t and invoke feature test macros
Added:
libcxx/trunk/test/std/utilities/function.objects/func.invoke/invoke_feature_test_macro.pass.cpp
libcxx/tr
mstorsjo added a comment.
> (should they be also on AArch64? I had problems with testing it for AArch64,
> so I left it)
Technically, I think they should be on AArch64 as well. But clang/LLVM probably
doesn't support AArch64/Windows yet (I guess?), so testing it probably is
impossible. When/if
Author: ericwf
Date: Fri Oct 14 02:49:15 2016
New Revision: 284210
URL: http://llvm.org/viewvc/llvm-project?rev=284210&view=rev
Log:
XFAIL aligned allocation test failures with UBSAN
Modified:
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_va
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D25586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: mkurdej
Date: Fri Oct 14 03:10:08 2016
New Revision: 284212
URL: http://llvm.org/viewvc/llvm-project?rev=284212&view=rev
Log:
[clang-tidy] Fix readability-braces-around-statements false positive
Summary:
This fixes a false-positive e.g. when string literals are returned from if
statement
Author: mzuckerm
Date: Fri Oct 14 03:13:27 2016
New Revision: 284213
URL: http://llvm.org/viewvc/llvm-project?rev=284213&view=rev
Log:
[x86][ms-inline-asm] use of "jmp short" in asm is not supported
Test linked to: https://reviews.llvm.org/D24957
Committing in the name of Ziv Izhar: After check-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284213: [x86][ms-inline-asm] use of "jmp short" in asm is
not supported (authored by mzuckerm).
Changed prior to commit:
https://reviews.llvm.org/D24958?vs=72624&id=74626#toc
Repository:
rL LLVM
htt
danielmarjamaki created this revision.
danielmarjamaki added a reviewer: NoQ.
danielmarjamaki added subscribers: cfe-commits, xazax.hun, dcoughlin.
danielmarjamaki set the repository for this revision to rL LLVM.
This patch fix false positives for loss of sign in addition and subtraction
assignme
Author: ericwf
Date: Fri Oct 14 03:47:09 2016
New Revision: 284214
URL: http://llvm.org/viewvc/llvm-project?rev=284214&view=rev
Log:
XFAIL aligned allocation tests for older Clang versions
Modified:
libcxx/trunk/test/libcxx/test/config.py
libcxx/trunk/test/std/language.support/support.dy
ioeric created this revision.
ioeric added a reviewer: bkramer.
ioeric added a subscriber: cfe-commits.
Since `remove_dots` does not delete leading "../" anymore, assertion test need
to be updated.
https://reviews.llvm.org/D25597
Files:
lib/Basic/VirtualFileSystem.cpp
Index: lib/Basic/Virtu
rmaprath closed this revision.
rmaprath added a comment.
Committed as r284128.
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
I'd not rename the function. Otherwise looks good.
https://reviews.llvm.org/D25565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Author: ericwf
Date: Fri Oct 14 04:06:38 2016
New Revision: 284216
URL: http://llvm.org/viewvc/llvm-project?rev=284216&view=rev
Log:
Remove dead CMake target
Modified:
libcxx/trunk/cmake/Modules/HandleLibCXXABI.cmake
libcxx/trunk/lib/CMakeLists.txt
Modified: libcxx/trunk/cmake/Modules/Ha
ioeric updated this revision to Diff 74631.
ioeric added a comment.
- Separate assertions to get more information.
https://reviews.llvm.org/D25597
Files:
lib/Basic/VirtualFileSystem.cpp
Index: lib/Basic/VirtualFileSystem.cpp
==
ioeric updated this revision to Diff 74632.
ioeric added a comment.
- Change name to groupReplacementsByFile
https://reviews.llvm.org/D25565
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactoring.cpp
Author: ericwf
Date: Fri Oct 14 04:12:53 2016
New Revision: 284217
URL: http://llvm.org/viewvc/llvm-project?rev=284217&view=rev
Log:
Mark test as unsupported without threads
Modified:
libcxxabi/trunk/test/libcxxabi/test/config.py
libcxxabi/trunk/test/thread_local_destruction_order.pass.cp
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25598
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/test.cpp
test/clang-move/Inputs/test.h
test/clang-move/move-class.cpp
Index: test/clang-move/move
ioeric updated this revision to Diff 74634.
ioeric added a comment.
- Merge branch 'master' of http://llvm.org/git/clang into arcpatch-D25565
- Forgot to update names in tests...
https://reviews.llvm.org/D25565
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactorin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284219: Deduplicate sets of replacements by file names.
(authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25565?vs=74634&id=74636#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: ioeric
Date: Fri Oct 14 04:32:06 2016
New Revision: 284219
URL: http://llvm.org/viewvc/llvm-project?rev=284219&view=rev
Log:
Deduplicate sets of replacements by file names.
Summary:
If there are multiple pairs with the same file
path after removing dots, we only keep one pair (with path
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D25598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
rogfer01 updated this revision to Diff 74638.
rogfer01 added a comment.
Updated patch, now we check if the innermost base of a MemberExpr is a
DeclRefExpr and check for its declaration in case it provides stronger
alignment guarantees.
https://reviews.llvm.org/D23657
Files:
include/clang/Se
hokein created this revision.
hokein added a reviewer: klimek.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25600
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp
Index: unittests/ASTMa
v.g.vassilev created this revision.
v.g.vassilev added a reviewer: rsmith.
v.g.vassilev added a subscriber: cfe-commits.
We are using this in the context of cling, where we keep the compiler instance
alive after EOF.
The incremental processing part in clang was done mostly by me and this patch
bkramer added a comment.
I think the assertion is correct, there's something fishy with the inputs. The
paths coming in should be absolute, and there should never be a .. at the start
in a absolute path. This only fails on a single buildbot and doesn't reproduce
anywhere else. @bruno any ideas?
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
`__libcpp_refstring` currently has two different definitions. First there is
the complete definition in `<__refstring>` but there is also a second in
``. The historical reason for this s
v.g.vassilev created this revision.
v.g.vassilev added reviewers: chandlerc, rsmith.
v.g.vassilev added a subscriber: cfe-commits.
v.g.vassilev set the repository for this revision to rL LLVM.
Repository:
rL LLVM
https://reviews.llvm.org/D25604
Files:
lib/Driver/ToolChains.cpp
Index: lib/D
EricWF added a comment.
I just spoke with Jonathan Wakely about this change, and he believes that it
should be ABI safe.
https://reviews.llvm.org/D25593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284221: [clang-move] Matching static class member more
correctly. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25598?vs=74633&id=74650#toc
Repository:
rL LLVM
https://rev
Author: hokein
Date: Fri Oct 14 05:07:58 2016
New Revision: 284221
URL: http://llvm.org/viewvc/llvm-project?rev=284221&view=rev
Log:
[clang-move] Matching static class member more correctly.
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25598
Modif
danielmarjamaki created this revision.
danielmarjamaki added reviewers: NoQ, dcoughlin.
danielmarjamaki added subscribers: cfe-commits, xazax.hun, zaks.anna, a.sidorin.
danielmarjamaki set the repository for this revision to rL LLVM.
This patch fixes false positives for such code:
#define RETUR
Author: ioeric
Date: Fri Oct 14 05:10:26 2016
New Revision: 284222
URL: http://llvm.org/viewvc/llvm-project?rev=284222&view=rev
Log:
Try to fix windows bot file path style failure caused by r284219.
Modified:
cfe/trunk/unittests/Tooling/RefactoringTest.cpp
Modified: cfe/trunk/unittests/Tooli
Author: ericwf
Date: Fri Oct 14 05:30:33 2016
New Revision: 284225
URL: http://llvm.org/viewvc/llvm-project?rev=284225&view=rev
Log:
Work around Clang driver segfault when --coverage is used with -c and /dev/null
Modified:
libcxx/trunk/test/libcxx/compiler.py
Modified: libcxx/trunk/test/libc
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
This doesn't seem right seeing as `print-libgcc_file-name` prints the
`libgcc.a` path, and we were previously linking `libgcc_s`.
https://reviews.llvm.org/D25568
___
EricWF added a comment.
Why not just compile the sources files as C++ by changing their extensions?
This change seems all kinds of wrong because we're throwing away *all* of our
flags, including things like `-m32` or `-target `.
https://reviews.llvm.org/D25431
__
ikudrin created this revision.
ikudrin added reviewers: hansonw, compnerd, indygreg, eliben.
ikudrin added a subscriber: cfe-commits.
Please note that this patch fixes only Windows-related issues.
https://reviews.llvm.org/D25470 is required to pass all the tests.
https://reviews.llvm.org/D25608
EricWF abandoned this revision.
EricWF added a comment.
Another fix was committed.
https://reviews.llvm.org/D23524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Fri Oct 14 06:48:10 2016
New Revision: 284228
URL: http://llvm.org/viewvc/llvm-project?rev=284228&view=rev
Log:
Removed duplicate header include
Reviewers: ioeric
Subscribers: klimek
Patch by Krasimir Georgiev!
Differential Revision: https://reviews.llvm.org/D25599
Modifi
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
The header guard generated by clang-move isn't always a perfect
style, just avoid getting the header included multiple times during
compiling period.
Also, we can use llvm-Header-guard clang-tid
mgorny added a comment.
In https://reviews.llvm.org/D25568#570222, @EricWF wrote:
> This doesn't seem right seeing as `print-libgcc_file-name` prints the
> `libgcc.a` path, and we were previously linking `libgcc_s`.
Do you have any other solution in mind? There is no switch to print the share
mgorny added a comment.
In https://reviews.llvm.org/D25431#570227, @EricWF wrote:
> Why not just compile the sources files as C++ by changing their extensions?
> This change seems all kinds of wrong because we're throwing away *all* of our
> flags, including things like `-m32` or `-target `.
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
Comment at: clang-move/ClangMove.cpp:264
+HeaderGuard += "#define " + GuardName + "\n";
+clang::tooling::Replacement HeaderGuardInclude(FileName, 0, 0,
+
mboehme created this revision.
mboehme added a reviewer: hokein.
mboehme added a subscriber: cfe-commits.
This adds a diagnostic to the misc-use-after-move check that is output when the
use happens on a later loop iteration than the move, for example:
A a;
for (int i = 0; i < 10; ++i) {
a
Author: abataev
Date: Fri Oct 14 07:43:59 2016
New Revision: 284229
URL: http://llvm.org/viewvc/llvm-project?rev=284229&view=rev
Log:
Fix for PR30632: Name mangling issue.
There was a bug in the implementation of captured statements. If it has
a lambda expression in it and the same lambda express
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
The code looks good.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:579
DiagnosticIDs::Note);
+ } else if(UseLoc < MoveLoc || Use.DeclRef == MoveArg) {
+
mgorny retitled this revision from "[libcxx] [CMake] Build Solaris compat as
separate C lib, to avoid -std= issues" to "[libcxx] Convert Solaris support
library to C++ to fix -std=c++11 build
".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 74666.
mgorny added
Author: ericwf
Date: Fri Oct 14 07:56:52 2016
New Revision: 284230
URL: http://llvm.org/viewvc/llvm-project?rev=284230&view=rev
Log:
Disable Modules when building the libc++ sources.
Libc++ will not build with modules enabled. In order to support an in-tree
libc++ when LLVM_ENABLE_MODULES is ON w
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:264
+HeaderGuard += "#define " + GuardName + "\n";
+clang::tooling::Replacement HeaderGuardInclude(FileName, 0, 0,
+ HeaderGuard);
ioeric
Author: asiri
Date: Fri Oct 14 08:00:07 2016
New Revision: 284232
URL: http://llvm.org/viewvc/llvm-project?rev=284232&view=rev
Log:
[libcxx] Do not declare the thread api when __external_threading is present
This fixes a small omission where even when __external_threading is provided,
we attempt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284232: [libcxx] Do not declare the thread api when
__external_threading is present (authored by asiri).
Changed prior to commit:
https://reviews.llvm.org/D25468?vs=74234&id=74668#toc
Repository:
rL
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3005
+/// \endcode
+AST_MATCHER(VarDecl, isStaticDataMember) {
+ return Node.isStaticDataMember();
How does this differ from t
Author: hokein
Date: Fri Oct 14 08:01:36 2016
New Revision: 284233
URL: http://llvm.org/viewvc/llvm-project?rev=284233&view=rev
Log:
[clang-move] Add header guard for the new header.
Summary:
The header guard generated by clang-move isn't always a perfect
style, just avoid getting the header incl
mboehme updated this revision to Diff 74671.
mboehme added a comment.
- Responses to reviewer comments
https://reviews.llvm.org/D25612
Files:
clang-tidy/misc/UseAfterMoveCheck.cpp
test/clang-tidy/misc-use-after-move.cpp
Index: test/clang-tidy/misc-use-after-move.cpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284233: [clang-move] Add header guard for the new header.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25610?vs=74663&id=74669#toc
Repository:
rL LLVM
https://reviews.llv
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25613
Files:
clang-move/ClangMove.cpp
Index: clang-move/ClangMove.cpp
===
--- clang-move/ClangMove.c
Author: mboehme
Date: Fri Oct 14 08:23:39 2016
New Revision: 284235
URL: http://llvm.org/viewvc/llvm-project?rev=284235&view=rev
Log:
[clang-tidy] Add additional diagnostic to misc-use-after-move
Summary:
This adds a diagnostic to the misc-use-after-move check that is output when the
use happens
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284235: [clang-tidy] Add additional diagnostic to
misc-use-after-move (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D25612?vs=74671&id=74673#toc
Repository:
rL LLVM
https:
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:472
std::string FilePath = RemoveReplacement.getFilePath().str();
addOrMergeReplacement(RemoveReplacement, &FileToReplacements[FilePath]);
For deletions, you can simply use `add`, whic
hokein updated this revision to Diff 74675.
hokein added a comment.
woohoo, delete more code!
https://reviews.llvm.org/D25613
Files:
clang-move/ClangMove.cpp
Index: clang-move/ClangMove.cpp
===
--- clang-move/ClangMove.cpp
+++ c
hokein updated this revision to Diff 74677.
hokein added a comment.
Delete one more function.
https://reviews.llvm.org/D25613
Files:
clang-move/ClangMove.cpp
Index: clang-move/ClangMove.cpp
===
--- clang-move/ClangMove.cpp
+++ c
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Awesome! Lg with one nit.
Comment at: clang-move/ClangMove.cpp:197
clang::tooling::Replacement
getReplacementInChangedCode(const clang::tooling::Replacements &Replacements,
Author: hokein
Date: Fri Oct 14 08:43:49 2016
New Revision: 284236
URL: http://llvm.org/viewvc/llvm-project?rev=284236&view=rev
Log:
[clang-move] Don't overuse Replacements::add.
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25613
Modified:
cla
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL284236: [clang-move] Don't overuse Replacements::add.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25613?vs=74677&id=74679#toc
Repos
ABataev added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:1044-1070
+static bool isBaseClass(const CXXRecordDecl *Record, CXXRecordDecl *Base) {
+ SmallVector Queue;
+
+ while (true) {
+for (const auto &I : Record->bases()) {
+ const RecordType *Ty = I.getType
emaste added inline comments.
Comment at: lib/abi/CHANGELOG.TXT:22
+ Although this change removes symbols, it should still be non-ABI breaking
+ since all of the definitions removed are inline functions.
+
Should we also include in this comment the further just
Author: asiri
Date: Fri Oct 14 08:56:58 2016
New Revision: 284237
URL: http://llvm.org/viewvc/llvm-project?rev=284237&view=rev
Log:
[libcxx] Improve the gcc workaround for the missing __has_include macro.
NFC.
Modified:
libcxx/trunk/include/__threading_support
Modified: libcxx/trunk/include
ikudrin accepted this revision.
ikudrin added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
ikudrin accepted this revision.
ikudrin added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Is there a bug to track this problem so it doesn't get lost?
--paulr
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Reid
Kleckner via cfe-commits
Sent: Thursday, October 13, 2016 4:02 PM
To: Arnold Schwaighofer
Cc: cfe-commits
Subject: Re: r284174 - Disable swiftcall t
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
hokein added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3005
+/// \endcode
+AST_MATCHER(VarDecl, isStaticDataMember) {
+ return Node.isStaticDataMember();
aaron.ballman wrote:
> How does this differ from the existing matcher `hasStaticS
https://llvm.org/bugs/show_bug.cgi?id=30699
> On Oct 14, 2016, at 7:11 AM, Robinson, Paul wrote:
>
> Is there a bug to track this problem so it doesn't get lost?
> --paulr
>
> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
> Reid Kleckner via cfe-commits
> Sent: T
vleschuk created this revision.
vleschuk added reviewers: aprantl, mehdi_amini, dblaikie, echristo.
vleschuk added a subscriber: cfe-commits.
Use DIAlignment type introduced in https://reviews.llvm.org/D25620
https://reviews.llvm.org/D25621
Files:
include/clang/AST/ASTContext.h
include/clan
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3005
+/// \endcode
+AST_MATCHER(VarDecl, isStaticDataMember) {
+ return Node.isStaticDataMember();
hokein wrote:
> aaron.ballman wrote:
> > How does this differ from the exi
vleschuk updated this revision to Diff 74686.
vleschuk added a comment.
Use DIAlignment type instead of uint64_t for alignment in DebugInfo.
https://reviews.llvm.org/D24426
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGen/debug-info-packed-struct.c
test/CodeGen/
yaxunl added a comment.
The test looks OK. However, the patch only contains the test now.
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AlexeySotkin updated this revision to Diff 74693.
AlexeySotkin added a comment.
Squashing commits
https://reviews.llvm.org/D25305
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGenOpenCL/private-array-initialization.cl
Index: test/CodeGenOpenCL/private-array-initialization.cl
AlexeySotkin added a comment.
Now there should be both :)
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ehsan resigned from this revision.
ehsan removed a reviewer: ehsan.
ehsan added a comment.
I also don't know enough about the build system to review this, sorry!
Repository:
rL LLVM
https://reviews.llvm.org/D1
___
cfe-commits mailing list
cfe
dcoughlin added a comment.
In https://reviews.llvm.org/D25326#569061, @danielmarjamaki wrote:
> > You could also try to add a canary with clang analyzer eval after the if
> > statement to force the test to fail if we do add this symbolic reasoning.
>
> sounds good. sorry but I don't see how to d
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
ayartsev closed this revision.
ayartsev added a comment.
Closed by r283499.
https://reviews.llvm.org/D22494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya created this revision.
hiraditya added reviewers: mclow.lists, EricWF.
hiraditya added subscribers: laxmansole, sebpop, cfe-commits.
Author: laxmansole
Original Differential Revision: https://reviews.llvm.org/D22834
Posting the patch again as the bug https://llvm.org/bu
aprantl added inline comments.
Comment at: include/clang/AST/ASTContext.h:83
uint64_t Width;
-unsigned Align;
+llvm::DIAlignment Align;
bool AlignIsRequired : 1;
I'm not sure we want to use a debug info type inside the AST. I think we only
want
See attached.
Returning a bool from main is a special case of return type mismatch. The
common convention when returning a bool is that 'true' (== 1) indicates
success and 'false' (== 0) failure. But since main expects a return value
of 0 on success, returning a bool is usually unintended.
From 4b
zaks.anna added a comment.
We should pattern match for this specific macro pattern (ex: do{...}while(0) )
instead of suppressing all warnings coming from macros. Maybe we could use the
same heuristic as -Wunreachable-code-return compiler warning?
Repository:
rL LLVM
https://reviews.llvm.org
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: agutowski
Date: Fri Oct 14 12:33:05 2016
New Revision: 284253
URL: http://llvm.org/viewvc/llvm-project?rev=284253&view=rev
Log:
Implement __stosb intrinsic as a volatile memset
Summary: We need `__stosb` to be an intrinsic, because SecureZeroMemory
function uses it without including intr
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
On Fri, Oct 14, 2016 at 12:49 AM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Fri Oct 14 02:49:15 2016
> New Revision: 284210
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284210&view=rev
> Log:
> XFAIL aligned allocation test failures with UBSAN
Author: emaste
Date: Fri Oct 14 12:59:53 2016
New Revision: 284256
URL: http://llvm.org/viewvc/llvm-project?rev=284256&view=rev
Log:
Link static PIE programs against rcrt0.o on OpenBSD
Patch by Stefan Kempf.
Differential Revision: https://reviews.llvm.org/D22130
Modified:
cfe/trunk/lib/Dri
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284256: Link static PIE programs against rcrt0.o on OpenBSD
(authored by emaste).
Changed prior to commit:
https://reviews.llvm.org/D22130?vs=68046&id=74718#toc
Repository:
rL LLVM
https://reviews.l
Author: emaste
Date: Fri Oct 14 13:20:12 2016
New Revision: 284259
URL: http://llvm.org/viewvc/llvm-project?rev=284259&view=rev
Log:
Revert r284256 due to test failure
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/openbsd.c
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
Hi Richard,
I have a patch on top of your suggested patch from a year ago, that
break the cyclic dependency we're seeing, with this (and a few changes
to the SDK) we can bootstrap clang with submodule local visibility on
darwin. I've attached the patch with a reduced, standalone testcase
that does
Author: mren
Date: Fri Oct 14 13:55:44 2016
New Revision: 284263
URL: http://llvm.org/viewvc/llvm-project?rev=284263&view=rev
Log:
Module: emit initializers in submodules when importing the parent module.
When importing the parent module, module initializers in submodules should
be emitted.
rdar
Hi Richard,
Another follow-up commit r284263.
When we import the top-level module with “@import X;”, all the initializers in
the submodule should be emitted.
Let me know if you see any problem,
Manman
> On Oct 13, 2016, at 4:03 PM, Richard Smith wrote:
>
> On Thu, Oct 13, 2016 at 11:52 AM, M
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284265: [Sema] Refactor context checking for availability
diagnostics (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D25283?vs=74547&id=74729#toc
Repository:
rL LLVM
https://
Author: epilk
Date: Fri Oct 14 14:08:01 2016
New Revision: 284265
URL: http://llvm.org/viewvc/llvm-project?rev=284265&view=rev
Log:
[Sema] Refactor context checking for availability diagnostics
This commit combines a couple of redundant functions that do availability
attribute context checking in
This is breaking tests for me:
Unexpected Passing Tests (4):
libc++ ::
std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t.pass.cpp
libc++ ::
std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow.pass.cpp
libc++ ::
std/lan
1 - 100 of 163 matches
Mail list logo
