malcolm.parsons updated this revision to Diff 74476.
malcolm.parsons added a comment.
Combine matchers
https://reviews.llvm.org/D25316
Files:
clang-tidy/modernize/UseAutoCheck.cpp
clang-tidy/modernize/UseAutoCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/modernize-use-auto.rst
t
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm with a comment
Comment at: test/CodeGen/ms-intrinsics.c:3
// RUN: -triple i686--windows -Oz -emit-llvm %s -o - \
-// RUN: | FileCheck %s -check-prefix=CHECK
majnemer added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:1151-1152
+ case Builtin::BI_ReturnAddress: {
+Value *Depth =
+Constant::getNullValue(ConvertType(getContext().UnsignedIntTy));
+Value *F = CGM.getIntrinsic(Intrinsic::returnaddress);
-
danielmarjamaki set the repository for this revision to rL LLVM.
danielmarjamaki updated this revision to Diff 74478.
danielmarjamaki added a comment.
Herald added a subscriber: modocache.
changed cast(D)->getName() to cast(D)
Repository:
rL LLVM
https://reviews.llvm.org/D24656
Files:
clan
Author: hokein
Date: Thu Oct 13 03:48:42 2016
New Revision: 284109
URL: http://llvm.org/viewvc/llvm-project?rev=284109&view=rev
Log:
Recommit r283538 "[clang-move] Support moving multiple classes in one run."
Added:
clang-tools-extra/trunk/test/clang-move/Inputs/multiple_class_test.cpp
cl
Author: abataev
Date: Thu Oct 13 04:52:46 2016
New Revision: 284110
URL: http://llvm.org/viewvc/llvm-project?rev=284110&view=rev
Log:
Fix for PR30639: CGDebugInfo Null dereference with OpenMP array
access, by Erich Keane
OpenMP creates a variable array type with a a null size-expr. The Debug
gene
krememek added a comment.
Looks great to me too. Thanks for doing this!
Repository:
rL LLVM
https://reviews.llvm.org/D25503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284110: Fix for PR30639: CGDebugInfo Null dereference with
OpenMP array (authored by ABataev).
Changed prior to commit:
https://reviews.llvm.org/D25373?vs=74386&id=74485#toc
Repository:
rL LLVM
http
hokein updated this revision to Diff 74490.
hokein added a comment.
Rebase to master.
https://reviews.llvm.org/D25369
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/multiple_class_test.cpp
test/clang-move/Inputs/multiple_class_test.h
test/clang-move/move-multiple-classes.cpp
In
Author: hokein
Date: Thu Oct 13 05:31:00 2016
New Revision: 284111
URL: http://llvm.org/viewvc/llvm-project?rev=284111&view=rev
Log:
[clang-move] Better support enclosing class.
Summary:
* When moving an outermost enclosing class, all its nested classes should also
be moved together.
* Add a te
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284111: [clang-move] Better support enclosing class.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25369?vs=74490&id=74492#toc
Repository:
rL LLVM
https://reviews.llvm.org
a.sidorin accepted this revision.
a.sidorin added a comment.
This patch reduces both the analysis time and the line count. I like it! :)
Did you test Artem's approach?
Repository:
rL LLVM
https://reviews.llvm.org/D25503
___
cfe-commits mailing li
NoQ accepted this revision.
NoQ added a comment.
In https://reviews.llvm.org/D25503#569046, @a.sidorin wrote:
> Did you test Artem's approach?
I don't think this is necessary, the priority queue looks like "the" data
structure to use here.
Repository:
rL LLVM
https://reviews.llvm.org/D255
danielmarjamaki added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D24861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki added a comment.
I agree with the comments from you dcoughlin but I am not sure how to do it.
> Can you also add a test that tests this more directly (i.e., with
> clang_analyzer_warnIfReached). I don't think it is good to have the only test
> for this core coverage issue to be
Author: dergachev
Date: Thu Oct 13 06:41:12 2016
New Revision: 284112
URL: http://llvm.org/viewvc/llvm-project?rev=284112&view=rev
Log:
[analyzer] Link libStaticAnalyzerCheckers to libASTMatchers.
AST matchers are useful for the analyzer's checkers.
More patches on particular checkers shall follo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284112: [analyzer] Link libStaticAnalyzerCheckers to
libASTMatchers. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D25429?vs=74109&id=74497#toc
Repository:
rL LLVM
https
sdardis updated this revision to Diff 74499.
sdardis added a comment.
Update ld / st to respect their range and multiple of 16 constraint.
https://reviews.llvm.org/D25017
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaChecking.cpp
test/CodeGen/b
AlexeySotkin removed rL LLVM as the repository for this revision.
AlexeySotkin updated this revision to Diff 74482.
AlexeySotkin added a comment.
Adding test checking address space of array initializer
https://reviews.llvm.org/D25305
Files:
test/CodeGenOpenCL/private-array-initialization.cl
zizhar updated this revision to Diff 74500.
zizhar added a comment.
changed :)
Thanks for the review :>
https://reviews.llvm.org/D15075
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/TargetInfo.h
lib/Basic/TargetInfo.cpp
lib/Basic/Targets.cpp
lib/Headers/intrin.
Hello, i would like to suggest a fix for one of the checks in clang-tidy and i should hope this one is the correct mailing list.The check is modernize-avoid-bind.Consider the following:void bar(int x, int y);namespace N{ void bar(int x, int y);}void foo(){ auto Test = std::bind(N::bar,1,1);}clang
v.g.vassilev added a subscriber: djasper.
v.g.vassilev added a comment.
I think @djasper could help with this review.
https://reviews.llvm.org/D7842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
djasper accepted this revision.
djasper added a reviewer: djasper.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D7842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
https://reviews.llvm.org/D20785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D25479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
SjoerdMeijer added a comment.
thanks again for reviewing.
https://reviews.llvm.org/D25479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 13 October 2016 at 03:42, Richard Smith wrote:
> Do we need the same change for if-statements too?
>
Yes, a similar change should be made for them as well.
>
> On 12 Oct 2016 6:26 pm, "Vedant Kumar via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
>
>> vsk created this revision.
>> vs
Author: marshall
Date: Thu Oct 13 08:21:38 2016
New Revision: 284120
URL: http://llvm.org/viewvc/llvm-project?rev=284120&view=rev
Log:
Add missing include in test; NFC. Thanks to Jonathan Wakely for the report.
Modified:
libcxx/trunk/test/std/algorithms/alg.modifying.operations/alg.partition
ahatanak created this revision.
ahatanak added reviewers: rsmith, rjmccall.
ahatanak added a subscriber: cfe-commits.
When compiling the following code, DoMarkVarDeclReferenced fails to capture
variable "outerp":
auto lambda =[&](auto p) {
return ^{
return p + outerp;
}();
};
arphaman added a comment.
> I'm unsure about whether or not the CodeGenPGO change in this patch deserves
> more testing.
It wouldn't harm to add a test for CodeGenPGO as well. A good test that you can
as a starting point for the new one is `test/Profile/cxx-rangefor.cpp`. A
single `PGOGEN` che
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284121: Guard flag –fdenormal-fp-math with –fno-fast-math.
(authored by SjoerdMeijer).
Changed prior to commit:
https://reviews.llvm.org/D25479?vs=74363&id=74508#toc
Repository:
rL LLVM
https://revi
omtcyfz updated this revision to Diff 74509.
omtcyfz marked 5 inline comments as done.
omtcyfz added a comment.
Herald added a subscriber: modocache.
Addressed bunch of comments.
https://reviews.llvm.org/D25024
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang
omtcyfz added inline comments.
Comment at: clang-tidy/cppcoreguidelines/OneNamePerDeclarationCheck.cpp:38
+ diag(MultipleNameDeclaration->getStartLoc(),
+ "Do not declare multiple names per declaration");
+}
aaron.ballman wrote:
> Diagnostics do not start
Author: asiri
Date: Thu Oct 13 09:32:24 2016
New Revision: 284125
URL: http://llvm.org/viewvc/llvm-project?rev=284125&view=rev
Log:
[libunwind] Add missing include. NFC.
This missing include seems to cause compilation failures on older MacOS
versions (< 10.9). This is because r270692 has introdu
Hi Jeremy,
Thanks for the patch, committed as r284125.
Cheers,
/ Asiri
From: jerem...@apple.com on behalf of Jeremy Huddleston
Sequoia
Sent: 13 October 2016 06:57
To: Asiri Rathnayake
Subject: libunwind build regression fix
Hi Asiri,
Could you pleas
yaxunl updated this revision to Diff 74514.
yaxunl marked 5 inline comments as done.
yaxunl added a comment.
Revised by Aaron's comments. Added a sema test.
https://reviews.llvm.org/D25343
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/CGCall.cpp
lib/Head
And... apologies for that disclaimer notice.
Cheers,
/ Asiri
From: cfe-commits on behalf of Asiri
Rathnayake via cfe-commits
Sent: 13 October 2016 15:42
To: Jeremy Huddleston Sequoia
Cc: cfe-commits@lists.llvm.org
Subject: Re: libunwind build regressio
arphaman added a comment.
In https://reviews.llvm.org/D25520#568448, @akyrtzi wrote:
> What if the user just wants to invoke the block, this is as common or more,
> like:
>
> `self.onEventHandler(10)`
>
> The assign literal completion is useful but it should be an additional entry
> (with maybe
rmaprath updated this revision to Diff 74519.
rmaprath added a comment.
Herald added a subscriber: modocache.
Patch re-based on the latest trunk.
I've resolved my downstream issues, will be committing soon.
/ Asiri
https://reviews.llvm.org/D24864
Files:
CMakeLists.txt
src/config.h
src/c
arphaman updated this revision to Diff 74520.
arphaman marked 2 inline comments as done.
arphaman added a comment.
The updated patch has comments for the two extracted functions.
Repository:
rL LLVM
https://reviews.llvm.org/D25519
Files:
lib/Sema/SemaCodeComplete.cpp
Index: lib/Sema/SemaC
Author: asiri
Date: Thu Oct 13 10:05:19 2016
New Revision: 284128
URL: http://llvm.org/viewvc/llvm-project?rev=284128&view=rev
Log:
[libcxxabi] Refactor pthread usage into a separate API
This patch refactors all pthread uses of libc++abi into a separate API. This
is the first step towards support
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-one-name-per-declaration.cpp:8
+ {
+int x = 42, y = 43;
+// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: Do not declare multiple names
per declaration [cppcoreguidelines-one-name-per-declar
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added subscribers: cfe-commits, bkramer, hokein.
Herald added a subscriber: klimek.
If there are multiple pairs with the same file
path after removing dots, we only keep one pair (with path after dots being
removed) and discar
ioeric updated this revision to Diff 74531.
ioeric added a comment.
- Updated comments for RefactoringTool.
https://reviews.llvm.org/D25565
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactoring.cpp
arphaman updated this revision to Diff 74528.
arphaman added a comment.
The updated patch now treats the block property setter completion as a
completion result that's additional to the default property completion result.
Repository:
rL LLVM
https://reviews.llvm.org/D25520
Files:
include/
arphaman added a comment.
Right now I gave the setter completion a flat priority bump of 3. Should
something different be used? What do you think of the following possible
priority heuristic: when completing blocks properties that return `void` the
default property completion result should show
agutowski updated this revision to Diff 74533.
agutowski added a comment.
change checking prefix for x86 tests; use Int32 instead of UnsignedIntTy
https://reviews.llvm.org/D25540
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/BuiltinsX86.def
lib/CodeGen/CGBuiltin.cpp
lib/He
Author: agutowski
Date: Thu Oct 13 11:03:42 2016
New Revision: 284131
URL: http://llvm.org/viewvc/llvm-project?rev=284131&view=rev
Log:
Implement MS _ReturnAddress and _AddressOfReturnAddress intrinsics
Reviewers: rnk, thakis, majnemer, hans
Subscribers: cfe-commits
Differential Revision: https
v.g.vassilev added a comment.
This patch needs rebasing.
https://reviews.llvm.org/D7842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev added a comment.
The print related changes were added in in r280240
(https://reviews.llvm.org/D23319). Could you rebase the patch?
Repository:
rL LLVM
https://reviews.llvm.org/D20785
___
cfe-commits mailing list
cfe-commits@lists.ll
ioeric added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:233
- Replacements mergeReplacements(const ReplacementsImpl &Second) const;
-
This is dead code.
https://reviews.llvm.org/D25565
___
aaron.ballman added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-one-name-per-declaration.cpp:8
+ {
+int x = 42, y = 43;
+// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: Do not declare multiple names
per declaration [cppcoreguidelines-one-name-per-declarat
rnk added a comment.
Nice! Looks like this wasn't too bad.
Comment at: clang/lib/Sema/SemaCUDA.cpp:546
+ // Externally-visible and similar functions are always emitted.
+ if (S.getASTContext().GetGVALinkageForFunction(FD) > GVA_DiscardableODR)
+return true;
--
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from some minor nits, the attribute functionality looks fine to me. As to
whether we think this is a worthy attribute to add or not, I leave that to
people who know CUDA an
mgorny created this revision.
mgorny added a reviewer: EricWF.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: modocache, beanz.
Use the -print-libgcc-file-name compiler option to obtain the path to
libgcc or an equivalent compiler runtime library, rather than hardcoding
-lgcc_s.
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 74536.
https://reviews.llvm.org/D25568
Files:
cmake/Modules/HandleLibcxxFlags.cmake
lib/CMakeLists.txt
Index: lib/CMakeLists.txt
===
--- lib/CMa
mgorny updated this revision to Diff 74538.
mgorny added a comment.
Fixed indentation.
https://reviews.llvm.org/D25568
Files:
cmake/Modules/HandleLibcxxFlags.cmake
lib/CMakeLists.txt
Index: lib/CMakeLists.txt
===
--- lib/CMak
akyrtzi added a comment.
> What do you think of the following possible priority heuristic
SGTM.
Changes LGTM. I'd also recommend that as a follow-up patch it would be great to
extend the setter completion to variables as well (global variables, fields,
ivars, etc.)
Repository:
rL LLVM
h
Thanks.
> On Oct 13, 2016, at 07:42, Asiri Rathnayake wrote:
>
> Hi Jeremy,
>
> Thanks for the patch, committed as r284125.
>
> Cheers,
>
> / Asiri
>
>
> From: jerem...@apple.com on behalf of Jeremy Huddleston
> Sequoia
> Sent: 13 October 2016 06:5
Author: arnolds
Date: Thu Oct 13 12:17:36 2016
New Revision: 284133
URL: http://llvm.org/viewvc/llvm-project?rev=284133&view=rev
Log:
Add more 64bit swiftcall convention tests
Added:
cfe/trunk/test/CodeGen/64bit-swiftcall.c
Added: cfe/trunk/test/CodeGen/64bit-swiftcall.c
URL:
http://llvm.or
yaxunl updated this revision to Diff 74541.
yaxunl added a comment.
Minor revision by Aaron's comments.
https://reviews.llvm.org/D25343
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/CGCall.cpp
lib/Headers/opencl-c.h
lib/Sema/SemaDeclAttr.cpp
test/Cod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284137: [ThinLTO] Update doc to include lld (now supported).
(authored by davide).
Changed prior to commit:
https://reviews.llvm.org/D25537?vs=74459&id=74545#toc
Repository:
rL LLVM
https://reviews.
Author: davide
Date: Thu Oct 13 12:42:38 2016
New Revision: 284137
URL: http://llvm.org/viewvc/llvm-project?rev=284137&view=rev
Log:
[ThinLTO] Update doc to include lld (now supported).
Differential Revision: https://reviews.llvm.org/D25537
Modified:
cfe/trunk/docs/ThinLTO.rst
Modified: cf
rjmccall requested changes to this revision.
rjmccall added inline comments.
This revision now requires changes to proceed.
Comment at: lib/CodeGen/CodeGenFunction.h:379
+ /// Set of object pointers which are blacklisted from the UB sanitizer.
+ llvm::SmallPtrSet SanitizerBaseP
vsk updated the summary for this revision.
vsk updated this revision to Diff 74552.
vsk added a comment.
Per @arphaman's comments:
- Add a CodeGenPGO test which checks whether counters can be created for
statements inside of switch initializers.
- Group calls to 'Visit' together.
https://revie
Author: tejohnson
Date: Thu Oct 13 13:05:53 2016
New Revision: 284140
URL: http://llvm.org/viewvc/llvm-project?rev=284140&view=rev
Log:
Pass -ffunction-sections/-fdata-sections along to gold-plugin
Summary:
These options need to be passed to the plugin in order to have
an effect on LTO/ThinLTO co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284140: Pass -ffunction-sections/-fdata-sections along to
gold-plugin (authored by tejohnson).
Changed prior to commit:
https://reviews.llvm.org/D24644?vs=71591&id=74555#toc
Repository:
rL LLVM
http
erik.pilkington updated this revision to Diff 74547.
erik.pilkington added a comment.
This new patch fixes the style issues @aaron.ballman and @manmanren brought up.
Thanks,
Erik
https://reviews.llvm.org/D25283
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaDecl.cpp
lib/Sema/SemaDeclAttr.c
erik.pilkington added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:179
- if (const DeclContext *DC = S.getCurObjCLexicalContext())
-ContextVersion = S.getVersionForDecl(cast(DC));
-
manmanren wrote:
> I don't quite get why we can remove the above logic
Looks like this broke the gcc builder:
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-gcc49-cxx11/builds/573/steps/build.libcxxabi/logs/stdio
I'll have a look soon, might not be able to do so before tomorrow. Please
feel free to revert if this is blocking.
Sorry for the tr
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D25571
Files:
clang/include/clang/Basic/Linkage.h
clang/include/clang/Sema/Sema.h
clang/lib/AST/ASTContext.cpp
clang/lib/Sema/SemaCUDA.cpp
Index: clang/lib/Sema/S
On Thu, Oct 13, 2016 at 02:32:24PM -, Asiri Rathnayake via cfe-commits
wrote:
> This missing include seems to cause compilation failures on older MacOS
> versions (< 10.9). This is because r270692 has introduced uint64_t into
> config.h without including this header.
But that would be inttype
vsk created this revision.
vsk added reviewers: arphaman, ikudrin.
vsk added a subscriber: cfe-commits.
Generate coverage mappings for in if (; ).
Here's some sample output (let's hope phab gets the spaces right :) --
12| |// CHECK-LABEL: define {{.*}}void @_Z11switch_initv()
13|
jacquelinekay added a comment.
I tested clang-format in vim with the recent state of trunk and it seems to
work without my patch. The bug I ran into initially was fixed in
https://reviews.llvm.org/D23319 with added encoding. So I think this can be
closed without merging.
Repository:
rL LLVM
sebpop added a comment.
In https://reviews.llvm.org/D24991#565861, @EricWF wrote:
> In https://reviews.llvm.org/D24991#565715, @mclow.lists wrote:
>
> > How does this play with existing binaries? Applications that expect these
> > functions to exist in the dylib?
>
>
> This patch is majorly ABI
rjmccall added a comment.
The correct fix is to honor isInit by folding the logic for EmitScalarInit into
this function. That should allow you to eliminate EmitScalarInit completely,
although it would be fine to leave it as just a call to EmitStoreThroughLValue.
I did a quick audit of all the
jlebar marked 2 inline comments as done.
jlebar added a comment.
In https://reviews.llvm.org/D25541#569360, @rnk wrote:
> Nice! Looks like this wasn't too bad.
Like many things in my life lately, it wasn't after Richard explained to me how
to do it. :)
Thank you for the review.
=
Author: asiri
Date: Thu Oct 13 13:40:57 2016
New Revision: 284141
URL: http://llvm.org/viewvc/llvm-project?rev=284141&view=rev
Log:
[libcxxabi] Fix gcc build after r284128
NFC.
Modified:
libcxxabi/trunk/src/config.h
Modified: libcxxabi/trunk/src/config.h
URL:
http://llvm.org/viewvc/llvm-pr
Author: mren
Date: Thu Oct 13 13:42:14 2016
New Revision: 284142
URL: http://llvm.org/viewvc/llvm-project?rev=284142&view=rev
Log:
Module: emit initializers for C/ObjC after r276159.
In r276159, we started to defer emitting initializers for VarDecls, but
forgot to add the initializers for non-C++
Hi Richard,
I committed a follow-up patch in r284142 to fix issues with C/ObjC.
Let me know if you see any problem.
Manman
> On Jul 20, 2016, at 12:10 PM, Richard Smith via cfe-commits
> wrote:
>
> Author: rsmith
> Date: Wed Jul 20 14:10:16 2016
> New Revision: 276159
>
> URL: http://llvm.o
Should be fixed in r284141.
/ Asiri
On Thu, Oct 13, 2016 at 7:20 PM, Asiri Rathnayake <
asiri.rathnay...@gmail.com> wrote:
> Looks like this broke the gcc builder: http://lab.llvm.org:
> 8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-
> gcc49-cxx11/builds/573/steps/build.libcxxabi/logs/stdio
Author: jlebar
Date: Thu Oct 13 13:45:13 2016
New Revision: 284144
URL: http://llvm.org/viewvc/llvm-project?rev=284144&view=rev
Log:
[CUDA] Disallow __shared__ variables in host functions.
Reviewers: tra, rnk
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25143
Modif
Author: jlebar
Date: Thu Oct 13 13:45:08 2016
New Revision: 284143
URL: http://llvm.org/viewvc/llvm-project?rev=284143&view=rev
Log:
[CUDA] Add Sema::CUDADiagBuilder and Sema::CUDADiagIf{Device,Host}Code().
Summary:
Together these let you easily create diagnostics that
- are never emitted for h
Author: jlebar
Date: Thu Oct 13 13:45:17 2016
New Revision: 284145
URL: http://llvm.org/viewvc/llvm-project?rev=284145&view=rev
Log:
[CUDA] Allow static variables in __host__ __device__ functions, so long as
they're never codegen'ed for device.
Reviewers: tra, rnk
Subscribers: cfe-commits
Diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284144: [CUDA] Disallow __shared__ variables in host
functions. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25143?vs=73172&id=74565#toc
Repository:
rL LLVM
https://revie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284145: [CUDA] Allow static variables in __host__ __device__
functions, so long as… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25150?vs=73182&id=74566#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284143: [CUDA] Add Sema::CUDADiagBuilder and
Sema::CUDADiagIf{Device,Host}Code(). (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25139?vs=73576&id=74564#toc
Repository:
rL L
Author: ioeric
Date: Thu Oct 13 13:56:14 2016
New Revision: 284147
URL: http://llvm.org/viewvc/llvm-project?rev=284147&view=rev
Log:
Print stack trace for clang-change-namespace tool.
Modified:
clang-tools-extra/trunk/change-namespace/tool/ClangChangeNamespace.cpp
Modified: clang-tools-extra
Had a look at the C99 spec, according to section 7.18.1.1 ("Exact-width
integer types"), the types uint_t should be available in stdint.h
itself, inttypes.h on the other hand builds on stdint.h and provides more
functionality.
I don't see a particular need to include inttypes.h here?
Cheers,
/ A
Author: ioeric
Date: Thu Oct 13 14:04:19 2016
New Revision: 284148
URL: http://llvm.org/viewvc/llvm-project?rev=284148&view=rev
Log:
Print stack trace for clang-move tool.
Modified:
clang-tools-extra/trunk/clang-move/tool/ClangMoveMain.cpp
Modified: clang-tools-extra/trunk/clang-move/tool/Cl
rmaprath added a comment.
@EricWF: Gentle ping.
https://reviews.llvm.org/D25468
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
Ping.
https://reviews.llvm.org/D25292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arnolds
Date: Thu Oct 13 14:19:37 2016
New Revision: 284150
URL: http://llvm.org/viewvc/llvm-project?rev=284150&view=rev
Log:
Swift Calling Convention: Fix out of bounds access
Use iterator instead of address of element in vector
It is not valid to access one after the last element.
rda
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Thanks I am closing it!
Repository:
rL LLVM
https://reviews.llvm.org/D20785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: compnerd
Date: Thu Oct 13 14:45:08 2016
New Revision: 284154
URL: http://llvm.org/viewvc/llvm-project?rev=284154&view=rev
Log:
CodeGen: ensure that the runtime calling convention matches
Incorrect specification of the calling convention results in UB which can cause
the code path to be el
Author: ioeric
Date: Thu Oct 13 14:49:19 2016
New Revision: 284155
URL: http://llvm.org/viewvc/llvm-project?rev=284155&view=rev
Log:
[clang-move] error out when fail to create new files.
Modified:
clang-tools-extra/trunk/clang-move/tool/ClangMoveMain.cpp
Modified: clang-tools-extra/trunk/cla
Author: compnerd
Date: Thu Oct 13 15:10:22 2016
New Revision: 284156
URL: http://llvm.org/viewvc/llvm-project?rev=284156&view=rev
Log:
test: attempt to repair SCEI buildbots
The tests target ARM, ensure that the ARM target is registered.
Modified:
cfe/trunk/test/CodeGenObjC/runtime-abi-match
agutowski created this revision.
agutowski added reviewers: rnk, hans, majnemer, mstorsjo.
agutowski added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
Previously global 64-bit versions of _Interlocked functions broke buildbots on
i386, so now I'm adding them as builtins for x8
rnk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2730
+llvm::AtomicOrdering::SequentiallyConsistent);
+return Builder.CreateSub(RMWI, ConstantInt::get(IntTy, 1));
}
Can you make a helper similar to MakeBinaryAtomicValue for inc/dec
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang/include/clang/Sema/Sema.h:9244
/// CUDAKnownEmittedFns.
- llvm::DenseMap> CUDACallGraph;
+ llvm::DenseMap>
CUDACallGraph;
I think yo
1 - 100 of 153 matches
Mail list logo
