Author: marshall
Date: Tue Oct 11 16:24:06 2016
New Revision: 283945
URL: http://llvm.org/viewvc/llvm-project?rev=283945&view=rev
Log:
Remove extraneous 'const' in the implementation of is_move_assignable. Howard
pleads temporary insanity about this. Discussed at
http://stackoverflow.com/questi
rsmith added inline comments.
Comment at: include/clang/AST/Decl.h:1213
+ bool isThisDeclarationADemotedDefinition() const {
+return NonParmVarDeclBits.IsThisDeclarationADemotedDefinition;
+ }
This is the bug. You can't read this bit here without first chec
EricWF added inline comments.
Comment at: include/__threading_support:25
// redundancy is intentional.
#if defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)
#if !defined(__clang__) && (_GNUC_VER < 500)
If `_LIBCPP_HAS_THREAD_API_EXTERNAL` is defined can't we just assum
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:378
+ Lexer::getLocForEndOfToken(Range.getEnd(), 0, SM,
Context->getLangOpts());
+ bool Whitespace = isWhitespace(*FullSourceLoc(Next, SM).getCharacterData());
+
aaron
rsmith added inline comments.
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:4849
+ DeclarationName Name = D->getDeclName();
+ if (auto *DD = dyn_cast(D))
+Name =
ahatanak wrote:
> rsmith wrote:
> > Do we need to do this for conversion fun
Yup, GCC is "fast enough" again. Thanks :)
On Tue, Oct 11, 2016 at 9:13 PM, Mehdi Amini wrote:
> Reverted in r283920, can you check if it is enough to “fix” the GCC issue?
>
>> On Oct 11, 2016, at 12:04 PM, Benjamin Kramer wrote:
>>
>> Committing this patch before the constexpr change seems back
rsmith added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:11356-11357
+ // Compute the EffectiveAlignment as the alignment of the whole chain.
+ CharUnits EffectiveAlignment = Context.getTypeAlignInChars(
+ ReverseMemberChain.back()->getParent()->getTypeForDecl()
Author: vedantk
Date: Tue Oct 11 16:56:05 2016
New Revision: 283949
URL: http://llvm.org/viewvc/llvm-project?rev=283949&view=rev
Log:
[Profile] Update testcase for r283948 (NFC)
Old: "__DATA,__llvm_prf_data"
New: "__DATA,__llvm_prf_data,regular,live_support"
This should fix the following bot fai
rmaprath added a comment.
Added some comments to @EricWF's feedback. Will check back tomorrow (falling
asleep...)
/ Asiri
Comment at: include/__threading_support:25
// redundancy is intentional.
#if defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)
#if !defined(__clang__) && (_GNUC
Author: sqlbyme
Date: Tue Oct 11 17:09:13 2016
New Revision: 283950
URL: http://llvm.org/viewvc/llvm-project?rev=283950&view=rev
Log:
Revert - When optimizing for size, enable loop rerolling by default
This reverts r283685 as it is causing test failures on Green Dragon.
Modified:
cfe/trunk/l
rnk added a comment.
We shouldn't thread this kind of boolean all the way through name lookup. This
is the kind of thing that callers should configure on the LookupResult object
that they pass in.
https://reviews.llvm.org/D25458
___
cfe-commits ma
Author: ericwf
Date: Tue Oct 11 17:18:09 2016
New Revision: 283951
URL: http://llvm.org/viewvc/llvm-project?rev=283951&view=rev
Log:
Fix LWG2683 - filesystem::copy() should always clear the user-provided
error_code
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
libcxx
rnk added a comment.
Can you provide a more complete motivating example where our diagnostics were
bad? I'm having a hard time figuring it out from the test
https://reviews.llvm.org/D25458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
phosek created this revision.
phosek added reviewers: EricWF, mclow.lists.
phosek added a subscriber: cfe-commits.
phosek set the repository for this revision to rL LLVM.
Herald added subscribers: mgorny, beanz.
musl's pthread implementations use volatile types in their structs which is not
being
phosek added a comment.
libc++ was already building with musl after https://reviews.llvm.org/D21637 was
commited, but this broke recently as a consequence of r282640 which introduced
the use of `_LIBCPP_SAFE_STATIC` for libc++ internal globals. I'm not sure if
this is the best solution, but it'
agutowski added a comment.
In https://reviews.llvm.org/D25458#567697, @rnk wrote:
> Can you provide a more complete motivating example where our diagnostics were
> bad? I'm having a hard time figuring it out from the test
Sure, compiling the following program in C++ for i386 emits warnings abo
erichkeane updated the summary for this revision.
erichkeane removed a reviewer: gbenyei.
erichkeane removed rL LLVM as the repository for this revision.
erichkeane updated this revision to Diff 74310.
erichkeane added a comment.
Emailed with Alexey who identified the problem in the OpenMP impleme
jbangert updated this revision to Diff 74311.
https://reviews.llvm.org/D24997
Files:
clang-tidy/utils/ASTUtils.cpp
clang-tidy/utils/ASTUtils.h
clang-tidy/utils/NamespaceAliaser.cpp
clang-tidy/utils/NamespaceAliaser.h
clang-tidy/utils/UsingInserter.cpp
clang-tidy/utils/UsingInserter.h
jbangert marked an inline comment as done.
jbangert added a comment.
Thanks for the review!
https://reviews.llvm.org/D24997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
BillyONeal created this revision.
BillyONeal added reviewers: EricWF, mclow.lists.
BillyONeal added a subscriber: cfe-commits.
https://reviews.llvm.org/D25492
Files:
test/std/strings/basic.string/string.modifiers/string_append/T_size_size.pass.cpp
test/std/strings/basic.string/string.modifi
Author: ericwf
Date: Tue Oct 11 19:00:37 2016
New Revision: 283958
URL: http://llvm.org/viewvc/llvm-project?rev=283958&view=rev
Log:
Make it easier to run the libc++ test suite against libstdc++
Modified:
libcxx/trunk/docs/TestingLibcxx.rst
libcxx/trunk/test/libcxx/test/config.py
libc
tavianator added a comment.
In https://reviews.llvm.org/D21803#556857, @EricWF wrote:
> @rmaprath I'll merge this if needed. Feel free to commit your patch first.
Yeah, @rmaprath I'm happy to rebase this over your patch.
> @tavianator Do you need somebody to merge this for you?
I assume so, y
Author: ericwf
Date: Tue Oct 11 19:28:14 2016
New Revision: 283960
URL: http://llvm.org/viewvc/llvm-project?rev=283960&view=rev
Log:
Add mork workarounds for running the test suite against libstdc++
Modified:
libcxx/trunk/test/libcxx/test/config.py
libcxx/trunk/test/lit.cfg
libcxx/tru
Author: ericwf
Date: Tue Oct 11 20:19:16 2016
New Revision: 283962
URL: http://llvm.org/viewvc/llvm-project?rev=283962&view=rev
Log:
Fix libc++abi test config after recent libc++ changes
Modified:
libcxxabi/trunk/test/libcxxabi/test/config.py
Modified: libcxxabi/trunk/test/libcxxabi/test/con
agutowski created this revision.
agutowski added reviewers: rnk, hans, thakis.
agutowski added a subscriber: cfe-commits.
Follow-up to https://reviews.llvm.org/D24598 (separating builtins for x84-64
and i386).
https://reviews.llvm.org/D25494
Files:
include/clang/Basic/BuiltinsX86.def
inclu
agutowski added inline comments.
Comment at: test/Sema/builtins-x86_64.c:17
+ v8ll vec8longlongs;
+ (void)__builtin_ia32_readeflags_u64(); //
expected-error{{use of unknown builtin}} expected-note 0+ {{}}
+ (void)__builtin_ia32_writeeflags_u64(4);
Author: jlebar
Date: Tue Oct 11 20:30:08 2016
New Revision: 283963
URL: http://llvm.org/viewvc/llvm-project?rev=283963&view=rev
Log:
[CUDA] Make touching a kernel from a __host__ __device__ function a deferred
error.
Previously, this was an immediate, don't pass go, don't collect $200
error. Bu
Author: tra
Date: Tue Oct 11 21:08:08 2016
New Revision: 283964
URL: http://llvm.org/viewvc/llvm-project?rev=283964&view=rev
Log:
Added REQUIRED triples to the test that fails on some ARM buildbots.
Modified:
cfe/trunk/test/SemaCUDA/function-overload-hd.cu
Modified: cfe/trunk/test/SemaCUDA/f
EricWF added a comment.
> musl's pthread implementations use volatile types in their structs which is
> not being constexpr in C++11 but is in C++14.
This means that libc++'s std::mutex is unsafe to use during dynamic
initialization in C++11 with MUSL, which would really suck except that Clang
On Tue, Oct 11, 2016 at 6:39 PM Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jlebar
>
> Date: Tue Oct 11 20:30:08 2016
>
> New Revision: 283963
>
>
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283963&view=rev
>
> Log:
>
> [CUDA] Make touching a kernel from a __ho
Yes, I have yet to figure out when that REQUIRES comment is, erm,
required. Sorry. :-/
I believe Art checked in a fix.
On Oct 11, 2016 7:22 PM, "Chandler Carruth" wrote:
> On Tue, Oct 11, 2016 at 6:39 PM Justin Lebar via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: jlebar
>
phosek added inline comments.
Comment at: CMakeLists.txt:327
# Required flags ==
set(LIBCXX_STANDARD_VER c++11 CACHE INTERNAL "internal option to change build
dialect")
add_compile_flags_if_supported(-std=${LIBCXX_ST
Author: ericwf
Date: Tue Oct 11 23:29:50 2016
New Revision: 283975
URL: http://llvm.org/viewvc/llvm-project?rev=283975&view=rev
Log:
Prevent the test suite from hanging when run against libstdc++
Modified:
libcxx/trunk/test/libcxx/test/config.py
libcxx/trunk/test/std/thread/thread.mutex/
EricWF added inline comments.
Comment at: CMakeLists.txt:327
# Required flags ==
set(LIBCXX_STANDARD_VER c++11 CACHE INTERNAL "internal option to change build
dialect")
add_compile_flags_if_supported(-std=${LIBCXX_ST
Author: ericwf
Date: Tue Oct 11 23:56:23 2016
New Revision: 283976
URL: http://llvm.org/viewvc/llvm-project?rev=283976&view=rev
Log:
Fix two more tests that hang when testing against libstdc++
Modified:
libcxx/trunk/test/std/utilities/intseq/intseq.make/make_integer_seq.fail.cpp
libcxx/t
ahatanak updated this revision to Diff 74324.
ahatanak added a comment.
Added a call to operator C1* in test case.
https://reviews.llvm.org/D24969
Files:
lib/Sema/SemaTemplateInstantiateDecl.cpp
lib/Sema/TreeTransform.h
test/SemaCXX/destructor.cpp
Index: test/SemaCXX/destructor.cpp
ahatanak marked an inline comment as done.
ahatanak added a comment.
(I'm replying to the comment near TreeTransform.h:11967 because phab doesn't
let me hit save)
It looks like RebuildCXXPseudoDestructorExpr isn't even called because a
MemberExpr is created instead of a CXXPseudoDestructorExpr.
Author: ericwf
Date: Wed Oct 12 01:48:31 2016
New Revision: 283978
URL: http://llvm.org/viewvc/llvm-project?rev=283978&view=rev
Log:
Revert Add . Will recommit with better commit message
Removed:
libcxx/trunk/include/optional
libcxx/trunk/test/libcxx/utilities/optional/
libcxx/trunk/t
101 - 138 of 138 matches
Mail list logo
