Author: mehdi_amini
Date: Tue Oct 11 02:31:29 2016
New Revision: 283856
URL: http://llvm.org/viewvc/llvm-project?rev=283856&view=rev
Log:
Turn FileManager DirectoryEntry::Name from raw pointer to StringRef (NFC)
Modified:
cfe/trunk/include/clang/Basic/FileManager.h
cfe/trunk/include/clang
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with one more nit.
Comment at: clang-tidy/utils/ASTUtils.h:25
+
+#endif
missing a trailing comment `// LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ASTUTILS_H`
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D24572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
On 11 October 2016 at 01:01, Bruno Cardoso Lopes via cfe-commits
wrote:
> Author: bruno
> Date: Mon Oct 10 19:01:22 2016
> New Revision: 283827
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283827&view=rev
> Log:
> [Driver][Diagnostics] Make 'show option names' default for driver warnings
>
> C
Author: klimek
Date: Tue Oct 11 04:15:10 2016
New Revision: 283861
URL: http://llvm.org/viewvc/llvm-project?rev=283861&view=rev
Log:
Make Emacs libraries compatible with Emacs 24.
Emacs 24 doesn't have format-message, fall back to format in that case.
Patch by Philipp Stephani.
Modified:
cl
Author: klimek
Date: Tue Oct 11 04:21:20 2016
New Revision: 283863
URL: http://llvm.org/viewvc/llvm-project?rev=283863&view=rev
Log:
clang-include-fixer.el: Don't prompt the user about killing clang-include-fixer
processes
By default, Emacs prompts the user when killing processes on exit. This i
Author: klimek
Date: Tue Oct 11 04:25:34 2016
New Revision: 283864
URL: http://llvm.org/viewvc/llvm-project?rev=283864&view=rev
Log:
Delete clang-completion-mode.el.
It has been unmaintained for a while (last change was more than four
years ago), and it appears not widely used.
By now there are m
Author: malcolm.parsons
Date: Tue Oct 11 04:42:13 2016
New Revision: 283865
URL: http://llvm.org/viewvc/llvm-project?rev=283865&view=rev
Log:
Fix typo in documentation
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/google-runtime-references.rst
Modified:
clang-tools-extra/trunk/do
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283767: Use unique_ptr in LLVMContextImpl's constant maps.
(authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25419?vs=74097&id=74206#toc
Repository:
rL LLVM
https://reviews.ll
This revision was automatically updated to reflect the committed changes.
jlebar marked an inline comment as done.
Closed by commit rL283773: [AST] Convert Marshallers to use unique_ptr.
(authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25425?vs=74103&id=74207#toc
Reposi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283801: Add -fno-sanitize-address-use-after-scope flag
(authored by vitalybuka).
Changed prior to commit:
https://reviews.llvm.org/D25453?vs=74176&id=74210#toc
Repository:
rL LLVM
https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283834: Add an option to save the backend-produced YAML
optimization record to a file (authored by hfinkel).
Changed prior to commit:
https://reviews.llvm.org/D25225?vs=74001&id=74214#toc
Repository:
sepavloff updated this revision to Diff 74218.
sepavloff added a comment.
Updated comments, NFC otherwise.
https://reviews.llvm.org/D21508
Files:
include/clang/AST/DeclTemplate.h
lib/AST/DeclTemplate.cpp
lib/Sema/SemaDecl.cpp
test/SemaCXX/friend2.cpp
Index: test/SemaCXX/friend2.cpp
===
arphaman added a comment.
Thanks!
Comment at: include/clang/Basic/Attr.td:1545
// let Subjects = SubjectList<[Record, TypedefName]>;
let Documentation = [Undocumented];
+ let LangOpts = [COnly];
aaron.ballman wrote:
> If you, or anyone else, is bored, it
Author: rengolin
Date: Tue Oct 11 05:26:33 2016
New Revision: 283868
URL: http://llvm.org/viewvc/llvm-project?rev=283868&view=rev
Log:
Revert "[Driver][Diagnostics] Make 'show option names' default for driver
warnings"
This reverts commit r283827, as it's breaking all ARM/AARch64 bots.
Removed:
On 11 October 2016 at 10:14, Renato Golin wrote:
> clang-4.0: warning: no such sysroot directory: '/FOO' [-Wmissing-sysroot]
> error: unable to create target: 'No available targets are compatible
> with this triple.'
> 1 error generated.
Reverted in r283868, as it was also breaking ARM bots.
che
hokein updated this revision to Diff 74221.
hokein added a comment.
Add FIXME.
https://reviews.llvm.org/D25437
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
==
hokein added inline comments.
Comment at: test/clang-tidy/misc-unused-using-decls.cpp:191
+// n::N is using in the explicit template instantiations.
+template void h(n::M* t);
aaron.ballman wrote:
> Can you add a test using a non-type template argument, like an i
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:387
+ Token Tok;
+ while (!Lex->LexFromRawLexer(Tok) && Tok.isNot(tok::TokenKind::l_brace)) {
+ }
Maybe we can use `findLocationAfterToken` here?
https://reviews.llvm.org/D25397
Author: malcolm.parsons
Date: Tue Oct 11 05:47:06 2016
New Revision: 283869
URL: http://llvm.org/viewvc/llvm-project?rev=283869&view=rev
Log:
[clang-tidy] modernize-use-default default constructor bugfix
Summary:
Only member initializers that are written should prevent
using '= default' on a defa
hokein added inline comments.
Comment at:
test/clang-tidy/cppcoreguidelines-pro-type-member-init-literal-initializers.cpp:1
+// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-member-init %t --
-config="{CheckOptions: [{key:
"cppcoreguidelines-pro-type-member-init.Literal
arphaman updated this revision to Diff 74227.
arphaman marked an inline comment as done.
arphaman added a comment.
The updated patch handles protocol properties together with the interface
properties.
Repository:
rL LLVM
https://reviews.llvm.org/D25436
Files:
lib/Sema/SemaCodeComplete.cpp
arphaman added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:3723
}
} else if (!IsArrow && BaseType->getAsObjCInterfacePointerType()) {
// Objective-C property reference.
manmanren wrote:
> I feel like the added logic belongs to here :]
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283869: [clang-tidy] modernize-use-default default
constructor bugfix (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D2?vs=70966&id=74232#toc
Repository:
rL LLVM
On 11 October 2016 at 07:13, Daniel Jasper via cfe-commits
wrote:
> Author: djasper
> Date: Tue Oct 11 01:13:18 2016
> New Revision: 283853
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283853&view=rev
> Log:
> Explicitly ignore return code in test for test systems that use pipefail
Hi Daniel,
On Tue, Oct 11, 2016 at 1:38 PM, Renato Golin
wrote:
> On 11 October 2016 at 07:13, Daniel Jasper via cfe-commits
> wrote:
> > Author: djasper
> > Date: Tue Oct 11 01:13:18 2016
> > New Revision: 283853
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=283853&view=rev
> > Log:
> > Explicitly
Author: malcolm.parsons
Date: Tue Oct 11 07:02:16 2016
New Revision: 283873
URL: http://llvm.org/viewvc/llvm-project?rev=283873&view=rev
Log:
[clang-tidy] readability-avoid-const-params-in-decls template instantiation
bugfix
Summary: Bugfix for 30398. Don't warn for template instantiations
Rev
rmaprath created this revision.
rmaprath added a reviewer: EricWF.
rmaprath added a subscriber: cfe-commits.
This fixes a small omission where even when `__external_threading` is provided,
we attempt to declare a pthread based threading API. Instead, we should leave
out everything for the `__ext
On 11 October 2016 at 12:39, Daniel Jasper wrote:
> Just because I don't know shell very well :). Feel free to use "not"
> instead.
Ah, ok. I'll reapply. :)
Thanks!
--renato
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
aaron.ballman added inline comments.
Comment at: test/clang-tidy/misc-unused-using-decls.cpp:191
+// n::N is using in the explicit template instantiations.
+template void h(n::M* t);
hokein wrote:
> aaron.ballman wrote:
> > Can you add a test using a non-type tem
ikudrin created this revision.
ikudrin added reviewers: hansonw, compnerd.
ikudrin added a subscriber: cfe-commits.
The test fails because the value does not lay in any existing group.
The value was added in r268167.
https://reviews.llvm.org/D25470
Files:
bindings/python/tests/cindex/test_cu
hokein updated this revision to Diff 74239.
hokein added a comment.
Add a non-type template argument test.
https://reviews.llvm.org/D25437
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
==
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D25437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283873: [clang-tidy] readability-avoid-const-params-in-decls
template instantiation… (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D24652?vs=72476&id=74242#toc
Reposi
joerg added a comment.
A simple case that still seems to fail:
#include
struct foo {
uint32_t x;
uint8_t y[2];
uint16_t z;
} __attribute__((__packed__));
typedef struct foo __attribute__((__aligned__(16))) aligned_foo;
int main(void) {
struct foo x;
struct
Author: hokein
Date: Tue Oct 11 08:50:34 2016
New Revision: 283879
URL: http://llvm.org/viewvc/llvm-project?rev=283879&view=rev
Log:
[clang-tidy] Fix template agrument false positives in unused-using-decls.
Summary:
* Fix a false postive when an using class is used in an explicit template
instan
Author: vvassilev
Date: Tue Oct 11 08:57:36 2016
New Revision: 283882
URL: http://llvm.org/viewvc/llvm-project?rev=283882&view=rev
Log:
[modules] PR28752: Do not instantiate variable declarations which are not
visible.
https://reviews.llvm.org/D24508
Patch developed in collaboration with Richar
v.g.vassilev marked 2 inline comments as done.
v.g.vassilev added a comment.
Landed in r283882.
Comment at: include/clang/AST/Decl.h:1222
+ void demoteThisDefinitionToDeclaration() {
+assert (!isThisDeclarationADemotedDefinition() && "Aleady demoted!");
+assert (isThis
javed.absar created this revision.
javed.absar added reviewers: jmolloy, rengolin.
javed.absar added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This patch fixes an incomplete test, wherein the target-cpu name (cortex-r52)
was missing.
https://reviews.llvm.org/D25474
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283879: [clang-tidy] Fix template agrument false positives
in unused-using-decls. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25437?vs=74239&id=74254#toc
Repository:
rL L
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283886: [clang-tidy] Ignore empty members and bases in
cppcoreguidelines-pro-type… (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D25238?vs=74125&id=74256#toc
Reposito
Author: malcolm.parsons
Date: Tue Oct 11 09:49:24 2016
New Revision: 283886
URL: http://llvm.org/viewvc/llvm-project?rev=283886&view=rev
Log:
[clang-tidy] Ignore empty members and bases in
cppcoreguidelines-pro-type-member-init
Summary: Empty/incomplete variables/members/bases don't need to be i
kromanenkov created this revision.
kromanenkov added reviewers: zaks.anna, NoQ, dcoughlin.
kromanenkov added subscribers: a.sidorin, cfe-commits.
Add a new type of NonLoc SVal for pointer-to-member operations. This SVal
supports both pointers to member functions and pointers to member data.
htt
Author: vvassilev
Date: Tue Oct 11 10:09:26 2016
New Revision: 283887
URL: http://llvm.org/viewvc/llvm-project?rev=283887&view=rev
Log:
r283882 followup. Don't demote ParmVarDecls. This should fix our module builds.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaD
Author: mehdi_amini
Date: Tue Oct 11 10:15:32 2016
New Revision: 283888
URL: http://llvm.org/viewvc/llvm-project?rev=283888&view=rev
Log:
Use StringRef instead of raw pointer in SourceManagerInternals LineTableInfo
API (NFC)
Modified:
cfe/trunk/include/clang/Basic/SourceManagerInternals.h
M
Thanks Renato!
On Tue, Oct 11, 2016 at 3:36 AM, Renato Golin wrote:
> On 11 October 2016 at 10:14, Renato Golin wrote:
>> clang-4.0: warning: no such sysroot directory: '/FOO' [-Wmissing-sysroot]
>> error: unable to create target: 'No available targets are compatible
>> with this triple.'
>> 1 e
yaxunl added inline comments.
Comment at: test/CodeGenOpenCL/partial_initializer.cl:5
+
+// CHECK: @GA = addrspace(1) global [6 x [6 x float]] {{[[][[]}}6 x float]
[float 1.00e+00, float 2.00e+00, float 0.00e+00, float
0.00e+00, float 0.00e+00, float 0.0
tstellarAMD added a comment.
In https://reviews.llvm.org/D25343#565288, @Anastasia wrote:
> Do you have any code example where Clang/LLVM performs wrong optimizations
> with respect to the control flow of SPMD execution?
>
> My understanding from the earlier discussion we have had:
> https://ww
elsteveogrande updated this revision to Diff 74265.
elsteveogrande added a comment.
Thanks very much @vsk for the feedback! Updated per your recommendations;
`CHECK` looks much better
https://reviews.llvm.org/D25153
Files:
include/clang/Driver/Options.td
include/clang/Frontend/Preprocesso
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: rengolin, jmolloy.
SjoerdMeijer added a subscriber: cfe-commits.
Guard the -fdenormal-fp-math with -fno-fast-math. This allows disabling the FP
options with just one flag: –fno-fast-math.
https://reviews.llvm.org/D25479
Files:
Author: vvassilev
Date: Tue Oct 11 10:51:06 2016
New Revision: 283890
URL: http://llvm.org/viewvc/llvm-project?rev=283890&view=rev
Log:
Revert r283887 and r283882, until the issue is understood and fixed.
Removed:
cfe/trunk/test/Modules/Inputs/PR28752/
cfe/trunk/test/Modules/pr28752.cpp
M
Author: yaxunl
Date: Tue Oct 11 10:53:28 2016
New Revision: 283891
URL: http://llvm.org/viewvc/llvm-project?rev=283891&view=rev
Log:
[OpenCL] Allow partial initializer for array and struct
Currently Clang allows partial initializer for C99 but not for OpenCL, e.g.
float a[16][16] = {1.0f, 2.0f};
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283891: [OpenCL] Allow partial initializer for array and
struct (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D25335?vs=73818&id=74266#toc
Repository:
rL LLVM
https://revie
Author: zturner
Date: Tue Oct 11 11:06:32 2016
New Revision: 283895
URL: http://llvm.org/viewvc/llvm-project?rev=283895&view=rev
Log:
Fix clang-offload-bundler test.
A recent change to llvm::cl slightly changed the format of
the help output, and it broke this test. NFC
Modified:
cfe/trunk/t
Can we figure out why having an incremental stage1 is problematic? I want
to keep it that way to speed up the bot.
It sounds like the problem is that we do not delete the stage1 install
directory before installing to it, or our install step uses a glob that may
include stale files from previous bu
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Manman
Repository:
rL LLVM
https://reviews.llvm.org/D25436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
> Can we figure out why having an incremental stage1 is problematic? I want to
> keep it that way to speed up the bot.
The problem is that the cmake install rule that we use does not remove
extra files that happen to be present in the install directory. So if
you put something bad in there, as I
On Tue, Oct 11, 2016 at 9:34 AM, Justin Lebar wrote:
> > Can we figure out why having an incremental stage1 is problematic? I
> want to keep it that way to speed up the bot.
>
> The problem is that the cmake install rule that we use does not remove
> extra files that happen to be present in the i
vbyakovlcl updated this revision to Diff 74269.
https://reviews.llvm.org/D24669
Files:
llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td
llvm/tools/clang/lib/Sema/SemaExpr.cpp
llvm/tools/clang/test/CodeGen/vecshift.c
llvm/tools/clang/test/Sema/vecshift.c
Index: llvm/tools/clang
vbyakovlcl added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787
}
+if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) {
+ const BuiltinType *LHSBT = LHSEleType->getAs();
bruno wrote:
> vbyakovlcl wrote:
> > bruno wrote:
> > > B
alexfh added inline comments.
Comment at: clang-tidy/google/NonConstReferences.cpp:73
+ [&](llvm::StringRef WhiteListType) {
+ return ReferencedType.getCanonicalType().getAsString(
+Result.Context->getPrintingP
This breaks MSVC 2013 builds:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/30238/steps/run%20tests/logs/stdio
FAILED:
tools/clang/lib/Frontend/CMakeFiles/clangFrontend.dir/CacheTokens.cpp.obj
...
C:\b\slave\sanitizer-windows\llvm\tools\clang\lib\Frontend\CacheTokens.cpp(63)
: error C
On 11 October 2016 at 16:34, Bruno Cardoso Lopes
wrote:
> Thanks Renato!
So, Daniel Jasper did a trick on r283853 (clang || true) to make it
not fail when it returns on error. However, I wasn't able to make it
return anything but 0, so I'm at odds why this fails on the bot.
I was expecting it to
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1469
+ let Spellings = [CXX11<"clang", "suppress">, CXX11<"gsl", "suppress">];
+ let Args = [VariadicStringArgument<"Rules">];
+ let Documentation = [SuppressDocs];
Perhaps we should
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp:25
- Finder->addMatcher(cxxReinterpretCastExpr().bind("cast"), this);
+ std::vector Rules{"type", "type.1",
"cppcoreguidelines-pro-type-reinterpret-cast"};
+
Finde
Author: rnk
Date: Tue Oct 11 12:24:09 2016
New Revision: 283906
URL: http://llvm.org/viewvc/llvm-project?rev=283906&view=rev
Log:
Fix the build with MSVC 2013 after r283856
Modified:
cfe/trunk/lib/Frontend/CacheTokens.cpp
Modified: cfe/trunk/lib/Frontend/CacheTokens.cpp
URL:
http://llvm.org
taniabarg created this revision.
taniabarg added reviewers: davidsh, hubert.reinterpretcast.
taniabarg added a subscriber: cfe-commits.
BIF fpclassify has the wrong number of integer parameters specified in
Builtins.def. There should be 5 int parameters (each representing the values
FP_NAN, FP_I
bruno added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787
}
+if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) {
+ const BuiltinType *LHSBT = LHSEleType->getAs();
vbyakovlcl wrote:
> bruno wrote:
> > vbyakovlcl wrote:
> > > b
idlecode marked an inline comment as done.
idlecode added a comment.
Sure, I will upload diff as soon as I test it
https://reviews.llvm.org/D25439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: jlebar
Date: Tue Oct 11 12:36:03 2016
New Revision: 283907
URL: http://llvm.org/viewvc/llvm-project?rev=283907&view=rev
Log:
[CUDA] Re-land support for (r283683 and r283680).
These were reverted in r283753 and r283747.
The first patch added a header to the root 'Headers' install directo
hubert.reinterpretcast added a comment.
A test should probably be added as well.
https://reviews.llvm.org/D25480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Oct 11, 2016 at 10:09 AM, Renato Golin wrote:
> On 11 October 2016 at 16:34, Bruno Cardoso Lopes
> wrote:
>> Thanks Renato!
>
> So, Daniel Jasper did a trick on r283853 (clang || true) to make it
> not fail when it returns on error. However, I wasn't able to make it
> return anything but
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:387
+ Token Tok;
+ while (!Lex->LexFromRawLexer(Tok) && Tok.isNot(tok::TokenKind::l_brace)) {
+ }
hokein wrote:
> Maybe we can use `findLocationAfterToken` here?
This doesn't seem
I don't think this change is worth it. We create huge static arrays
with Builtin::Info in Builtins.cpp and Targets.cpp, StringRef(const
char*) is not constexpr (because of strlen). This means you'll get a
huge generated initialization function for it. We want to reduce the
number of global initiali
Author: bruno
Date: Tue Oct 11 13:21:26 2016
New Revision: 283913
URL: http://llvm.org/viewvc/llvm-project?rev=283913&view=rev
Log:
Reapply [Driver][Diagnostics] Make 'show option names' default for driver
warnings
Reapply r283827 by fixing the tests to not be target specific
Currently, driver
Let's see how it goes: Committed r283913
On Tue, Oct 11, 2016 at 11:13 AM, Bruno Cardoso Lopes
wrote:
> On Tue, Oct 11, 2016 at 10:09 AM, Renato Golin
> wrote:
>> On 11 October 2016 at 16:34, Bruno Cardoso Lopes
>> wrote:
>>> Thanks Renato!
>>
>> So, Daniel Jasper did a trick on r283853 (clang
This is temporary: the last patch of my series of patches adds the constexpr
ctor and remove all these static initializers.
> On Oct 11, 2016, at 11:26 AM, Benjamin Kramer wrote:
>
> I don't think this change is worth it. We create huge static arrays
> with Builtin::Info in Builtins.cpp and Tar
Author: bruno
Date: Tue Oct 11 13:31:45 2016
New Revision: 283915
URL: http://llvm.org/viewvc/llvm-project?rev=283915&view=rev
Log:
[Driver] Fix test from r283913 to unbreak bots
Followup from r283913 & r283827
http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/55135
Modified:
cfe/tr
Author: bruno
Date: Tue Oct 11 13:38:33 2016
New Revision: 283917
URL: http://llvm.org/viewvc/llvm-project?rev=283917&view=rev
Log:
[Driver] Use -fsyntax-only in test/Driver/show-option-names.c
Make the test less expensive, follow up from r283915.
Modified:
cfe/trunk/test/Driver/show-option-
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
The recently-added limited_allocator is much more conformant than the evil old
stack_allocator. However, limited_allocator encodes non-Standard assumptions
about how many allo
malcolm.parsons added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp:25
- Finder->addMatcher(cxxReinterpretCastExpr().bind("cast"), this);
+ std::vector Rules{"type", "type.1",
"cppcoreguidelines-pro-type-reinterpret-cast"};
+
Fin
ahatanak added a comment.
__builtin_fpclassify takes five int arguments followed by one last argument
that is of floating point type. Do you know if there is a way to specify the
last one argument is a floating point rather than using '.'?
https://reviews.llvm.org/D25480
___
Committing this patch before the constexpr change seems backwards
then? The static initializers are already breaking stuff because it
takes GCC with optimization and debug info takes 10+ minutes to
generate megabytes of static initializer code in Targets.cpp. Can you
please revert this until the co
But this also increases the size of the builtin table too right? Since
StringRef is twice the size of a pointer.
~Craig
On Tue, Oct 11, 2016 at 11:40 AM, Mehdi Amini via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This is temporary: the last patch of my series of patches adds the
> conste
> On Oct 11, 2016, at 12:04 PM, Benjamin Kramer wrote:
>
> Committing this patch before the constexpr change seems backwards
> then?
Well not really because I need to make StringRef(const char *) explicit, so all
the others have to go first.
> The static initializers are already breaking stuf
Yes, do you have a specific concern for this table size in particular?
> On Oct 11, 2016, at 12:07 PM, Craig Topper wrote:
>
> But this also increases the size of the builtin table too right? Since
> StringRef is twice the size of a pointer.
>
> ~Craig
>
> On Tue, Oct 11, 2016 at 11:40 AM, Me
Author: mehdi_amini
Date: Tue Oct 11 14:04:24 2016
New Revision: 283920
URL: http://llvm.org/viewvc/llvm-project?rev=283920&view=rev
Log:
Revert "Change Builtins name to be stored as StringRef instead of raw pointers
(NFC)"
This reverts commit r283802. It introduces temporarily static
initialize
Reverted in r283920, can you check if it is enough to “fix” the GCC issue?
> On Oct 11, 2016, at 12:04 PM, Benjamin Kramer wrote:
>
> Committing this patch before the constexpr change seems backwards
> then? The static initializers are already breaking stuff because it
> takes GCC with optimizat
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp:25
- Finder->addMatcher(cxxReinterpretCastExpr().bind("cast"), this);
+ std::vector Rules{"type", "type.1",
"cppcoreguidelines-pro-type-reinterpret-cast"};
+
Finde
hubert.reinterpretcast added a comment.
In https://reviews.llvm.org/D25480#567552, @ahatanak wrote:
> __builtin_fpclassify takes five int arguments followed by one last argument
> that is of floating point type. Do you know if there is a way to specify the
> last one argument is a floating poin
Hal,
I noticed since this commit there is a test-suite failure:
http://lab.llvm.org:8080/green/job/perf_darwin_x86_Osflto/64/
SingleSource.Benchmarks.Adobe-C++.loop_unroll appears to be failing.
Tailing the output of the program gets:
…
test 236 failed
test 236 failed
test 236 failed
test 236
I noticed since this commit there is a test-suite failure:
http://lab.llvm.org:8080/green/job/perf_darwin_x86_Osflto/64/
SingleSource.Benchmarks.Adobe-C++.loop_unroll appears to be failing.
Tailing the output of the program gets:
…
test 236 failed
test 236 failed
test 236 failed
test 2
Hi Chris,
Thanks! Can you (or someone else) revert this. I won't be able to look at it
until tonight.
-Hal
- Original Message -
> From: "Chris Matthews"
> To: "Hal Finkel" , cfe-commits@lists.llvm.org
> Sent: Tuesday, October 11, 2016 2:32:33 PM
> Subject: Re: r283685 - When optimi
vbyakovlcl added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787
}
+if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) {
+ const BuiltinType *LHSBT = LHSEleType->getAs();
bruno wrote:
> vbyakovlcl wrote:
> > bruno wrote:
> > > v
Author: arnolds
Date: Tue Oct 11 15:34:06 2016
New Revision: 283933
URL: http://llvm.org/viewvc/llvm-project?rev=283933&view=rev
Log:
Swift Calling Convention: Parameters are allowed after the
swift_error/swift_context parameter
We need to be able to decelare witness functions which append the se
Author: arnolds
Date: Tue Oct 11 15:34:03 2016
New Revision: 283932
URL: http://llvm.org/viewvc/llvm-project?rev=283932&view=rev
Log:
Pass the end of a component to SwiftAggLowering's enumerateComponents callback
This is usefull for determining whether components overlap.
Modified:
cfe/trunk
Author: ericwf
Date: Tue Oct 11 16:13:44 2016
New Revision: 283941
URL: http://llvm.org/viewvc/llvm-project?rev=283941&view=rev
Log:
Fix incorrect exception handling behavior in the uninitialized algorithms
Modified:
libcxx/trunk/include/memory
libcxx/trunk/test/std/utilities/memory/spec
Author: mren
Date: Tue Oct 11 16:18:20 2016
New Revision: 283943
URL: http://llvm.org/viewvc/llvm-project?rev=283943&view=rev
Log:
Module: for ObjectiveC, be consistent when checking hidden decls.
In MatchAllMethodDeclarations, when checking a hidden decl, be sure
to allow hidden when searching f
Author: ericwf
Date: Tue Oct 11 16:22:21 2016
New Revision: 283944
URL: http://llvm.org/viewvc/llvm-project?rev=283944&view=rev
Log:
Fix std::pair on FreeBSD
Summary:
FreeBSD ships an old ABI for std::pair which requires that it have non-trivial
copy/move constructors. Currently the non-trivial
We noticed that this change also caused VS2015 to take a lot longer when
building Targets.cpp. The revert in r283920 seems to have fixed it. The
upstream PS4 Windows bot went from a build time of 17:53
(http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/127
1 - 100 of 138 matches
Mail list logo
