Author: jlebar
Date: Mon Oct 10 11:26:36 2016
New Revision: 283772
URL: http://llvm.org/viewvc/llvm-project?rev=283772&view=rev
Log:
Use unique_ptr for VTableBuilder::VBaseInfo map.
Reviewers: timshen
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25424
Modified:
Author: jlebar
Date: Mon Oct 10 11:26:29 2016
New Revision: 283770
URL: http://llvm.org/viewvc/llvm-project?rev=283770&view=rev
Log:
Use unique_ptr for VPtrLocationsMap and VPtrInfoVector.
Reviewers: timshen
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25422
Modifi
Author: jlebar
Date: Mon Oct 10 11:26:48 2016
New Revision: 283775
URL: http://llvm.org/viewvc/llvm-project?rev=283775&view=rev
Log:
[Analysis] Use unique_ptr for CallGraph::FunctionMap.
Reviewers: timshen
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25427
Modified
Author: jlebar
Date: Mon Oct 10 11:26:44 2016
New Revision: 283774
URL: http://llvm.org/viewvc/llvm-project?rev=283774&view=rev
Log:
[Analysis] Use unique_ptr in AnalyaisDeclContextManager's ContextMap.
Reviewers: timshen
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/
hokein updated this revision to Diff 74138.
hokein marked an inline comment as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D25244
Files:
clang-tidy/google/NonConstReferences.cpp
clang-tidy/google/NonConstReferences.h
docs/clang-tidy/checks/google-runtim
Author: mehdi_amini
Date: Mon Oct 10 11:34:07 2016
New Revision: 283776
URL: http://llvm.org/viewvc/llvm-project?rev=283776&view=rev
Log:
Use StringRef in LangOptions::isNoBuiltinFunc API (NFC)
Modified:
cfe/trunk/include/clang/Basic/LangOptions.h
cfe/trunk/lib/Basic/LangOptions.cpp
Modi
hokein created this revision.
hokein added a subscriber: cfe-commits.
- Fix a false postive when an using class is used in an explicit template
instantiation.
- Fix a false postive when an using template class is used as template argument.
https://reviews.llvm.org/D25437
Files:
clang-tidy/mi
arphaman created this revision.
arphaman added reviewers: manmanren, doug.gregor.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves code completion for properties that are declared in
Objective-C protocols by making sure that p
Hmm,
I thought it must return a pointer to the element type rather than [*]
kind type. Did you checked it?
Best regards,
Alexey Bataev
On 10/10/2016 07:09 PM, Erich Keane wrote:
> erichkeane added a comment.
>
> Andrey-
> It seems that getVariableArrayDecayedType and getCanonicalParamType retur
Author: hokein
Date: Mon Oct 10 11:38:11 2016
New Revision: 283777
URL: http://llvm.org/viewvc/llvm-project?rev=283777&view=rev
Log:
[clang-tidy] Add a whitelist option in google-runtime-references.
Reviewers: aaron.ballman
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.or
Author: jlebar
Date: Mon Oct 10 11:41:00 2016
New Revision: 283778
URL: http://llvm.org/viewvc/llvm-project?rev=283778&view=rev
Log:
[Examples] Fix use of sema.LateParsedTemplateMap in clang/examples.
Modified:
cfe/trunk/examples/PrintFunctionNames/PrintFunctionNames.cpp
Modified: cfe/trunk/
I did. I changed line 236 to "ArgType =
getContext().getCanonicalParamType(ArgType);" (as I believe you were
suggesting), and the output was identical when doing dump on ArgType:
This:
LValueReferenceType 0xa451620 'int (&)[*]' variably_modified
`-VariableArrayType 0xa4515e0 'int [*]' vari
Author: marshall
Date: Mon Oct 10 11:47:48 2016
New Revision: 283780
URL: http://llvm.org/viewvc/llvm-project?rev=283780&view=rev
Log:
Add tests to check that swap(std::function, std::function) is noexcept. This is
LWG#2062, but we already do this. No changes to the library, just adding tests.
M
mgorny closed this revision.
mgorny added a comment.
r283746
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
idlecode created this revision.
idlecode added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
During clang-format source lexing >> and << operators are split and
treated as two less/greater operators but column position of following
tokens was not adjusted accordingly.
https://rev
Aaaahhh,
Now I see. We have a parameter with the type that is a reference to VLA.
I think in this case we should rework this code to something like this:
if (ArgType->isVariablyModifiedType())
ArgType =
getContext().getCanonicalParamType(ArgType.getNonReferenceType());
Try this solutio
That does turn ArgType into a PointerType int*. However, line 301
(GenerateOpenMPCapturedStmtFunction) attempts to cast it to a reference type a
bit later, resulting in a SIGABRT there. Do I need to re-add the reference
there? Is removing the array type REALLY what we wish to do?
-Origin
Author: marshall
Date: Mon Oct 10 12:11:37 2016
New Revision: 283781
URL: http://llvm.org/viewvc/llvm-project?rev=283781&view=rev
Log:
Updated notes about issues; marked 2062, 2223, 2394, 2460 and 2540 as complete.
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/u
mprobst added a comment.
Looks good to me, but Daniel is a better owner for this code.
https://reviews.llvm.org/D25439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh added a comment.
ping
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hfinkel added a comment.
In https://reviews.llvm.org/D25308#566176, @arphaman wrote:
> The updated patch now makes clang warn every time it encounters this
> attribute in C++ mode. Would that be the desired behaviour?
As I understand it, transparent_union was designed for use in system headers
djasper added inline comments.
Comment at: test/Format/bitshift-operator-width.cpp:1
+// RUN: grep -Ev "// *[A-Z-]+:" %s | clang-format -style=LLVM \
+// RUN: | FileCheck -strict-whitespace %s
Could you move this test into unittests/Format/FormatTest.cpp?
htt
Add a check to line 299:
if (!VarTy->isReferenceType() &&
!(FD->getType()->isVariablyModifiedType() &&
ArgLVal.getType()->isPointerType()))
Best regards,
Alexey Bataev
On 10/10/2016 08:19 PM, Keane, Erich wrote:
> That does turn ArgType into a PointerType int*. However, line 301
> (Generate
alexfh accepted this revision.
alexfh added a comment.
LG
https://reviews.llvm.org/D25238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
agutowski updated this revision to Diff 74147.
agutowski added a comment.
address comments
https://reviews.llvm.org/D25353
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
test/CodeGen/ms-intrinsics.c
te
Author: agutowski
Date: Mon Oct 10 13:09:27 2016
New Revision: 283785
URL: http://llvm.org/viewvc/llvm-project?rev=283785&view=rev
Log:
Implement __emul, __emulu, _mul128 and _umul128 MS intrinsics
Reviewers: rnk, thakis, majnemer, hans
Subscribers: cfe-commits
Differential Revision: https://re
erichkeane added a comment.
I'm going to need to pump-the-brakes on this for a little bit. The
name-decoration work I did here highlighted a number of issues with that
section of the spec. We're currently considering rev'ing the spec to properly
name mangle/decorate when C++ and Microsoft is
manmanren added a comment.
Thanks for working on this!
Manman
Comment at: lib/Sema/SemaCodeComplete.cpp:3723
}
} else if (!IsArrow && BaseType->getAsObjCInterfacePointerType()) {
// Objective-C property reference.
I feel like the added logic belong
This causes a massive number of openmp test failures (obviously), and I'm not
terribly comfortable with how OpenMP works. I can update the tests (and will),
but would like it if you could be extra diligent in confirming the correct
behavior for me.
Failing Tests (6):
Clang :: OpenMP/for_re
Hi Artem,
This revision broke one our our builders:
http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/21910
Please have a look at it.
Thanks
Galina
On Fri, Oct 7, 2016 at 4:26 AM, Artem Dergachev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dergachev
> Da
agutowski created this revision.
agutowski added reviewers: majnemer, hans, rnk.
agutowski added a subscriber: cfe-commits.
https://reviews.llvm.org/D25442
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
te
bruno added a reviewer: bruno.
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3915
- if (D.getVFS().exists("/etc/SuSE-release"))
-return OpenSUSE;
+ File = llvm::MemoryBuffer::getFile("/etc/SuSE-release");
+ if (File)
You should keep
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:331
+void UseAutoCheck::replaceExpr(const DeclStmt *D, ASTContext *Context,
+ Ty
Hi Galina,
Hmm, this sounds strange to me, because this commit has been instantly
reverted three days ago (replaced with correct code later), and current
errors on this buildbot do not seem to be related.
On 10/10/16 9:36 PM, Galina Kistanova wrote:
Hi Artem,
This revision broke one our our
Author: phosek
Date: Mon Oct 10 13:53:32 2016
New Revision: 283788
URL: http://llvm.org/viewvc/llvm-project?rev=283788&view=rev
Log:
[libcxx] Add support for Fuchsia
Fuchsia is a new operating system which uses musl as the standard
C library, libc++ and libc++abi as the C++ standard library.
Dif
Author: rsmith
Date: Mon Oct 10 13:54:32 2016
New Revision: 283789
URL: http://llvm.org/viewvc/llvm-project?rev=283789&view=rev
Log:
Re-commit r283722, reverted in r283750, with a fix for a CUDA-specific use of
past-the-end iterator.
Original commit message:
P0035R4: Semantic analysis and code g
agutowski updated this revision to Diff 74157.
agutowski added a comment.
remove nullptr check; don't repeat EmitScalarExpr
https://reviews.llvm.org/D25334
Files:
include/clang/Basic/BuiltinsX86.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
test/CodeGen/ms-intrinsics.c
test/Heade
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
agutowski marked 2 inline comments as done.
agutowski added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:7610
+Value *SizeVal = EmitScalarExpr(E->getArg(2));
+EmitNonNullArgCheck(RValue::get(Dest.getPointer()),
E->getArg(0)->getType(),
+
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/readability/RedundantDeclarationCheck.cpp:39
+ bool MultiVar = false;
+ if (const auto *VD = dyn_cast(D)) {
+if (VD && VD->getPrevi
On Mon, Oct 10, 2016 at 10:45 AM, Hal Finkel via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> hfinkel added a comment.
>
> In https://reviews.llvm.org/D25308#566176, @arphaman wrote:
>
> > The updated patch now makes clang warn every time it encounters this
> attribute in C++ mode. Would tha
Could you send the new results for these tests?
Best regards,
Alexey Bataev
On 10/10/2016 09:22 PM, Keane, Erich wrote:
> This causes a massive number of openmp test failures (obviously), and I'm not
> terribly comfortable with how OpenMP works. I can update the tests (and
> will), but would l
alexfh updated this revision to Diff 74160.
alexfh marked 6 inline comments as done.
alexfh added a comment.
Herald added subscribers: mgorny, beanz.
- Addressed review comments
https://reviews.llvm.org/D24572
Files:
clang-tidy/CMakeLists.txt
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyD
rSerge added a comment.
I have extended this feature to check for OS support too (currently Linux
only). I can't commit it so far because I don't know how to implement a test.
XFAIL cannot check for both CPU and OS: it can only check for one of them. I
tried to implement 2 tests instead like th
- Original Message -
> From: "Richard Smith"
> To: reviews+d25308+public+96c9b20dd11b9...@reviews.llvm.org, "Hal
> Finkel"
> Cc: "Alex L" , "Reid Kleckner" ,
> "Aaron Ballman" , "cfe-commits"
>
> Sent: Monday, October 10, 2016 2:16:13 PM
> Subject: Re: [PATCH] D25308: [Sema] Ignore tran
majnemer added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:7610
+Value *SizeVal = EmitScalarExpr(E->getArg(2));
+EmitNonNullArgCheck(RValue::get(Dest.getPointer()),
E->getArg(0)->getType(),
+E->getArg(0)->getExprLoc(), FD, 0);
-
malcolm.parsons updated this revision to Diff 74162.
malcolm.parsons added a comment.
Use std::function
https://reviews.llvm.org/D25316
Files:
clang-tidy/modernize/UseAutoCheck.cpp
clang-tidy/modernize/UseAutoCheck.h
docs/clang-tidy/checks/modernize-use-auto.rst
test/clang-tidy/moderniz
Author: jlebar
Date: Mon Oct 10 14:26:22 2016
New Revision: 283790
URL: http://llvm.org/viewvc/llvm-project?rev=283790&view=rev
Log:
[AST] Don't use make_pointee_iterator in VTableBuilder.
Our implementation of make_pointee_iterator seems to be causing MSVC
2015 to crash, so I'm going to remove i
alexfh added a comment.
The change seems to be reasonable, and the size increase is not huge. However,
I'm not sure who should make the call.
https://reviews.llvm.org/D25429
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
malcolm.parsons updated this revision to Diff 74163.
malcolm.parsons added a comment.
Really mention in release notes.
https://reviews.llvm.org/D25316
Files:
clang-tidy/modernize/UseAutoCheck.cpp
clang-tidy/modernize/UseAutoCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/modernize-
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
Yes, this looks good to me. For trunk r283783, this brought the number of
unexpected failures down from 61 to 41. Tests fixed by this change:
libc++ :: std/algorithms/alg.sorting/alg.min.max/min
manmanren added a comment.
This is a nice cleanup!
Manman
Comment at: lib/Sema/SemaDeclAttr.cpp:6348
+
+ auto IsContextGreater = [&](const Decl *C) {
+if (K == AR_NotYetIntroduced) {
Can you add a comment for the lambda?
Comment at: lib
Author: agutowski
Date: Mon Oct 10 14:40:51 2016
New Revision: 283793
URL: http://llvm.org/viewvc/llvm-project?rev=283793&view=rev
Log:
Implement MS read/write barriers and __faststorefence intrinsic
Reviewers: hans, rnk, majnemer
Subscribers: cfe-commits
Differential Revision: https://reviews.
zaks.anna added a comment.
I am in support of this as well.
https://reviews.llvm.org/D25429
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk created this revision.
vsk added reviewers: pcc, rjmccall.
vsk added subscribers: krasin, cfe-commits.
ubsan reports a false positive 'invalid member call' diagnostic on the
following example (PR30478):
struct Base1 {
virtual int f1() { return 1; }
};
struct Base2 {
virtual i
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:252-254
+ anyOf(hasType(autoType()),
+hasType(pointerType(pointee(autoType(,
+hasType(referenceType(pointee(autoType())
thakis added a comment.
I noticed that using this slows down clang-format about 300% --
https://llvm.org/bugs/show_bug.cgi?id=30656
Repository:
rL LLVM
https://reviews.llvm.org/D10840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
LGTM
> On Oct 9, 2016, at 2:39 PM, Nick Lewycky via cfe-commits
> wrote:
>
> The attached patch makes the LValue created in EmitValueForIvarAtOffset have
> the same Qualifiers in the LValue as the QualType in the LValue. Noticed when
> auditing for reasons the QualType would different from th
Author: nicholas
Date: Mon Oct 10 15:07:13 2016
New Revision: 283795
URL: http://llvm.org/viewvc/llvm-project?rev=283795&view=rev
Log:
Make the LValue created in EmitValueForIvarAtOffset have the same Qualifiers in
the LValue as the QualType in the LValue. No functionality change intended.
Modif
I mean, could you send new .ll files, which you get after these changes?
Best regards,
Alexey Bataev
> 10 окт. 2016 г., в 22:26, Keane, Erich написал(а):
>
> Sure, attached. So far, there are a few changes that seem curious and
> concerning. A few cases of loads going missing, and a few more
ahatanak accepted this revision.
ahatanak added a comment.
LGTM with a few nits.
Please fix lib/Headers/intrin.h too and commit it as a separate patch.
Comment at: lib/Sema/SemaStmtAsm.cpp:142
+// Extracting the register name from the Expression value,
+// if there is no regis
I don't see any .ll files for the tests. I see the directory
build/tools/clang/test/OpenMP/Output has a bunch of .script and .tmp(binary
files), but no obvious .ll files.
-Original Message-
From: Alexey Bataev [mailto:a.bat...@hotmail.com]
Sent: Monday, October 10, 2016 1:22 PM
To: Ke
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D25308#566176, @arphaman wrote:
> The updated patch now makes clang warn every time it encounters this
> attribute in C++ mode. Would that be the desi
dim created this revision.
dim added reviewers: EricWF, emaste, rsmith, theraven.
dim added a subscriber: cfe-commits.
On FreeBSD, for ABI compatibility reasons, the pair trivial copy
constructor is disabled, using the aptly-named
`_LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR` define.
Di
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:378
+ Lexer::getLocForEndOfToken(Range.getEnd(), 0, SM,
Context->getLangOpts());
+ bool Whitespace = isWhitespace(*FullSourceLoc(Next, SM).getCharacterData());
+
malcolm
CaseyCarter abandoned this revision.
CaseyCarter added a comment.
Ignoring the assignment from in_place_t issue for now, r283606 is good modulo a
couple of tiny things that I'll just email you directly.
https://reviews.llvm.org/D25249
___
cfe-commi
STL_MSFT abandoned this revision.
STL_MSFT added a comment.
Abandoning, as this machinery has been replaced.
https://reviews.llvm.org/D22973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
jhen created this revision.
jhen added a reviewer: alexfh.
jhen added a subscriber: cfe-commits.
Herald added a subscriber: jlebar.
clang-tidy should fix identifier naming even when the identifier is
referenced inside a macro expansion, provided that the identifier enters
the macro expansion compl
jhen added a comment.
alexfh, sorry if you are not the right person to review this change. I based my
choice on this history of this file.
https://reviews.llvm.org/D25450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
limited_allocator must grant friendship in order to be rebindable. Found by
MSVC, which rebinds allocators in more situations than libc++ does.
This raises an interesting ques
bruno added inline comments.
Comment at: CMakeLists.txt:198
+set(CLANG_DEFAULT_LINKER "" CACHE STRING
+ "Default linker to use (\"bfd\" or \"gold\" or \"lld\", empty for platform
default")
mgorny wrote:
> Is there a reason not to allow using the absolute path
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in rL283793.
https://reviews.llvm.org/D25442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in rL283785.
https://reviews.llvm.org/D25353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in rL283774.
https://reviews.llvm.org/D25426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Frontend/CompilerInvocation.cpp:739
+ UasArg &&
+ UasArg->getOption().matches(OPT_fsanitize_address_use_after_scope);
Opts.SSPBufferSize =
aaron.ballman added inline comments.
Comment at: test/clang-tidy/misc-unused-using-decls.cpp:191
+// n::N is using in the explicit template instantiations.
+template void h(n::M* t);
Can you add a test using a non-type template argument, like an integer literal?
Author: marshall
Date: Mon Oct 10 16:00:12 2016
New Revision: 283799
URL: http://llvm.org/viewvc/llvm-project?rev=283799&view=rev
Log:
Update with the rest of the results from the 7-Oct Telecom
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
Hello Justin,
Some of your resent commits broke the next builder:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/12710
Please have a look at it?
Thanks
Galina
On Mon, Oct 10, 2016 at 9:26 AM, Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org
Galina, I've already reverted the offending changes in iterator.h.
The MSVC build is now broken due to a different change.
Sorry for the noise (but not really sorry, MSVC shouldn't crash :).
On Mon, Oct 10, 2016 at 2:15 PM, Galina Kistanova wrote:
> Hello Justin,
>
> Some of your resent commits
mgorny added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3915
- if (D.getVFS().exists("/etc/SuSE-release"))
-return OpenSUSE;
+ File = llvm::MemoryBuffer::getFile("/etc/SuSE-release");
+ if (File)
bruno wrote:
> You should keep using the VFS t
jlebar added a comment.
Do you know why phab didn't pick up this change when I pushed it?
https://reviews.llvm.org/D25426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a comment.
Look like problem with Phabricator itself. I noticed several other reviews
which were not closed with valid reference to review in commit summary.
Weirdly, **https://reviews.llvm.org/diffusion/L/** prefix doesn't work too.
https://reviews.llvm.org/D25426
jlebar added a comment.
Heh, all right. So long as I didn't screw anything up, I'm happy with it being
a mystery.
https://reviews.llvm.org/D25426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3915
- if (D.getVFS().exists("/etc/SuSE-release"))
-return OpenSUSE;
+ File = llvm::MemoryBuffer::getFile("/etc/SuSE-release");
+ if (File)
mgorny wrote:
> bruno wrote:
> > You should kee
vitalybuka marked an inline comment as done.
vitalybuka added inline comments.
Comment at: test/Driver/fsanitize.c:124
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=address %s -### 2>&1 |
FileCheck %s --check-prefix=CHECK-ASAN-WITHOUT-USE-AFTER-SCOPE
+// CHECK-ASAN-WITHOUT
vitalybuka updated this revision to Diff 74176.
vitalybuka added a comment.
resolved comments
https://reviews.llvm.org/D25453
Files:
include/clang/Driver/Options.td
lib/Driver/SanitizerArgs.cpp
lib/Frontend/CompilerInvocation.cpp
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
Author: vitalybuka
Date: Mon Oct 10 16:31:50 2016
New Revision: 283801
URL: http://llvm.org/viewvc/llvm-project?rev=283801&view=rev
Log:
Add -fno-sanitize-address-use-after-scope flag
Reviewers: eugenis
Differential Revision: https://reviews.llvm.org/D25453
Modified:
cfe/trunk/include/clang
Author: mehdi_amini
Date: Mon Oct 10 16:34:29 2016
New Revision: 283802
URL: http://llvm.org/viewvc/llvm-project?rev=283802&view=rev
Log:
Change Builtins name to be stored as StringRef instead of raw pointers (NFC)
Modified:
cfe/trunk/include/clang/Basic/Builtins.h
cfe/trunk/lib/CodeGen/C
Author: marshall
Date: Mon Oct 10 16:37:16 2016
New Revision: 283804
URL: http://llvm.org/viewvc/llvm-project?rev=283804&view=rev
Log:
Mark 2777 as complete
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-pro
bruno added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787
}
+if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) {
+ const BuiltinType *LHSBT = LHSEleType->getAs();
vbyakovlcl wrote:
> bruno wrote:
> > Besides `__ext_vector_typ
bruno added a reviewer: vsk.
bruno added a comment.
Ping!!
https://reviews.llvm.org/D24516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:965
+ Opts.ShowOptionNames = Args.hasArg(OPT_fdiagnostics_show_option) ||
+ (DefaultShowOpt && !Args.hasArg(OPT_fno_diagnostics_show_option));
Does it make sense to use: hasFlag (O
Author: adrian
Date: Mon Oct 10 16:56:20 2016
New Revision: 283810
URL: http://llvm.org/viewvc/llvm-project?rev=283810&view=rev
Log:
[Driver] Let -gline-tables-only win when it comes after -gmodules.
The -gmodules option is all about putting debug type info into clang
modules and for line tables t
jhen updated this revision to Diff 74181.
jhen added a comment.
- Return to original checking for macro in range
https://reviews.llvm.org/D25450
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming.cpp
Index: test/clang-tidy/readability-iden
jhen added a comment.
I found a bug in my first patch that I have fixed now. I was trying to iterate
over the source range by using `SourceLocation::getLocWithOffset`, but I
realized that doesn't work, so I removed it and went back to the original
method of checking `SourceRange.getBegin().isMa
jlebar accepted this revision.
jlebar added a reviewer: jlebar.
jlebar marked an inline comment as done.
jlebar added a comment.
This revision is now accepted and ready to land.
https://github.com/llvm-mirror/clang/commit/b28828e8b38c7e208386f783e6502305c42cb479
https://reviews.llvm.org/D25427
jlebar closed this revision.
jlebar added a comment.
Phab seemed to be having trouble closing revisions today.
https://github.com/llvm-mirror/clang/commit/c4e9e7b35a2d113c8aa3bcdaf858c5bac4d78b03
https://reviews.llvm.org/D25424
___
cfe-commits mail
jlebar closed this revision.
jlebar added a comment.
https://github.com/llvm-mirror/clang/commit/dd0969a0ae3b6421685a9d78953bb1127a8cfe9c
https://reviews.llvm.org/D25422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
jlebar closed this revision.
jlebar added a comment.
https://github.com/llvm-mirror/clang/commit/be96a853a5dd33cce210617fb11575d33df7
https://reviews.llvm.org/D25423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
101 - 200 of 233 matches
Mail list logo
