[PATCH] D25154: [libc++] Fix stack_allocator

STL_MSFT accepted this revision. STL_MSFT added a comment. This revision is now accepted and ready to land. Seems plausible to me. I haven't tested this against MSVC yet, but at most I expect to have minor issues with space consumption (as we allocate helper objects and sentinel nodes, so any ex

[PATCH] D25154: [libc++] Fix stack_allocator

EricWF added a comment. In https://reviews.llvm.org/D25154#564980, @STL_MSFT wrote: > Seems plausible to me. I haven't tested this against MSVC yet, but at most I > expect to have minor issues with space consumption (as we allocate helper > objects and sentinel nodes, so any exactly-sized buffe

[libcxx] r283618 - Fix shadow warnings. Patch from s...@microsoft.com

Author: ericwf Date: Fri Oct 7 17:10:35 2016 New Revision: 283618 URL: http://llvm.org/viewvc/llvm-project?rev=283618&view=rev Log: Fix shadow warnings. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/utilities/utility/forward/move.pass.cpp Modified: libcxx/trunk/test/std/util

[PATCH] D25248: [libcxx] [test] Fix shadow warnings.

EricWF closed this revision. EricWF added a comment. r283618. https://reviews.llvm.org/D25248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25225: Add an option to save the backend-produced YAML optimization record to a file

anemet added inline comments. Comment at: test/CodeGen/opt-record.c:17-25 +// CHECK: --- !Missed +// CHECK: Pass:inline +// CHECK: Name:NoDefinition +// CHECK: Function:foo + +// CHECK: --- !Passed +// CHECK: Pass:loop-vectorize ---

Re: [libcxx] r281673 - [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

This caused https://llvm.org/bugs/show_bug.cgi?id=30642 On Thu, Sep 15, 2016 at 6:27 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Thu Sep 15 17:27:07 2016 > New Revision: 281673 > > URL: http://llvm.org/viewvc/llvm-project?rev=281673&view=rev > L

[PATCH] D25225: Add an option to save the backend-produced YAML optimization record to a file

anemet added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:198 + +Ctx.setDiagnosticsOutputFile(new yaml::Output(OptRecordFile->os())); + } Sorry, one more thing: if PGO is available, I think we want to set Ctx.setDiagnosticHotnessReques

[PATCH] D25225: Add an option to save the backend-produced YAML optimization record to a file

hfinkel added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:198 + +Ctx.setDiagnosticsOutputFile(new yaml::Output(OptRecordFile->os())); + } anemet wrote: > Sorry, one more thing: if PGO is available, I think we want to set > Ctx.setDiag

[PATCH] D25145: [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS

mclow.lists added a comment. Sigh. Make an expedient choice that you don't really agree with, and you get immediately reminded of it. I suggested on an earlier review (not this patch) that I really didn't want to see `_WIN32` in any files other than ``, that we should have a libc++-specific o

Re: r283537 - Revert "[analyzer] Try to re-apply r283092 "Extend bug reports with extra notes"

Yep, should be fixed already. I had to split the commit into senseless parts because microsoft compiler was crashing and it wasn't obvious (to anybody who tried to look into this) which part of the commit might have caused that. Now the complete commit has finally landed. Sorry for the trouble

[libcxx] r283620 - Fix PR30642 - libc++ leaks always-visible symbols into programs

Author: ericwf Date: Fri Oct 7 18:07:59 2016 New Revision: 283620 URL: http://llvm.org/viewvc/llvm-project?rev=283620&view=rev Log: Fix PR30642 - libc++ leaks always-visible symbols into programs This was caused by r281673, specifically changing `_LIBCPP_EXTERN_TEMPLATE_TYPE_VIS` from `__attri

[PATCH] D25249: [libc++] Many any test fixes

EricWF added a comment. Addressed the issues about `in_place` SFINAE constraints in an inline comment. Comment at: test/libcxx/utilities/any/any.class/any.assign/value.pass.cpp:25 +// Test that any& operator=(ValueType&&) is *never* selected for: +// * std::in_place type. +

[PATCH] D24975: [CUDA] Add #pragma clang force_cuda_host_device_{begin, end} pragmas.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Please add a test to test/PCH for the serialization code. Otherwise, LGTM. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1032 + "force_cuda_host_device end

[libcxx] r283621 - Disable alignment support of 0x4000 for Win32. https://reviews.llvm.org/D25053

Author: marshall Date: Fri Oct 7 18:19:04 2016 New Revision: 283621 URL: http://llvm.org/viewvc/llvm-project?rev=283621&view=rev Log: Disable alignment support of 0x4000 for Win32. https://reviews.llvm.org/D25053 Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type

[PATCH] D25053: [libc++] Correct alignment condition

mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 283621 https://reviews.llvm.org/D25053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D14259: The maximum alignment of std::aligned_storage applies to all Windows compilers

mclow.lists closed this revision. mclow.lists added a comment. This duplicates @D25053, and I've landed this change as revision 283621. https://reviews.llvm.org/D14259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D25225: Add an option to save the backend-produced YAML optimization record to a file

hfinkel updated this revision to Diff 74001. hfinkel added a comment. Herald added a subscriber: mehdi_amini. Addressed review comments (DebugLoc is tested, and we enable hotness computation when saving the optimization record and also using PGO). https://reviews.llvm.org/D25225 Files: inclu

[PATCH] D25225: Add an option to save the backend-produced YAML optimization record to a file

anemet added a comment. LGTM, thanks. I also like the option name but will let the the other reviewers official approve that part. https://reviews.llvm.org/D25225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D25008: [cmake] Split linked libraries into private & public, for linker script

EricWF added inline comments. Comment at: lib/CMakeLists.txt:41 +else() + list(APPEND LIBCXX_LIBRARIES_PUBLIC "${LIBCXX_CXX_ABI_LIBRARY}") +endif() Please handle the special case for Apple here, where it manually re-exports the ABI lib. Comme

[PATCH] D25154: [libc++] Fix stack_allocator

STL_MSFT added a comment. F2472251: msvc_warnings.txt - The attached patch on top of your patch fixes two simple MSVC warnings - unreferenced formal parameter and class/struct mismatch. - Three tests are emitting stack consumption warnings (since MSVC /analyz

[PATCH] D24371: Add diagnostics to require_constant_initialization

EricWF added a comment. @rsmith ping. Any more comments on this patch? Repository: rL LLVM https://reviews.llvm.org/D24371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25361: [libcxx] Add the missing limits.h header

mclow.lists added a comment. This looks fine to me, but since @rsmith added all the other C headers, I'd like him to weigh in. https://reviews.llvm.org/D25361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D25361: [libcxx] Add the missing limits.h header

rsmith added a comment. I only skipped this one because it seemed pointless to me. I have no objection to providing it, and this change makes perfect sense if libc++ wants to guarantee that `<__config>` is included whenever any standard C++ header is included. https://reviews.llvm.org/D25361

[PATCH] D25154: [libc++] Fix stack_allocator

EricWF updated this revision to Diff 74006. EricWF added a comment. Rewrite the patch entirely. Instead of using an actual "stack buffer" I've transformed `stack_allocator` into `limited_allocator` which allows at most `N` elements to be allocated from it. This resolves the issues about stack u

[libcxx] r283631 - [libc++] Fix stack_allocator

Author: ericwf Date: Fri Oct 7 19:56:22 2016 New Revision: 283631 URL: http://llvm.org/viewvc/llvm-project?rev=283631&view=rev Log: [libc++] Fix stack_allocator Summary: To quote STL the problems with stack allocator are" >"stack_allocator is seriously nonconformant to N4582 17.6.3.5 >[allocat

[libcxx] r283632 - Add missing include in test_allocator.h

Author: ericwf Date: Fri Oct 7 19:57:56 2016 New Revision: 283632 URL: http://llvm.org/viewvc/llvm-project?rev=283632&view=rev Log: Add missing include in test_allocator.h Modified: libcxx/trunk/test/support/test_allocator.h Modified: libcxx/trunk/test/support/test_allocator.h URL: http://

[libcxx] r283633 - Add missing include in test

Author: ericwf Date: Fri Oct 7 19:59:16 2016 New Revision: 283633 URL: http://llvm.org/viewvc/llvm-project?rev=283633&view=rev Log: Add missing include in test Modified: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.assign/copy.pass.cpp Modified: libcxx/trunk/test/std/utilities/

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

ahatanak added a comment. I have a couple of minor comments, but patch looks good to me. Comment at: lib/Sema/SemaStmtAsm.cpp:141 +// Extracting the register name from the Expression value, +// if there is no register name to extract, returns "" Please remove

r283637 - [CUDA] Do a better job at detecting wrong-side calls.

Author: jlebar Date: Fri Oct 7 20:07:11 2016 New Revision: 283637 URL: http://llvm.org/viewvc/llvm-project?rev=283637&view=rev Log: [CUDA] Do a better job at detecting wrong-side calls. Summary: Move CheckCUDACall from ActOnCallExpr and BuildDeclRefExpr to DiagnoseUseOfDecl. This lets us catch

[PATCH] D25387: When optimizing for size, enable loop rerolling by default.

hfinkel created this revision. hfinkel added a reviewer: jmolloy. hfinkel added a subscriber: cfe-commits. Herald added a subscriber: mcrosier. We have a loop-rerolling optimization which can be enabled by using -freroll-loops. While sometimes loops are hand-unrolled for performance reasons, whe

[libcxx] r283643 - Purge all usages of _LIBCPP_STD_VER under test/std/algorithm

Author: ericwf Date: Fri Oct 7 20:25:23 2016 New Revision: 283643 URL: http://llvm.org/viewvc/llvm-project?rev=283643&view=rev Log: Purge all usages of _LIBCPP_STD_VER under test/std/algorithm Modified: libcxx/trunk/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpp libcxx/tr

[libcxx] r283644 - Remove all _LIBCPP_VERSION tests from under test/std

Author: ericwf Date: Fri Oct 7 20:32:56 2016 New Revision: 283644 URL: http://llvm.org/viewvc/llvm-project?rev=283644&view=rev Log: Remove all _LIBCPP_VERSION tests from under test/std Added: libcxx/trunk/test/libcxx/depr/depr.c.headers/ciso646.pass.cpp libcxx/trunk/test/libcxx/depr/depr

r283645 - Use StringRef in Command::printArg() instead of raw pointer (NFC)

Author: mehdi_amini Date: Fri Oct 7 20:38:43 2016 New Revision: 283645 URL: http://llvm.org/viewvc/llvm-project?rev=283645&view=rev Log: Use StringRef in Command::printArg() instead of raw pointer (NFC) Modified: cfe/trunk/include/clang/Driver/Job.h cfe/trunk/lib/Driver/Job.cpp Modified

[PATCH] D25389: Fix std::pair on FreeBSD

EricWF created this revision. EricWF added reviewers: emaste, dim, theraven, rsmith. EricWF added a subscriber: cfe-commits. FreeBSD ships an old ABI for std::pair which requires that it have non-trivial copy/move constructors. Currently the non-trivial copy/move is achieved by providing explici

r283657 - Un-tabify source files, NFC.

Author: yrnkrn Date: Sat Oct 8 01:45:10 2016 New Revision: 283657 URL: http://llvm.org/viewvc/llvm-project?rev=283657&view=rev Log: Un-tabify source files, NFC. Modified: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/lib/AST/NestedNameSpecifier.cpp

<    1   2