[PATCH] D25267: cmake: Set CMAKE_INSTALL_RPATH in Clang when building separately from LLVM

mgorny added a comment. I presume you copied it out of LLVM. If that's the case, please add an comment above stating where it's been copied from. https://reviews.llvm.org/D25267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D24656: [clang-tidy] Add check readability-redundant-declaration

danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. Ping. I am not very happy about how I detect multivariable declarations. But I really don't see any such info in the VarDecl. For instance, the AST dump does not show this info. https://reviews.llvm.org/D24656

[PATCH] D25267: cmake: Set CMAKE_INSTALL_RPATH in Clang when building separately from LLVM

plevine added a comment. In https://reviews.llvm.org/D25267#561955, @mgorny wrote: > I presume you copied it out of LLVM. If that's the case, please add an > comment above stating where it's been copied from. Yes. I copied it from LLVM's top-level CMakeLists.txt and added ${LLVM_LIBRARY_DIR

[PATCH] D25092: [analyzer] Add "Assuming..." diagnostic pieces for short-circuit logical operators.

This revision was automatically updated to reflect the committed changes. Closed by commit rL283302: [analyzer] Improve "Assuming..." diagnostic pieces for logical operators. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D25092?vs=73472&id=73601#toc Repository: r

r283302 - [analyzer] Improve "Assuming..." diagnostic pieces for logical operators.

Author: dergachev Date: Wed Oct 5 03:28:25 2016 New Revision: 283302 URL: http://llvm.org/viewvc/llvm-project?rev=283302&view=rev Log: [analyzer] Improve "Assuming..." diagnostic pieces for logical operators. Logical short-circuit operators now act like other branch conditions. If the symbolic

Re: [clang-tools-extra] r281453 - [clang-tidy] Add check 'misc-use-after-move'

(Somehow I missed this, sorry for silence...) On Wed, Sep 14, 2016 at 6:13 AM Martin Böhme wrote: > While I'm excited to see this go in anywhere, I have to say I'm a bit sad > it isn't going in as a warning and instead inside clang-tidy. This has been > a much requested warning from Clang for ma

r283303 - [analyzer] Squash a compile error in r283301.

Author: dergachev Date: Wed Oct 5 03:47:31 2016 New Revision: 283303 URL: http://llvm.org/viewvc/llvm-project?rev=283303&view=rev Log: [analyzer] Squash a compile error in r283301. The constexpr string literal trick isn't supported in MSVC2013. Modified: cfe/trunk/include/clang/StaticAnalyz

[PATCH] D24998: Add a new optimization option -Og

keith.walker.arm added a comment. Looking into what optimisations would be relevant to -Og (or rather what optimisation should be omitted because they are too disruptive to the debug experience) is something that I have on my road-map as something to look into and gather feedback on. I agree t

r283304 - [Sema] Packed member warning: Use the typedef name for anonymous structures

Author: arphaman Date: Wed Oct 5 04:27:48 2016 New Revision: 283304 URL: http://llvm.org/viewvc/llvm-project?rev=283304&view=rev Log: [Sema] Packed member warning: Use the typedef name for anonymous structures This commit improves the packed member warning by showing the name of the anonymous st

[PATCH] D25106: Packed member warning: Use the typedef name for anonymous structures when it is available

This revision was automatically updated to reflect the committed changes. Closed by commit rL283304: [Sema] Packed member warning: Use the typedef name for anonymous structures (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25106?vs=73338&id=73611#toc Repository:

[PATCH] D25254: test-suite: Change extension used for reference outputs by Makefile-based harness so we can start improving how the CMake-based harness works without breaking the old system or the bui

rengolin added a comment. Can you expand on how you plan to add the second set of reference outputs? We already have multiple reference outputs, for example big endian vs. little endian. I was expecting you to have done a similar thing, which doesn't involve changing every single reference file

[PATCH] D24954: [ToolChains] Disable OpenSUSE rules for SLES10

ismail added a comment. That looks good to me but I am not a reviewer. Someone else must approve. https://reviews.llvm.org/D24954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r283306 - Overhaul clang-include-fixer.el

Author: hokein Date: Wed Oct 5 05:04:13 2016 New Revision: 283306 URL: http://llvm.org/viewvc/llvm-project?rev=283306&view=rev Log: Overhaul clang-include-fixer.el General overhaul to fix many coding bugs, simplify the code, and improve readability. * Clarify documentation strings of user opti

[PATCH] D25210: [ARM] Add Cortex-R52 target to CLANG

jmolloy accepted this revision. jmolloy added a comment. This revision is now accepted and ready to land. LGTM, thanks Javed! https://reviews.llvm.org/D25210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D24615: [OpenMP] clang doesnt diagnose if there is a lexical block around a for stmt for OpenMP loops. It is technically not allowed in the OpenMP standard

ABataev added a comment. In https://reviews.llvm.org/D24615#561532, @kkwli0 wrote: > Should we issue a warning message in this case? Agree https://reviews.llvm.org/D24615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D25153: preprocessor supports `-dI` flag

elsteveogrande updated this revision to Diff 73625. elsteveogrande added a comment. Addressed most recent comments, hopefully squashed the last few things. https://reviews.llvm.org/D25153 Files: include/clang/Driver/Options.td include/clang/Frontend/PreprocessorOutputOptions.h lib/Fronten

[PATCH] D25273: Fix PR30520: Fix incomplete type crash when dealing with transparent_union attribute

arphaman created this revision. arphaman added a reviewer: aaron.ballman. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch fixes a crash that happens when clang is analyzing a transparent_union attribute on a union which has a field wi

[PATCH] D24861: [Sema] extend Wshift-op-parentheses so it warns for multiplicative operators

danielmarjamaki set the repository for this revision to rL LLVM. danielmarjamaki updated this revision to Diff 73633. danielmarjamaki added a comment. Add new flag : -Wshift-op-parentheses-mul This is not enabled by default. Repository: rL LLVM https://reviews.llvm.org/D24861 Files: includ

[PATCH] D25252: [OpenMP] Check if the template specialization is mappable instead of specialized template

davidsh created this revision. davidsh added reviewers: carlo.bertolli, arpith-jacob, kkwli0, sfantao, ABataev. davidsh added a subscriber: cfe-commits. Clang segfaults on this case instead of diagnosing because it looks at the specialized template: template struct MyClass; template<> struct My

[PATCH] D25256: [Driver] Print path to correct rtlib for -print_libgcc_file_name

phosek created this revision. phosek added a subscriber: cfe-commits. phosek set the repository for this revision to rL LLVM. When compiler-rt is being used as a runtime library, Clang would print an invalid path when -print_libgcc_file_name option is used. We should print a path to compiler-rt

[PATCH] D25171: clang-format: Add two new formatting options

rsmmr added a comment. Cool, thanks Steve. What's the next step for me to get it committed? https://reviews.llvm.org/D25171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25117: [Driver] Add driver support for Fuchsia

phosek updated this revision to Diff 73562. Repository: rL LLVM https://reviews.llvm.org/D25117 Files: lib/Basic/Targets.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h test/Driver/fuchsia.c test/Driver/fuchsia

[PATCH] D25263: [Driver] Allow setting the default linker during build

phosek created this revision. phosek added a subscriber: cfe-commits. phosek set the repository for this revision to rL LLVM. Herald added subscribers: mgorny, beanz. This change allows setting the default linker used by the Clang driver when configuring the build. Repository: rL LLVM https:

[PATCH] D25204: Register Calling Convention, Clang changes

oren_ben_simhon added inline comments. > AttrDocs.td:1267 > + > +.. _`__regcall`: https://software.intel.com/en-us/node/512847 > + }]; You might want to use the following link instead because it is most updated: https://software.intel.com/en-us/node/693069 > TargetInfo.cpp:3352 >// Keep t

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar updated this revision to Diff 73617. zizhar added a comment. Changed the '^' to point to the clobber which conflicts. Changed the relevant comments. However, regarding the point about the non-alphabetical characters - It's a different behavior for these specific characters, since these sho

[PATCH] D25012: [x86][inline-asm] Add support for curly brackets escape using "%" in extended inline asm.

mharoush updated this revision to Diff 73602. Repository: rL LLVM https://reviews.llvm.org/D25012 Files: lib/AST/Stmt.cpp test/CodeGen/x86_inlineasm_curly_bracket_escape.c Index: lib/AST/Stmt.cpp === --- lib/AST/Stmt.cpp +++

[PATCH] D25011: [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage

mharoush added a comment. This patch is a part of a larger support for k constraints, its main purpose is to add the option to choose the specific kN register while using basic inline assembly, the constraint support for extended inline assembly is being supported by another patch D25062

[PATCH] D25012: [x86][inline-asm] Add support for curly brackets escape using "%" in extended inline asm.

mharoush marked an inline comment as done. mharoush added a comment. Done Repository: rL LLVM https://reviews.llvm.org/D25012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r283314 - [Clang][AVX512][BuiltIn]Adding missing intrinsics move_{sd|ss} to clang

Author: mzuckerm Date: Wed Oct 5 07:56:06 2016 New Revision: 283314 URL: http://llvm.org/viewvc/llvm-project?rev=283314&view=rev Log: [Clang][AVX512][BuiltIn]Adding missing intrinsics move_{sd|ss} to clang Differential Revision: http://reviews.llvm.org/D21021 Modified: cfe/trunk/include/cl

[PATCH] D21021: [Clang][AVX512][BuiltIn]Adding intrinsics move_{sd|ss} to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL283314: [Clang][AVX512][BuiltIn]Adding missing intrinsics move_{sd|ss} to clang (authored by mzuckerm). Changed prior to commit: https://reviews.llvm.org/D21021?vs=59720&id=73638#toc Repository: rL L

[PATCH] D19586: Misleading Indentation check

danielmarjamaki added inline comments. > MisleadingIndentationCheck.cpp:20 > + > +void MisleadingIndentationCheck::danglingElseCheck( > +const MatchFinder::MatchResult &Result) { There is no handling of tabs and spaces by danglingElseCheck as far as I see. The "if" might for example be inde

[PATCH] D25252: [OpenMP] Check if the template specialization is mappable instead of specialized template

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D25252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D25204: Register Calling Convention, Clang changes

ABataev added inline comments. > Type.h:1381 > /// regparm and the calling convention. > -unsigned ExtInfo : 9; > +unsigned ExtInfo : 10; > Erich, do you really need this? You don't increase number of required bits anymore, so this code must be restored > Type.h:2909-2921 > +

[PATCH] D25162: Make DeletedLines local variables in checkEmptyNamespace.

ioeric updated this revision to Diff 73641. ioeric added a comment. - Added a test case. https://reviews.llvm.org/D25162 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp ==

[PATCH] D24085: arm: Fix ttype encoding assertion failure.

mclow.lists added inline comments. > cxa_personality.cpp:363 > + "Unexpected TTypeEncoding"); > (void)ttypeEncoding; > It's not clear to me how this accomplishes what you want. You're looking for `00/10/90`, right? Why not just check for that? Why are you anding with 0x0f ? Be

[PATCH] D24012: Fix strict-aliasing violation in typeinfo::hash_code()

mclow.lists added a comment. Adding a reference here: https://llvm.org/bugs/show_bug.cgi?id=30613 https://reviews.llvm.org/D24012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl updated this revision to Diff 73642. https://reviews.llvm.org/D24669 Files: llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td llvm/tools/clang/lib/Sema/SemaExpr.cpp llvm/tools/clang/test/CodeGen/vecshift.c llvm/tools/clang/test/Sema/vecshift.c Index: llvm/tools/clan

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl added inline comments. > ahatanak wrote in SemaExpr.cpp:8787 > Is it possible to use ASTContext::getTypeSize here? You are right. https://reviews.llvm.org/D24669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D21026: [clang-format] append newline after code when inserting new headers at the end of the code which does not end with newline.

ioeric added a comment. Sorry for the delay I've updated the patch to work with the new tooling::Replacements. https://reviews.llvm.org/D21026 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D21026: [clang-format] append newline after code when inserting new headers at the end of the code which does not end with newline.

ioeric updated this revision to Diff 73648. ioeric marked 2 inline comments as done. ioeric added a comment. - Merged with origin/master. - Update newline insertion according to the new Replacements implementation. https://reviews.llvm.org/D21026 Files: lib/Format/Format.cpp unittests/Forma

[PATCH] D21026: [clang-format] append newline after code when inserting new headers at the end of the code which does not end with newline.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D21026 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

echristo added a comment. There are two things pushing and pulling here: a) You want to be able to pass compiler code generation options at the time we're actually doing the code generation, b) "Traditionally" we don't pass CFLAGS to the linker. I think I'd like to see us passing more options d

[PATCH] D25162: Make DeletedLines local variables in checkEmptyNamespace.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D25162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

mehdi_amini added a comment. What about function attributes? Hey that's the trend :) You could have a subset of the functions in their own sections but not all. With LTO it means that you can disable this for a single input file. https://reviews.llvm.org/D24644 __

[libcxx] r283325 - Mark LWG issues 2221, 2556 and 2589 as complete

Author: marshall Date: Wed Oct 5 10:21:11 2016 New Revision: 283325 URL: http://llvm.org/viewvc/llvm-project?rev=283325&view=rev Log: Mark LWG issues 2221, 2556 and 2589 as complete Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http:

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

echristo added a comment. In https://reviews.llvm.org/D24644#562286, @mehdi_amini wrote: > What about function attributes? Hey that's the trend :) > You could have a subset of the functions in their own sections but not all. > With LTO it means that you can disable this for a single input file.

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane marked 9 inline comments as done. erichkeane added inline comments. > oren_ben_simhon wrote in AttrDocs.td:1267 > You might want to use the following link instead because it is most updated: > https://software.intel.com/en-us/node/693069 This has changed 2x since I started this proje

r283330 - [clang-format] append newline after code when inserting new headers at the end of the code which does not end with newline.

Author: ioeric Date: Wed Oct 5 10:42:19 2016 New Revision: 283330 URL: http://llvm.org/viewvc/llvm-project?rev=283330&view=rev Log: [clang-format] append newline after code when inserting new headers at the end of the code which does not end with newline. Summary: append newline after code when

[PATCH] D21026: [clang-format] append newline after code when inserting new headers at the end of the code which does not end with newline.

This revision was automatically updated to reflect the committed changes. Closed by commit rL283330: [clang-format] append newline after code when inserting new headers at the end… (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D21026?vs=73648&id=73651#toc Repository:

[libcxx] r283331 - Add another append test for basic_string

Author: marshall Date: Wed Oct 5 10:47:13 2016 New Revision: 283331 URL: http://llvm.org/viewvc/llvm-project?rev=283331&view=rev Log: Add another append test for basic_string Modified: libcxx/trunk/test/std/strings/basic.string/string.modifiers/string_append/T_size_size.pass.cpp Modified:

r283332 - Make DeletedLines local variables in checkEmptyNamespace.

Author: ioeric Date: Wed Oct 5 10:49:01 2016 New Revision: 283332 URL: http://llvm.org/viewvc/llvm-project?rev=283332&view=rev Log: Make DeletedLines local variables in checkEmptyNamespace. Summary: Patch by Sam McCall! Reviewers: djasper Subscribers: klimek, cfe-commits Differential Revision

[PATCH] D25162: Make DeletedLines local variables in checkEmptyNamespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rL283332: Make DeletedLines local variables in checkEmptyNamespace. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D25162?vs=73641&id=73652#toc Repository: rL LLVM https://rev

[clang-tools-extra] r283333 - [change-namespace] Fixed a bug in getShortestQualifiedNameInNamespace.

Author: ioeric Date: Wed Oct 5 10:52:39 2016 New Revision: 28 URL: http://llvm.org/viewvc/llvm-project?rev=28&view=rev Log: [change-namespace] Fixed a bug in getShortestQualifiedNameInNamespace. Reviewers: hokein Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/

[PATCH] D25264: Implement MS _BitScan intrinsics

agutowski added inline comments. > majnemer wrote in CGBuiltin.cpp:2656-2684 > Does this do the right thing if the arg is zero? I think it would if you > gave the call to the intrinsic an operand of false instead of true. MSDN doesn't specify what should be put under the "Index" address when t

[PATCH] D25065: [change-namespace] Fixed a bug in getShortestQualifiedNameInNamespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rL28: [change-namespace] Fixed a bug in getShortestQualifiedNameInNamespace. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D25065?vs=73459&id=73653#toc Repository: rL LLVM

Re: [PATCH] D25254: test-suite: Change extension used for reference outputs by Makefile-based harness so we can start improving how the CMake-based harness works without breaking the old system or the

Can you expand on how you plan to add the second set of reference outputs? I plan to {either re-target or replace with normal files} the new symlinks in upcoming patches. The patch proposal to which you referred in the above is just "stage 1" of a large clean-up. We [Sebastian and I] have CMa

[PATCH] D25264: Implement MS _BitScan intrinsics

rnk added a comment. Nice, probably ready to land with one revision. > majnemer wrote in CGBuiltin.cpp:2640-2647 > This should be in an anonymous namespace. Also, consider using an `enum > class` instead of an `enum` nested inside a namespace. Let's also use a more specific name than MSVC, ma

[PATCH] D25264: Implement MS _BitScan intrinsics

agutowski added inline comments. > majnemer wrote in CGBuiltin.cpp:2640-2647 > This should be in an anonymous namespace. Also, consider using an `enum > class` instead of an `enum` nested inside a namespace. I can see three options: (1) put the existing code inside an anonymous namespace; (2)

[PATCH] D25282: [clang-move] Cleanup around replacements.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. cleanup the remaining empty namespace after moving out the class defintitions. https://reviews.llvm.org/D25282 Files: clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/Clan

[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

rmaprath updated this revision to Diff 73661. rmaprath added a comment. First batch of XFAIL fixes. I've changed some XFAILs to UNSUPPORTED where the test is all about exception handling. In other cases, I've used the test macro TEST_HAS_NO_EXCEPTIONS to conditionally exclude those parts that t

[PATCH] D25283: AvailabilityAttrs: Refactor context checking when diagnosing an availability violation

erik.pilkington created this revision. erik.pilkington added a reviewer: manmanren. erik.pilkington added a subscriber: cfe-commits. This patch removes some redundant functions that implement checking availability against context, and implements a new, more correct one: `ShouldDiagnoseAvailabili

[PATCH] D25284: AvailabilityAttrs: Delay partial availability diagnostics

erik.pilkington created this revision. erik.pilkington added a reviewer: manmanren. erik.pilkington added a subscriber: cfe-commits. Note: this patch depends on: https://reviews.llvm.org/D25283 This patch delays handling of `AR_NotYetIntroduced` diagnostics, so that the following compiles with n

[libcxx] r283339 - Make tests for is_empty better. No functional change.

Author: marshall Date: Wed Oct 5 12:01:16 2016 New Revision: 283339 URL: http://llvm.org/viewvc/llvm-project?rev=283339&view=rev Log: Make tests for is_empty better. No functional change. Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_empty.pass.cpp Modified:

[libcxx] r283341 - Mark LWG#2358 as done

Author: marshall Date: Wed Oct 5 12:02:43 2016 New Revision: 283341 URL: http://llvm.org/viewvc/llvm-project?rev=283341&view=rev Log: Mark LWG#2358 as done Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-pro

[PATCH] D25273: Fix PR30520: Fix incomplete type crash when dealing with transparent_union attribute

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rL LLVM https://reviews.llvm.org/D25273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r283338 - [change-namespace] Pass Style to ChangeNamespaceTool.

Author: hokein Date: Wed Oct 5 12:00:40 2016 New Revision: 283338 URL: http://llvm.org/viewvc/llvm-project?rev=283338&view=rev Log: [change-namespace] Pass Style to ChangeNamespaceTool. Modified: clang-tools-extra/trunk/change-namespace/tool/ClangChangeNamespace.cpp Modified: clang-tools-ex

[PATCH] D25264: Implement MS _BitScan intrinsics

agutowski updated this revision to Diff 73668. agutowski added a comment. change enum in MSVC namespace to enum class MSVCIntrin in CodeGenFunction; cover all control paths https://reviews.llvm.org/D25264 Files: include/clang/Basic/BuiltinsARM.def include/clang/Basic/BuiltinsX86.def incl

[PATCH] D25273: Fix PR30520: Fix incomplete type crash when dealing with transparent_union attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! Repository: rL LLVM https://reviews.llvm.org/D25273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D25264: Implement MS _BitScan intrinsics

rnk added inline comments. > CodeGenFunction.h:2964 > +private: > + enum class MSVCIntrin; > + Does this work on Linux? I thought you had to give it an explicit underlying type (enum class MSVCIntrin : unsigned;) to make that work. https://reviews.llvm.org/D25264 __

[PATCH] D25264: Implement MS _BitScan intrinsics

agutowski added inline comments. > rnk wrote in CodeGenFunction.h:2964 > Does this work on Linux? I thought you had to give it an explicit underlying > type (enum class MSVCIntrin : unsigned;) to make that work. Yes, it seems to work on Linux too. According to the cppreference.com, it "declare

[PATCH] D24932: Fix PR 30440

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. I think we need to fix this regression. Repository: rL LLVM https://reviews.llvm.org/D24932 ___ cfe-commits mailing list cfe-c

[PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

bjope added a comment. What is the progress about getting rid of these code generation checks? (I'm still hesitating about commiting https://reviews.llvm.org/D24955 in llvm since that would make these clang tests fail...) Repository: rL LLVM https://reviews.llvm.org/D24397 __

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. In https://reviews.llvm.org/D24799#561879, @dberris wrote: > In https://reviews.llvm.org/D24799#561106, @rSerge wrote: > > > My mistake was that initially I only enumerated the unsupported targets > > from llvm\include\llvm\ADT\Triple.h . Now I've added also the cases fro

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge updated this revision to Diff 73673. https://reviews.llvm.org/D24799 Files: lib/Driver/Tools.cpp test/Driver/xray-instrument.c Index: test/Driver/xray-instrument.c === --- test/Driver/xray-instrument.c +++ test/Driver/xr

[PATCH] D25264: Implement MS _BitScan intrinsics

majnemer added inline comments. > agutowski wrote in CGBuiltin.cpp:2656-2684 > MSDN doesn't specify what should be put under the "Index" address when the > argument is zero; as I checked, VS2015 with optimizations puts undefined > value there, and I hope that's what I'm doing here. Intel (http

[PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

spatel added a comment. In https://reviews.llvm.org/D24397#562469, @bjope wrote: > (I'm still hesitating about commiting https://reviews.llvm.org/D24955 in llvm > since that would make these clang tests fail...) You can't do that. Bots will send you fail mail all day as they choke on the clan

[PATCH] D23096: [Sema] Pass CombineWithOuterScope = true to constructor of LocalInstantiationScope

sepavloff added a comment. IIUC, the problem is observed because `Sema::getTemplateInstantiationArgs` does not handle the case of variable templates properly. Classes and functions are declaration contexts and implementation of the aforementioned function (and probably others) relies on this fa

[libcxx] r283356 - Mark LWG#2679 as complete

Author: marshall Date: Wed Oct 5 13:36:24 2016 New Revision: 283356 URL: http://llvm.org/viewvc/llvm-project?rev=283356&view=rev Log: Mark LWG#2679 as complete Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm

[libcxx] r283360 - Comment out failing test while I figure out who is at fault

Author: marshall Date: Wed Oct 5 13:47:18 2016 New Revision: 283360 URL: http://llvm.org/viewvc/llvm-project?rev=283360&view=rev Log: Comment out failing test while I figure out who is at fault Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_empty.pass.cpp Modi

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

OK, I get testing that I'm fine with if I remove the -O2 and the checks for 'select i1'. Does that change suffice for the purposes of https://reviews.llvm.org/D24955 ? Namely, do I need to account for the possible addition of nsw/nuw flags to the add instructions even without -O2? On Wed, Oct 5,

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

You should not need to account for any nsw/nuw flags if the clang test does not enable the optimizer. Ie, D24955 should not be running at -O0. On Wed, Oct 5, 2016 at 1:09 PM, Nemanja Ivanovic wrote: > OK, I get testing that I'm fine with if I remove the -O2 and the checks > for 'select i1'. > >

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

OK, will remove optimization and the selects and commit this now. Sorry about the delay. On Wed, Oct 5, 2016 at 9:16 PM, Sanjay Patel wrote: > You should not need to account for any nsw/nuw flags if the clang test > does not enable the optimizer. > Ie, D24955 should not be running at -O0. > > On

r283363 - Removing optimization from the RUN lines and adjusting the checks

Author: nemanjai Date: Wed Oct 5 14:11:36 2016 New Revision: 283363 URL: http://llvm.org/viewvc/llvm-project?rev=283363&view=rev Log: Removing optimization from the RUN lines and adjusting the checks to not rely on optimization. Modified: cfe/trunk/test/CodeGen/builtins-ppc-p9vector.c Modif

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

Committed revision 283363. On Wed, Oct 5, 2016 at 9:18 PM, Nemanja Ivanovic wrote: > OK, will remove optimization and the selects and commit this now. > Sorry about the delay. > > On Wed, Oct 5, 2016 at 9:16 PM, Sanjay Patel > wrote: > >> You should not need to account for any nsw/nuw flags if

[PATCH] D25282: [clang-move] Cleanup around replacements.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg https://reviews.llvm.org/D25282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D25264: Implement MS _BitScan intrinsics

agutowski updated this revision to Diff 73685. agutowski added a comment. make _BitScan intrinsics compatible with Intel specification when the mask is zero https://reviews.llvm.org/D25264 Files: include/clang/Basic/BuiltinsARM.def include/clang/Basic/BuiltinsX86.def include/clang/Basic/

[PATCH] D1391: Bug fix: note diagnosis on expression narrowing...

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL188409. https://reviews.llvm.org/D1391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D25264: Implement MS _BitScan intrinsics

agutowski added inline comments. > CGBuiltin.cpp:2665 > +BasicBlock *End = createBasicBlock("bitscan_end", this->CurFn); > +Builder.SetInsertPoint(End); > +PHINode *Result = Builder.CreatePHI(ResultType, 2, "bitscan_result"); Is this line needed? I took it from __builtin_fpclassify,

[PATCH] D1147: FIXME fix: improving diagnostics for template arguments deduction of class templates and explicit specializations

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL186727. https://reviews.llvm.org/D1147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D1067: Variable templates w/ partial support for static data members

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL187762. https://reviews.llvm.org/D1067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D25171: clang-format: Add two new formatting options

rsmmr added a comment. Sure, I'm aiming to use clang-format on a couple of open-source code bases using this style, with the main one being the Bro network security monitor, see www.bro.org and github.com/bro/bro (note the stars and forks :-) Bro is also featured on GitHub's list of security sh

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev updated this revision to Diff 73688. v.g.vassilev added a comment. Address some comments and publish current progress. https://reviews.llvm.org/D24508 Files: include/clang/AST/Decl.h lib/AST/Decl.cpp lib/Sema/SemaTemplate.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp lib/S

[PATCH] D25171: clang-format: Add two new formatting options

djasper added a comment. Sorry, but that's actually not enough, at least at first sight. With 37 contributors total, bro is still quite small and only 12 of them have more than a handful of commits. And it doesn't have a real style guide. It has: https://www.bro.org/development/contribute.html#

[PATCH] D834: Private Headers for Modules

Eugene.Zelenko added a comment. This revision now requires review to proceed. Committed in https://reviews.llvm.org/rL184471 and https://reviews.llvm.org/rL184472. https://reviews.llvm.org/D834 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D25047: [AST] Add a const version of CallExpr::children() (NFC)

vsk abandoned this revision. vsk added a comment. I no longer need this functionality. https://reviews.llvm.org/D25047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

rnk added a comment. You should use git-clang-format or some equivalent to format your change. > TargetInfo.h:597 > + StringRef getNormalizedGCCRegisterName(StringRef Name, > +bool ReturnCanonical = false) const; > format > TargetInfo.h:600 > + virtual StringRef getConstraintRegister(

[PATCH] D25171: clang-format: Add two new formatting options

djasper added a comment. It's not about whether or not we like the patch. It's whether adding these options is a good trade-off for clang-format overall. If we find that actually more people would find these styles desirable, we can reconsider. I have left some comments anyway in case you want

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

rsmith added a comment. This looks like it's going in the right direction. > Decl.cpp:2269-2272 > + // If we have hit a point where the user provided a specialization of > + // this template, we're done looking. > + if (VarTemplate->isMemberSpecialization()) > +break; I

[PATCH] D25171: clang-format: Add two new formatting options

rsmmr added a comment. Well, last time I counted it was more like 100 contributors---Bro existed before GitHub (and before git). The style-guide is lacking, yes ... what can I say. I don't really want to argue about importance of the project. We would like to use clang-format here and elsewher

[PATCH] D25264: Implement MS _BitScan intrinsics

majnemer added inline comments. > agutowski wrote in CGBuiltin.cpp:2665 > Is this line needed? I took it from __builtin_fpclassify, but I don't know > what could be its purpose (it's repeated below, where the "bitscan_end" block > really starts). It's needed for the call to CreatePHI to be in

  1   2   >