Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Obsoleted by https://reviews.llvm.org/D1885.
https://reviews.llvm.org/D1869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL192410.
https://reviews.llvm.org/D1854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Eugene.Zelenko added a comment.
This revision now requires review to proceed.
Looks like patch was not committed, but may be irrelevant these days.
https://reviews.llvm.org/D1837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL192141.
https://reviews.llvm.org/D1818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL192029.
https://reviews.llvm.org/D1817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL192028.
https://reviews.llvm.org/D1816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
hfinkel abandoned this revision.
hfinkel added a comment.
Abandoned in favor of
https://reviews.llvm.org/D25225/https://reviews.llvm.org/D25262.
https://reviews.llvm.org/D19678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL191808.
https://reviews.llvm.org/D1801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL191944.
https://reviews.llvm.org/D1753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL191945.
https://reviews.llvm.org/D1752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
agutowski created this revision.
agutowski added reviewers: rnk, hans, thakis, majnemer.
agutowski added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
_BitScan intrinsics (and some others, for example _Interlocked and _bittest)
are supposed to work on both ARM and x86. This is a
majnemer added inline comments.
> CGBuiltin.cpp:2640-2647
> +// Many of MSVC builtins are on both x64 and ARM; to avoid repeating code, we
> +// handle them here.
> +namespace MSVC {
> + enum {
> +_BitScanForward,
> +_BitScanReverse
> + };
This should be in an anonymous namespace. Also
dberris added a comment.
In https://reviews.llvm.org/D24799#561106, @rSerge wrote:
> My mistake was that initially I only enumerated the unsupported targets from
> llvm\include\llvm\ADT\Triple.h . Now I've added also the cases from
> llvm\lib\Support\Triple.cpp .
> `XFAIL` requires a list of a
ahatanak added inline comments.
> rsmith wrote in SemaTemplateInstantiateDecl.cpp:4849
> Do we need to do this for conversion function names too? (Eg, `operator
> C1*`)
I added a definition of "operator C1*" and called it in C1::foo1. I didn't
see any crashes or asserts.
Calls to a destructor
bmharper added a comment.
ping!
https://reviews.llvm.org/D21279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper added a comment.
So sorry. Seems I forgot to hit "Submit" :(.
If you don't like the ".first" and ".second" of the pair, you could introduce a
struct for it and overload operator<. Might actually be more readable.
> WhitespaceManager.cpp:73
> + Tok.NestingLevel,
>/*Spaces=
djasper added a comment.
Could you read:
http://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options
And provide some evidence about the requirements for new style options?
https://reviews.llvm.org/D25171
___
cfe-commits
plevine created this revision.
plevine added a reviewer: chandlerc.
plevine added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
LLVM sets CMAKE_INSTALL_RPATH in its top-level CMakeLists.txt to
"\$ORIGIN/../lib${LLVM_LIBDIR_SUFFIX}". When Clang is built with LLVM, this
prop
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Sorry for the delay. Looks good.
https://reviews.llvm.org/D19063
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
djasper added a comment.
Ping?
SpaceAfterTemplateKeyword exists by now.
https://reviews.llvm.org/D19066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper added a comment.
I think we should add a test for why this was a problem. IIUC, this is caused
by something like:
#if a
#else
#endif
namespace {
}
Because we actually analyze the whole thing twice.
https://reviews.llvm.org/D25162
__
djasper added a comment.
Ping?
https://reviews.llvm.org/D21026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D19385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
201 - 223 of 223 matches
Mail list logo