jlebar added inline comments.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:139
@@ -137,1 +138,3 @@
+// CUDA 8.0.41 relies on __USE_FAST_MATH__ and __CUDA_PREC_DIV's values
+// Previous versions used to check thether they are defined or not.
Nit, missin
mstorsjo created this revision.
mstorsjo added a reviewer: majnemer.
mstorsjo added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This implements what is missing for PR30394, making it possible to compile C++
for ARM in MSVC mode with MSVC headers.
https://reviews.llvm.org/D249
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D24979#554378, @jlebar wrote:
> > I' personally would prefer to force-include these files. I suspect it will
> > not change things much as we already include a
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D12505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks good to me.
I appreciate the cleverness in the tests.
Repository:
rL LLVM
https://reviews.llvm.org/D24372
___
cfe-commit
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL243489.
https://reviews.llvm.org/D11472
___
cfe-commits mailing list
cfe-commits@lists.ll
Author: anemet
Date: Tue Sep 27 15:55:12 2016
New Revision: 282540
URL: http://llvm.org/viewvc/llvm-project?rev=282540&view=rev
Log:
Adapt to LLVM optimization remark interface change. NFC
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp
URL
tra marked an inline comment as done.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:156
@@ +155,3 @@
+#endif
+#endif
+
jlebar wrote:
> I don't understand what we are doing here...
>
> We're saying, if __USE_FAST_MATH__ is defined, and if it's not equal t
I'd still wonder if this meets the bar for false positives (generally we
try to only add warnings that would be enabled by default, even in new
codebases - where most of what they find in a newcodebase are latent bugs,
not noise (so the cleanup is at least fairly justified as being beneficial
in it
tra updated this revision to Diff 72707.
tra added a comment.
addressed Justin's comments.
https://reviews.llvm.org/D24946
Files:
lib/Driver/ToolChains.cpp
lib/Headers/__clang_cuda_runtime_wrapper.h
test/Driver/Inputs/CUDA/usr/local/cuda/nvvm/libdevice/libdevice.compute_20.10.bc
test/
rsmith added inline comments.
Comment at: clang/lib/Parse/ParsePragma.cpp:172
@@ +171,3 @@
+ PragmaForceCUDAHostDeviceStartHandler(Sema &Actions)
+ : PragmaHandler("force_cuda_host_device_begin"), Actions(Actions) {}
+ void HandlePragma(Preprocessor &PP, PragmaIntroducerKin
hiraditya added a comment.
ping!
https://reviews.llvm.org/D24682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
loladiro added a comment.
Before I commit this, I just realized
__libcpp_compressed_pair_imp& operator=(const __libcpp_compressed_pair_imp&
__p)
_NOEXCEPT_(is_nothrow_copy_assignable<_T1>::value &&
is_nothrow_copy_assignable<_T2>::value)
{
_T1::operator=(
majnemer added a comment.
IMO, this should be implemented in clang CodeGen so that we don't get extra
acquire/release barriers with /volatile:ms but that might be overkill; feel
free to disregard this.
https://reviews.llvm.org/D24986
___
cfe-commi
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM and Devin's comments have been addressed.
https://reviews.llvm.org/D24915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
loladiro updated this revision to Diff 72712.
loladiro added a comment.
Some extra _AFTER_CXX11 that may be necessary - please double check me here,
C++11 constexpr rules are not exactly my specialty ;).
Repository:
rL LLVM
https://reviews.llvm.org/D24372
Files:
include/memory
test/std/
joerg added a subscriber: joerg.
joerg added a comment.
I think the comment from Daniel shows the crux of the issue. A left shift is by
nature a multiplication operation, so I don't see why it should get the
warning. A right shift works like a division and order is quite significant for
that.
jlebar updated this revision to Diff 72717.
jlebar marked 2 inline comments as done.
jlebar added a comment.
Address Richard Smith's review comments:
- Change macro format.
- Add tests (these Just Worked).
https://reviews.llvm.org/D24975
Files:
clang/include/clang/Basic/DiagnosticParseKinds.
jlebar updated this revision to Diff 72719.
jlebar added a comment.
Herald added a subscriber: mehdi_amini.
s/libgcc/runtime/
https://reviews.llvm.org/D24979
Files:
clang/lib/Driver/ToolChains.cpp
clang/lib/Headers/CMakeLists.txt
clang/lib/Headers/__clang_cuda_complex_builtins.h
clang/l
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D11235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: anemet
Date: Tue Sep 27 17:19:29 2016
New Revision: 282545
URL: http://llvm.org/viewvc/llvm-project?rev=282545&view=rev
Log:
Shorten DiagnosticInfoOptimizationRemark* to OptimizationRemark*. NFC
With the new streaming interface in LLVM, these class names need to be
typed a lot and it's wa
Author: rtrieu
Date: Tue Sep 27 17:28:59 2016
New Revision: 282547
URL: http://llvm.org/viewvc/llvm-project?rev=282547&view=rev
Log:
Fix defaulted member functions for templated classes.
In some cases, non-special member functions were being marked as being defaulted
in templated classes. This c
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL256046.
https://reviews.llvm.org/D10370
___
cfe-commits mailing list
cfe-commits@lists.ll
rsmith added a comment.
Please add serialisation code for the push count for PCH. Should it be an error
if the count is nonzero at the end of the TU?
What happens if there are trailing tokens after the pragma?
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1027
It looks like this will reject valid code, such as:
template struct X {
using T = typename std::conditional::type;
X();
X(T) = default; // either copyable or moveable, depending on B
};
On Tue, Sep 27, 2016 at 3:28 PM, Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Au
hxy9243 created this revision.
hxy9243 added reviewers: sebpop, hiraditya, wmi.
hxy9243 added a subscriber: cfe-commits.
hxy9243 set the repository for this revision to rL LLVM.
This patch moves some existing functions from the memory.cpp to the memory
header file, so that they could be properly
rsmith added inline comments.
Comment at: clang/lib/CodeGen/CGCXX.cpp:137-138
@@ -136,1 +136,4 @@
+ // Disallow aliases to available_externally because available_externally
+ // will not be there in the end to allow the creation of the alias (PR30341).
+ // FIXME: An extern t
Author: arphaman
Date: Tue Sep 27 18:30:36 2016
New Revision: 282554
URL: http://llvm.org/viewvc/llvm-project?rev=282554&view=rev
Log:
[Coverage] The coverage region for switch covers the code after the switch.
This patch fixes a regression introduced in r262697 that changed the way the
coverage
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282554: [Coverage] The coverage region for switch covers the
code after the switch. (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D24981?vs=72692&id=72733#toc
Repository:
GorNishanov updated the summary for this revision.
GorNishanov removed a reviewer: majnemer.
GorNishanov updated this revision to Diff 72732.
GorNishanov added a comment.
Herald added a subscriber: mgorny.
1. Added documentation for builtins
2. Added a couple of tests with -disable-llvm-passes to
GorNishanov marked an inline comment as done.
Comment at: include/clang/Basic/Builtins.def:1293
@@ +1292,3 @@
+
+BUILTIN(__builtin_coro_id, "v*Iiv*v*v*", "n")
+BUILTIN(__builtin_coro_alloc, "bv*", "n")
rsmith wrote:
> I don't really like having builtins which will
Author: rsmith
Date: Tue Sep 27 18:44:22 2016
New Revision: 282556
URL: http://llvm.org/viewvc/llvm-project?rev=282556&view=rev
Log:
P0145R3 (C++17 evaluation order tweaks): evaluate the right-hand side of
assignment and compound-assignment operators before the left-hand side. (Even
if it's an ove
Author: matze
Date: Tue Sep 27 18:44:38 2016
New Revision: 282557
URL: http://llvm.org/viewvc/llvm-project?rev=282557&view=rev
Log:
Put new warning in a diagnostic group.
The warning I added in r282426 should be a diagnostic group.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticFrontendKi
Author: rtrieu
Date: Tue Sep 27 18:44:07 2016
New Revision: 282555
URL: http://llvm.org/viewvc/llvm-project?rev=282555&view=rev
Log:
Revert r282547 and add test to show correct behavior.
Modified:
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp
Mod
Reverted in r282555.
On Tue, Sep 27, 2016 at 3:44 PM, Richard Smith
wrote:
> It looks like this will reject valid code, such as:
>
> template struct X {
> using T = typename std::conditional::type;
> X();
> X(T) = default; // either copyable or moveable, depending on B
> };
>
> On Tue, Sep
jlebar updated this revision to Diff 72734.
jlebar marked 2 inline comments as done.
jlebar added a comment.
Address Richard's comments.
I'm fairly neutral on whether we want to make it an error not to match all of
your "begin" pragmas with "end"s. I checked pragma push_macro, and it looks
like
jlebar added a comment.
> What happens if there are trailing tokens after the pragma?
Added code to make this an error.
https://reviews.llvm.org/D24975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
jbangert created this revision.
jbangert added a reviewer: alexfh.
jbangert added a subscriber: cfe-commits.
jbangert added a project: clang-tools-extra.
This adds helper classes to add using declaractions and namespace aliases to
function bodies. These help making function calls to deeply nested
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
Repository:
rL LLVM
https://reviews.llvm.org/D9127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: rsmith
Date: Tue Sep 27 21:20:06 2016
New Revision: 282564
URL: http://llvm.org/viewvc/llvm-project?rev=282564&view=rev
Log:
Revert r282556. This change made several bots unhappy.
Modified:
cfe/trunk/include/clang/AST/ExprCXX.h
cfe/trunk/lib/CodeGen/CGCall.cpp
cfe/trunk/lib/Co
dcoughlin added a comment.
@parallaxe Do you need someone to commit this for you?
https://reviews.llvm.org/D23236
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: rengolin.
sylvestre.ledru added a subscriber: cfe-commits.
Just like gcc, we should have the -Og option as more and more software are
using it:
https://llvm.org/bugs/show_bug.cgi?id=20765
https://reviews.llvm.org/D24998
Fi
george.burgess.iv created this revision.
george.burgess.iv added reviewers: joerg, rsmith.
george.burgess.iv added a subscriber: cfe-commits.
Mostly asking for a review to verify that you guys are happy with this approach.
Given that Hal said struct-path-tbaa doesn't really deal with arrays (yet)
majnemer added a subscriber: majnemer.
majnemer added a comment.
Please include full context with your diff.
Comment at: lib/Frontend/CompilerInvocation.cpp:101-103
@@ -100,1 +100,5 @@
+if (S == "g") {
+return 1;
+}
+
Please clang-format this.
sylvestre.ledru updated this revision to Diff 72759.
sylvestre.ledru added a comment.
with the full context + clang format
https://reviews.llvm.org/D24998
Files:
docs/CommandGuide/clang.rst
lib/Frontend/CompilerInvocation.cpp
test/Driver/debug-options.c
test/Preprocessor/init.c
Index:
ahatanak created this revision.
ahatanak added reviewers: doug.gregor, rsmith.
ahatanak added a subscriber: cfe-commits.
This patch fixes a crash that occurs when a non-prototype function is declared
before a header containing a prototype of the same function is included. This
caused Sema::Looku
halyavin added a subscriber: halyavin.
Comment at: libcxx/include/atomic_support.h:1
@@ +1,2 @@
+//===--===
+//
Non-standard include files in the main include directory must start with __ to
Hahnfeld added a comment.
In https://reviews.llvm.org/D24601#553482, @vsk wrote:
> It should be fine to XFAIL this test temporarily. Is there a PR for this?
I've now created an entry in Bugzilla:
https://llvm.org/bugs/show_bug.cgi?id=30548
https://reviews.llvm.org/D24601
_
Hahnfeld updated the summary for this revision.
Hahnfeld updated this revision to Diff 72765.
Hahnfeld added a comment.
Link PR
https://reviews.llvm.org/D24601
Files:
test/Driver/darwin-stdlib.cpp
test/lit.cfg
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
=
101 - 149 of 149 matches
Mail list logo
