bmharper added a comment.
So.. I finally got some time to look at this again:
Quick Recap - IndentLevel and NestingLevel are now stored separately inside
WhitespaceManager::Change. I've added a function ScopeLevel() which combines
them with a bit of logic, and returns a number that can be used
Author: danielmarjamaki
Date: Fri Sep 23 03:27:24 2016
New Revision: 282233
URL: http://llvm.org/viewvc/llvm-project?rev=282233&view=rev
Log:
Fix indentation
Modified:
cfe/trunk/test/Sema/constant-conversion.c
Modified: cfe/trunk/test/Sema/constant-conversion.c
URL:
http://llvm.org/viewvc/l
ABataev added a comment.
LG for me.
https://reviews.llvm.org/D18172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
LG for me
https://reviews.llvm.org/D21840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
LG
https://reviews.llvm.org/D21843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
LG
https://reviews.llvm.org/D21845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
LG
https://reviews.llvm.org/D21847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
ping
https://reviews.llvm.org/D24601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki updated this revision to Diff 72252.
danielmarjamaki added a comment.
Updated CFGBuilder::VisitDoStmt
https://reviews.llvm.org/D24759
Files:
lib/Analysis/CFG.cpp
test/Analysis/uninit-sometimes.cpp
test/Analysis/unreachable-code-path.c
Index: test/Analysis/unreachable-code
danielmarjamaki added a comment.
My change is causing a false negative in the
test/Analysis/uninit-sometimes.cpp. As far as I see my change anyway makes the
unoptimized CFG better.
https://reviews.llvm.org/D24759
___
cfe-commits mailing list
cfe-c
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: lib/Format/Format.cpp:1557
@@ +1556,3 @@
+ const std::set HeadersToDelete) {
+ if (HeadersToDelete.find(HeaderName) != HeadersTo
rogfer01 added a comment.
Ping?
https://reviews.llvm.org/D23657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: danielmarjamaki
Date: Fri Sep 23 07:23:44 2016
New Revision: 282242
URL: http://llvm.org/viewvc/llvm-project?rev=282242&view=rev
Log:
Minor tweak. Avoid hardcoding.
Modified:
cfe/trunk/lib/Frontend/InitPreprocessor.cpp
Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp
URL:
http:
danielmarjamaki abandoned this revision.
danielmarjamaki added a comment.
Fixed by r282242
https://reviews.llvm.org/D16309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
berenm added a comment.
Hello,
I had a little bit of look into the NestingLevel field. I understand that it
only indicates the nesting level of the token inside the current unwrapped
line, which could very well be the same as the nesting level of another token
in the previous or next unwrapped
djasper added a comment.
Are we talking completely past each other? I specifically think we should *NOT*
combine NestingLevel and IndentLevel into one value. Not in ScopeLevel() and
not anywhere else.
https://reviews.llvm.org/D21279
___
cfe-commit
danielmarjamaki created this revision.
danielmarjamaki added reviewers: dblaikie, rtrieu.
danielmarjamaki added a subscriber: cfe-commits.
danielmarjamaki set the repository for this revision to rL LLVM.
This patch makes Clang warn about following code:
a = (b * c >> 2);
It might be a good i
ABataev added a comment.
LG
https://reviews.llvm.org/D21857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
LG
https://reviews.llvm.org/D21856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
LG
https://reviews.llvm.org/D21853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
LG
https://reviews.llvm.org/D21852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
berenm added a comment.
In https://reviews.llvm.org/D21279#550565, @djasper wrote:
> Are we talking completely past each other? I specifically think we should
> *NOT* combine NestingLevel and IndentLevel into one value. Not in
> ScopeLevel() and not anywhere else.
Ok, I probably misunderstood
hokein updated this revision to Diff 72265.
hokein marked 2 inline comments as done.
hokein added a comment.
Add comments.
https://reviews.llvm.org/D24828
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveT
ABataev added a comment.
LG
https://reviews.llvm.org/D21848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
- UsingDecl matcher crashed when `UsingShadowDecl` has no parent map.
Workaround by moving parent check into `UsingDecl`.
- FunctionDecl matcher crashed when there is a lambda defined in paramet
ioeric updated this revision to Diff 72269.
ioeric added a comment.
- Update comments
https://reviews.llvm.org/D24862
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/tool/ClangChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-nam
Author: hokein
Date: Fri Sep 23 08:28:38 2016
New Revision: 282247
URL: http://llvm.org/viewvc/llvm-project?rev=282247&view=rev
Log:
[clang-move] The new.cc file should include new_header.h instead of old_header.h
Summary:
Previously, all #includes (includeing old_header.h) in old.cc will be copi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282247: [clang-move] The new.cc file should include
new_header.h instead of old_header.h (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24828?vs=72265&id=72270#toc
Repository:
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added reviewers: klimek, sbenza.
aaron.ballman added a comment.
Should this perhaps be fixed in the AST matchers rather than in the check
itself?
https://reviews.llvm.org/D24862
___
cfe
ioeric added a comment.
In https://reviews.llvm.org/D24862#550615, @aaron.ballman wrote:
> Should this perhaps be fixed in the AST matchers rather than in the check
> itself?
I'll file bugs for the crashes, but the fix in this patch is not that "dirty" -
it simply changes the order of matcher
vpykhtin accepted this revision.
vpykhtin added a comment.
Sorry for a deelay, LGTM either.
https://reviews.llvm.org/D23992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
aaron.ballman added a comment.
In https://reviews.llvm.org/D24862#550628, @ioeric wrote:
> In https://reviews.llvm.org/D24862#550615, @aaron.ballman wrote:
>
> > Should this perhaps be fixed in the AST matchers rather than in the check
> > itself?
>
>
> I'll file bugs for the crashes, but the fi
Author: etienneb
Date: Fri Sep 23 09:07:47 2016
New Revision: 282251
URL: http://llvm.org/viewvc/llvm-project?rev=282251&view=rev
Log:
[asan] Fix incorrect SEH symbol mangling on win64.
Summary:
The ASAN unittests are failing (check-asan-dynamic) due to an incorrect symbol
name:
```
LINK : error
ioeric added a comment.
In https://reviews.llvm.org/D24862#550637, @aaron.ballman wrote:
> In https://reviews.llvm.org/D24862#550628, @ioeric wrote:
>
> > In https://reviews.llvm.org/D24862#550615, @aaron.ballman wrote:
> >
> > > Should this perhaps be fixed in the AST matchers rather than in the
ioeric updated this revision to Diff 72273.
ioeric added a comment.
- Update comments.
https://reviews.llvm.org/D24862
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/tool/ClangChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-na
aaron.ballman added a comment.
In https://reviews.llvm.org/D24862#550646, @ioeric wrote:
> Acked, and I totally agree with you :) It's just that the change in this
> patch would still be valid after the underlying bugs are fixed, so I thought
> it was fine to fix those bugs after this.
I migh
dcoughlin requested changes to this revision.
dcoughlin added a reviewer: dcoughlin.
This revision now requires changes to proceed.
Comment at: lib/Analysis/CFG.cpp:2986
@@ -2985,3 +2985,1 @@
-if (!KnownVal.isFalse()) {
- // Add an intermediate block between the BodyBlo
rmaprath created this revision.
rmaprath added reviewers: EricWF, mclow.lists, jroelofs, compnerd.
rmaprath added a subscriber: cfe-commits.
This is simply a cleanup of D18482 (patch taken with permission) while adapting
it to match what we have already implemented for libcxx.
Note that I haven'
ioeric updated this revision to Diff 72275.
ioeric added a comment.
- Update comment.
https://reviews.llvm.org/D24862
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/tool/ClangChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-nam
Author: bader
Date: Fri Sep 23 09:20:00 2016
New Revision: 282252
URL: http://llvm.org/viewvc/llvm-project?rev=282252&view=rev
Log:
[OpenCL] Augment pipe built-ins with pipe packet size and alignment.
Reviewers: Anastasia, vpykhtin
Subscribers: dmitry, cfe-commits
Differential Revision: https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282252: [OpenCL] Augment pipe built-ins with pipe packet
size and alignment. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23992?vs=70366&id=72276#toc
Repository:
rL LLVM
h
ioeric added a comment.
In https://reviews.llvm.org/D24862#550654, @aaron.ballman wrote:
> In https://reviews.llvm.org/D24862#550646, @ioeric wrote:
>
> > Acked, and I totally agree with you :) It's just that the change in this
> > patch would still be valid after the underlying bugs are fixed,
aaron.ballman added a comment.
In https://reviews.llvm.org/D24862#550665, @ioeric wrote:
> Sorry for the confusion. I guess I should've been clearer in the comments and
> patch summary... The changes would've been what we wanted even without the
> underlying bugs and would not be reverted after
emaste created this revision.
emaste added reviewers: dim, brooks.
emaste added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
It seems a bad idea to change the default in the middle of a release branch due
to possible changes in global ctor / dtor ordering between .ctors and
.ini
ioeric added a comment.
Thanks for the comments!
Comment at: change-namespace/ChangeNamespace.cpp:279
@@ -276,2 +278,3 @@
Finder->addMatcher(
- usingDecl(hasAnyUsingShadowDecl(IsInMovedNs)).bind("using_decl"), this);
+ usingDecl(IsInMovedNs, hasAnyUsingShadowDecl(de
ioeric updated this revision to Diff 72285.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed comments.
https://reviews.llvm.org/D24829
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282253: [clang-format] support header deletion in
cleanupAroundReplacemnts. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24829?vs=72285&id=72286#toc
Repository:
rL LLVM
h
ioeric updated this revision to Diff 72284.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D24862
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-
Author: ioeric
Date: Fri Sep 23 10:10:56 2016
New Revision: 282253
URL: http://llvm.org/viewvc/llvm-project?rev=282253&view=rev
Log:
[clang-format] support header deletion in cleanupAroundReplacemnts.
Summary:
- If a replacement has offset UINT_MAX, length 0, and a replacement text
that is an #
Author: sjoerdmeijer
Date: Fri Sep 23 10:21:33 2016
New Revision: 282255
URL: http://llvm.org/viewvc/llvm-project?rev=282255&view=rev
Log:
Fix for r280064 that added options for fp denormals and exceptions.
These options were forgotten to be copied in setCommandLineOpts.
Modified:
cfe/trunk/l
mgorny created this revision.
mgorny added reviewers: rsmith, beanz, samsonov.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
Fix the test run to declare missing HAVE_LIBZ value in stand-alone builds,
using the LLVM_ENABLE_ZLIB that is exported in LLVMConfig.cmak
mgorny added a comment.
For the record: I've tested the patch with and without zlib installed, using
in-tree and stand-alone builds.
https://reviews.llvm.org/D24869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: sjoerdmeijer
Date: Fri Sep 23 10:37:17 2016
New Revision: 282257
URL: http://llvm.org/viewvc/llvm-project?rev=282257&view=rev
Log:
Revert of r282255 because of "Fell off the end of a string-switch" buildbot
failures.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trunk
Nothing was breaking, but it wasn't working either (because those options were
not copied).
I've reverted the patch directly after the first buildbot failure.
I don't think I am committing at will: I thought it was okay to commit
directly because it is a simple fix (or should be) for my own pr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282259: set the underlying value of “#pragma STDC
FP_CONTRACT” on by default (authored by spop).
Changed prior to commit:
https://reviews.llvm.org/D24481?vs=72186&id=72299#toc
Repository:
rL LLVM
ht
On 23 September 2016 at 16:21, Sjoerd Meijer via cfe-commits
wrote:
> Author: sjoerdmeijer
> Date: Fri Sep 23 10:21:33 2016
> New Revision: 282255
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282255&view=rev
> Log:
> Fix for r280064 that added options for fp denormals and exceptions.
> These o
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
tejohnson updated this revision to Diff 72301.
tejohnson added a comment.
Update option description as per decision to split from parallel code gen.
https://reviews.llvm.org/D24826
Files:
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
test/Driver/lto-jobs.c
Index: test/Driver/lto-j
tejohnson added a comment.
> > I do see other uses of -mllvm in lib/Driver/Tools.cpp, but are you talking
> > about something else?
>
> I think this is okay, since clang is talking to the same version of
> libLTO.dylib. I feel like there might be another case where
> clang talks to libLTO
zaks.anna added a comment.
Thanks!
@alexshap, Do yon have commit access or should we commit on your behalf?
Repository:
rL LLVM
https://reviews.llvm.org/D24792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
alexshap added a comment.
Thanks, Chris has recently granted me commit access, i will rebase, rerun all
the tests and then commit.
Repository:
rL LLVM
https://reviews.llvm.org/D24792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
aaron.ballman created this revision.
aaron.ballman added reviewers: klimek, sbenza.
aaron.ballman added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
It turns out that our support for the `cxxCtorInitializer()` matcher was
incomplete in that it could not be used as a top-level mat
On 23 September 2016 at 17:12, Sjoerd Meijer wrote:
> I don't think I am committing at will: I thought it was okay to commit
> directly because it is a simple fix (or should be) for my own previous
> half-working patch, but I don't mind going through phab.
A review would have caught many issu
mehdi_amini added inline comments.
Comment at: include/clang/Driver/Options.td:818
@@ -815,1 +817,3 @@
+ HelpText<"Controls the backend parallelism of -flto=thin (default "
+ "of 0 means use std::thread::hardware_concurrency)">;
def fthinlto_index_EQ : Joined<["-"], "f
bruno added inline comments.
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
Why removing StatsFile here? IIUC, at this point StatsFile is still the
rSerge updated this revision to Diff 72312.
rSerge added a comment.
Herald added a subscriber: rampitec.
Added a test.
Changed the error message to:
> clang++.exe: error: the clang compiler does not support '-fxray-instrument on
> armv6kz--linux-gnueabihf'
https://reviews.llvm.org/D24799
Fil
MatzeB added inline comments.
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
bruno wrote:
> Why removing StatsFile here? IIUC, at this point StatsF
tejohnson updated this revision to Diff 72317.
tejohnson added a comment.
Update option help message per Mehdi's suggestion
https://reviews.llvm.org/D24826
Files:
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
test/Driver/lto-jobs.c
Index: test/Driver/lto-jobs.c
===
Do you have some data on the true/false positive rate for this warning?
On Fri, Sep 23, 2016 at 6:12 AM Daniel Marjamäki <
daniel.marjam...@evidente.se> wrote:
> danielmarjamaki created this revision.
> danielmarjamaki added reviewers: dblaikie, rtrieu.
> danielmarjamaki added a subscriber: cfe-c
Hello,
https://reviews.llvm.org/D14326
has been accepted but hasn't seen any activity for a couple of months.
Are there any plans to merge it?
There is now a small conflict with master, which I have resolved in
the patch below. There is currently one test failing, which I am
working to fix now.
aturetsk abandoned this revision.
aturetsk added a comment.
New version in https://reviews.llvm.org/D21374
https://reviews.llvm.org/D21066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
vitalybuka added a comment.
In https://reviews.llvm.org/D24693#550119, @ahatanak wrote:
> Thank you for the great example! I can now see this patch does fix
> mis-compiles.
>
> There are probably other lifetime bugs you'll see when the code being
> compiled includes gotos that jump past variabl
khazem added a comment.
I'm updating this patch so that it rebases cleanly onto master, as this patch
hasn't been updated for a couple of months...
At the time of writing, one of Clang's tests is failing with this patch.
Specifically, there is a segfault at line 130 of
test/ASTMerge/Inputs/exp
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
On Windows builds, we currently require `_LIBCPP_DLL` to be specified in
order for dllexport/dllimport annotations to be generated. I believe
it's better to do the opposi
khazem created this revision.
khazem added reviewers: spyffe, sepavloff.
khazem added subscribers: phosek, khazem, NoQ, xazax.hun, cfe-commits.
This patch implements some expression-related AST node import (patch #2).
- Some code cleanup
- Add tests not present in http://reviews.llvm.org/D14
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Visual Studio 2013 and onward have all the required functions in their
CRT headers, and we don't support older versions anymore.
https://reviews.llvm.org/D24879
Files:
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM, Thanks!
https://reviews.llvm.org/D24826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
khazem added a comment.
This diff is a continuation of https://reviews.llvm.org/D14326, which was
accepted for inclusion but has not been merged in for the past couple of months.
I added a small patch so that it rebases cleanly onto master:
--- a/lib/AST/ASTImporter.cpp
+++ b/lib/AST/ASTImp
Now has broken the other:
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/3162
But when I try to revert, git get entangled with another commit and
brings a lot of unrelated changes to it.
I'll continue trying to revert, but if you can do it faster, I'd appreciate.
thanks!
--re
xazax.hun created this revision.
xazax.hun added reviewers: hokein, alexfh.
xazax.hun added a subscriber: cfe-commits.
xazax.hun set the repository for this revision to rL LLVM.
xazax.hun added a project: clang-tools-extra.
Herald added a subscriber: nemanjai.
In some cases do not register the mat
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r275460.
Repository:
rL LLVM
https://reviews.llvm.org/D22270
___
cfe-commits mailing list
cfe-commits@lists.llvm.
rengolin added a subscriber: rengolin.
rengolin added a comment.
Folks, this commit has broken both AArch64 test-suite buildbots:
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/3162
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/10449
I have reverted in r2
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282291: [LTO] Add -flto-jobs=N to control backend
parallelism (authored by tejohnson).
Changed prior to commit:
https://reviews.llvm.org/D24826?vs=72317&id=72349#toc
Repository:
rL LLVM
https://revi
Funny, git-svnrevert is buggy, I had to do it by hand, but now it's
done: r282289.
Let me know if you need help testing it.
--renato
On 23 September 2016 at 21:28, Renato Golin wrote:
> Now has broken the other:
>
> http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/3162
>
> But
Author: tejohnson
Date: Fri Sep 23 15:38:09 2016
New Revision: 282291
URL: http://llvm.org/viewvc/llvm-project?rev=282291&view=rev
Log:
[LTO] Add -flto-jobs=N to control backend parallelism
Summary:
Currently, a linker option must be used to control the backend
parallelism of ThinLTO. The linker
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This fixes PR 30274 by making sure that we skip the 'Using' and
'ConstructorUsingShadowDecl' declarations when evaluating the
'__
beanz added a reviewer: rnk.
beanz added a comment.
This looks reasonable to me, but I'm not super familiar with multi-lib
conventions. I think @chandlerc is more familiar with how that stuff works.
https://reviews.llvm.org/D23752
___
cfe-commits m
Author: alexshap
Date: Fri Sep 23 15:49:01 2016
New Revision: 282293
URL: http://llvm.org/viewvc/llvm-project?rev=282293&view=rev
Log:
[analyzer] Fix crash in RetainCountChecker::checkEndFunction
The class BodyFarm creates bodies for
OSAtomicCompareAndSwap*, objc_atomicCompareAndSwap*, dispatch_s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282293: [analyzer] Fix crash in
RetainCountChecker::checkEndFunction (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D24792?vs=72206&id=72354#toc
Repository:
rL LLVM
https:
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D19854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
bruno added a comment.
Maybe add some docs to explain the new flags?
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
MatzeB wrote:
> bruno wrote:
ahatanak added a comment.
In https://reviews.llvm.org/D24693#551050, @vitalybuka wrote:
> I can see how to insert starts, e.g. on every label which bypass declaration,
> but I am not sure where to put ends.
> Probably it's possible, but patch will be significantly more complicated.
> I'd prefe
ahatanak updated this revision to Diff 72356.
ahatanak added a comment.
I agree that extending the logic of getTemplateInstantiationArgs seems like a
better approach. I changed Sema::getTemplateInstantiationArgs to search for the
template arguments twice, first for the initializer's template arg
mgehre created this revision.
mgehre added reviewers: alexfh, aaron.ballman, rsmith.
mgehre added a subscriber: cfe-commits.
This patch implements parsing of [[clang::suppress(rule, ...)]]
attributes.
C++ Core Guidelines depend heavily on tool support for
rule enforcement. They also propose a way
Author: compnerd
Date: Fri Sep 23 16:36:24 2016
New Revision: 282300
URL: http://llvm.org/viewvc/llvm-project?rev=282300&view=rev
Log:
annotate more function visibility
These data and text symbols were missing annotations for building with hidden
visibility. As we do not currently enable hidden
Without digging into them yet, these are almost caused by overly-sensitive
tests that are erroneously expecting bit-exact results.
- Steve
Sent from my iPhone
> On Sep 23, 2016, at 4:42 PM, Renato Golin wrote:
>
> rengolin added a subscriber: rengolin.
> rengolin added a comment.
>
> Folks,
bruno added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:8090
@@ +8089,3 @@
+ *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast);
+ return VecType;
+}
ahatanak wrote:
> Sorry I wasn't clear, but I was asking whether you were plan
lukasza updated the summary for this revision.
lukasza updated this revision to Diff 72350.
lukasza marked an inline comment as done.
lukasza added a comment.
- Added test where both TemplateSpecializationType and TypedefType are present
and both should match regardless of code order inside
HasD
lukasza added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:750
@@ +749,3 @@
+else if (auto *ET = Node->getAs())
+ return matchesSpecialized(ET->getNamedType(), Finder, Builder);
+else if (auto *TST = Node->getAs())
luka
Author: pcc
Date: Fri Sep 23 16:43:51 2016
New Revision: 282301
URL: http://llvm.org/viewvc/llvm-project?rev=282301&view=rev
Log:
Update clang for r282299.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp
URL:
http://llvm.org/viewvc/llvm-projec
1 - 100 of 141 matches
Mail list logo
