meikeb added a comment.
This is the same as https://reviews.llvm.org/D23820 besides that I added myself
in the commit message as "Patch by". https://reviews.llvm.org/D23820 was
reverted in https://reviews.llvm.org/D24579 because srhines' commit took
authorship of this patch.
https://reviews.l
meikeb updated this revision to Diff 71438.
meikeb added a comment.
Fix typos in commit message.
https://reviews.llvm.org/D24584
Files:
lib/Sema/SemaChecking.cpp
test/Sema/format-strings.c
Index: test/Sema/format-strings.c
===
dim added a comment.
FWIW, I have already imported this fix into FreeBSD two weeks ago:
https://svnweb.freebsd.org/changeset/base/304960
It has been working fine for us.
https://reviews.llvm.org/D23921
___
cfe-commits mailing list
cfe-commits@lists
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
We need to add a bunch more "using"s, which weren't necessary with
libstdc++.
Once this is in I can check in a test to the test-suite.
https://reviews.llvm.org/D24588
Files:
clang/lib/Headers/_
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Fix typo (s/Externals/External/), and mention cuda-tests-simple.
https://reviews.llvm.org/D24590
Files:
External/CUDA/README
Index: External/CUDA/README
Author: jlebar
Date: Wed Sep 14 16:50:14 2016
New Revision: 281544
URL: http://llvm.org/viewvc/llvm-project?rev=281544&view=rev
Log:
[CUDA] Make __clang_cuda_cmath.h compatible with libc++.
Summary:
We need to add a bunch more "using"s, which weren't necessary with
libstdc++.
Once this is in I c
Author: jlebar
Date: Wed Sep 14 16:50:11 2016
New Revision: 281543
URL: http://llvm.org/viewvc/llvm-project?rev=281543&view=rev
Log:
[CUDA] Add test checking our ability to take a function pointer to a __global__
function on the host side.
Summary: This functionality is used by Thrust.
Reviewer
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281543: [CUDA] Add test checking our ability to take a
function pointer to a… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D24581?vs=71423&id=71446#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281544: [CUDA] Make __clang_cuda_cmath.h compatible with
libc++. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D24588?vs=71443&id=71447#toc
Repository:
rL LLVM
https://revi
kzhuravl updated this revision to Diff 71449.
kzhuravl marked 15 inline comments as done.
kzhuravl added a comment.
Address review feedback
https://reviews.llvm.org/D24513
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/C
kzhuravl added inline comments.
Comment at: include/clang/Basic/Attr.td:1067
@@ +1066,3 @@
+ let Spellings = [GNU<"amdgpu_waves_per_eu">];
+ let Args = [UnsignedArgument<"Min">, VariadicUnsignedArgument<"Max">];
+ let Documentation = [AMDGPUWavesPerEUDocs];
aar
Sunil_Srivastava updated this revision to Diff 71432.
Sunil_Srivastava added a comment.
This is an update to address points raised by Richard Smith:
1. The bit and the access functions have been renamed from
MarkedForPendingInstantiation to InstantiationIsPending.
2. It closely, though not entir
LGTM
On 14 Sep 2016 2:36 pm, "Dimitry Andric" wrote:
dim added a comment.
FWIW, I have already imported this fix into FreeBSD two weeks ago:
https://svnweb.freebsd.org/changeset/base/304960
It has been working fine for us.
https://reviews.llvm.org/D23921
__
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: External/CUDA/README:58
@@ +57,3 @@
+ There's a cuda-tests-simple target that excludes tests that take a long time
+ to build (thrust).
+
It may
Author: rnk
Date: Wed Sep 14 17:31:24 2016
New Revision: 281550
URL: http://llvm.org/viewvc/llvm-project?rev=281550&view=rev
Log:
[clang-cl] Accept the joined equals version of -resource-dir=
lib/Tooling injects this argument without regard for what driver syntax
is in use.
Modified:
cfe/tru
jlebar marked an inline comment as done.
jlebar added a comment.
Will add. Thank you for the reviews!
https://reviews.llvm.org/D24590
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281552: [test-suite] [CUDA] Update README. (authored by
jlebar).
Changed prior to commit:
https://reviews.llvm.org/D24590?vs=71445&id=71457#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24590
F
Author: tra
Date: Wed Sep 14 18:03:06 2016
New Revision: 281557
URL: http://llvm.org/viewvc/llvm-project?rev=281557&view=rev
Log:
Revert r281457 "Supports adding insertion around non-insertion replacements."
Commit was breaking our internal tests.
Modified:
cfe/trunk/include/clang/Tooling/Co
twoh added a comment.
Ping.
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Sep 14 18:52:01 2016
New Revision: 281562
URL: http://llvm.org/viewvc/llvm-project?rev=281562&view=rev
Log:
Revert r280944 - Added 'inline' attribute to basic_string's destructor
This patch causes a couple of issues:
1) It triggers http://llvm.org/PR30341. Although the b
FYI I had to revert this in r281562 because of:
* http://llvm.org/PR30341 which breaks the LLVM build.
* http://llvm.org/PR30391 which breaks ABI compatibility when libc++.so is
compiled with GCC.
I'm working on fixing these issues so that this patch may be recommitted.
The GCC issue
also made wo
Author: awatry
Date: Wed Sep 14 19:17:31 2016
New Revision: 281565
URL: http://llvm.org/viewvc/llvm-project?rev=281565&view=rev
Log:
math: Implement lgamma
Just use lgamma_r and ignore the value returned in the second argument
Signed-off-by: Aaron Watry
Reviewed-by: Tom Stellard
Added:
li
Author: awatry
Date: Wed Sep 14 19:17:28 2016
New Revision: 281564
URL: http://llvm.org/viewvc/llvm-project?rev=281564&view=rev
Log:
math: Implement lgamma_r
Ported from the amd-builtins branch, which is itself based on the
Sun Microsystems implementation.
Signed-off-by: Aaron Watry
Reviewed-by
Author: awatry
Date: Wed Sep 14 19:17:22 2016
New Revision: 281563
URL: http://llvm.org/viewvc/llvm-project?rev=281563&view=rev
Log:
Add ADDR_SPACE parameter to _CLC_V_V_VP_VECTORIZE
This macro is currently unused, but I plan to use it shortly.
The previous form did casts of pointers without an
Author: awatry
Date: Wed Sep 14 19:17:34 2016
New Revision: 281566
URL: http://llvm.org/viewvc/llvm-project?rev=281566&view=rev
Log:
math: Implement tgamma
Signed-off-by: Aaron Watry
Reviewed-by: Tom Stellard
Added:
libclc/trunk/generic/include/clc/math/tgamma.h
libclc/trunk/generic/in
sashab added a comment.
Pinging for another LGTM since I have added it to -Wall and added a portability
comment to the error message :)
https://reviews.llvm.org/D24289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
agutowski created this revision.
agutowski added reviewers: rnk, thakis, majnemer.
agutowski added a subscriber: cfe-commits.
We need x86-64-specific builtins if we want to implement some of the MS
intrinsics - winnt.h contains definitions of some functions for i386, but not
for x86-64 (for exam
EricWF created this revision.
EricWF added reviewers: mclow.lists, laxmansole, hiraditya, dblaikie.
EricWF added a subscriber: cfe-commits.
r280944 attempted to add both `inline` and `_LIBCPP_INLINE_VISIBILITY` to
basic_string's destructor in order to achieve better inlining behavior.
Unfortunat
EricWF created this revision.
EricWF added reviewers: mclow.lists, eugenis, danalbert, jroelofs.
EricWF added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
GCC and Clang handle visibility attributes on the out-of-line definition of
externally instantiated templates different
Author: chapuni
Date: Thu Sep 15 00:11:43 2016
New Revision: 281582
URL: http://llvm.org/viewvc/llvm-project?rev=281582&view=rev
Log:
Builtins.def: Explicitly undef finitef, to appease mingw. It defines finitef as
alias of _finitef.
Modified:
cfe/trunk/include/clang/Basic/Builtins.def
Modif
Author: wmi
Date: Thu Sep 15 01:31:30 2016
New Revision: 281587
URL: http://llvm.org/viewvc/llvm-project?rev=281587&view=rev
Log:
Update clang unittests for rL281586.
The change in rL281586 is in llvm component and tests updated here are
in clang component, so I have to commit them consecutively.
sepavloff added a subscriber: sepavloff.
sepavloff added a comment.
You need to provide a test for the fix.
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
101 - 134 of 134 matches
Mail list logo
