[PATCH] D24374: [libc++] Avoid include in locale_win32.h

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. When `_LIBCPP_NO_EXCEPTIONS` is defined, we end up with compile errors when targeting MSVCRT: * Code includes `` * `` includes `` in order to get `abort` * `` includes `

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

smeenai added a comment. I'm aware that my replacement code isn't entirely equivalent, since it won't restore the locale in case `MB_CUR_MAX` throws. However, I'm quite certain the `MB_CUR_MAX` implementation won't throw. I can make my own RAII wrapper if desired, however. Alternatively, MSDN

Re: [PATCH] D21515: Update clang for D21514. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL281018: Update clang for D21514. NFC (authored by deadalnix). Changed prior to commit: https://reviews.llvm.org/D21515?vs=62791&id=70783#toc Repository: rL LLVM https://reviews.llvm.org/D21515 Files

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

EricWF added a comment. LGTM. I'm OK with things that are "technically" regressions in Windows support if it helps us get it working today. https://reviews.llvm.org/D24374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

smeenai added a comment. Cool. Any thoughts on this implementation vs. `___mb_cur_max_l_func`? In other words, do we have a general policy on using internal CRT functionality? FWIW, `support/win32/support.h` was using `xlocinfo.h` before my recent cleanup, which is also an internal header. ht

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

I believe mclow is working on this On Sep 8, 2016 9:30 PM, "Keno Fischer" wrote: > loladiro created this revision. > loladiro added reviewers: EricWF, mclow.lists. > loladiro added a subscriber: cfe-commits. > loladiro set the repository for this revision to rL LLVM. > > Without this, unique_ptr

[PATCH] D24378: [CodeGen] Provide an appropriate alignment for dynamic allocas

majnemer created this revision. majnemer added reviewers: rnk, rsmith, efriedma, chandlerc. majnemer added a subscriber: cfe-commits. GCC documents __builtin_alloca as aligning the storage to at least __BIGGEST_ALIGNMENT__. MSVC documents essentially the same for the x64 ABI: https://msdn.microso

<    1   2