Author: arsenm
Date: Wed Sep 7 02:07:59 2016
New Revision: 280786
URL: http://llvm.org/viewvc/llvm-project?rev=280786&view=rev
Log:
Fix whitespace issues
^M and extra space
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/v
Author: arsenm
Date: Wed Sep 7 02:08:02 2016
New Revision: 280787
URL: http://llvm.org/viewvc/llvm-project?rev=280787&view=rev
Log:
OpenCL: Defining __ENDIAN_LITTLE__ and fix target endianness
OpenCL requires __ENDIAN_LITTLE__ be set for little endian targets.
The default for targets was also ap
arsenm closed this revision.
arsenm added a comment.
r280787
https://reviews.llvm.org/D23953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:844
@@ +843,3 @@
+ Args.hasFlag(options::OPT_fdiagnostics_show_hotness,
+ options::OPT_fno_diagnostics_show_hotness,
+ /*default*/ false);
You sh
Hi Nico,
One of our thumb bots [1] is having issues building lately and it
looks like it might be related to one of the commits in this series.
Could you please have a look?
Thanks,
Diana
[1]
http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15/builds/15286/steps/build%20stage%201/logs/std
bmharper added a comment.
PING!
My previous commit hopefully addressed the issue with the sprawl of IndentLevel
+ ScopeLevel
https://reviews.llvm.org/D21279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
curdeius added a subscriber: curdeius.
curdeius added a comment.
For the moment, just a few nitty-gritty comments inline.
What I miss here is (as already pointed by someone) an example on how to write
a new module, register it etc.
Comment at: clang-refactor/driver/Driver.cpp:4
Scratch that, apparently it fixed itself after I removed the build
directory and restarted the bot.
Sorry about the noise.
Diana
On 7 September 2016 at 11:10, Diana Picus wrote:
> Hi Nico,
>
> One of our thumb bots [1] is having issues building lately and it
> looks like it might be related to o
Author: bader
Date: Wed Sep 7 05:32:03 2016
New Revision: 280800
URL: http://llvm.org/viewvc/llvm-project?rev=280800&view=rev
Log:
[OpenCL] Fix pipe built-in functions return type.
By default return type of call expressions calling built-in
functions is set to bool.
Fixes https://llvm.org/bugs/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280800: [OpenCL] Fix pipe built-in functions return type.
(authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D24136?vs=70368&id=70516#toc
Repository:
rL LLVM
https://reviews.llvm
On 6 September 2016 at 01:21, Nico Weber wrote:
> Renato, I remember you saying you worked around the bot problem by making
> the build dir a symlink. Maybe stuff gets confused by that setup? Symlink
> build dirs tend to cause trouble.
Hi Nico,
The symlink was from base source to base source, sh
alexfh added a comment.
Kirill, first, thank you for working on this!
As discussed offline, the RefactoringModule interface should explicitly define:
- separation of execution stages for each check:
1. preparation or execution planning - should figure out the set of affected
translation units
bader added a comment.
Valery, do you have any additional comments/questions regarding this patch?
https://reviews.llvm.org/D23992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-refactor/driver/Driver.cpp:41
@@ +40,3 @@
+Command = argv[1];
+std::string Invocation = std::string(argv[0]) + " " + argv[1];
+argv[1] = Invocation.c_str();
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-rename/USRFindingAction.cpp:158
@@ +157,3 @@
+
+FoundDecl = QualifiedName.empty() ? getNamedDeclAt(Context, Point)
+ : getNamedDeclF
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
A few late comments. Looks good overall.
Comment at: clang-tidy-vs/ClangTidy/CategoryVerb.cs:52
@@ +51,3 @@
+{
+if (value.GetType() == typeof(CategoryVerb)
alexfh added inline comments.
Comment at: clang-tidy-vs/ClangTidy/ClangTidyPackage.cs:53
@@ +52,3 @@
+private void MenuItemCallback(object sender, EventArgs args)
+{
+}
Add a FIXME to actually implement this.
https://reviews.llvm.org/D238
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good.
Please ensure it works reasonably on LLVM code before submitting.
Sorry for the delay. Feel free to ping earlier.
https://reviews.llvm.org/D21134
_
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Close, but still a bunch of comments in the docs and a suggestion to fix a
class of false positives.
Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:210
@@ +209,3 @
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:30
@@ +29,3 @@
+/// a `CFGBlock`.
+///
+/// While a `CFGBlock` does contain individual `CFGElement`s for some
Author: slthakur
Date: Wed Sep 7 07:23:15 2016
New Revision: 280806
URL: http://llvm.org/viewvc/llvm-project?rev=280806&view=rev
Log:
[EfficiencySanitizer] [MIPS64] Enables esan clang driver options for MIPS64
Reviewed by bruening
Differential: D23800
Modified:
cfe/trunk/lib/Driver/ToolChai
rogfer01 added a comment.
Ping? :)
Thank you very much.
https://reviews.llvm.org/D23657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
neil.hickey updated this revision to Diff 70527.
neil.hickey added a comment.
Added a CodeGen test as well as fixed an issue with vararg type promotion
https://reviews.llvm.org/D24235
Files:
lib/Sema/SemaExpr.cpp
lib/Sema/SemaType.cpp
test/CodeGenOpenCL/fpmath.cl
test/SemaOpenCL/extensi
tavianator added inline comments.
Comment at: src/cxa_thread_atexit.cpp:70
@@ +69,3 @@
+while (auto head = dtors) {
+ dtors = head->next;
+ head->dtor(head->obj);
EricWF wrote:
> There is a bug here. If `head->next == nullptr` and if
> `head->dtor(h
yaxunl added a subscriber: yaxunl.
yaxunl added a comment.
This seems to cause regression for the following test:
__kernel void test_atomic_fn(volatile __global uint *destMemory, __global
uint *oldValues)
{
int tid = get_global_id(0);
oldValues[tid] = atom_add( &destMemory[0], ti
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
I can't really comment on the emacs integration with my limited knowledge of
elisp. The rest looks good to me.
https://reviews.llvm.org/D24075
___
hokein added a comment.
+ Jens for reviewing emacs integration part.
https://reviews.llvm.org/D24075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Looks great, thanks!
https://reviews.llvm.org/D24286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: rnk
Date: Wed Sep 7 10:15:51 2016
New Revision: 280815
URL: http://llvm.org/viewvc/llvm-project?rev=280815&view=rev
Log:
[MS] Fix 'this' type when calling virtual methods with inalloca
If the virtual method comes from a secondary vtable, then the type of
the 'this' parameter should be i8
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:38
@@ +37,3 @@
+ const clang::Module * /*Imported*/) override {
+if (const auto *FileEntry = SM.getFileEntryForID(SM.getFileID(HashLoc))) {
+ if (IsAngled) {
ioeri
Thanks, I’ll take a look at your patch today.
vec1.patch
Description: Binary data
> On Sep 7, 2016, at 12:53 AM, Vladimir Yakovlev wrote:
>
> I did another fix (attached). It fixes the error and chang-check has not any
> new errors. Please take a look.
>
> Where can I see your fix?
>
>
>
hokein updated this revision to Diff 70538.
hokein marked 19 inline comments as done.
hokein added a comment.
Herald added a subscriber: beanz.
- Address review comments.
https://reviews.llvm.org/D24243
Files:
CMakeLists.txt
clang-move/CMakeLists.txt
clang-move/ClangMove.cpp
clang-move/
massberg added a comment.
Added two comments. It took some time for me to recall Emacs Lisps ;)
Comment at: include-fixer/tool/clang-include-fixer.el:48
@@ +47,3 @@
+ :group 'clang-include-fixer
+ :type 'bool
+ :risky t)
Please use 'boolean here
vsk added a comment.
Ping?
https://reviews.llvm.org/D7
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 70545.
hokein marked an inline comment as done.
hokein updated the summary for this revision.
hokein added a comment.
bool => boolean
https://reviews.llvm.org/D24075
Files:
include-fixer/find-all-symbols/SymbolInfo.h
include-fixer/tool/ClangIncludeFixer.
hokein marked an inline comment as done.
Comment at: include-fixer/tool/clang-include-fixer.el:204
@@ -197,3 +203,3 @@
(message (concat "Calling the include fixer. "
"This might take some seconds. Please wait."))
massberg wrote:
> Is this message
massberg added a comment.
The Emacs part looks good for me now.
Comment at: include-fixer/tool/clang-include-fixer.el:204
@@ -197,3 +203,3 @@
(message (concat "Calling the include fixer. "
"This might take some seconds. Please wait."))
Then it f
anemet marked an inline comment as done.
anemet added a comment.
https://reviews.llvm.org/D23284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
anemet updated this revision to Diff 70547.
anemet updated the summary for this revision.
anemet added a comment.
Address Richard's comment
https://reviews.llvm.org/D23284
Files:
docs/UsersManual.rst
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Options.td
include/cl
Author: hokein
Date: Wed Sep 7 11:34:35 2016
New Revision: 280824
URL: http://llvm.org/viewvc/llvm-project?rev=280824&view=rev
Log:
[include-fixer] Support finding headers for the symbol under cursor.
Summary:
* Add a `query-symbol` option to query symbol without parsing the source file.
* Updat
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL280824: [include-fixer] Support finding headers for the
symbol under cursor. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24075?vs=70
Author: rnk
Date: Wed Sep 7 11:38:32 2016
New Revision: 280825
URL: http://llvm.org/viewvc/llvm-project?rev=280825&view=rev
Log:
Parsing MS pragma intrinsic
Parse pragma intrinsic, display warning if the function isn't a builtin
function in clang and suggest including intrin.h.
Patch by Albert
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280825: Parsing MS pragma intrinsic (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D23944?vs=69768&id=70551#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23944
Files:
cfe
rnk added a comment.
Looks good to me. David, do you remember any subtleties here? I seem to recall
there were some bugs in our intrin.h implementations, or inconsistencies
between us and MSVC.
Comment at: test/CodeGen/ms-intrinsics.c:297
@@ +296,3 @@
+// CHECK: define{{.*}}i1
Author: rnk
Date: Wed Sep 7 11:55:12 2016
New Revision: 280826
URL: http://llvm.org/viewvc/llvm-project?rev=280826&view=rev
Log:
Add MS __nop intrinsic to intrin.h
Summary: There was no definition for __nop function - added inline
assembly.
Patch by Albert Gutowski!
Reviewers: rnk, thakis
Sub
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280826: Add MS __nop intrinsic to intrin.h (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D24286?vs=70495&id=70555#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24286
Files
Anastasia added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:832
@@ -831,2 +831,3 @@
BTy->getKind() == BuiltinType::Float))
-E = ImpCastExprToType(E, Context.DoubleTy, CK_FloatingCast).get();
+ {
+if (getLangOpts().OpenCL &&
This shou
ismailp updated this revision to Diff 70561.
ismailp added a comment.
- Added more tests
https://reviews.llvm.org/D24158
Files:
lib/Sema/SemaOverload.cpp
test/CodeGenCXX/cxx1z-constexpr-if.cpp
Index: test/CodeGenCXX/cxx1z-constexpr-if.cpp
===
Author: vvassilev
Date: Wed Sep 7 12:30:50 2016
New Revision: 280827
URL: http://llvm.org/viewvc/llvm-project?rev=280827&view=rev
Log:
Add missing include. White space.
Modified:
cfe/trunk/include/clang/Lex/ModuleMap.h
Modified: cfe/trunk/include/clang/Lex/ModuleMap.h
URL:
http://llvm.org
ismailp added a comment.
Thank you for reviewing.
Sure, I'll try to look into those conversions as well.
Comment at: test/CodeGenCXX/cxx1z-constexpr-if.cpp:2
@@ -1,2 +1,3 @@
// RUN: %clang_cc1 -std=c++1z %s -emit-llvm -o - | FileCheck %s
--implicit-check-not=should_not_be_use
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280828: [clang-offload-bundler] Fix some Clang-tidy
modernize-use-override and… (authored by eugenezelenko).
Changed prior to commit:
https://reviews.llvm.org/D24165?vs=70084&id=70564#toc
Repository:
Author: eugenezelenko
Date: Wed Sep 7 12:37:28 2016
New Revision: 280828
URL: http://llvm.org/viewvc/llvm-project?rev=280828&view=rev
Log:
[clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include
What You Use warnings; other minor fixes.
Differential revision: https://revi
rsmith added inline comments.
Comment at: test/CodeGenCXX/cxx1z-constexpr-if.cpp:2
@@ -1,2 +1,3 @@
// RUN: %clang_cc1 -std=c++1z %s -emit-llvm -o - | FileCheck %s
--implicit-check-not=should_not_be_used
+// RUN: %clang_cc1 -std=c++1z %s -DCHECK_CONVERSION -verify %s
--
dkrupp created this revision.
dkrupp added reviewers: xazax.hun, NoQ, dcoughlin, zaks.anna.
dkrupp added a subscriber: cfe-commits.
ArrayBoundChecker did not detect out of bounds memory access errors in case an
array was allocated by the new expression.
1. MallocChecker.cpp was updated to calcu
On Tue, Sep 6, 2016 at 10:55 PM, George Burgess IV <
george.burgess...@gmail.com> wrote:
> george.burgess.iv added a comment.
>
> > Although I think that users will expect atomic_add(unsigned int *, 5) to
> work.without error
>
>
> Totally agree; I was just making sure that I understood the proble
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 70569.
yaxunl added a comment.
Herald added a subscriber: wdng.
Implemented a simple AST reader listener to replace PCHValidator. Added a test.
https://reviews.llvm.org/D24054
Files:
include/clang/Serialization
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:21
@@ +20,3 @@
+inline std::string formatNamespace(llvm::StringRef NS) {
+ (void)NS.ltrim(':');
+ return NS.str();
hokein wrote:
> this statement doesn't do the intended thing (It won
agutowski updated this revision to Diff 70572.
agutowski added a comment.
Mark _InterlockedIncrement and _InterlockedDecrement as non-volatile
https://reviews.llvm.org/D24153
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
test/CodeGen/ms-intrinsic
agutowski marked an inline comment as done.
agutowski added a comment.
https://reviews.llvm.org/D24153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Wed Sep 7 13:21:30 2016
New Revision: 280836
URL: http://llvm.org/viewvc/llvm-project?rev=280836&view=rev
Log:
[MS] Fix prologue this adjustment when 'this' is passed indirectly
Move the logic for doing this from the ABI argument lowering into
EmitParmDecl, which runs for all p
Author: ismailp
Date: Wed Sep 7 13:24:54 2016
New Revision: 280838
URL: http://llvm.org/viewvc/llvm-project?rev=280838&view=rev
Log:
Try contextually converting condition of constexpr if to Boolean value
Summary:
C++1z 6.4.1/p2:
If the if statement is of the form if constexpr, the value of the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280838: Try contextually converting condition of constexpr
if to Boolean value (authored by ismailp).
Changed prior to commit:
https://reviews.llvm.org/D24158?vs=70561&id=70577#toc
Repository:
rL LLV
The unnecessary usings are added by Visual Studio, so I would rather leave
them. For example, they often provide extension methods to containers so
that containers can be used with functional paradigms, and you expect to
see those methods in the Intellisense window when you type "Foo.", but
withou
ismailp added inline comments.
Comment at: test/CodeGenCXX/cxx1z-constexpr-if.cpp:2
@@ -1,2 +1,3 @@
// RUN: %clang_cc1 -std=c++1z %s -emit-llvm -o - | FileCheck %s
--implicit-check-not=should_not_be_used
+// RUN: %clang_cc1 -std=c++1z %s -DCHECK_CONVERSION -verify %s
-
Author: zturner
Date: Wed Sep 7 13:28:42 2016
New Revision: 280839
URL: http://llvm.org/viewvc/llvm-project?rev=280839&view=rev
Log:
Resubmit "Add a test for clang-tidy using the clang-cl driver."
This was originally reverted because the patch on the clang
tooling side was reverted. That patch
alexshap added a subscriber: alexshap.
Comment at: change-namespace/ChangeNamespace.cpp:125
@@ +124,3 @@
+// applying all existing Replaces first if there is conflict.
+void addOrMergeReplacement(const tooling::Replacement &R,
+ tooling::Replacements *Rep
rsmith accepted this revision.
rsmith added a comment.
It's pretty gross that we're computing `SuggestedPredefines` in the
`ASTReaderListener`, but sure, this seems OK for now.
https://reviews.llvm.org/D24054
___
cfe-commits mailing list
cfe-commit
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D24054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Author: yaxunl
Date: Wed Sep 7 13:40:20 2016
New Revision: 280842
URL: http://llvm.org/viewvc/llvm-project?rev=280842&view=rev
Log:
Do not validate pch when -fno-validate-pch is set
There is a bug causing pch to be validated even though -fno-validate-pch is
set. This patch fixes it.
ASTReader
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280842: Do not validate pch when -fno-validate-pch is set
(authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D24054?vs=70569&id=70580#toc
Repository:
rL LLVM
https://reviews.llv
alexshap added inline comments.
Comment at: change-namespace/tool/ClangChangeNamespace.cpp:48
@@ +47,3 @@
+
+cl::opt OldNamespace("old_namespace", cl::desc("Old namespace."),
+ cl::cat(ChangeNamespaceCategory));
probably you need t
majnemer added a comment.
In https://reviews.llvm.org/D24153#535992, @rnk wrote:
> Looks good to me. David, do you remember any subtleties here? I seem to
> recall there were some bugs in our intrin.h implementations, or
> inconsistencies between us and MSVC.
I can't seem to recall anything m
rSerge added a comment.
I don't have commit access rights. Could someone commit?
https://reviews.llvm.org/D23932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lukasza added a comment.
In https://reviews.llvm.org/D24268#535463, @rsmith wrote:
> This patch looks great, thank you! Do you have an SVN account or do you need
> someone to commit this for you?
I don't have an SVN account. Could you please commit the patch for me?
https://reviews.llvm.org
Hi Richard,
We noticed a regression for this simple testing case:
rm -rf tmp3
clang -cc1 -fimplicit-module-maps -x objective-c -fmodules
-fmodules-cache-path=tmp3 -emit-obj standalone.c -I Inputs/
—>
standalone.c:4:6: error: variable has incomplete type 'void'
void foo __P(());
^
standalone.
On Tue, Sep 6, 2016 at 6:54 PM, Richard Smith wrote:
> On Tue, Sep 6, 2016 at 11:16 AM, Manman Ren via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: mren
>> Date: Tue Sep 6 13:16:54 2016
>> New Revision: 280728
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=280728&view=rev
Author: zturner
Date: Wed Sep 7 14:41:19 2016
New Revision: 280844
URL: http://llvm.org/viewvc/llvm-project?rev=280844&view=rev
Log:
Fix a few oversights in the clang-tidy VS plugin.
Over-zealous cleanup of using statements removed some that were
actually needed. Also cleaned up a few warnings.
Author: nico
Date: Wed Sep 7 14:41:35 2016
New Revision: 280845
URL: http://llvm.org/viewvc/llvm-project?rev=280845&view=rev
Log:
Add a few more test for []-style uuid attributes.
- Should diag on a function (clang-cl warns; it's an error in cl)
- Test the attribute on nested classes (clang-cl i
agutowski created this revision.
agutowski added reviewers: rnk, thakis, Prazek, compnerd.
agutowski added a subscriber: cfe-commits.
https://reviews.llvm.org/D24311
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
test/CodeGen/ms-intrinsics-rotations
ioeric updated this revision to Diff 70588.
ioeric marked 9 inline comments as done.
ioeric added a comment.
Herald added a subscriber: beanz.
- Addressed reviewer comments.
https://reviews.llvm.org/D24183
Files:
CMakeLists.txt
change-namespace/CMakeLists.txt
change-namespace/ChangeNamesp
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:125
@@ +124,3 @@
+// applying all existing Replaces first if there is conflict.
+void addOrMergeReplacement(const tooling::Replacement &R,
+ tooling::Replacements *Replaces) {
Author: gbiv
Date: Wed Sep 7 15:03:19 2016
New Revision: 280847
URL: http://llvm.org/viewvc/llvm-project?rev=280847&view=rev
Log:
[Sema] Compare bad conversions in overload resolution.
r280553 introduced an issue where we'd emit ambiguity errors for code
like:
```
void foo(int *, int);
void foo
ahatanak created this revision.
ahatanak added a reviewer: rjmccall.
ahatanak added a subscriber: cfe-commits.
r235815 changed CGRecordLowering::accumulateBases to ignore non-virtual bases
of size 0, which prevented adding those non-virtual bases to CGRecordLayout's
NonVirtualBases. EmitNullCons
Fix committed as r280847 -- thanks for the reports!
> It seems to me that we could handle this by ranking viable-but-ill-formed
conversion sequences before non-viable ones in
clang::isBetterOverloadCandidate
That's what I was thinking, too. :)
> Clang reports an ambiguity on line 3
TIL. Woohoo
Author: gbiv
Date: Wed Sep 7 15:15:03 2016
New Revision: 280852
URL: http://llvm.org/viewvc/llvm-project?rev=280852&view=rev
Log:
Move CHECK right before the function it describes.
Modified:
cfe/trunk/test/CodeGen/overloadable.c
Modified: cfe/trunk/test/CodeGen/overloadable.c
URL:
http://l
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:103
@@ +102,3 @@
+ const clang::SourceManager *SM) {
+ // Gets the ending ";".
+ auto EndLoc = clang::Lexer::getLocForEndOfToken(D->getLocEnd(), 0, *SM,
hokein
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1003
@@ +1002,3 @@
+//
+ProgramStateRef MallocChecker::addExtentSize(CheckerContext &C,
+ const CXXNewExpr *NE,
I am not sure thi
rnk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:740
@@ +739,3 @@
+Value *LeftShifted = Builder.CreateShl(Val, Shift);
+Value *RightShifted = Builder.CreateLShr(Val, RightShift);
+Value *Shifted = Builder.CreateOr(LeftShifted, RightShifted);
---
rnk added a comment.
You should locally verify that this generates the correct assembly when
optimizations are enabled, and if it doesn't, try to make the input look more
like llvm/test/CodeGen/X86/rotate.ll
Comment at: test/CodeGen/ms-intrinsics-rotations.c:2
@@ +1,3 @@
+// R
EricWF added inline comments.
Comment at: src/cxa_thread_atexit.cpp:70
@@ +69,3 @@
+while (auto head = dtors) {
+ dtors = head->next;
+ head->dtor(head->obj);
tavianator wrote:
> EricWF wrote:
> > There is a bug here. If `head->next == nullptr` and i
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1003
@@ +1002,3 @@
+//
+ProgramStateRef MallocChecker::addExtentSize(CheckerContext &C,
+ const CXXNewExpr *NE,
zaks.anna wrote:
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Visual Studio 2013 (CRT version 12) added support for many C99 long long
and long double functions. Visual Studio 2015 (CRT version 14) increased
C99 and C11 compliance f
EricWF added a comment.
This LGTM but I'll let @compnerd give it the final OK, since I've never built
libc++ on windows.
Comment at: include/support/win32/support.h:48
@@ -47,2 +47,3 @@
#if defined(_LIBCPP_MSVCRT)
+#if _VC_CRT_MAJOR_VERSION < 14
#define snprintf _snprintf
---
smeenai added inline comments.
Comment at: include/support/win32/support.h:48
@@ -47,2 +47,3 @@
#if defined(_LIBCPP_MSVCRT)
+#if _VC_CRT_MAJOR_VERSION < 14
#define snprintf _snprintf
EricWF wrote:
> Maybe fold these to `#if`'s into `#if defined(_VC_CRT_MAJOR_VER
smeenai updated this revision to Diff 70598.
smeenai added a comment.
Simpliying conditional per EricWF's suggestion
https://reviews.llvm.org/D24314
Files:
include/support/win32/support.h
Index: include/support/win32/support.h
=
smeenai marked 2 inline comments as done.
smeenai added a comment.
https://reviews.llvm.org/D24314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eugenezelenko
Date: Wed Sep 7 16:53:17 2016
New Revision: 280870
URL: http://llvm.org/viewvc/llvm-project?rev=280870&view=rev
Log:
Fix some Clang-tidy modernize-use-using and Include What You Use warnings;
other minor fixes.
Differential revision: https://reviews.llvm.org/D24115
Modifi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280870: Fix some Clang-tidy modernize-use-using and Include
What You Use warnings… (authored by eugenezelenko).
Changed prior to commit:
https://reviews.llvm.org/D24115?vs=69937&id=70606#toc
Repository
lhchavez created this revision.
lhchavez added a reviewer: djasper.
lhchavez added subscribers: srhines, cfe-commits.
lhchavez set the repository for this revision to rL LLVM.
lhchavez added a project: clang-c.
When building pre-upload hooks using git-clang-format, it is useful to limit
the scope
Author: jvesely
Date: Wed Sep 7 17:11:02 2016
New Revision: 280871
URL: http://llvm.org/viewvc/llvm-project?rev=280871&view=rev
Log:
Avoid ambiguity in calling atom_add functions.
clang (since r280553) allows pointer casts in function overloads,
so we need to disambiguate the second argument.
c
1 - 100 of 135 matches
Mail list logo
