[libcxx] r280780 - Avoid compile error by giving the test type a user defined default constructor

Author: ericwf Date: Tue Sep 6 22:50:36 2016 New Revision: 280780 URL: http://llvm.org/viewvc/llvm-project?rev=280780&view=rev Log: Avoid compile error by giving the test type a user defined default constructor Modified: libcxx/trunk/test/std/experimental/optional/optional.object/optional.o

Re: [PATCH] D24113: Allow implicit conversions between incompatible pointer types in overload resolution in C.

jvesely added a comment. In https://reviews.llvm.org/D24113#535255, @george.burgess.iv wrote: > Thanks for the heads-up! > > I'm assuming that below is an example of code that this patch broke? > > void foo(int *a, int) __attribute__((overloadable)); > void foo(unsigned int *a, unsigned int)

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

mclow.lists added a comment. The patch (again) doesn't apply cleanly (test/CMakeLists.txt), so I applied it manually. After that, it builds w/o errors, and passes all the tests. After addressing @EricWF's concerns, I think this is ready to land. https://reviews.llvm.org/D21968 _

Re: [PATCH] D24113: Allow implicit conversions between incompatible pointer types in overload resolution in C.

george.burgess.iv added a comment. > Although I think that users will expect atomic_add(unsigned int *, 5) to > work.without error Totally agree; I was just making sure that I understood the problem. :) I think, with a small tweak in semantics, we can make everything work without needing to p

Re: [PATCH] D23284: Add -Rpass-with-hotness

anemet updated this revision to Diff 70502. anemet added a comment. This renames the flag to -fdiagnostics-show-hotness as requested by Richard. Also added the missing documentation bits. https://reviews.llvm.org/D23284 Files: docs/UsersManual.rst include/clang/Basic/DiagnosticDriverKinds.t

Re: [PATCH] D23096: [Sema] Pass CombineWithOuterScope = true to constructor of LocalInstantiationScope

sepavloff added inline comments. Comment at: include/clang/Sema/Sema.h:6619 @@ -6618,1 +6618,3 @@ + ArrayRef varTemplateArguments() const; + I would propose to use something like 'getVarTemplateArguments' to make the name more similar to other methods. ==

Re: [PATCH] D23684: Resolve ambiguity in a declaration if global nested name specifier is used

sepavloff updated this revision to Diff 70503. sepavloff added a comment. Reworked patch https://reviews.llvm.org/D23684 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Parse/ParseExprCXX.cpp lib/P

<    1   2