Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3377-3378 @@ -3376,4 +3376,4 @@ if (!Context.hasSameType(NewArray, PrevVDTy)) return diagnoseVarDeclTypeMismatch(*this, New, PrevVD); } ahatanak wrote: > rsmith wrot

[PATCH] D24113: Allow implicit conversions between incompatible pointer types in overload resolution in C.

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. In C, we allow pointer conversions like: ``` void foo(int *a); long b; void runFoo() { foo(&b); } ``` ...But not when overloading: ``` int bar(char *a) __attri

Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info

bruno added inline comments. Comment at: docs/CommandGuide/clang.rst:114 @@ -110,1 +113,3 @@ + compiler-rt. + .. option:: -ansi zlei wrote: > bruno wrote: > > It might be worth mentioning what's the default behaviour in case the flag > > isn't specified? > This

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

ahatanak added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3377-3378 @@ -3376,4 +3376,4 @@ if (!Context.hasSameType(NewArray, PrevVDTy)) return diagnoseVarDeclTypeMismatch(*this, New, PrevVD); } rsmith wrote: > ahatanak wr

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

ahatanak added a comment. I'll commit the patch as-is first and come up with a new patch which implements the improvements you suggested later. https://reviews.llvm.org/D24110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

r280330 - [Sema] Don't diagnose an array type mismatch when the new or previous

Author: ahatanak Date: Wed Aug 31 20:03:21 2016 New Revision: 280330 URL: http://llvm.org/viewvc/llvm-project?rev=280330&view=rev Log: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type. This fixes a bug where clang errors out on a valid code.

[PATCH] D24115: [Clang] Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: mehdi_amini, compnerd. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

r280333 - Fix typos in comments.

Author: gbiv Date: Wed Aug 31 20:26:58 2016 New Revision: 280333 URL: http://llvm.org/viewvc/llvm-project?rev=280333&view=rev Log: Fix typos in comments. Modified: cfe/trunk/lib/Sema/SemaExprObjC.cpp Modified: cfe/trunk/lib/Sema/SemaExprObjC.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/

[libcxx] r280335 - Fix libc++ configuration with -fsanitize-coverage

Author: krasin Date: Wed Aug 31 20:38:32 2016 New Revision: 280335 URL: http://llvm.org/viewvc/llvm-project?rev=280335&view=rev Log: Fix libc++ configuration with -fsanitize-coverage Summary: a recent change (r280015) in libc++ configuration broke LibFuzzer bot: http://lab.llvm.org:8011/builders/

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

This revision was automatically updated to reflect the committed changes. Closed by commit rL280330: [Sema] Don't diagnose an array type mismatch when the new or previous (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D24110?vs=69927&id=69935#toc Repository: rL LLV

[PATCH] D24119: [libc++] add linker option "-Wl, -z, defs" in standalone build

zlei created this revision. zlei added a reviewer: cfe-commits. This option is used to avoid underlinking. It's available in LLVM's main tree, but not in a standalone build of libc++. This patch ensures the option is passed in whether libc++ is built in-tree or out-of-tree. https://reviews.llvm

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

mclow.lists added a comment. Other than the iterator.primitives/iterator.operations/prev.pass.cpp test, I think this is good to go. Comment at: test/std/iterators/iterator.primitives/iterator.operations/prev.pass.cpp:47 @@ +46,3 @@ + +{ +constexpr const char* s = "

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

Chris Bieneman writes: > beanz created this revision. > beanz added reviewers: bogner, zaks.anna, bruno, filcab. > beanz added a subscriber: cfe-commits. > Herald added a subscriber: emaste. > > The FreeBSD and GNUTools drivers support -fsanitize arguments > bypassing -nodefaultlibs. With https://

Re: r262189 - [modules] Prefer more complete array types.

On 01/09/16 02:59, Akira Hatanaka wrote: I’ve come up with a patch and sent it to the list today since it is urgent to fix. https://reviews.llvm.org/D24110 Thank you. I saw it landed in the trunk. Thanks! On Aug 31, 2016, at 1:50 PM, Vassil Vassilev > wrote:

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

Chris Bieneman writes: > beanz created this revision. > beanz added reviewers: zaks.anna, kubabrecka, bogner. > beanz added a subscriber: cfe-commits. > > The -nodefaultlibs and -nostdlib flags suppress all the runtime > libraries that the driver puts on the link line. This feels wrong. If > a use

Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info

zlei edited reviewers, added: bruno; removed: cfe-commits. zlei edited subscribers, added: cfe-commits; removed: bruno. zlei updated this revision to Diff 69947. zlei added a comment. Update the man page entry to state default behavior of this option. https://reviews.llvm.org/D24069 Files: do

r280337 - Remove whitespace to test commit access

Author: honggyu.kim Date: Thu Sep 1 01:14:45 2016 New Revision: 280337 URL: http://llvm.org/viewvc/llvm-project?rev=280337&view=rev Log: Remove whitespace to test commit access Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp URL: htt

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

gribozavr added a subscriber: gribozavr. gribozavr added a comment. > If a user specifies "-fsanitize=" I think it is expected that the > sanitizer library would be included on the link line. I deeply disagree. If the user asks for `-nodefaultlibs`, we should not add any libraries ourselves,

<    1   2