r280159 - [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

Author: bruno Date: Tue Aug 30 16:25:42 2016 New Revision: 280159 URL: http://llvm.org/viewvc/llvm-project?rev=280159&view=rev Log: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list. This adds support for modules that require (no-)gnu-inline-asm environment, such as the comp

Re: [PATCH] D23325: [WIP] Binding of references to packed fields

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:436 @@ -434,1 +435,3 @@ + /// \brief Returns true if this expression is a gl-value that + /// potentially refers to a packed-field. Here packed-field means s/gl-value/glvalue =

Re: [PATCH] D23905: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

bruno closed this revision. bruno added a comment. Thanks Richard. r280159 https://reviews.llvm.org/D23905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280165 - clang-format: Correctly calculate affected ranges when sorting #includes.

Author: djasper Date: Tue Aug 30 16:33:41 2016 New Revision: 280165 URL: http://llvm.org/viewvc/llvm-project?rev=280165&view=rev Log: clang-format: Correctly calculate affected ranges when sorting #includes. affectedRanges takes a start and an end offset, not offset and length. Modified: cfe

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 5 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23657: Remove some false positives when taking the address of packed members

aaron.ballman added a comment. Some minor nits; @rsmith may have more substantial comments. Comment at: lib/Sema/SemaChecking.cpp:11039 @@ -11036,2 +11038,3 @@ std::function Action) { + // return; const auto *ME = dyn_cast(E); Spurious comment. ===

Re: r280133 - PR30195: Fix clang-cl attempting to precompile bogus (non-precompilable) input types.

On 30 August 2016 at 19:55, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Tue Aug 30 13:55:16 2016 > New Revision: 280133 > > URL: http://llvm.org/viewvc/llvm-project?rev=280133&view=rev > Log: > PR30195: Fix clang-cl attempting to precompile bogus (non-precompilable) > input type

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF marked 3 inline comments as done. Comment at: include/clang/Basic/AttrDocs.td:836 @@ +835,3 @@ + let Content = [{ +This attribute specifies that the variable to which it is attached is intended +to have a `constant initializer

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF updated this revision to Diff 69761. EricWF added a comment. Address all comments except making the attribute C++ only. https://reviews.llvm.org/D23385 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema

[PATCH] D24054: Do not validate pch when -fno-validate-pch is set

yaxunl created this revision. yaxunl added reviewers: rsmith, Anastasia. yaxunl added a subscriber: cfe-commits. There is a bug causing pch to be validated even though -fno-validate-pch is set. This patch fixes it. https://reviews.llvm.org/D24054 Files: lib/Serialization/ASTReader.cpp Index:

Re: [PATCH] D23944: Parsing MS pragma intrinsic

rnk added a comment. One buglet, otherwise looks good. Comment at: lib/Parse/ParsePragma.cpp:2169 @@ +2168,3 @@ +IdentifierInfo *II = Tok.getIdentifierInfo(); +if (II->getBuiltinID() < 2) + PP.Diag(Tok.getLocation(), diag::warn_pragma_intrinsic_builtin)

Re: [PATCH] D23279: clang-reorder-fields

djasper added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:178 @@ +177,3 @@ +const InitListExpr *InitListEx, ArrayRef NewFieldsOrder, +const ASTContext &Context, +std::map &Replacements) { alexshap wrote: > yeah, i am aware

Re: [PATCH] D23079: ObjC: Use a new type for ObjC type parameter (patch 2 out of 3)

manmanren updated this revision to Diff 69764. manmanren added a comment. Address Doug's comment. ObjCTypeParamType is a non-canonical type now, it is canonicalized to the underlying type with protocol qualifiers. https://reviews.llvm.org/D23079 Files: include/clang/AST/ASTContext.h includ

Re: [PATCH] D23080: ObjC: Use a new type for ObjC type parameter (patch 3 out of 3)

manmanren updated the summary for this revision. manmanren updated this revision to Diff 69765. manmanren added a comment. This patch is now much simpler with the updated version of https://reviews.llvm.org/D23079. https://reviews.llvm.org/D23080 Files: lib/AST/ASTContext.cpp lib/AST/DeclO

Re: [PATCH] D23944: Parsing MS pragma intrinsic

agutowski updated this revision to Diff 69767. agutowski added a comment. Fixed checking if the function is an intrinsic. Updated getBuiltinID description. https://reviews.llvm.org/D23944 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/IdentifierTable.h include/cla

[PATCH] D24059: NFC: refactor applyObjCProtocolQualifiers from SemaType.cpp to ASTContext so it can be shared.

manmanren created this revision. manmanren added a reviewer: doug.gregor. manmanren added a subscriber: cfe-commits. To construct the canonical type of ObjCTypeParamType, we need to apply qualifiers on ObjCObjectPointerType. The updated applyObjCProtocolQualifiers handles this case by merging th

r280169 - Driver: use the canonical static library naming

Author: compnerd Date: Tue Aug 30 17:10:27 2016 New Revision: 280169 URL: http://llvm.org/viewvc/llvm-project?rev=280169&view=rev Log: Driver: use the canonical static library naming On Windows, static libraries are named lib.lib while import libraries are named .lib. Use the appropriate naming

Re: [PATCH] D23944: Parsing MS pragma intrinsic

agutowski updated this revision to Diff 69768. agutowski added a comment. Fixed typo https://reviews.llvm.org/D23944 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/IdentifierTable.h include/clang/Parse/Parser.h lib/Parse/ParsePragma.cpp test/Preprocessor/pragma

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69769. alexshap marked an inline comment as not done. alexshap added a comment. Check the return value of reorderFieldsInInitListExpr. Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-fields/CMakeLists.txt cl

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:179 @@ +178,3 @@ +const ASTContext &Context, +std::map &Replacements) { + assert(InitListEx && "Init list expression is null"); >Also, I don't understand what the pro

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 4 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23944: Parsing MS pragma intrinsic

agutowski marked an inline comment as done. agutowski added a comment. https://reviews.llvm.org/D23944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Now that you can, you should add test cases for the different cases where you cannot reorder fields. Otherwise looks good. Repository: rL LLVM https://reviews.llvm.org/D23279 ___

Re: [PATCH] D23279: clang-reorder-fields

djasper added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:179 @@ +178,3 @@ +const ASTContext &Context, +std::map &Replacements) { + assert(InitListEx && "Init list expression is null"); alexshap wrote: > >Also, I don't unders

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. Okay, many thanks for the code review. May i commit this ? I will add more tests as a follow-up Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 2 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r280133 - PR30195: Fix clang-cl attempting to precompile bogus (non-precompilable) input types.

On 30 August 2016 at 22:44, Renato Golin wrote: > This breakage was hidden by Duncan's build breakage: > > http://lab.llvm.org:8011/builders/clang-cmake-aarch64-42vma/builds/11172 Also, http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/9813 Same error... cheers, --renato __

Re: r280104 - Disable clang/test/SemaTemplate/instantiation-depth-default.cpp temporarily for targeting mingw32. It crashes. Investigating.

Thanks, Richard. Conversely, do we need to give sufficient amount of stack to the clang executable whenever this fails? By default, clang.exe has 2MiB (and *-tblgen.exe(s) are gaven 16MiB) of stack on mingw-w64. 10,000,000 bytes on MS-compiled executables. I can easily increase the size. See Hand

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF updated this revision to Diff 69775. EricWF added a comment. Make the attribute C++ only. https://reviews.llvm.org/D23385 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/AttributeList.h lib/Sema/Se

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF marked an inline comment as done. Comment at: utils/TableGen/ClangAttrEmitter.cpp:2794 @@ -2794,1 +2793,3 @@ +if ((*I)->getValueAsBit("Negated")) { + FnName += "Not"; Test += "!"; This is needed so that the `COnly` and `CPlusPlus` entries in

r280174 - [analyzer] Use lazily created buffer in EmptyLocalizationContextChecker

Author: dcoughlin Date: Tue Aug 30 18:07:14 2016 New Revision: 280174 URL: http://llvm.org/viewvc/llvm-project?rev=280174&view=rev Log: [analyzer] Use lazily created buffer in EmptyLocalizationContextChecker Fix a crash when relexing the underlying memory buffer to find incorrect arguments to NSL

Re: [PATCH] D23734: Add -fprofile-dir= to clang.

nlewycky updated this revision to Diff 69778. nlewycky marked 5 inline comments as done. https://reviews.llvm.org/D23734 Files: lib/Transforms/Instrumentation/GCOVProfiling.cpp test/Transforms/GCOVProfiling/three-element-mdnode.ll tools/clang/include/clang/Driver/CC1Options.td tools/clang

Re: [PATCH] D23734: Add -fprofile-dir= to clang.

nlewycky added inline comments. Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:447 @@ -432,3 +446,3 @@ return Filename.str(); } } compnerd wrote: > It really feels like these two cases can be collapsed. I don't see a great way to

Re: [PATCH] D23944: Parsing MS pragma intrinsic

rnk accepted this revision. rnk added a comment. lgtm https://reviews.llvm.org/D23944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280178 - Don't try to run a test that generates code for x86 if it's not a registered target.

Author: rsmith Date: Tue Aug 30 18:53:34 2016 New Revision: 280178 URL: http://llvm.org/viewvc/llvm-project?rev=280178&view=rev Log: Don't try to run a test that generates code for x86 if it's not a registered target. Modified: cfe/trunk/test/Driver/cl-pch.c Modified: cfe/trunk/test/Driver/

Re: r280133 - PR30195: Fix clang-cl attempting to precompile bogus (non-precompilable) input types.

Hopefully r280178 should fix this. On Tue, Aug 30, 2016 at 4:00 PM, Renato Golin wrote: > On 30 August 2016 at 22:44, Renato Golin wrote: > > This breakage was hidden by Duncan's build breakage: > > > > http://lab.llvm.org:8011/builders/clang-cmake-aarch64-42vma/builds/11172 > > Also, http://la

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

rsmith added inline comments. Comment at: include/clang/Basic/AttrDocs.td:836 @@ +835,3 @@ + let Content = [{ +This attribute specifies that the variable to which it is attached is intended +to have a `constant initializer

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24065: [libc++] Don't attempt to dllexport enum class

smeenai created this revision. smeenai added reviewers: abdulras, EricWF, mclow.lists. smeenai added subscribers: cfe-commits, kastiglione. An enum class can't be dllexport'ed, and attempting to do so produces warnings. https://reviews.llvm.org/D24065 Files: include/__config Index: include/__

[clang-tools-extra] r280180 - [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Author: prazek Date: Tue Aug 30 19:06:55 2016 New Revision: 280180 URL: http://llvm.org/viewvc/llvm-project?rev=280180&view=rev Log: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix Summary: Bugfix for 27321. When the constructor of stored pointer type is private then it is invalid to

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

This revision was automatically updated to reflect the committed changes. Closed by commit rL280180: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix (authored by Prazek). Changed prior to commit: https://reviews.llvm.org/D23343?vs=68824&id=69787#toc Repository: rL LLVM https://r

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Prazek added a comment. Sorry for long delay. I had some issues with git-svn on mac. Repository: rL LLVM https://reviews.llvm.org/D23343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF added inline comments. Comment at: include/clang/Basic/AttrDocs.td:836 @@ +835,3 @@ + let Content = [{ +This attribute specifies that the variable to which it is attached is intended +to have a `constant initializer

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF added a comment. Are there any remaining issues with this patch? https://reviews.llvm.org/D23385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23325: [WIP] Binding of references to packed fields

rsmith added inline comments. Comment at: include/clang/AST/Expr.h:441 @@ +440,3 @@ + /// Likewise bitfields, we model gl-values referring to packed-fields as + /// an aspect of the value-kind type system. + bool refersToPackedField() const { return getObjectKind() == OK_Packed

Re: [PATCH] D23657: Remove some false positives when taking the address of packed members

rsmith added inline comments. Comment at: lib/Sema/SemaChecking.cpp:11054 @@ +11053,3 @@ + auto AlignRecord = Context.getTypeAlignInChars(BaseType); + if ((RequiredAlignment > AlignRecord) || + ((Context.toCharUnitsFromBits( Suppose I have this:

r280187 - clangTooling: Update libdeps: LLVMOptions, since r280118.

Author: chapuni Date: Tue Aug 30 19:46:32 2016 New Revision: 280187 URL: http://llvm.org/viewvc/llvm-project?rev=280187&view=rev Log: clangTooling: Update libdeps: LLVMOptions, since r280118. Modified: cfe/trunk/lib/Tooling/CMakeLists.txt Modified: cfe/trunk/lib/Tooling/CMakeLists.txt URL:

r280186 - clangTooling depends on ClangDriverOptions since r280118.

Author: chapuni Date: Tue Aug 30 19:46:25 2016 New Revision: 280186 URL: http://llvm.org/viewvc/llvm-project?rev=280186&view=rev Log: clangTooling depends on ClangDriverOptions since r280118. Modified: cfe/trunk/lib/Tooling/CMakeLists.txt Modified: cfe/trunk/lib/Tooling/CMakeLists.txt URL:

r280189 - Concatenate two FileCheck lines in a test.

Author: rtrieu Date: Tue Aug 30 20:57:12 2016 New Revision: 280189 URL: http://llvm.org/viewvc/llvm-project?rev=280189&view=rev Log: Concatenate two FileCheck lines in a test. 'cc1' is a valid sequence of hexadecimal and sometimes can occur in the path when testing. This can lead to FileCheck ma

r280190 - PR12298 et al: don't recursively instantiate a template specialization from

Author: rsmith Date: Tue Aug 30 21:15:21 2016 New Revision: 280190 URL: http://llvm.org/viewvc/llvm-project?rev=280190&view=rev Log: PR12298 et al: don't recursively instantiate a template specialization from within the instantiation of that same specialization. This could previously happen for ea

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

reames added a comment. This seems to have landed a couple of days ago without problem, but if anyone sees any weird effects in shared builds for Linux, this change is probably the culprit. The last time I tried to do something like this, I had to back out my change due to linker errors I neve

Re: [PATCH] D23734: Add -fprofile-dir= to clang.

compnerd added inline comments. Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:447 @@ -432,3 +446,3 @@ return Filename.str(); } } A quick pass over this yielded something like: if (N->getNumOperands() != 2 && N->getNumOperan

Re: [PATCH] D24065: [libc++] Don't attempt to dllexport enum class

compnerd added inline comments. Comment at: include/__config:719 @@ -718,3 +718,3 @@ #else // _LIBCPP_HAS_NO_STRONG_ENUMS -#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS x +#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS_ONLY x #define _LI

Re: [PATCH] D24065: [libc++] Don't attempt to dllexport enum class

smeenai added inline comments. Comment at: include/__config:719 @@ -718,3 +718,3 @@ #else // _LIBCPP_HAS_NO_STRONG_ENUMS -#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS x +#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS_ONLY x #define _LIB

Re: [PATCH] D24065: [libc++] Don't attempt to dllexport enum class

compnerd added inline comments. Comment at: include/__config:719 @@ -718,3 +718,3 @@ #else // _LIBCPP_HAS_NO_STRONG_ENUMS -#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS x +#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS_ONLY x #define _LI

Re: [PATCH] D24065: [libc++] Don't attempt to dllexport enum class

smeenai updated this revision to Diff 69797. smeenai updated the summary for this revision. smeenai added a comment. Removing export entirely, per compnerd's suggestion https://reviews.llvm.org/D24065 Files: include/__config Index: include/__config ===

Re: [PATCH] D24065: [libc++] Don't attempt to dllexport enum class

smeenai marked 3 inline comments as done. smeenai added a comment. https://reviews.llvm.org/D24065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

djasper added a comment. As per my comment, please add tests for cases where you currently don't do re-ordering (different access specifiers, partial initializers). Other than that, yes, this is fine to commit. Repository: rL LLVM https://reviews.llvm.org/D23279 _

r280196 - [X86] Use v2i64 vectors to implement _mm_and/andn/or/xor_pd.

Author: ctopper Date: Wed Aug 31 00:38:55 2016 New Revision: 280196 URL: http://llvm.org/viewvc/llvm-project?rev=280196&view=rev Log: [X86] Use v2i64 vectors to implement _mm_and/andn/or/xor_pd. These will be reused when removing some builtins from avx512vldqintrin.h and this will make the tests

r280197 - [AVX-512] Implement masked floating point logical operations with native IR and remove the builtins.

Author: ctopper Date: Wed Aug 31 00:38:58 2016 New Revision: 280197 URL: http://llvm.org/viewvc/llvm-project?rev=280197&view=rev Log: [AVX-512] Implement masked floating point logical operations with native IR and remove the builtins. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

Re: r280104 - Disable clang/test/SemaTemplate/instantiation-depth-default.cpp temporarily for targeting mingw32. It crashes. Investigating.

On 30 Aug 2016 4:05 pm, "NAKAMURA Takumi" wrote: Thanks, Richard. Conversely, do we need to give sufficient amount of stack to the clang executable whenever this fails? By default, clang.exe has 2MiB (and *-tblgen.exe(s) are gaven 16MiB) of stack on mingw-w64. 10,000,000 bytes on MS-compiled ex

<    1   2