Re: [PATCH] D24002: clang-rename: improve error message when -old-name is used and could not find symbol

vmiklos updated this revision to Diff 69644. https://reviews.llvm.org/D24002 Files: clang-rename/USRFindingAction.cpp test/clang-rename/InvalidOldName.cpp Index: test/clang-rename/InvalidOldName.cpp === --- /dev/null +++ test/cl

Re: [PATCH] D24002: clang-rename: improve error message when -old-name is used and could not find symbol

vmiklos marked an inline comment as done. vmiklos added a comment. > Probably something like "could not find symbol OldName" would be reasonable, > too. OK, changed. https://reviews.llvm.org/D24002 ___ cfe-commits mailing list cfe-commits@lists.l

Re: [PATCH] D24002: clang-rename: improve error message when -old-name is used and could not find symbol

omtcyfz accepted this revision. omtcyfz added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D24002#528556, @vmiklos wrote: > > Probably something like "could not find symbol OldName" would be > > reasonable, too. > > > OK, changed. Great! Good catch, t

Re: [PATCH] D24002: clang-rename: improve error message when -old-name is used and could not find symbol

This revision was automatically updated to reflect the committed changes. Closed by commit rL280062: clang-rename: improve error message when -old-name is used and could not find… (authored by vmiklos). Changed prior to commit: https://reviews.llvm.org/D24002?vs=69644&id=69646#toc Repository:

[clang-tools-extra] r280062 - clang-rename: improve error message when -old-name is used and could not find symbol

Author: vmiklos Date: Tue Aug 30 02:23:24 2016 New Revision: 280062 URL: http://llvm.org/viewvc/llvm-project?rev=280062&view=rev Log: clang-rename: improve error message when -old-name is used and could not find symbol Old output was: clang-rename: could not find symbol at tools/clang/tools/ex

[clang-tools-extra] r280063 - clang-rename: fix formatting in USRFinder

Author: vmiklos Date: Tue Aug 30 02:24:57 2016 New Revision: 280063 URL: http://llvm.org/viewvc/llvm-project?rev=280063&view=rev Log: clang-rename: fix formatting in USRFinder As detected by clang-format. Modified: clang-tools-extra/trunk/clang-rename/USRFinder.cpp Modified: clang-tools-ext

Re: [PATCH] D23279: clang-reorder-fields

djasper added a comment. Probably the last round .. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:202 @@ +201,3 @@ +for (const auto *C : RD->ctors()) { + if (C->isImplicit() || C->isDelegatingConstructor()) +continue; alexshap wrote:

r280064 - This adds new options -fdenormal-fp-math and passes through option -ffast-math

Author: sjoerdmeijer Date: Tue Aug 30 03:09:45 2016 New Revision: 280064 URL: http://llvm.org/viewvc/llvm-project?rev=280064&view=rev Log: This adds new options -fdenormal-fp-math and passes through option -ffast-math to CC1, which are translated to function attributes and can e.g. be mapped on bu

Re: [PATCH] D23840: New options -fexceptions-fp-math and -fdenormal-fp-math

This revision was automatically updated to reflect the committed changes. Closed by commit rL280064: This adds new options -fdenormal-fp-math and passes through option -ffast-math (authored by SjoerdMeijer). Changed prior to commit: https://reviews.llvm.org/D23840?vs=69379&id=69647#toc Reposit

Re: [PATCH] D23915: [OpenCL] Remove access qualifiers on images in arg info metadata.

etyurin updated this revision to Diff 69649. etyurin added a comment. Applied comments from Sam. https://reviews.llvm.org/D23915 Files: lib/CodeGen/CodeGenFunction.cpp test/CodeGenOpenCL/kernel-arg-info.cl Index: test/CodeGenOpenCL/kernel-arg-info.cl ===

Re: [PATCH] D23914: [OpenCL] Make is_valid_event, create_user_event overloadable.

etyurin retitled this revision from "[OpenCL] Make is_valid_event overloadable." to "[OpenCL] Make is_valid_event, create_user_event overloadable.". etyurin updated the summary for this revision. etyurin updated this revision to Diff 69650. etyurin added a comment. Applied comment from Sam. ht

r280065 - Fix for commit 280064 that break the build.

Author: sjoerdmeijer Date: Tue Aug 30 03:56:00 2016 New Revision: 280065 URL: http://llvm.org/viewvc/llvm-project?rev=280065&view=rev Log: Fix for commit 280064 that break the build. Modified: cfe/trunk/test/Driver/fast-math.c Modified: cfe/trunk/test/Driver/fast-math.c URL: http://llvm.org

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

halyavin added a comment. Thank you for fixing most of warnings. Now it says "cc1plus: warning: unrecognized command line option "-Wno-c++14-compat"" though. https://reviews.llvm.org/D23831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [PATCH] D23837: Fix colored diagnostics from tools

ogoffart added a comment. Ping https://reviews.llvm.org/D23837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21502: Fix heuristics skipping invalid ctor-initializers with C++11

ogoffart added a comment. ping https://reviews.llvm.org/D21502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

EricWF added a comment. In https://reviews.llvm.org/D23831#528637, @halyavin wrote: > Thank you for fixing most of warnings. Now it says "cc1plus: warning: > unrecognized command line option "-Wno-c++14-compat"" though. No worries, it was driving me nuts. The addition of `-Wno-c++14-compat` an

Re: [PATCH] D21502: Fix heuristics skipping invalid ctor-initializers with C++11

ogoffart added a comment. Ping https://reviews.llvm.org/D21502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

EricWF added a comment. The reason I'm dragging my feet on this patch is I'm not sure the two formulations are *exactly* equivalent. I need to re-read the standard to be sure. What's the motivation for fixing a warning which libc++ never tests against? Normally the headers are treated as syste

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

halyavin added a comment. We have libc++ in our source tree and compile it as part of our build process. All code in the source tree uses -Werror by default, so I am having compile errors on gcc 4.9. https://reviews.llvm.org/D23831 ___ cfe-commits

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

EricWF added a comment. In https://reviews.llvm.org/D23831#528666, @halyavin wrote: > We have libc++ in our source tree and compile it as part of our build > process. All code in the source tree uses -Werror by default, so I am having > compile errors on gcc 4.9. Are you also compiling with `

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

mboehme updated this revision to Diff 69662. mboehme added a comment. Fix typo https://reviews.llvm.org/D0 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/MoveForwardingReferenceCheck.cpp clang-tidy/misc/MoveForwardingReferenceCheck.h docs/

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

mboehme marked an inline comment as done. mboehme added a comment. https://reviews.llvm.org/D0 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

halyavin added a comment. > ! In https://reviews.llvm.org/D23831#528668, @EricWF wrote: > > Are you also compiling with `-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER`? No. Libc++ buildbots doesn't set this option either and we do see warnings there. So the pragma doesn't help with compiling libc++

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

mboehme updated this revision to Diff 69665. mboehme added a comment. Update to current head https://reviews.llvm.org/D0 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/MoveForwardingReferenceCheck.cpp clang-tidy/misc/MoveForwardingReferenceC

[clang-tools-extra] r280077 - [clang-tidy] Add check 'misc-move-forwarding-reference'

Author: mboehme Date: Tue Aug 30 07:11:12 2016 New Revision: 280077 URL: http://llvm.org/viewvc/llvm-project?rev=280077&view=rev Log: [clang-tidy] Add check 'misc-move-forwarding-reference' Summary: The check emits a warning if std::move() is applied to a forwarding reference, i.e. an rvalue ref

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

This revision was automatically updated to reflect the committed changes. Closed by commit rL280077: [clang-tidy] Add check 'misc-move-forwarding-reference' (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D0?vs=69665&id=69666#toc Repository: rL LLVM https://revi

[PATCH] D24024: Checkout cfe when building clang-tools-extra docs.

alexfh created this revision. alexfh added a reviewer: gribozavr. alexfh added a subscriber: cfe-commits. Checkout cfe when building clang-tools-extra docs. Otherwise cmake doesn't find clang-tools-extra cmake files. https://reviews.llvm.org/D24024 Files: zorg/buildbot/builders/SphinxDocsBuild

Re: [PATCH] D23787: Add builder for clang extra tools Sphinx docs

alexfh added a comment. In https://reviews.llvm.org/D23787#527369, @gribozavr wrote: > Here's the new builder: > http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs > > Fails with `ninja: error: unknown target 'docs-clang-tools-html'`. I hope, https://reviews.llvm.org/D24024 should fix t

[clang-tools-extra] r280078 - clang-tools-extra/test/clang-tidy/misc-move-forwarding-reference.cpp: Appease ms targets with -fno-delayed-template-parsing.

Author: chapuni Date: Tue Aug 30 07:34:03 2016 New Revision: 280078 URL: http://llvm.org/viewvc/llvm-project?rev=280078&view=rev Log: clang-tools-extra/test/clang-tidy/misc-move-forwarding-reference.cpp: Appease ms targets with -fno-delayed-template-parsing. Modified: clang-tools-extra/trunk

r280085 - clang/test/Driver/modules-ts.cpp: Satisfy quoted filename.

Author: chapuni Date: Tue Aug 30 08:07:53 2016 New Revision: 280085 URL: http://llvm.org/viewvc/llvm-project?rev=280085&view=rev Log: clang/test/Driver/modules-ts.cpp: Satisfy quoted filename. On win32, backslashed filename is emitted like; -o "C:\\bb-win\\ninja-clang-i686-msc19-R\\build\\too

[libunwind] r280086 - libunwind: correct 'libuwind' typo

Author: emaste Date: Tue Aug 30 08:08:21 2016 New Revision: 280086 URL: http://llvm.org/viewvc/llvm-project?rev=280086&view=rev Log: libunwind: correct 'libuwind' typo There were several instances of libuwind (missing an "n"), dating to the initial import of libunwind. Modified: libunwind/tr

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper updated this revision to Diff 69671. bmharper added a comment. I have added an initial phase which propagates IndentLevel from the first token on a line, to all of the tokens on that line. This allows us to get rid of the ScopeLevel state. However, I have retained the name "ScopeLevel",

r280089 - Handle -mlong-calls on Hexagon

Author: kparzysz Date: Tue Aug 30 08:57:50 2016 New Revision: 280089 URL: http://llvm.org/viewvc/llvm-project?rev=280089&view=rev Log: Handle -mlong-calls on Hexagon Differential Revision:://reviews.llvm.org/D22766 Added: cfe/trunk/test/Driver/hexagon-long-calls.c Modified: cfe/trunk/in

Re: [PATCH] D22334: Fix for Bug 28172 : clang crashes on invalid code (with too few arguments to __builtin_signbit) without any proper diagnostics.

mayurpandey updated this revision to Diff 69674. mayurpandey added a comment. Hi, Updated the patch to add a template based testcase. As suggested by you, I tried updating the error diagnostic to err_typecheck_cond_expect_float and to issue diagnostic in similar fashion to err_typecheck_cond_ex

r280091 - Revert r280035 (and followups r280057, r280085), it caused PR30195

Author: nico Date: Tue Aug 30 09:12:06 2016 New Revision: 280091 URL: http://llvm.org/viewvc/llvm-project?rev=280091&view=rev Log: Revert r280035 (and followups r280057, r280085), it caused PR30195 Removed: cfe/trunk/test/Driver/modules-ts.cpp Modified: cfe/trunk/include/clang/Driver/CC1O

r280093 - [Hexagon] Use handleTargetFeaturesGroup to process target-specific features

Author: kparzysz Date: Tue Aug 30 09:17:10 2016 New Revision: 280093 URL: http://llvm.org/viewvc/llvm-project?rev=280093&view=rev Log: [Hexagon] Use handleTargetFeaturesGroup to process target-specific features Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/lib/Driver/Tools.cpp Modi

Re: [PATCH] D23914: [OpenCL] Make is_valid_event, create_user_event overloadable.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. https://reviews.llvm.org/D23914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23915: [OpenCL] Remove access qualifiers on images in arg info metadata.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. https://reviews.llvm.org/D23915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r280095 - [clang-tidy docs] Fix build errors on Sphinx 1.4.6

Author: hokein Date: Tue Aug 30 09:29:36 2016 New Revision: 280095 URL: http://llvm.org/viewvc/llvm-project?rev=280095&view=rev Log: [clang-tidy docs] Fix build errors on Sphinx 1.4.6 Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-suspicious-string-compare.rst clang-tools

r280094 - Fix typo in comment

Author: nico Date: Tue Aug 30 09:24:28 2016 New Revision: 280094 URL: http://llvm.org/viewvc/llvm-project?rev=280094&view=rev Log: Fix typo in comment Modified: cfe/trunk/test/Driver/cl-pch.cpp Modified: cfe/trunk/test/Driver/cl-pch.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tes

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein updated this revision to Diff 69679. hokein marked an inline comment as done. hokein added a comment. - Use empty string words. - rebase to master. https://reviews.llvm.org/D23918 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/chec

Re: [PATCH] D23746: Basic/Targets.cpp: Add polaris10 and polaris11 gpus

tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D23746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D23914: [OpenCL] Make is_valid_event, create_user_event overloadable.

This revision was automatically updated to reflect the committed changes. Closed by commit rL280097: [OpenCL] Make is_valid_event, create_user_event overloadable. (authored by bader). Changed prior to commit: https://reviews.llvm.org/D23914?vs=69650&id=69682#toc Repository: rL LLVM https://

r280097 - [OpenCL] Make is_valid_event, create_user_event overloadable.

Author: bader Date: Tue Aug 30 09:42:54 2016 New Revision: 280097 URL: http://llvm.org/viewvc/llvm-project?rev=280097&view=rev Log: [OpenCL] Make is_valid_event, create_user_event overloadable. Summary: Make is_valid_event and create_user_event overloadable like other built-ins. Patch by Evgeni

[libunwind] r280099 - libunwind: fix X86 register numbers for FreeBSD/i386

Author: emaste Date: Tue Aug 30 10:10:08 2016 New Revision: 280099 URL: http://llvm.org/viewvc/llvm-project?rev=280099&view=rev Log: libunwind: fix X86 register numbers for FreeBSD/i386 For historical reasons i386 has ebp and esp swapped in the eh_frame register numbering on at least Darwin. Tha

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

On Mon, Aug 29, 2016 at 7:52 PM, Reid Kleckner wrote: > rnk added a comment. > > In https://reviews.llvm.org/D23895#528208, @aaron.ballman wrote: > >> You are removing a lot of instances of `MaybeParseMicrosoftAttributes()`, >> but I'm not certain I understand why. Can you describe why you need t

r280104 - Disable clang/test/SemaTemplate/instantiation-depth-default.cpp temporarily for targeting mingw32. It crashes. Investigating.

Author: chapuni Date: Tue Aug 30 10:38:18 2016 New Revision: 280104 URL: http://llvm.org/viewvc/llvm-project?rev=280104&view=rev Log: Disable clang/test/SemaTemplate/instantiation-depth-default.cpp temporarily for targeting mingw32. It crashes. Investigating. Modified: cfe/trunk/test/SemaTem

[libunwind] r280103 - consistently add \n to log and trace messages

Author: emaste Date: Tue Aug 30 10:38:10 2016 New Revision: 280103 URL: http://llvm.org/viewvc/llvm-project?rev=280103&view=rev Log: consistently add \n to log and trace messages Previously most messages included a newline in the string, but a few of them were missing. Fix these and simplify by j

RE: r280057 - Combine two FileCheck patterns to prevent overzealous matching of .*

> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Richard Smith via cfe-commits > Sent: Monday, August 29, 2016 10:15 PM > To: cfe-commits@lists.llvm.org > Subject: r280057 - Combine two FileCheck patterns to prevent overzealous > matching

Re: [PATCH] D23987: [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

ikudrin added inline comments. Comment at: lib/CodeGen/CoverageMappingGen.cpp:261 @@ -253,2 +260,3 @@ + void emitSourceRegions(const SourceRegionFilter &Filter) { for (const auto &Region : SourceRegions) { assert(Region.hasEndLoc() && "incomplete region"); ---

Re: [PATCH] D23926: [libcxx] Don't use C99 math ops in -std=c++03 mode

rmaprath updated this revision to Diff 69710. rmaprath added a comment. Re-spinning a new patch to test the waters. @EricWF: Does this approach look OK? / Asiri https://reviews.llvm.org/D23926 Files: include/__config include/math.h test/std/depr/depr.c.headers/math_h.pass.cpp test/std

RE: r280057 - Combine two FileCheck patterns to prevent overzealous matching of .*

On 30 Aug 2016 9:45 am, "Robinson, Paul" wrote: > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Richard Smith via cfe-commits > Sent: Monday, August 29, 2016 10:15 PM > To: cfe-commits@lists.llvm.org > Subject: r280057 - Combine two Fi

[libcxx] r280108 - [CMake] Copy headers relative to LLVM_BINARY_DIR

Author: cbieneman Date: Tue Aug 30 11:51:34 2016 New Revision: 280108 URL: http://llvm.org/viewvc/llvm-project?rev=280108&view=rev Log: [CMake] Copy headers relative to LLVM_BINARY_DIR Summary: This copy phase is only needed for in-tree builds, so we should be copying to the LLVM build directory

Re: [PATCH] D23987: [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

ikudrin updated this revision to Diff 69709. ikudrin added a comment. - Removed a default value in `emitSourceRegions()`, added the corresponding argument to its call in `EmptyCoverageMappingBuilder::write()`. - Removed an additional sorting step in `CounterCoverageMappingBuilder::write()`, the

Re: [PATCH] D23837: Fix colored diagnostics from tools

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks, LGTM https://reviews.llvm.org/D23837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

RE: r280057 - Combine two FileCheck patterns to prevent overzealous matching of .*

The case that failed on the build not was something like -o blah.o -x c++ -o system /.../llvm.org/... ... where the first line of the old pattern matched up to the .o in llvm.org, causing the second line to fail to match. That suggests the .* behavior is 'gree

Re: [PATCH] D24015: [CMake] Copy headers relative to LLVM_BINARY_DIR

This revision was automatically updated to reflect the committed changes. Closed by commit rL280108: [CMake] Copy headers relative to LLVM_BINARY_DIR (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D24015?vs=69637&id=69716#toc Repository: rL LLVM https://reviews.l

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added a comment. Thanks! Shall I close this? https://reviews.llvm.org/D23492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23987: [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm! https://reviews.llvm.org/D23987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

vsk created this revision. vsk added a reviewer: bruno. vsk added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. Running 'check-clang' on a stock checkout of llvm+clang doesn't work on Darwin, because test/Driver/darwin-ld-lto.c can't find libLTO.dylib. Add libLTO as a clang

Re: [PATCH] D23492: Make function local tags visible.

Yes please On 30 Aug 2016 10:33 am, "Vassil Vassilev" wrote: > v.g.vassilev added a comment. > > Thanks! Shall I close this? > > > https://reviews.llvm.org/D23492 > > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r279164 and r279486. https://reviews.llvm.org/D23492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280118 - Fix colored diagnostics from tools

Author: ogoffart Date: Tue Aug 30 12:42:29 2016 New Revision: 280118 URL: http://llvm.org/viewvc/llvm-project?rev=280118&view=rev Log: Fix colored diagnostics from tools r271042 changed the way the diagnostic arguments are parsed. It assumes that the diagnostics options were already parsed by the

Re: [PATCH] D23837: Fix colored diagnostics from tools

This revision was automatically updated to reflect the committed changes. Closed by commit rL280118: Fix colored diagnostics from tools (authored by ogoffart). Changed prior to commit: https://reviews.llvm.org/D23837?vs=69225&id=69725#toc Repository: rL LLVM https://reviews.llvm.org/D23837

[clang-tools-extra] r280119 - [Release notes] Fix highlighting.

Author: eugenezelenko Date: Tue Aug 30 12:47:07 2016 New Revision: 280119 URL: http://llvm.org/viewvc/llvm-project?rev=280119&view=rev Log: [Release notes] Fix highlighting. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL:

r280120 - Basic/Targets.cpp: Add polaris10 and polaris11 gpus

Author: olesalscheider Date: Tue Aug 30 13:00:22 2016 New Revision: 280120 URL: http://llvm.org/viewvc/llvm-project?rev=280120&view=rev Log: Basic/Targets.cpp: Add polaris10 and polaris11 gpus Differential Revision: https://reviews.llvm.org/D23746 Modified: cfe/trunk/lib/Basic/Targets.cpp M

[libclc] r280121 - configure.py: Add polaris10 and polaris11

Author: olesalscheider Date: Tue Aug 30 13:00:41 2016 New Revision: 280121 URL: http://llvm.org/viewvc/llvm-project?rev=280121&view=rev Log: configure.py: Add polaris10 and polaris11 Modified: libclc/trunk/configure.py Modified: libclc/trunk/configure.py URL: http://llvm.org/viewvc/llvm-pro

Re: [PATCH] D23905: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

bruno added a comment. Ping! https://reviews.llvm.org/D23905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

bruno added a comment. Ping! https://reviews.llvm.org/D23852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280127 - typo + indentation [NFC]

Author: etienneb Date: Tue Aug 30 13:38:25 2016 New Revision: 280127 URL: http://llvm.org/viewvc/llvm-project?rev=280127&view=rev Log: typo + indentation [NFC] Modified: cfe/trunk/lib/Driver/MSVCToolChain.cpp cfe/trunk/lib/Driver/ToolChains.h Modified: cfe/trunk/lib/Driver/MSVCToolChain.

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

Eugene.Zelenko added a subscriber: aaron.ballman. Eugene.Zelenko added a comment. I don't have further comments, but as non-English speaker and mediocre writer, I would like see other people comments. May be @aaron.ballman could help if Alexander is busy? https://reviews.llvm.org/D23918 ___

Re: [PATCH] D23944: Parsing MS pragma intrinsic

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but you should wait for @rnk to accept as well. https://reviews.llvm.org/D23944 ___ cfe-commits mailing list cfe-commits@list

r280133 - PR30195: Fix clang-cl attempting to precompile bogus (non-precompilable) input types.

Author: rsmith Date: Tue Aug 30 13:55:16 2016 New Revision: 280133 URL: http://llvm.org/viewvc/llvm-project?rev=280133&view=rev Log: PR30195: Fix clang-cl attempting to precompile bogus (non-precompilable) input types. Modified: cfe/trunk/include/clang/Driver/Types.h cfe/trunk/lib/Driver

[PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz created this revision. beanz added reviewers: zaks.anna, kubabrecka, bogner. beanz added a subscriber: cfe-commits. The -nodefaultlibs and -nostdlib flags suppress all the runtime libraries that the driver puts on the link line. This feels wrong. If a user specifies "-fsanitize=" I think i

Re: r280104 - Disable clang/test/SemaTemplate/instantiation-depth-default.cpp temporarily for targeting mingw32. It crashes. Investigating.

On Tue, Aug 30, 2016 at 8:38 AM, NAKAMURA Takumi via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chapuni > Date: Tue Aug 30 10:38:18 2016 > New Revision: 280104 > > URL: http://llvm.org/viewvc/llvm-project?rev=280104&view=rev > Log: > Disable clang/test/SemaTemplate/instantiation-de

r280134 - Unrevert r280035 now that the clang-cl bug it exposed has been fixed by

Author: rsmith Date: Tue Aug 30 14:06:26 2016 New Revision: 280134 URL: http://llvm.org/viewvc/llvm-project?rev=280134&view=rev Log: Unrevert r280035 now that the clang-cl bug it exposed has been fixed by r280133. Original commit message: C++ Modules TS: driver support for building modules. This

r280136 - PR29166: when merging declarations with typedef names for linkage purposes,

Author: rsmith Date: Tue Aug 30 14:13:18 2016 New Revision: 280136 URL: http://llvm.org/viewvc/llvm-project?rev=280136&view=rev Log: PR29166: when merging declarations with typedef names for linkage purposes, don't assume that the anonymous struct will be part of the most recent declaration of the

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

I don't think so. "No default libs" should mean "no default libs", not "some default libs". Maybe you're using an alternate sanitizer lib or something, hence usage of that flag. Thank you, Filipe On Tuesday, 30 August 2016, Chris Bieneman via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

Re: [PATCH] D23746: Basic/Targets.cpp: Add polaris10 and polaris11 gpus

This revision was automatically updated to reflect the committed changes. Closed by commit rL280120: Basic/Targets.cpp: Add polaris10 and polaris11 gpus (authored by olesalscheider). Changed prior to commit: https://reviews.llvm.org/D23746?vs=69485&id=69730#toc Repository: rL LLVM https://r

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Nice, LGTM https://reviews.llvm.org/D24042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

Filipe, You say that, but the darwin driver’s behavior is different from the FreeBSD or GNUTools behavior. This patch provides the GNUTools & FreeBSD behavior via the Darwin driver. -Chris > On Aug 30, 2016, at 12:26 PM, Filipe Cabecinhas > wrote: > > I don't think so. "No default libs" sho

r280142 - [test] Add libLTO as a clang test dependency on Darwin

Author: vedantk Date: Tue Aug 30 14:57:40 2016 New Revision: 280142 URL: http://llvm.org/viewvc/llvm-project?rev=280142&view=rev Log: [test] Add libLTO as a clang test dependency on Darwin Running 'check-clang' on a stock checkout of llvm+clang doesn't work on Darwin, because test/Driver/darwin-l

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL280142: [test] Add libLTO as a clang test dependency on Darwin (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D24042?vs=69723&id=69743#toc Repository: rL LLVM https://revie

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

thakis marked 3 inline comments as done. thakis added a comment. > There are things missing from this patch as well. To wit: > > - Attributes.h needs to know about this attribute syntax, and > `hasAttribute()` needs to support it (this hooks into `__has_attribute` > support). > - AttributeLi

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

Alternatively, since you only need the presence of a file named libLTO for the driver to do its magic, test can create an empty file named libLTO.dylib and use the -ccc-install-dir to make sure the right flag is passed. > On Aug 30, 2016, at 10:40 AM, Vedant Kumar wrote: > > vsk created this

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

bruno added a subscriber: bruno. bruno added a comment. Regardless of the way we decide to go with this, it would be nice if a driver level warning is used to tell users about any non-obvious assumed behavior when these flags are used together. https://reviews.llvm.org/D24048 _

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for working on this! Comment at: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant

Re: [PATCH] D23905: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D23905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

aaron.ballman added a comment. In https://reviews.llvm.org/D23895#529275, @thakis wrote: > > There are things missing from this patch as well. To wit: > > > > > > - Attributes.h needs to know about this attribute syntax, and > > `hasAttribute()` needs to support it (this hooks into `__has_attri

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a reviewer: djasper. alexshap updated this revision to Diff 69748. alexshap added a comment. Address @djasper 's comments Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-fields/CMakeLists.txt clang-reorder-fields/ReorderFieldsActio

r280150 - [test] Pass a fake libLTO.dylib to a driver test which depends on it

Author: vedantk Date: Tue Aug 30 15:36:50 2016 New Revision: 280150 URL: http://llvm.org/viewvc/llvm-project?rev=280150&view=rev Log: [test] Pass a fake libLTO.dylib to a driver test which depends on it This makes it possible to run 'check-clang' on Darwin without building libLTO.dylib. See r2801

r280149 - Revert "[test] Add libLTO as a clang test dependency on Darwin"

Author: vedantk Date: Tue Aug 30 15:36:48 2016 New Revision: 280149 URL: http://llvm.org/viewvc/llvm-project?rev=280149&view=rev Log: Revert "[test] Add libLTO as a clang test dependency on Darwin" This reverts commit r280142. Mehdi suggested a better way to fix up the test: just create a fake li

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

Done in r280149 (revert this commit) and r280150 (use fake libLTO.dylib). thanks, vedant > On Aug 30, 2016, at 1:12 PM, Mehdi Amini wrote: > > Alternatively, since you only need the presence of a file named libLTO for > the driver to do its magic, test can create an empty file named libLTO.dyl

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a comment. In https://reviews.llvm.org/D23852#525291, @doug.gregor wrote: > This will work, but it's *really* unfortunate to put tentative parsing into > this code path because tentative parsing is far from free, and specialize

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:836 @@ +835,3 @@ + let Content = [{ +This attribute specifies that the variable to which it is attached is intended +to have a `constant initializer

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

thakis marked 2 inline comments as done. thakis added a comment. (Just wanted to ask if I'm missing something about these three bullets. I do need to make a few other changes: More tests, parsing for uuid(1-2-3) without quotes + tests, and I also want to add a deprecation warning with a fixit,

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:83 @@ +82,3 @@ +static void +addReplacement(SourceRange Old, SourceRange New, const ASTContext &Context, + std::map &Replacements) { khm, it Replaces Old by New,

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

Haha, the joke is on me. I had the opposite opinion two years ago (I guess by virtue of working on the sanitizers for a while, I've come to see them as default libs?). Making the behavior more consistent is good, and the r218541 discussion (+220455) makes me think your patch is good. We end up hav

Re: [PATCH] D23767: DebugInfo: use llvm::DINode::DIFlags type for debug info flags

vleschuk retitled this revision from "DebugInfo: use llvm::DIFlagsUnderlying type for debug info flags" to "DebugInfo: use llvm::DINode::DIFlags type for debug info flags". vleschuk updated the summary for this revision. vleschuk updated this revision to Diff 69755. vleschuk added a comment. Swi

r280157 - Fix memory leak by storing returned pointer in std::unique_ptr

Author: rtrieu Date: Tue Aug 30 16:12:48 2016 New Revision: 280157 URL: http://llvm.org/viewvc/llvm-project?rev=280157&view=rev Log: Fix memory leak by storing returned pointer in std::unique_ptr Modified: cfe/trunk/lib/Tooling/Tooling.cpp Modified: cfe/trunk/lib/Tooling/Tooling.cpp URL: ht

  1   2   >