Anastasia closed this revision.
Anastasia added a comment.
Thanks! Committed in r278677.
https://reviews.llvm.org/D23452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
+cmake people for the feasibility of emitting 'arguments' instead of 'command'
into the JSON compilation database.
https://reviews.llvm.org/D23455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
hans added a comment.
> [This is my first time submitting 'pull requests' for a specific branch. I
> checked-out the respective release branches for llvm and clang, and reverted
> the above commit (resolved a conflict in the process) and created a patch. My
> box is currently still compiling an
zatrazz added a comment.
Ping.
https://reviews.llvm.org/D23449
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zatrazz added a comment.
Ping.
https://reviews.llvm.org/D23420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
In https://reviews.llvm.org/D23086#514279, @yaxunl wrote:
> How about we decide if a type is ndrange_t type based on their canonical
> types. If the canonical type of type X is the same as the canonical type of
> ndrange_t type, then type X is treated as ndrange_t typ
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
More trivial changes. LGTM. Thanks!
https://reviews.llvm.org/D23293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
alexshap marked 2 inline comments as done.
alexshap added a comment.
ping
https://reviews.llvm.org/D23387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
In https://reviews.llvm.org/D23086#515443, @Anastasia wrote:
> In https://reviews.llvm.org/D23086#514279, @yaxunl wrote:
>
> > How about we decide if a type is ndrange_t type based on their canonical
> > types. If the canonical type of type X is the same as the canonical
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278686: [Documentation] Improve checks groups descriptions
in clang-tidy/index.rst (authored by eugenezelenko).
Changed prior to commit:
https://reviews.llvm.org/D23471?vs=67926&id=68050#toc
Repository
Author: eugenezelenko
Date: Mon Aug 15 12:44:29 2016
New Revision: 278686
URL: http://llvm.org/viewvc/llvm-project?rev=278686&view=rev
Log:
[Documentation] Improve checks groups descriptions in clang-tidy/index.rst
Use table to avoid tautology. List all existing checks groups. Use alphabetical
o
brad.king added a comment.
> the feasibility of emitting 'arguments' instead of 'command' into the JSON
> compilation database.
CMake constructs the command lines internally using string replacement on
templates. We never actually know the exact arguments. Therefore providing
arguments inst
bcraig added a comment.
LGTM
Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:217
@@ +216,3 @@
+// then large field indices to small field indices
+return std::make_tuple(Align, -Size,
+ Field ?
-static_cast(Field->getFiel
Anastasia added a comment.
In https://reviews.llvm.org/D23086#515468, @yaxunl wrote:
> In https://reviews.llvm.org/D23086#515443, @Anastasia wrote:
>
> > In https://reviews.llvm.org/D23086#514279, @yaxunl wrote:
> >
> > > How about we decide if a type is ndrange_t type based on their canonical
>
alexshap added a comment.
i don't have commit access, if you could land this patch i would be grateful
https://reviews.llvm.org/D23387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:1546-1548
@@ -1545,5 +1549,5 @@
// definition of it, because parameters aren't "within" the definition.
if ((D->isTemplateParameter() || isa(D))
? isVisible(SemaRef, cast(DC))
: S
rnk added a comment.
In https://reviews.llvm.org/D23455#515486, @brad.king wrote:
> > the feasibility of emitting 'arguments' instead of 'command' into the JSON
> > compilation database.
>
>
> CMake constructs the command lines internally using string replacement on
> templates. We never actua
Author: probinson
Date: Mon Aug 15 13:45:52 2016
New Revision: 278710
URL: http://llvm.org/viewvc/llvm-project?rev=278710&view=rev
Log:
Replace an obsolete company name.
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/llvm-projec
EricWF accepted this revision.
EricWF added a comment.
Also LGTM.
https://reviews.llvm.org/D23507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Mon Aug 15 13:58:57 2016
New Revision: 278716
URL: http://llvm.org/viewvc/llvm-project?rev=278716&view=rev
Log:
Fix PR28506. Re-enable missing math.h C++11 decls on SunOS. Patch from Michal
Gorny.
Modified:
libcxx/trunk/include/cmath
libcxx/trunk/include/math.h
Modi
EricWF closed this revision.
EricWF added a comment.
r278716.
https://reviews.llvm.org/D23507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi Eugene,
On Wed, Aug 10, 2016 at 10:00:50PM -, Eugene Zelenko via cfe-commits
wrote:
> Modified: clang-tools-extra/trunk/docs/clang-rename.rst
> URL:
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-rename.rst?rev=278295&r1=278294&r2=278295&view=diff
>
yaxunl added a comment.
In https://reviews.llvm.org/D23086#515506, @Anastasia wrote:
>
> Surely vendors can re-implement all OpenCL types with an implicit typedef.
> For example this would just work:
>
> typedef int queue_t;
> void bar(queue_t q);
>
>
> I am afraid we will ne
Hi, Miklos!
Sorry, I was not aware about documentation source.
But I think will be good idea to improve punctuation consistency in tool itself.
Eugene.
On Mon, Aug 15, 2016 at 12:24 PM, Miklos Vajna wrote:
> Hi Eugene,
>
> On Wed, Aug 10, 2016 at 10:00:50PM -, Eugene Zelenko via cfe-commit
Author: ericwf
Date: Mon Aug 15 14:37:20 2016
New Revision: 278722
URL: http://llvm.org/viewvc/llvm-project?rev=278722&view=rev
Log:
Use -O1 when testing with ASAN and MSAN to prevent Clang OOM errors.
Currently certain tests get killed when compiled with ASAN at -O0 because
they eat all of the s
jlebar updated this revision to Diff 68063.
jlebar added a comment.
Move deferred diags storage into ASTContext.
https://reviews.llvm.org/D23241
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/Decl.h
clang/lib/AST/Decl.cpp
clang/lib/CodeGen/CodeGenModule.cpp
clang/
You may also want to just try using the unicode character (not that it
really matters that much though).
On Mon, Aug 15, 2016 at 11:45 AM, Paul Robinson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: probinson
> Date: Mon Aug 15 13:45:52 2016
> New Revision: 278710
>
> URL: http:/
hans added a comment.
Faisal: go ahead and commit directly to the branch, or let me know if you'd
like me to do it.
https://reviews.llvm.org/D23485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:4791-4802
@@ -4790,1 +4790,14 @@
+CallStackFrame *getNearestContainingCallFrame(CallStackFrame *CurFrame,
+ const VarDecl *VD) {
+ if (auto *FD =
+dyn_cas
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D23241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cbieneman
Date: Mon Aug 15 15:15:22 2016
New Revision: 278729
URL: http://llvm.org/viewvc/llvm-project?rev=278729&view=rev
Log:
[CMake] Apple stage1 doesn't need to set libcxx options
LibCXX settings are configured in stage2 so we don't need them here.
Modified:
cfe/trunk/cmake/cache
LGTM. But it would be great if someone with more exposure to CFE could double
check.
-Gerolf
> On Aug 14, 2016, at 11:39 PM, David Majnemer via cfe-commits
> wrote:
>
> Author: majnemer
> Date: Mon Aug 15 01:39:18 2016
> New Revision: 278655
>
> URL: http://llvm.org/viewvc/llvm-project?rev=
Author: compnerd
Date: Mon Aug 15 15:16:13 2016
New Revision: 278730
URL: http://llvm.org/viewvc/llvm-project?rev=278730&view=rev
Log:
StaticAnalyzer: Report found fields order in PaddingChecker
Report the found fields order in PaddingChecker.
Patch by Alexander Shaposhnikov!
Modified:
cfe/
compnerd closed this revision.
compnerd added a comment.
SVN r278730
https://reviews.llvm.org/D23387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen created this revision.
timshen added a reviewer: dblaikie.
timshen added a subscriber: cfe-commits.
Corresponding LLVM change: D23522
https://reviews.llvm.org/D23523
Files:
include/clang/Analysis/CFG.h
include/clang/Analysis/CallGraph.h
Index: include/clang/Analysis/CallGraph.h
Author: jlebar
Date: Mon Aug 15 15:38:48 2016
New Revision: 278733
URL: http://llvm.org/viewvc/llvm-project?rev=278733&view=rev
Log:
[CUDA] Fix CUDA install version parsing.
Summary:
getAsInteger returns true on error. Oops.
No test because the behavior at the moment is identical with or withou
Author: jlebar
Date: Mon Aug 15 15:38:56 2016
New Revision: 278735
URL: http://llvm.org/viewvc/llvm-project?rev=278735&view=rev
Log:
Add the notion of deferred diagnostics.
Summary:
This patch lets you create diagnostics that are emitted if and only if a
particular FunctionDecl is codegen'ed.
Th
101 - 137 of 137 matches
Mail list logo
