omtcyfz updated this revision to Diff 66434.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/CMakeLists.txt
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clang-renam
omtcyfz added a comment.
In https://reviews.llvm.org/D23006#502814, @Eugene.Zelenko wrote:
> Please add install rule for clang-rename.el. See clang-format CMakeLists.txt
> as example.
Good point! Thank you!
Done.
https://reviews.llvm.org/D23006
___
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22
@@ +21,2 @@
+ DESTINATION share/clang
+ COMPONENT find-all-symbols)
I think
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
lgtm with two nits.
Comment at: clang-rename/tool/CMakeLists.txt:14
@@ +13,3 @@
+
+install(PROGRAMS clang-rename.el
+ DESTINATION share/clang
Also include th
omtcyfz updated this revision to Diff 66437.
omtcyfz added a comment.
- s/print/type
- Add `clang-rename.py` to the `CMakeLists.txt` installation instructions.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/CMakeLists.txt
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
omtcyfz marked 2 inline comments as done.
omtcyfz added a comment.
Thanks! Fixed.
Waiting few more hours just in case anyone will jump in and write few comments.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
rovka created this revision.
rovka added a reviewer: thakis.
rovka added subscribers: cfe-commits, hans.
Herald added a subscriber: aemerson.
These tests require x86-registered-target, but they don't force the target as
x86 on the command line, which means they will be run and they might fail when
rovka added a comment.
This seems to be the case for other similar tests as well (e.g.
cl-pch-errorhandling.cpp requires x86-registered-target, but doesn't force it
on the command line), but they're not currently crashing. I can update those as
well if people think it's the right thing to do.
alexfh accepted this revision.
alexfh added a comment.
LG
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer accepted this revision.
This revision is now accepted and ready to land.
Comment at: include-fixer/SymbolIndexManager.h:32
@@ +31,3 @@
+ /// \param IsNestedSearch Whether searching nested classes. If true, the
+ ///method tries to stripping identifier name parts
Author: omtcyfz
Date: Tue Aug 2 03:51:26 2016
New Revision: 277433
URL: http://llvm.org/viewvc/llvm-project?rev=277433&view=rev
Log:
[clang-rename] add basic Emacs integration
This patch aims to add very basic Emacs integration.
Reviewers: hokein, alexfh
Differential Revision: https://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277433: [clang-rename] add basic Emacs integration (authored
by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23006?vs=66437&id=66442#toc
Repository:
rL LLVM
https://reviews.llvm.org/
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Hi Ben,
Looks like there's a typo in this patch that is causing a buildbot failure:
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-singlethreaded-x86_64-linux-debian/builds/1128/steps/build.libcxx/logs/stdio
Also seen in our local builders. I will fix it if I get around to it before
you :)
C
omtcyfz added a comment.
//Make sure to rebase once more; documentation was updated in the last
revision.//
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: clang-rename/USRFinder.cpp:80
@@ -79,1 +79,3 @@
TypeBeginLoc, 0, Context.getSourceManager(), Context.getLangOpts());
+if (const auto *TemplateTypeP
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 66444.
jbcoe added a comment.
Add test that triggers segfault without fix in place.
https://reviews.llvm.org/D23008
Files:
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp
clang-tidy/c
Author: omtcyfz
Date: Tue Aug 2 04:38:38 2016
New Revision: 277437
URL: http://llvm.org/viewvc/llvm-project?rev=277437&view=rev
Log:
[clang-rename] add support for template parameter renaming
Few simple tweaks allow template parameters to be renamed. See
TemplateTypenameFindBy{TemplateParam|Type
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277437: [clang-rename] add support for template parameter
renaming (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D22853?vs=66373&id=66446#toc
Repository:
rL LLVM
https://r
alexfh added a comment.
Please add revision number (this can be automated, if include differential
revision URL in your commit message as described in
http://llvm.org/docs/Phabricator.html#committing-a-change).
https://reviews.llvm.org/D22208
___
Author: vmiklos
Date: Tue Aug 2 04:51:31 2016
New Revision: 277438
URL: http://llvm.org/viewvc/llvm-project?rev=277438&view=rev
Log:
clang-rename: split existing options into two new subcommands
- rename-at is meant to be integrated with editors and works mainly off
of a location in a file, an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277438: clang-rename: split existing options into two new
subcommands (authored by vmiklos).
Changed prior to commit:
https://reviews.llvm.org/D21814?vs=66362&id=66448#toc
Repository:
rL LLVM
https:
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115
@@ -95,1 +114,3 @@
+ auto CtorCallSourceRange = CharSourceRange::getTokenRange(
+ InnerCtorCall->getExprLoc(), CallParensRange.getBegin());
Prazek wrote:
> alexfh wrote:
hokein updated this revision to Diff 66452.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D23023
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.cpp
include-fixer/SymbolIndexManager.cpp
include-fixer/SymbolIndexManager.h
unittests/in
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Sorry for the delay. I almost missed that there was an update to the patch.
Please mark addressed comments as "Done". This way it's easier for me to track
changes and it's easier for
Author: hokein
Date: Tue Aug 2 05:43:10 2016
New Revision: 277442
URL: http://llvm.org/viewvc/llvm-project?rev=277442&view=rev
Log:
[include-fixer] Correct nested class search for identifiers with scoped
information
Summary:
include-fixer will firstly try to use scoped namespace context informa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277442: [include-fixer] Correct nested class search for
identifiers with scoped… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D23023?vs=66452&id=66454#toc
Repository:
rL LL
rengolin added a subscriber: rengolin.
rengolin added a comment.
All tests should have the target explicit, so I'd advocate for all of them to
be changed.
Also, we need to make sure --target=x86_64 is enough on Windows. I remember
some -target=arm not being enough (arm-eabi was enough, for some
Author: hokein
Date: Tue Aug 2 06:26:35 2016
New Revision: 277444
URL: http://llvm.org/viewvc/llvm-project?rev=277444&view=rev
Log:
[clang-tidy] Fix an unused-using-decl false positive about template arguments in
function call expression.
Summary:
The check doesn't mark the template argument as
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL277444: [clang-tidy] Fix an unused-using-decl false positive
about template arguments in (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/
djasper added inline comments.
Comment at: lib/Format/FormatTokenLexer.cpp:254
@@ +253,3 @@
+ for (; Offset != Lex->getBuffer().end(); ++Offset) {
+if (*Offset == '`') {
+ StateStack.pop();
I'd use Offset[0]
Comment at: lib/Format/Forma
On Sat, Jul 30, 2016 at 12:47 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Jul 26, 2016 at 10:30:22PM +, Laxman Sole via cfe-commits
> wrote:
> > Currently basic_string's destructor is not getting inlined. So adding
> 'inline' attribute to ~basic_string
klimek added a comment.
Perhaps call it AccessModifierIntroducesScope or something?
Side-track: I find it highly confusing that in
class C {
int v1;
private:
int v2;
}
v1 & v2 have different indent, although they are in the same scope.
https://reviews.llvm.org/D22505
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277449: [analyzer] Respect statement-specific data in
CloneDetection. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D22514?vs=66309&id=66460#toc
Repository:
rL LLVM
http
Author: dergachev
Date: Tue Aug 2 07:21:09 2016
New Revision: 277449
URL: http://llvm.org/viewvc/llvm-project?rev=277449&view=rev
Log:
[analyzer] Respect statement-specific data in CloneDetection.
So far the CloneDetector only respected the kind of each statement when
searching for clones. This
djasper added a comment.
So you'd be for #1 of the three choices from my previous comment?
https://reviews.llvm.org/D22505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
In https://reviews.llvm.org/D22505#503278, @djasper wrote:
> So you'd be for #1 of the three choices from my previous comment?
Yes, because I think ultimately introducing scopes is different from simple
outdents/indents.
https://reviews.llvm.org/D22505
klimek added a comment.
(full disclosure: I'm also generally opposed to this change, but if there are
really enough users using this it's probably a lost cause)
https://reviews.llvm.org/D22505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
djasper added a comment.
I generally agree. Note, however, that the mentioned style guide doesn't
actually specify this. All it says is "The public, protected, and private
keywords should be indented inside the class with the function declarations
indented as well."
So I guess,
class C {
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek.
omtcyfz added a subscriber: cfe-commits.
This patch introduces basic capabilities of renaming templated class and its
specializations.
https://reviews.llvm.org/D23058
Files:
clang-rename/USRFinder.cpp
clang-rename/USRFi
rovka added a comment.
In https://reviews.llvm.org/D23054#503246, @rengolin wrote:
> All tests should have the target explicit, so I'd advocate for all of them to
> be changed.
Coming right up...
> Also, we need to make sure --target=x86_64 is enough on Windows. I remember
> some -target=arm
Author: chapuni
Date: Tue Aug 2 08:17:40 2016
New Revision: 277452
URL: http://llvm.org/viewvc/llvm-project?rev=277452&view=rev
Log:
clang-tools-extra/test/clang-rename/TemplateTypenameFindBy*.cpp: Appease
targeting ms mode.
Modified:
clang-tools-extra/trunk/test/clang-rename/TemplateTypen
Author: chapuni
Date: Tue Aug 2 08:17:36 2016
New Revision: 277451
URL: http://llvm.org/viewvc/llvm-project?rev=277451&view=rev
Log:
clang-tools-extra/test/clang-rename/TemplateTypenameFindBy*.cpp: Move RUN:
lines below not to be affected by tweaks of parameters.
Modified:
clang-tools-extr
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:423
@@ +422,3 @@
+
+if (!val.isZeroConstant()) {
+ val = getStoreManager().evalDynamicCast(val, T, Failed);
I guess if `val` is a //non-zero// constant, it wouldn't mak
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:423
@@ +422,3 @@
+
+if (!val.isZeroConstant()) {
+ val = getStoreManager().evalDynamicCast(val, T, Failed);
NoQ wrote:
> I guess if `val` is a //non-zero// consta
chapuni added a subscriber: chapuni.
chapuni added a comment.
Seems a couple of tests would be incompatible to -fdelayed-template-parsing.
Appeased in r277452.
Repository:
rL LLVM
https://reviews.llvm.org/D22853
___
cfe-commits mailing list
cfe-
rovka retitled this revision from "[clang-cl] Fix 2 pch tests to use x86_64 as
target" to "[clang-cl] Fix PCH tests to use x86_64 as target".
rovka updated this revision to Diff 66467.
rovka added a comment.
Added cl-pch-errorhandling.cpp
https://reviews.llvm.org/D23054
Files:
test/Driver/cl
Author: bcraig
Date: Tue Aug 2 08:43:48 2016
New Revision: 277456
URL: http://llvm.org/viewvc/llvm-project?rev=277456&view=rev
Log:
Fixing 'Aquire' typo and libcxx build.
Modified:
libcxx/trunk/src/include/atomic_support.h
libcxx/trunk/src/memory.cpp
Modified: libcxx/trunk/src/include/a
tavianator added a comment.
Anything else I need to do for this patch?
https://reviews.llvm.org/D21803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rovka
Date: Tue Aug 2 08:53:00 2016
New Revision: 277457
URL: http://llvm.org/viewvc/llvm-project?rev=277457&view=rev
Log:
[clang-cl] Fix PCH tests to use x86_64 as target
These tests require x86-registered-target, but they don't force the target as
x86 on the command line, which means t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277457: [clang-cl] Fix PCH tests to use x86_64 as target
(authored by rovka).
Changed prior to commit:
https://reviews.llvm.org/D23054?vs=66467&id=66468#toc
Repository:
rL LLVM
https://reviews.llvm.
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:423
@@ +422,3 @@
+
+if (!val.isZeroConstant()) {
+ val = getStoreManager().evalDynamicCast(val, T, Failed);
xazax.hun wrote:
> NoQ wrote:
> > I guess if `val` is a //no
xazax.hun created this revision.
xazax.hun added reviewers: zaks.anna, dcoughlin, NoQ.
xazax.hun added a subscriber: cfe-commits.
This patch adds a command line option to list the checkers that were enabled by
analyzer-checker and not disabled by -analyzer-disable-checker.
It can be very useful
The LLVM IR generated by Clang trunk for spir target is not conformant to SPIR
spec 1.2 or 2.0 even without my change. For example, it differs from SPIR spec
about LLVM version, image type name, sampler type representation, blocks
representation, etc. It is the result of evolution of the origina
On 2 August 2016 at 13:21, Artem Dergachev via cfe-commits
wrote:
> Author: dergachev
> Date: Tue Aug 2 07:21:09 2016
> New Revision: 277449
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277449&view=rev
> Log:
> [analyzer] Respect statement-specific data in CloneDetection.
Hi Artem,
Just to
Wow, i haven't noticed it's mine!
Will have a look, sorry.
On 8/2/16 5:51 PM, Renato Golin via cfe-commits wrote:
On 2 August 2016 at 13:21, Artem Dergachev via cfe-commits
wrote:
Author: dergachev
Date: Tue Aug 2 07:21:09 2016
New Revision: 277449
URL: http://llvm.org/viewvc/llvm-project?
vmiklos added a comment.
Yes, I did that -- but I got no conflicts there. ;-)
Repository:
rL LLVM
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: omtcyfz
Date: Tue Aug 2 10:10:17 2016
New Revision: 277469
URL: http://llvm.org/viewvc/llvm-project?rev=277469&view=rev
Log:
[clang-rename] fix Emacs script build failure
Clang-rename Emacs integration script sometimes doesn't work correctly.
Modified:
clang-tools-extra/trunk/clang
Author: dergachev
Date: Tue Aug 2 10:16:06 2016
New Revision: 277473
URL: http://llvm.org/viewvc/llvm-project?rev=277473&view=rev
Log:
[analyzer] Hotfix for buildbot failure due to unspecified triple in r277449
If a target triple is not specified, the default host triple is used,
which is not go
dcoughlin added a comment.
Other than a naming/documentation suggestion, looks good to me. Thanks Gábor!
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:424
@@ +423,3 @@
+if (!val.isZeroConstant()) {
+ val = getStoreManager().evalDynamicCast(val, T, Failed);
cameron314 added a comment.
Anyone have time to check this out this week?
It's a one-line fix, includes a test, and is for a fairly important bug :-)
https://reviews.llvm.org/D20338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D22698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Author: tstellar
Date: Tue Aug 2 11:29:52 2016
New Revision: 277481
URL: http://llvm.org/viewvc/llvm-project?rev=277481&view=rev
Log:
Creating release_38 off revision 260304
Added:
libclc/branches/release_38/
- copied from r260304, libclc/trunk/
___
LokiAstari added a comment.
I don't have a problem changing it so the default behaviour is:
class C {
int v1;
private:
int v2;
};
But I would like to retain the functionality that if there is no explicit
public/private/protected that it follows the original.
But if there is
bittnerbarni updated this revision to Diff 66492.
https://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationCheck.h
clang-tidy/performance/PerformanceTidy
bittnerbarni marked 14 inline comments as done.
bittnerbarni added a comment.
https://reviews.llvm.org/D20196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added inline comments.
Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22
@@ +21,2 @@
+ DESTINATION share/clang
+ COMPONENT find-all-symbols)
hokein wrote:
> I think we can put it in `clang-include-fixer` as find-all-symbols is a
>
nandor added a comment.
ping
https://reviews.llvm.org/D22419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington updated this revision to Diff 66501.
erik.pilkington added a comment.
This new patch removes the warning `diag::warn_available_using_star_case`, as
per Devin's suggestion.
https://reviews.llvm.org/D23003
Files:
include/clang/AST/Stmt.h
include/clang/Basic/DiagnosticGroups.t
Author: cbieneman
Date: Tue Aug 2 12:50:53 2016
New Revision: 277487
URL: http://llvm.org/viewvc/llvm-project?rev=277487&view=rev
Log:
[Order Files] Remove dtrace predicate
Having the dtrace predicate setup to only show probes in clang filters out
static initializers executed by dyld, which we
Author: vitalybuka
Date: Tue Aug 2 12:51:48 2016
New Revision: 277488
URL: http://llvm.org/viewvc/llvm-project?rev=277488&view=rev
Log:
Updated documentation
Reviewers: kcc, eugenis
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D22992
Modified:
cfe/trunk/docs/A
tra updated this revision to Diff 66505.
tra added a comment.
Herald added a subscriber: klimek.
Abort pipeline constructions early if we detect that NVPTX is used for host
compilation.
Restore assertions for presence of -march flag.
https://reviews.llvm.org/D23042
Files:
include/clang/Basic
Should we merge this to 3.9?
Thanks,
Hans
On Thu, Jul 28, 2016 at 5:55 PM, Erik Pilkington via cfe-commits
wrote:
> Author: epilk
> Date: Thu Jul 28 19:55:40 2016
> New Revision: 277095
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277095&view=rev
> Log:
> [Parser] Fix bug where delayed typo
Prazek added a comment.
In https://reviews.llvm.org/D22208#503194, @alexfh wrote:
> Please add revision number (this can be automated, if include differential
> revision URL in your commit message as described in
> http://llvm.org/docs/Phabricator.html#committing-a-change).
I normally use arc
Prazek marked 5 inline comments as done.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115
@@ -95,1 +114,3 @@
+ auto CtorCallSourceRange = CharSourceRange::getTokenRange(
+ InnerCtorCall->getExprLoc(), CallParensRange.getBegin());
alexfh wrote:
> Pr
Author: niravd
Date: Tue Aug 2 12:58:14 2016
New Revision: 277490
URL: http://llvm.org/viewvc/llvm-project?rev=277490&view=rev
Log:
Update Clang Parser test error message to match new parser errors
Update clang tests in light of r277489.
Modified:
cfe/trunk/test/Parser/ms-inline-asm.c
Modi
ashi1 created this revision.
ashi1 added reviewers: Anastasia, yaxunl, nhaustov.
ashi1 added a subscriber: cfe-commits.
ashi1 set the repository for this revision to rL LLVM.
There should be no native_ builtin functions with double type arguments.
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: omtcyfz
Date: Tue Aug 2 13:23:08 2016
New Revision: 277491
URL: http://llvm.org/viewvc/llvm-project?rev=277491&view=rev
Log:
[clang-rename] fix Emacs integration script
Modified:
clang-tools-extra/trunk/clang-rename/tool/clang-rename.el
Modified: clang-tools-extra/trunk/clang-rename
Author: cbieneman
Date: Tue Aug 2 13:23:56 2016
New Revision: 277492
URL: http://llvm.org/viewvc/llvm-project?rev=277492&view=rev
Log:
Revert "[Order Files] Remove dtrace predicate"
This reverts commit r277487.
Removing the probe predicate was a red herring. It results in more symbols
being pl
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2809
@@ +2808,3 @@
+/// matches \c foo in \c foo(t);
+AST_MATCHER_P(OverloadExpr, canReferToDecl, internal::Matcher,
+ InnerMatcher) {
I find the name of this m
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63-64
@@ -62,4 +62,4 @@
-std::string SpecialMemberFunctionsCheck::join(
-llvm::ArrayRef SMFS, llvm::StringRef AndOr) {
+template
+static std::string join(const R &S
Prazek added a subscriber: Prazek.
Prazek accepted this revision.
Prazek added a reviewer: Prazek.
Prazek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23008
___
cfe-commits mailing list
cfe-commits
nhaustov accepted this revision.
nhaustov added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
Could you also note in commit message that online HTML docs are not very clear,
but pdf of OpenCL specification has it right.
Repository:
rL LLVM
https://reviews.llvm.or
klimek added a comment.
In https://reviews.llvm.org/D22505#503472, @LokiAstari wrote:
> I don't have a problem changing it so the default behaviour is:
>
> class C {
> int v1;
> private:
> int v2;
> };
>
>
> But I would like to retain the functionality that if there is no e
dcoughlin added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:6611
@@ +6610,3 @@
+ if (auto *E = dyn_cast(If->getCond())) {
+// If we're using the '*' case here, then we cannot emit any warnings for
+// the 'then' branch.
Do you still want to sup
manmanren created this revision.
manmanren added reviewers: dexonsmith, doug.gregor.
manmanren added a subscriber: cfe-commits.
For ObjC type parameter, we used to have TypedefType that is canonicalized to
id or the bound type. We can't represent "T " and thus will lose
the type information in the
LokiAstari added a comment.
> That should already be doable with a negative offset today, right?
Yes. So I don't need to add any changes. right?
https://reviews.llvm.org/D22505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
manmanren created this revision.
manmanren added a reviewer: doug.gregor.
manmanren added a subscriber: cfe-commits.
This depends on https://reviews.llvm.org/D23078
ObjC generics: Add ObjCTypeParamType in the type system.
We also need to add ObjCTypeParamTypeLoc. ObjCTypeParamType supports the
r
manmanren created this revision.
manmanren added a reviewer: doug.gregor.
manmanren added a subscriber: cfe-commits.
Depends on https://reviews.llvm.org/D23078 and https://reviews.llvm.org/D23079
We say ObjCTypeParamType is ObjCObjectPointerType, but we assert
fail when trying to call Type::getP
jbcoe added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63-64
@@ -62,4 +62,4 @@
-std::string SpecialMemberFunctionsCheck::join(
-llvm::ArrayRef SMFS, llvm::StringRef AndOr) {
+template
+static std::string join(const R &SMFS, llv
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63-64
@@ -62,4 +62,4 @@
-std::string SpecialMemberFunctionsCheck::join(
-llvm::ArrayRef SMFS, llvm::StringRef AndOr) {
+template
+static std::string join(const R &S
alexfh added a comment.
Running tests, will submit shortly.
Comment at: docs/clang-tidy/checks/mpi-type-mismatch.rst:13
@@ +12,3 @@
+.. code:: c++
+ // In this case, the buffer type matches MPI datatype.
+ char buf;
This doesn't parse - an extra newline is nee
jbcoe updated this revision to Diff 66541.
jbcoe added a comment.
static `join` function is no longer a function template.
https://reviews.llvm.org/D23008
Files:
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h
test/cl
jbcoe marked an inline comment as done.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63-64
@@ -62,3 +62,4 @@
-std::string SpecialMemberFunctionsCheck::join(
-llvm::ArrayRef SMFS, llvm::StringRef AndOr) {
+static std::string
+join(ArrayRef SMFS,
+
Author: ericwf
Date: Tue Aug 2 15:21:07 2016
New Revision: 277512
URL: http://llvm.org/viewvc/llvm-project?rev=277512&view=rev
Log:
Pass compilers when configuring Google Benchmark.
Modified:
libcxx/trunk/benchmarks/CMakeLists.txt
Modified: libcxx/trunk/benchmarks/CMakeLists.txt
URL:
http
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM now, thank you for switching back! I was mostly worried about an
unrestricted template argument in this case, not the particular form of the
change. :-)
https://reviews.llvm.org/D23008
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp:2
@@ -1,3 +1,3 @@
// RUN: cat %s > %t.cpp
-// RUN: clang-rename -offset=287 -new-name=Bar %t.cpp -i --
+// RUN:
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
> Restore assertions for presence of -march flag.
We don't need an explicit assertion in TranslateArgs?
Comment at: lib/Driver/Driver.cpp:1412
@@ +1411,3 @@
+ assert(HostTC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277516: [clang-tidy] MPITypeMismatchCheck (authored by
alexfh).
Changed prior to commit:
https://reviews.llvm.org/D21962?vs=65404&id=66544#toc
Repository:
rL LLVM
https://reviews.llvm.org/D21962
Fi
Author: alexfh
Date: Tue Aug 2 15:29:47 2016
New Revision: 277517
URL: http://llvm.org/viewvc/llvm-project?rev=277517&view=rev
Log:
[docs] Fix links format.
Modified:
clang-tools-extra/trunk/docs/clang-rename.rst
clang-tools-extra/trunk/docs/include-fixer.rst
Modified: clang-tools-extra
1 - 100 of 157 matches
Mail list logo
