alexfh added a comment.
Thanks for the new check! Looks awesome! A couple of late comments inline.
Comment at:
clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:91
@@ +90,3 @@
+
+ std::initializer_list>
+ Matchers = {{"dtor", SpecialMemb
mboehme created this revision.
mboehme added reviewers: aaron.ballman, sbenza.
mboehme added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Required for D0
https://reviews.llvm.org/D23004
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
li
mboehme updated this revision to Diff 66284.
mboehme marked 3 inline comments as done.
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.h
Author: sylvestre
Date: Mon Aug 1 03:04:45 2016
New Revision: 277328
URL: http://llvm.org/viewvc/llvm-project?rev=277328&view=rev
Log:
scan-build: Add an option to show the description in the list of defect
Summary:
This patch adds an option //--show-description// to add the defect description
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115
@@ -95,1 +114,3 @@
+ auto CtorCallSourceRange = CharSourceRange::getTokenRange(
+ InnerCtorCall->getExprLoc(), CallParensRange.getBegin());
Prazek wrote:
> alexfh wrote:
mboehme marked 7 inline comments as done.
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:93
@@ +92,3 @@
+ hasArgument(0, ignoringParenImpCasts(declRefExpr(
+ to(ForwardingReferenceParmMatcher)
+ .bind("call-
mboehme added a comment.
Retracting from review for the moment. Tests fail to compile (embarrasingly
enough, I ran the wrong test suite -- apologies).
https://reviews.llvm.org/D23004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
NoQ added a comment.
Congrats on the fantastic hack that nobody else noticed! I've a feeling we
cannot add tests for that, because any test would quickly break if we change
the hash, though demonstrating that we fixed the problem would still be cool
(eg. take two unsupported expressions of diff
hokein added a comment.
Looks like the dependency of this patch https://reviews.llvm.org/D21962 got
reverted by some reasons.
Comment at: clang-tidy/mpi/BufferDerefCheck.cpp:63
@@ +62,3 @@
+if (FuncClassifier.isReduceType(Identifier)) {
+ addBuffer(0);
+ addBuffer
nhaustov accepted this revision.
nhaustov added a comment.
This revision is now accepted and ready to land.
Ok.
https://reviews.llvm.org/D22940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
omtcyfz created this revision.
omtcyfz added reviewers: bkramer, alexfh, klimek.
omtcyfz added a subscriber: cfe-commits.
This patch aims to add very basic Emacs integration. My experience with Emacs
is limited to few days, so I'm not sure whether I've done things correctly.
https://reviews.llvm
NoQ added a comment.
Uhm. I've a feeling that now i realize how it should have been written from the
start. That's a pretty bad feeling to have.
I wish we had a //series of passes//. Before the first pass, all statements are
considered equivalent. After the first pass, they're split into smalle
mboehme added reviewers: sbenza, aaron.ballman.
mboehme updated this revision to Diff 66291.
mboehme added a comment.
Updated test and documentation for hasUnderlyingDecl() to use using
declarations instead of typedefs. (I made the mistaken assumption that
getUnderlyingDecl() would also work on
omtcyfz updated this revision to Diff 66292.
omtcyfz added a comment.
Update docs by adding information about Emacs integration.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
=
ericLemanissier added a comment.
I have an segfault on all the source files of my project when I enable this
check (it works ok when I disable this check). Sorry I don't have time to post
a minimal source file producing the segfault. I will maybe tomorrow, or in two
weeks.
Repository:
rL LL
klimek added inline comments.
Comment at: clang-rename/tool/clang-rename.el:7
@@ +6,3 @@
+
+;; This package allows to filter code through clang-format to fix its
formatting.
+;; clang-format is a tool that formats C/C++/Obj-C code according to a set of
s/clang-fo
ioeric updated this revision to Diff 66295.
ioeric added a comment.
- merged with origin/master
https://reviews.llvm.org/D21749
Files:
clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h
clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp
clang-ap
ioeric updated this revision to Diff 66294.
ioeric added a comment.
- Merge branch 'master' of http://llvm.org/git/clang into replace
https://reviews.llvm.org/D21748
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
lib/Format/Format.cpp
lib/Format/Sort
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D22903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
omtcyfz added inline comments.
Comment at: clang-rename/tool/clang-rename.el:7
@@ +6,3 @@
+
+;; This package allows to filter code through clang-format to fix its
formatting.
+;; clang-format is a tool that formats C/C++/Obj-C code according to a set of
klimek wr
omtcyfz updated this revision to Diff 66296.
omtcyfz marked 2 inline comments as done.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clan
Author: yrnkrn
Date: Mon Aug 1 05:14:54 2016
New Revision: 277334
URL: http://llvm.org/viewvc/llvm-project?rev=277334&view=rev
Log:
Allow .exe extension to ld to fix test with mingw.
Modified:
cfe/trunk/test/Driver/offloading-interoperability.c
Modified: cfe/trunk/test/Driver/offloading-in
Author: ioeric
Date: Mon Aug 1 05:16:37 2016
New Revision: 277335
URL: http://llvm.org/viewvc/llvm-project?rev=277335&view=rev
Log:
Implement tooling::Replacements as a class.
Summary:
- Implement clang::tooling::Replacements as a class to provide interfaces to
control how replacements for a s
Author: ioeric
Date: Mon Aug 1 05:16:39 2016
New Revision: 277336
URL: http://llvm.org/viewvc/llvm-project?rev=277336&view=rev
Log:
Changes related to new implementation of tooling::Replacements as class.
Summary: See http://reviews.llvm.org/D21748 for details.
Reviewers: djasper, klimek
Subsc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277336: Changes related to new implementation of
tooling::Replacements as class. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D21749?vs=66295&id=66298#toc
Repository:
rL LL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277335: Implement tooling::Replacements as a class.
(authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D21748?vs=66294&id=66297#toc
Repository:
rL LLVM
https://reviews.llvm.org/
NoQ added a comment.
Looks good, minor comments :)
Comment at: lib/Analysis/CloneDetection.cpp:99
@@ +98,3 @@
+ /// Every item in this list is unique.
+ std::vector Variables;
+
I've a feeling this is essentially a `map`, because
that harmonizes with our acce
Thanks for reporting this.
I can reproduce the segfault and have a fix. Is it ok to commit and have
review done later?
regards,
Jon
On 1 August 2016 at 11:06, Eric Lemanissier
wrote:
> ericLemanissier added a comment.
>
> I have an segfault on all the source files of my project when I enable
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277338: [analyzer] Fix execution permissions for the
scan-build-py scripts. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D22969?vs=66159&id=66300#toc
Repository:
rL LLVM
Patch posted to Phabricator as https://reviews.llvm.org/D23008
regards,
Jon
On 1 August 2016 at 11:48, Jonathan Coe wrote:
> Thanks for reporting this.
>
> I can reproduce the segfault and have a fix. Is it ok to commit and have
> review done later?
>
> regards,
>
> Jon
>
> On 1 August 2016 at
rengolin added a reviewer: compnerd.
rengolin added a subscriber: compnerd.
rengolin added a comment.
Can you add a test on test/Headers, like the others, please?
I'm not well versed on Windows. @compnerd?
Comment at: lib/Headers/armintr.h:1
@@ +1,2 @@
+/*=== armintr.h - AR
mstorsjo added a comment.
In https://reviews.llvm.org/D22774#501993, @rengolin wrote:
> Can you add a test on test/Headers, like the others, please?
Sure, there seems to be a good spot for that in ms-intrin.cpp.
Comment at: lib/Headers/armintr.h:1
@@ +1,2 @@
+/*=== armint
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277339: [clang-tidy] Prepare modernize-loop-convert for
upcoming changes in D22566 (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D22903?vs=65877&id=66303#toc
Repository:
rL
Author: mboehme
Date: Mon Aug 1 06:29:17 2016
New Revision: 277339
URL: http://llvm.org/viewvc/llvm-project?rev=277339&view=rev
Log:
[clang-tidy] Prepare modernize-loop-convert for upcoming changes in D22566
Summary:
D22566 will change RecursiveASTVisitor so that it descends into the
initializa
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek.
omtcyfz added a subscriber: cfe-commits.
1. Renaming overridden functions only works for two levels of "overriding
hierarchy". `clang-rename` should recursively add overridden methods.
2. Make use of `forEachOverridden` AST M
rengolin added inline comments.
Comment at: lib/Headers/armintr.h:27
@@ +26,3 @@
+
+typedef enum
+{
mstorsjo wrote:
> rengolin wrote:
> > Maybe an ifdef Windows wrapper, to make sure not to mess up *nix
> > environments?
> I can add the same as at the top of intr
mstorsjo added inline comments.
Comment at: lib/Headers/armintr.h:27
@@ +26,3 @@
+
+typedef enum
+{
rengolin wrote:
> mstorsjo wrote:
> > rengolin wrote:
> > > Maybe an ifdef Windows wrapper, to make sure not to mess up *nix
> > > environments?
> > I can add the
Alexander_Droste added a comment.
Hi, thanks for having a look!
Comment at: clang-tidy/mpi/BufferDerefCheck.cpp:63
@@ +62,3 @@
+if (FuncClassifier.isReduceType(Identifier)) {
+ addBuffer(0);
+ addBuffer(1);
hokein wrote:
> Could you add some commen
vmiklos updated this revision to Diff 66304.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
test/c
vmiklos added a comment.
Rebased on top of r277339 and resolved conflicts.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added inline comments.
Comment at: lib/Headers/armintr.h:27
@@ +26,3 @@
+
+typedef enum
+{
mstorsjo wrote:
> rengolin wrote:
> > mstorsjo wrote:
> > > rengolin wrote:
> > > > Maybe an ifdef Windows wrapper, to make sure not to mess up *nix
> > > > enviro
omtcyfz added a comment.
Manuel, any other comments? Jens seems to be missing and I don't know about
anyone else who is familiar with Emacs :(
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Author: omtcyfz
Date: Mon Aug 1 07:06:18 2016
New Revision: 277340
URL: http://llvm.org/viewvc/llvm-project?rev=277340&view=rev
Log:
[clang-tidy] remove trailing whitespaces and retab
Modified:
clang-tools-extra/trunk/clang-tidy/cert/LICENSE.TXT
clang-tools-extra/trunk/clang-tidy/cert/St
xazax.hun marked 10 inline comments as done.
xazax.hun added a comment.
https://reviews.llvm.org/D15227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alexander_Droste added a comment.
> Looks like the dependency of this patch https://reviews.llvm.org/D21962 got
> reverted by some reasons.
I know, I updated the patch after that, in order to fix the problem.
https://reviews.llvm.org/D22729
___
c
On Mon, Aug 1, 2016 at 6:48 AM, Jonathan Coe wrote:
> Thanks for reporting this.
>
> I can reproduce the segfault and have a fix. Is it ok to commit and have
> review done later?
Yes, this sort of thing is typical to handle post-commit (along with
other feedback that comes in post-commit).
~Aaro
Author: mboehme
Date: Mon Aug 1 07:15:46 2016
New Revision: 277342
URL: http://llvm.org/viewvc/llvm-project?rev=277342&view=rev
Log:
Make RecursiveASTVisitor visit lambda capture initialization expressions
Summary:
Lambda capture initializations are part of the explicit source code and
therefore
guyblank added a comment.
ping
https://reviews.llvm.org/D21959
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dergachev
Date: Mon Aug 1 05:55:59 2016
New Revision: 277338
URL: http://llvm.org/viewvc/llvm-project?rev=277338&view=rev
Log:
[analyzer] Fix execution permissions for the scan-build-py scripts.
Differential Revision: https://reviews.llvm.org/D22969
Modified:
cfe/trunk/tools/scan-bu
mstorsjo updated this revision to Diff 66306.
mstorsjo added a comment.
Added a test, added "windows" to the header title line, added an `#ifndef
_MSC_VER #include_next` to the header.
https://reviews.llvm.org/D22774
Files:
lib/Headers/CMakeLists.txt
lib/Headers/armintr.h
lib/Headers/int
teemperor updated this revision to Diff 66308.
teemperor added a comment.
- No longer re-initialize memory created from resize().
- Added test for checking that StmtDataCollector visits all parent classes.
https://reviews.llvm.org/D22514
Files:
include/clang/Analysis/CloneDetection.h
lib/An
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D22774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
teemperor updated this revision to Diff 66309.
teemperor added a comment.
- s/super class/base class/g
https://reviews.llvm.org/D22514
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.cpp
test/Analysis/copypaste/asm.cpp
test/Analysis/copypaste/attributes.cpp
xazax.hun created this revision.
xazax.hun added reviewers: zaks.anna, dcoughlin, dergachev.a, a.sidorin.
xazax.hun added a subscriber: cfe-commits.
Dynamic casts are handled relatively well by the static analyzer. BaseToDerived
casts however are handled conservatively. This can cause some false
xazax.hun added inline comments.
Comment at: test/Analysis/NewDelete-checker-test.cpp:394
@@ +393,3 @@
+ Derived *p = (Derived *)allocate();
+ delete p;
+}
Before the modification the analyzer reports a leak here, since the symbol
returned by the BaseToDerived
sepavloff created this revision.
sepavloff added a subscriber: cfe-commits.
Function specializations used in friend declarations in class templates, like:
```
template class C1 {
friend void func<>(int);
```
previously were processed incorrectly: class instantiation made them ordinary
hokein added inline comments.
Comment at: clang-rename/tool/clang-rename.el:16
@@ +15,3 @@
+
+(defvar clang-rename-binary "clang-rename")
+
I think we should make `clang-rename` binary path configurable by making it a
custom variable (using `defcustom`).
===
alexfh added inline comments.
Comment at: clang-rename/tool/clang-rename.el:18
@@ +17,3 @@
+
+(defun clang-rename-upstream (new-name)
+ "Rename all instances of the symbol at the point using clang-rename"
The name should be just "clang-rename".
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
omtcyfz added inline comments.
Comment at: clang-rename/tool/clang-rename.el:20
@@ +19,3 @@
+ "Rename all instances of the symbol at the point using clang-rename"
+ (interactive "sEnter a new name: ")
+ (let (;; Emacs offset is 1-based.
hokein wrote:
> `s` is a
omtcyfz updated this revision to Diff 66328.
omtcyfz marked 8 inline comments as done.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clan
> On Jul 30, 2016, at 12:59 PM, Joerg Sonnenberger via cfe-commits
> wrote:
>
> On Thu, Jul 28, 2016 at 10:11:05PM +, Vedant Kumar wrote:
>> - test/Driver/netbsd.c
>>
>>We see -mcpu=arm1022e instead of arm926ej-s in a single run.
>
> Which one exactly?
Here is the test (test/Driver/
omtcyfz added a comment.
All the comments seem to be addressed.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: test/clang-rename/FunctionOverride.cpp:3
@@ +2,3 @@
+
+class A { virtual void foo(); };// CHECK: class A { virtual void boo(); };
+class B : public A { void foo(); }; // CHECK
On Sun, Jul 31, 2016 at 10:32 PM, Gerolf Hoflehner
wrote:
>
> > On Jul 31, 2016, at 1:46 AM, Amjad Aboud wrote:
> >
> > aaboud added a comment.
> >
> >> ISTM that the DWARF spec intended such thunks to be encoded as
> `DW_AT_trampoline`. That seems more appropriate than relying on codegen
> emi
On Wed, Jul 27, 2016 at 6:43 AM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Tue Jul 26 23:43:15 2016
> New Revision: 276836
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276836&view=rev
> Log:
> test: simplify commands, NFC
>
> Rather than
Author: majnemer
Date: Mon Aug 1 11:39:29 2016
New Revision: 277352
URL: http://llvm.org/viewvc/llvm-project?rev=277352&view=rev
Log:
[Parse] Let declarations follow labels in -fms-extensions mode
MSVC permits declarations in these places as conforming extension (it is
a constraint violation oth
Author: omtcyfz
Date: Mon Aug 1 11:48:33 2016
New Revision: 277354
URL: http://llvm.org/viewvc/llvm-project?rev=277354&view=rev
Log:
[clang-rename] revert r276836
Revert r276836, which resulted in tests passing regardless of the actual tool
replacements.
Modified:
clang-tools-extra/trunk/
omtcyfz updated this revision to Diff 66338.
omtcyfz marked an inline comment as done.
https://reviews.llvm.org/D23009
Files:
clang-rename/USRFindingAction.cpp
test/clang-rename/FunctionOverride.cpp
Index: test/clang-rename/FunctionOverride.cpp
===
alexfh added a subscriber: alexfh.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2440
@@ +2439,3 @@
+
+ return (UnderlyingDecl != nullptr &&
+ InnerMatcher.matches(*UnderlyingDecl, Finder, Builder));
nit: Parentheses are superfluous here.
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D23009
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-rename/USRFinder.cpp:80
@@ -79,1 +79,3 @@
TypeBeginLoc, 0, Context.getSourceManager(), Context.getLangOpts());
+if (const auto *TemplateTypeParm =
dyn_cast(Loc
alexfh added inline comments.
Comment at: clang-rename/tool/clang-rename.el:28
@@ +27,3 @@
+(orig-buf (current-buffer))
+(file-name (buffer-file-name)))
+
For posterity, please add a short summary of the offline discussion.
Commen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277356: [clang-rename] handle overridden functions correctly
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23009?vs=66338&id=66340#toc
Repository:
rL LLVM
https://reviews
omtcyfz updated this revision to Diff 66341.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clang-rename.rst
+++ docs/clang-rename.rst
@@
omtcyfz marked 2 inline comments as done.
Comment at: clang-rename/tool/clang-rename.el:28
@@ +27,3 @@
+(orig-buf (current-buffer))
+(file-name (buffer-file-name)))
+
alexfh wrote:
> For posterity, please add a short summary of the offline discussi
Author: omtcyfz
Date: Mon Aug 1 12:15:57 2016
New Revision: 277356
URL: http://llvm.org/viewvc/llvm-project?rev=277356&view=rev
Log:
[clang-rename] handle overridden functions correctly
1. Renaming overridden functions only works for two levels of "overriding
hierarchy". clang-rename should r
omtcyfz added inline comments.
Comment at: clang-rename/USRFinder.cpp:80
@@ -79,1 +79,3 @@
TypeBeginLoc, 0, Context.getSourceManager(), Context.getLangOpts());
+if (const auto *TemplateTypeParm =
dyn_cast(Loc.getType())) {
+ return setResult(TemplateTypeParm->ge
bcraig added a comment.
I am going to submit the code changes and the tests independently. I'm having
trouble getting cmake to use the right compiler for the libcxx-benchmarks
target.
https://reviews.llvm.org/D22470
___
cfe-commits mailing list
c
Hi Erik,
with this change clangs warns on this program:
$ cat test.mm
#import
@interface AXPlatformNodeCocoa : NSObject
@end
@implementation AXPlatformNodeCocoa
- (NSArray*)accessibilityAttributeNames {
NSArray* const kTextfieldAttributes = @[
NSAccessibilityPlaceholderValueAttribute,
];
rnk added a comment.
I think the correctness problem is in DSE. It should be safe for clang to put
'tail' here. The tail call does not capture the address of any local variables,
but it does load from them via 'byval'.
https://reviews.llvm.org/D22900
rnk added a comment.
I think Nick was responsible for adding this DSE optimization *years* ago.
https://reviews.llvm.org/D22900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bcraig
Date: Mon Aug 1 12:51:26 2016
New Revision: 277357
URL: http://llvm.org/viewvc/llvm-project?rev=277357&view=rev
Log:
Improve shared_ptr dtor performance
If the last destruction is uncontended, skip the atomic store on
__shared_weak_owners_. This shifts some costs from normal
share
bcraig closed this revision.
bcraig added a comment.
committed https://reviews.llvm.org/rL277357: Improve shared_ptr dtor
performance.
https://reviews.llvm.org/D22470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
LokiAstari added a comment.
@djasper@klimek
Just want to bring this to the top of your queue again :-)
Any further thoughts on the processes?
Loki
https://reviews.llvm.org/D22505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Hi Xiuli,
Could you please elaborate what do you think it broken exactly?
Because we haven't actually removed opencl.kernels metadata but just changed
the format of it.
Basically, we are using function metadata instead of generic metadata as it was
before.
Thanks,
Anastasia
-Original Me
jfb updated this revision to Diff 66342.
jfb added a comment.
- Move atomics.align to libcxx-specific
- Give names to anonymous structs
- Rename test, use REQUIRES / RUN commands
https://reviews.llvm.org/D22073
Files:
test/libcxx/atomics/atomics.align/align.pass.sh.cpp
Index: test/libcxx/ato
jfb added a comment.
In https://reviews.llvm.org/D22073#486636, @EricWF wrote:
> OK, IMO the way to handle this test is to have it manually link `-latomic`.
> This can be done by renaming the test to `.sh.cpp` and adding the
> following lines:
>
> // REQUIRES: libatomic
> // RUN: %build -la
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D22927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
include-fixer will firstly try to use scoped namespace context information to
search identifier. However, in some cases, it's unsafe to do nested class
search, because it might treat the identif
Author: evandro
Date: Mon Aug 1 13:39:55 2016
New Revision: 277365
URL: http://llvm.org/viewvc/llvm-project?rev=277365&view=rev
Log:
[AArch64] Add support for Samsung Exynos M2 (NFC).
Modified:
cfe/trunk/test/CodeGen/arm-target-features.c
cfe/trunk/test/Driver/aarch64-cpus.c
cfe/trun
JDevlieghere updated this revision to Diff 66350.
JDevlieghere added a comment.
Addressed comments from Piotr Padlewski
Repository:
rL LLVM
https://reviews.llvm.org/D22725
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseAl
erik.pilkington created this revision.
erik.pilkington added reviewers: manmanren, thakis.
erik.pilkington added a subscriber: cfe-commits.
As of r277058, Clang would incorrectly emit -Wpartial-availability for the
following (when compiled with -mmacosx-verison-min=10.6):
```
int fn_10_5() __att
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks for the quick fix!
https://reviews.llvm.org/D23024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Author: rnk
Date: Mon Aug 1 13:56:13 2016
New Revision: 277367
URL: http://llvm.org/viewvc/llvm-project?rev=277367&view=rev
Log:
[codeview] Skip injected class names in nested record emission
We were already trying to do this, but our check wasn't quite right.
Fixes PR28790
Added:
cfe/trun
ariccio added a comment.
Bump?
https://reviews.llvm.org/D18073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jfb
Date: Mon Aug 1 14:27:08 2016
New Revision: 277368
URL: http://llvm.org/viewvc/llvm-project?rev=277368&view=rev
Log:
libc++: test lock-free atomic alignment
Summary:
libc++ implements std::atomic<_Tp> using __atomic_base<_Tp> with
`mutable _Atomic(_Tp) __a_`. That member must be suit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277368: libc++: test lock-free atomic alignment (authored by
jfb).
Changed prior to commit:
https://reviews.llvm.org/D22073?vs=66342&id=66356#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22073
Prazek added a comment.
In https://reviews.llvm.org/D22725#502374, @JDevlieghere wrote:
> Addressed comments from Piotr Padlewski
>
> LLVM compiles with the latest version of this check, however some tests are
> failing. I'll investigate the cause of this and update this check if it can
> be pr
I forwarded your the thread for the DSE path. Even my original intent for was a
short-term bandage and by no means a long term fix.
> On Aug 1, 2016, at 10:53 AM, Reid Kleckner wrote:
>
> rnk added a comment.
>
> I think the correctness problem is in DSE. It should be safe for clang to put
>
1 - 100 of 150 matches
Mail list logo
