[libcxx] r277235 - Creating release directory for release_390.

2016-07-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jul 29 17:48:17 2016 New Revision: 277235 URL: http://llvm.org/viewvc/llvm-project?rev=277235&view=rev Log: Creating release directory for release_390. Added: libcxx/tags/RELEASE_390/ ___ cfe-commits mailing list cfe-commits@

[libcxxabi] r277237 - Creating release directory for release_390.

2016-07-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jul 29 17:48:24 2016 New Revision: 277237 URL: http://llvm.org/viewvc/llvm-project?rev=277237&view=rev Log: Creating release directory for release_390. Added: libcxxabi/tags/RELEASE_390/ ___ cfe-commits mailing list cfe-commi

[libcxxabi] r277238 - Creating release candidate rc1 from release_390 branch

2016-07-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jul 29 17:48:26 2016 New Revision: 277238 URL: http://llvm.org/viewvc/llvm-project?rev=277238&view=rev Log: Creating release candidate rc1 from release_390 branch Added: libcxxabi/tags/RELEASE_390/rc1/ - copied from r277237, libcxxabi/branches/release_39/ ___

[libunwind] r277249 - Creating release directory for release_390.

2016-07-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jul 29 17:48:51 2016 New Revision: 277249 URL: http://llvm.org/viewvc/llvm-project?rev=277249&view=rev Log: Creating release directory for release_390. Added: libunwind/tags/RELEASE_390/ ___ cfe-commits mailing list cfe-commi

[libunwind] r277250 - Creating release candidate rc1 from release_390 branch

2016-07-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jul 29 17:48:54 2016 New Revision: 277250 URL: http://llvm.org/viewvc/llvm-project?rev=277250&view=rev Log: Creating release candidate rc1 from release_390 branch Added: libunwind/tags/RELEASE_390/rc1/ (props changed) - copied from r277249, libunwind/branches/re

Re: [PATCH] D22668: TrailingObjects::FixedSizeStorage constexpr fixes

2016-07-29 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast updated this revision to Diff 66194. hubert.reinterpretcast added a comment. Make FixedSizeStorage accessible to test code FixedSizeStorage and not FixedSizeStorageOwner is what the test code needs. Use alias template to avoid issues with MSVC. https://reviews.llvm.org/D

Re: [PATCH] D22668: TrailingObjects::FixedSizeStorage constexpr fixes

2016-07-29 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D22668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D22982: [CloneDetector] No longer reporting clones that don't have a common referenced variable pattern.

2016-07-29 Thread Raphael Isemann via cfe-commits
teemperor created this revision. teemperor added reviewers: v.g.vassilev, NoQ, zaks.anna. teemperor added a subscriber: cfe-commits. One of the current false-positives the CloneDetector produces is that the statements `a < b ? b` and `b < a ? b` are considered clones of each other, even though t

Re: r277221 - Remove unused variable.

2016-07-29 Thread Eric Christopher via cfe-commits
Hi Hans, Can you make sure this makes it into 3.9 please? Thanks! -eric On Fri, Jul 29, 2016 at 3:18 PM Eric Christopher via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: echristo > Date: Fri Jul 29 17:11:11 2016 > New Revision: 277221 > > URL: http://llvm.org/viewvc/llvm-project?

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

2016-07-29 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216 @@ +215,3 @@ +llvm::raw_svector_ostream warning(buf); +warning << "warning: Path diagnostic report is not generated. Current " +<< "output format does not support diagno

Re: [PATCH] D22862: [analyzer] Fix for PR15623: eliminate unwanted ProgramState checker data propagation.

2016-07-29 Thread Devin Coughlin via cfe-commits
dcoughlin added a comment. As PR15623 shows, returning the existing cast is not correct. But rather than replace it with an unknown, here is a proposal for how to address this without regressing in precision. Instead of using `assumeDual()` in `ExprEngine::VisitLogicalExpr()` on the `RHSVal` a

Re: [PATCH] D22810: scan-build: Add an option to show the description in the list of defect

2016-07-29 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Ok. LGTM. Thank you! Anna. https://reviews.llvm.org/D22810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

Re: [PATCH] D22926: Static Analyzer - Localizability Checker: New Localizable APIs for macOS Sierra

2016-07-29 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM Thank you! https://reviews.llvm.org/D22926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D20811: [analyzer] Model some library functions

2016-07-29 Thread Anna Zaks via cfe-commits
zaks.anna added a subscriber: Alexander_Droste. zaks.anna added a comment. > Even though there are some doxygen-style comments in the checkers, i’ve never > seen doxygen actually generate any docs for checker classes. > Are they useful for IDE quick-hints only? I think it's useful to have co

Re: [PATCH] D20811: [analyzer] Model some library functions

2016-07-29 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:206 @@ +205,3 @@ +: Call.getArgExpr(ArgNo)->getType().getCanonicalType(); + } + static QualType getArgType(const CallExpr *CE, ArgNoTy ArgNo) { ---

r277256 - Fix VS2013 build of CGOpenMPRuntime.cpp

2016-07-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Jul 29 19:41:37 2016 New Revision: 277256 URL: http://llvm.org/viewvc/llvm-project?rev=277256&view=rev Log: Fix VS2013 build of CGOpenMPRuntime.cpp It seems the compiler was getting confused by the in-class initializers in local struct MapInfo, so moving those to a default

Re: [PATCH] D22856: [analyzer] Change -analyze-function to accept qualified names.

2016-07-29 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Since this is an improvement, it looks good to me. (Improving printing of ObjC methods is a good add on, but not blocking..) https://reviews.llvm.org/D22856 _

Re: r276977 - [OpenMP] Codegen for use_device_ptr clause.

2016-07-29 Thread Hans Wennborg via cfe-commits
It seems the compiler was getting thrown off by the in-class initializers of the local MapInfo struct. I've tried to work around this in r277256. Hopefully this will make the buildbots happier. Cheers, Hans On Fri, Jul 29, 2016 at 2:20 PM, Samuel F Antao wrote: > Hi Hans, > > Thanks for the trou

Re: [PATCH] D22982: [CloneDetector] No longer reporting clones that don't have a common referenced variable pattern.

2016-07-29 Thread Vedant Kumar via cfe-commits
vsk added a subscriber: vsk. vsk added a comment. This is neat! I may be missing something, but could you explain why 'false-positives.cpp' was deleted? I'd expect the test to be incorporated into 'functions.cpp' with the 'expected-*' directives removed. Comment at: lib/Analy

r277261 - [c-index-test] Make sure to check that clang_Cursor_getNumTemplateArguments did not return -1.

2016-07-29 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Fri Jul 29 21:20:21 2016 New Revision: 277261 URL: http://llvm.org/viewvc/llvm-project?rev=277261&view=rev Log: [c-index-test] Make sure to check that clang_Cursor_getNumTemplateArguments did not return -1. Modified: cfe/trunk/tools/c-index-test/c-index-test.c Modif

<    1   2