Author: eugenezelenko
Date: Thu Jul 21 19:34:42 2016
New Revision: 276371
URL: http://llvm.org/viewvc/llvm-project?rev=276371&view=rev
Log:
Restructure release notes.
Differential revision: https://reviews.llvm.org/D22605
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276371: Restructure release notes. (authored by
eugenezelenko).
Changed prior to commit:
https://reviews.llvm.org/D22605?vs=64806&id=65003#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22605
Fi
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Full context diffs, please. See
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
Repository:
rL LLVM
https://reviews.llvm.org/D22656
___
Eugene.Zelenko updated this revision to Diff 65004.
Eugene.Zelenko added a comment.
Full context diff.
Repository:
rL LLVM
https://reviews.llvm.org/D22656
Files:
clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp
Index: clang-apply-replacements/tool/ClangApplyReplacementsMain.cp
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:45
@@ -33,3 +44,3 @@
hasDeclaration(functionDecl(hasName("push_back"))),
- on(hasType(cxxRecordDecl(hasAnyName("std::vector",
Prazek added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:45
@@ -33,3 +44,3 @@
hasDeclaration(functionDecl(hasName("push_back"))),
- on(hasType(cxxRecordDecl(hasAnyName("std::vector", "llvm::SmallVector",
-
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:45
@@ -33,3 +44,3 @@
hasDeclaration(functionDecl(hasName("push_back"))),
- on(hasType(cxxRecordDecl(hasAnyName("std::vector", "llvm::SmallVector",
-
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-rename/USRFinder.cpp:81
@@ +80,3 @@
+const auto TypeEndLoc = Loc.getEndLoc(),
+ TypeBeginLoc = Lexer::GetBeginningOfToken(
+ TypeEndLoc,
Prazek added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:112
@@ -95,1 +111,3 @@
+ auto CtorCallSourceRange = CharSourceRange::getTokenRange(
+ InnerCtorCall->getExprLoc(), CallParensRange.getBegin());
alexfh wrote:
> > There is a
Prazek added a comment.
There is one bug left:
In the ClangIncludeFixer.cpp:169 there is push back that looks like this
Symbols.push_back(find_all_symbols::SymbolInfo(
Split.first.trim(),
find_all_symbols::SymbolInfo::SymbolKind::Unknown,
CommaSplits[I].trim(), 1, {}, /*NumOccurrences=*/E
Prazek added a subscriber: klimek.
Prazek added a comment.
Can you look at my previous comment? I nedd an expert for AST.
Repository:
rL LLVM
https://reviews.llvm.org/D22208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Prazek removed rL LLVM as the repository for this revision.
Prazek updated this revision to Diff 65023.
Prazek marked 4 inline comments as done.
https://reviews.llvm.org/D22208
Files:
clang-tidy/modernize/UseEmplaceCheck.cpp
clang-tidy/modernize/UseEmplaceCheck.h
clang-tidy/utils/Matchers.h
zlei created this revision.
zlei added reviewers: cfe-commits, ddunbar, Hahnfeld.
This patch introduces a new cmake variable: CLANG_DEFAULT_RTLIB, thru
which we can specify a default value for -rtlib (libgcc or
compiler-rt) at build time, just like how we set the default C++
stdlib thru CLANG_DEFA
Prazek marked 6 inline comments as done.
Prazek added a comment.
Repository:
rL LLVM
https://reviews.llvm.org/D22208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added a comment.
Is it in upstream yet?
Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.h:19
@@ +18,3 @@
+
+/// Flags slicing of member variables or vtable. See:
+/// -
courbet wrote:
> Prazek wrote:
> > some short description what does this check
faisalv updated this revision to Diff 65026.
faisalv added a comment.
Factor out the diagnostic builder RAII creation (through Sema.Diag) and reduce
repetition.
https://reviews.llvm.org/D22662
Files:
include/clang/AST/DeclCXX.h
lib/Sema/SemaType.cpp
test/SemaCXX/cxx1z-constexpr-lambdas.c
mclow.lists added inline comments.
Comment at: include/string_view:216
@@ +215,3 @@
+ basic_string_view(const _CharT* __s)
+ : __data(__s), __size(_Traits::length(__s)) {}
+
kimgr wrote:
> mclow.lists wrote:
> > mclow.lists wrote:
> > > kimgr w
klimek added inline comments.
Comment at: clang-rename/RenamingAction.cpp:48
@@ +47,3 @@
+for (unsigned I = 0; I < NewNameList.size(); ++I) {
+ HandleOneRename(Context, NewNameList[I], PrevNameList[I], USRList[I]);
+}
Question is whether if we go down
rsmith added a comment.
Everything other than the diagnostics change LGTM; can we handle the
diagnostics change as a central patch and put this fallback logic directly into
the diagnostics formatting code, so it applies everywhere we try to print the
name of an unnamed class?
101 - 119 of 119 matches
Mail list logo
