Re: [PATCH] D21992: [clang-tidy] new cppcoreguidelines-slicing

courbet updated this revision to Diff 64642. courbet added a comment. rebase https://reviews.llvm.org/D21992 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguidelines/SlicingCheck.cpp clang-tidy/cppcoregu

Re: [PATCH] D21992: [clang-tidy] new cppcoreguidelines-slicing

Prazek added a subscriber: Prazek. Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.cpp:30 @@ +29,3 @@ + // or + // - B does not define any additional members (either variables or + // overrides) wrt A. What is A and what is B? I guess you are missin

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

jlebar added a comment. In https://reviews.llvm.org/D22463#489461, @rengolin wrote: > You will not be required to use submodules at all, as we'll all use the > individual projects, like we have always been. I don't understand why people > keep going back to it. There is a key use case that is

Re: [PATCH] D21992: [clang-tidy] new cppcoreguidelines-slicing

courbet marked an inline comment as done. Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.h:19 @@ +18,3 @@ + +/// Flags slicing of member variables or vtable. See: +/// - Prazek wrote: > some short description what does this check do? There is already a mo

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

delena added a comment. #include in the test is not clear for me. Does it mean that you broke backward compatibility? Comment at: lib/CodeGen/CGBuiltin.cpp:6779 @@ -6776,1 +6778,3 @@ } + case X86::BI__builtin_ia32_xgetbv: { +return Builder.CreateCall(CGM.getIntrinsic(In

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin added a comment. In https://reviews.llvm.org/D22463#489483, @jlebar wrote: > Again, we can make this work with submodules, but it's a giant pain, see my > earlier comment. (...) > I've read as many of these as I can find in the past few hours, and every > argument I have found is, i

[clang-tools-extra] r276096 - [include-fixer] Tweak: remove unintended const.

Author: hokein Date: Wed Jul 20 04:00:22 2016 New Revision: 276096 URL: http://llvm.org/viewvc/llvm-project?rev=276096&view=rev Log: [include-fixer] Tweak: remove unintended const. Modified: clang-tools-extra/trunk/include-fixer/IncludeFixerContext.cpp clang-tools-extra/trunk/include-fixe

[clang-tools-extra] r276098 - [include-fixer] Make error messages a bit prettier and make sure to

Author: d0k Date: Wed Jul 20 04:12:19 2016 New Revision: 276098 URL: http://llvm.org/viewvc/llvm-project?rev=276098&view=rev Log: [include-fixer] Make error messages a bit prettier and make sure to include a newline at the end. Modified: clang-tools-extra/trunk/include-fixer/tool/ClangInclude

Re: [PATCH] D22465: [clang-rename] introduce better symbol finding and add few more tests

omtcyfz added a comment. Can anyone please take a look at this? My current work is based on this patch and I'd be happy to know I'm doing things right :) https://reviews.llvm.org/D22465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

r276102 - [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

Author: rksimon Date: Wed Jul 20 05:18:01 2016 New Revision: 276102 URL: http://llvm.org/viewvc/llvm-project?rev=276102&view=rev Log: [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR D20859 and D20860 attempted to replace the SSE (V)CVTTPS2DQ and VCVTTPD2DQ tru

Re: [PATCH] D22105: [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

This revision was automatically updated to reflect the committed changes. Closed by commit rL276102: [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using… (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D22105?vs=64534&id=64653#toc Repository: rL L

Re: [PATCH] D21472: [clang-tidy] readability-identifier-naming - support for other case types

JamesReynolds added a comment. Thank you! Can you land this for me please? This is me done for the time being, but once our implementation gets into the swing of things I'll try and start picking up some bugs / enhancements. https://reviews.llvm.org/D21472 __

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated this revision to Diff 64663. a.sidorin added a comment. An attempt to fix unit test on Windows. Serge, thank you! Could you please check this patch again? https://reviews.llvm.org/D14326 Files: include/clang/AST/ASTImporter.h include/clang/AST/DeclFriend.h lib/AST/ASTImp

[PATCH] D22566: Make RecursiveASTVisitor visit lambda capture initialization expressions

mboehme created this revision. mboehme added a reviewer: klimek. mboehme added a subscriber: cfe-commits. Herald added a subscriber: klimek. Lambda capture initializations are part of the explicit source code and therefore should be visited by default but, so far, RecursiveASTVisitor does not vi

Re: [PATCH] D22465: [clang-rename] introduce better symbol finding and add few more tests

omtcyfz updated this revision to Diff 64668. omtcyfz added a comment. add support for renaming inside NestedNameSpecifier's https://reviews.llvm.org/D22465 Files: clang-rename/RenamingAction.cpp clang-rename/USRFinder.cpp clang-rename/USRFinder.h clang-rename/USRLocFinder.cpp test/cla

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

guyblank added a comment. the include is because i added calls to the intrinsics themselves in the test, no just the builtins. Comment at: lib/Headers/intrin.h:905 @@ -906,9 +904,3 @@ } -static __inline__ unsigned __int64 __cdecl __DEFAULT_FN_ATTRS -_xgetbv(unsigned int __xcr

Re: [PATCH] D22566: Make RecursiveASTVisitor visit lambda capture initialization expressions

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D22566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang-tools-extra] r276110 - [clang-tidy] readability-identifier-naming - support for other case types

Author: omtcyfz Date: Wed Jul 20 07:28:38 2016 New Revision: 276110 URL: http://llvm.org/viewvc/llvm-project?rev=276110&view=rev Log: [clang-tidy] readability-identifier-naming - support for other case types Added Camel_Snake_Case and camel_Snake_Back class Camel_Snake_Case_Class_Name { void p

Re: [PATCH] D21472: [clang-tidy] readability-identifier-naming - support for other case types

This revision was automatically updated to reflect the committed changes. Closed by commit rL276110: [clang-tidy] readability-identifier-naming - support for other case types (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D21472?vs=63462&id=64671#toc Repository: rL

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

v.g.vassilev requested changes to this revision. v.g.vassilev added a comment. I guess the question about the binary size holds here, too. What would be the impact on the binary size? Comment at: lib/Analysis/CloneDetection.cpp:104 @@ +103,3 @@ +/// defines what a 'similar' clo

[clang-tools-extra] r276111 - clang-tidy modernize-loop-convert: preserve type of alias declaration (bug 28341)

Author: mgehre Date: Wed Jul 20 07:32:06 2016 New Revision: 276111 URL: http://llvm.org/viewvc/llvm-project?rev=276111&view=rev Log: clang-tidy modernize-loop-convert: preserve type of alias declaration (bug 28341) Summary: Previoly, the added test failed with the fillowing fixit: char v[5

Re: [PATCH] D22069: clang-tidy modernize-loop-convert: preserve type of alias declaration (bug 28341)

This revision was automatically updated to reflect the committed changes. Closed by commit rL276111: clang-tidy modernize-loop-convert: preserve type of alias declaration (bug… (authored by mgehre). Changed prior to commit: https://reviews.llvm.org/D22069?vs=63400&id=64672#toc Repository: rL

Re: [PATCH] D21748: Implement tooling::Replacements as a class.

ioeric added a comment. Ping https://reviews.llvm.org/D21748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21748: Implement tooling::Replacements as a class.

klimek added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:145 @@ -145,4 +144,3 @@ -/// \brief A set of Replacements. -/// FIXME: Change to a vector and deduplicate in the RefactoringTool. -typedef std::set Replacements; +/// \brief This maintains a set o

Re: [PATCH] D21748: Implement tooling::Replacements as a class.

ioeric updated this revision to Diff 64675. ioeric marked 5 inline comments as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D21748 Files: include/clang/Tooling/Core/Replacement.h include/clang/Tooling/Refactoring.h lib/Format/Format.cpp lib/Format/

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. I'm auto accepting this proposal, as it seems to have ran its course. The commit is r276097. If anyone has any additional comment/suggestion, please su

[PATCH] D22567: [include-fixer] Add mising qualifiers to all instances of an unidentified symbol.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D22567 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.cpp include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp

Re: [libcxx] r276003 - Fix undefined behavior in __tree

On Wed, Jul 20, 2016 at 1:42 AM, Marshall Clow wrote: > > > On Tue, Jul 19, 2016 at 11:06 AM, Eric Fiselier wrote: >> >> @Hans. This needs to be merged into 3.9. It fixes PR28469 which is a >> release blocker. > > > I'm fine with this. Thanks! Eric, go ahead and merge this, or let me know if you

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated this revision to Diff 64676. a.sidorin added a comment. Removed unneeded matcher. https://reviews.llvm.org/D14326 Files: include/clang/AST/ASTImporter.h include/clang/AST/DeclFriend.h lib/AST/ASTImporter.cpp test/ASTMerge/Inputs/class3.cpp test/ASTMerge/Inputs/exprs3

Re: [PATCH] D22567: [include-fixer] Add mising qualifiers to all instances of an unidentified symbol.

ioeric added a subscriber: ioeric. Comment at: include-fixer/tool/ClangIncludeFixer.cpp:365 @@ +364,3 @@ + for (const auto &Info : Context.getQuerySymbolInfos()) { +Replacements->insert({FilePath, Info.Range.getOffset(), + Info.Range.getLength(),

Re: [PATCH] D21970: Add attribute abi_tag to the release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL276113: Add attribute abi_tag to the release notes (authored by hans). Changed prior to commit: https://reviews.llvm.org/D21970?vs=62673&id=64678#toc Repository: rL LLVM https://reviews.llvm.org/D21

Re: [PATCH] D21970: Add attribute abi_tag to the release notes

hans added a comment. Committed r276113. Thanks! Repository: rL LLVM https://reviews.llvm.org/D21970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22567: [include-fixer] Add mising qualifiers to all instances of an unidentified symbol.

bkramer added inline comments. Comment at: include-fixer/IncludeFixer.cpp:246 @@ +245,3 @@ +if (!QuerySymbolInfos.empty()) { + if (ScopedQualifiers.str() == QuerySymbolInfos.front().ScopedQualifiers && + Query.str() == QuerySymbolInfos.front().RawIdentifier) { -

Re: [clang-tools-extra] r275943 - clang-rename: fix referenced variable in vim-script

Sure, r276115. Thanks, Hans On Mon, Jul 18, 2016 at 10:22 PM, Saleem Abdulrasool wrote: > Hey Hans, > > I think that we should get this merged into 3.9. Its a trivial fix and > makes the script usable if you set g:clang_rename_path. > > Thanks! > > On Mon, Jul 18, 2016 at 7:13 PM, Saleem Abdulr

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:6945 @@ +6944,3 @@ + // get the integer literal. + Init = cast(const_cast( +Var->getInit()))->getSubExpr(); What if global variable sampler is initialized with another

r276120 - [MS] Improve VPtrInfo field names and doc comments

Author: rnk Date: Wed Jul 20 09:40:25 2016 New Revision: 276120 URL: http://llvm.org/viewvc/llvm-project?rev=276120&view=rev Log: [MS] Improve VPtrInfo field names and doc comments 'ReusingBase' was a terrible name. It might actually refer to the most derived class, which is not a base. 'BaseWith

Re: [PATCH] D22523: [OpenCL] AMDGCN target will generate images in constant address space

Anastasia accepted this revision. Anastasia added a comment. LGTM! Comment at: lib/CodeGen/TargetInfo.cpp:6868 @@ +6867,3 @@ +unsigned AMDGPUTargetCodeGenInfo::getOpenCLImageAddrSpace(CodeGen::CodeGenModule &CGM) const { + return CGM.getContext().getTargetAddressSpace(LangAS:

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl added inline comments. Comment at: lib/Sema/SemaInit.cpp:6945 @@ +6944,3 @@ + // get the integer literal. + Init = cast(const_cast( +Var->getInit()))->getSubExpr(); Anastasia wrote: > What if global variable sampler is initiali

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

jlebar added a comment. Hi, Renato. Just to explain why I'm going to go forward with this RFC about a monolithic repository: From speaking with some top contributors on IRC, I have heard that they feel that the discussion of whether to move to git has been conflated with the discussion of how

[libunwind] r276128 - libunwind: limit stack usage in unwind cursor

Author: emaste Date: Wed Jul 20 10:19:09 2016 New Revision: 276128 URL: http://llvm.org/viewvc/llvm-project?rev=276128&view=rev Log: libunwind: limit stack usage in unwind cursor Obtained from FreeBSD SVN r302475 Differential Revision: https://reviews.llvm.org/D22570 Modified: libunwind/tr

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

sepavloff added a comment. With this patch unit tests pass on Windows as well. I do not have formal authority to approve patches, but for me the patch is good enough to be accepted. Comment at: lib/AST/ASTImporter.cpp:3422 @@ +3421,3 @@ + D->getTrailingObjects(); + for (i

Buildmaster restart in few minutes

Hello everyone, LLVM buildmaster will be restarted in few minutes. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r202329 - Add a 'use-external-names' option to VFS overlay files

> On Jul 18, 2016, at 3:21 PM, Richard Smith wrote: > > On Wed, Feb 26, 2014 at 4:25 PM, Ben Langmuir > wrote: > Author: benlangmuir > Date: Wed Feb 26 18:25:12 2014 > New Revision: 202329 > > URL: http://llvm.org/viewvc/llvm-project?rev=202329&view=rev >

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated this revision to Diff 64704. a.sidorin added a comment. Fix signed/unsigned mismatch warning in the loop condition. https://reviews.llvm.org/D14326 Files: include/clang/AST/ASTImporter.h include/clang/AST/DeclFriend.h lib/AST/ASTImporter.cpp test/ASTMerge/Inputs/class3

Re: [PATCH] D22523: [OpenCL] AMDGCN target will generate images in constant address space

ashi1 updated this revision to Diff 64706. ashi1 marked an inline comment as done. ashi1 added a comment. Removed excess semicolon by Anastasia's comments Repository: rL LLVM https://reviews.llvm.org/D22523 Files: lib/CodeGen/CGOpenCLRuntime.cpp lib/CodeGen/TargetInfo.cpp lib/CodeGen/T

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

emaste added a comment. Is this going to be committed? Libunwind is about to grow the same alignment attribute (https://reviews.llvm.org/D22543) https://reviews.llvm.org/D12512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

danalbert added a comment. The configure-time check LGTM. Android has it for all recent versions (since JB), but that will cover the case of GB and ICS. Comment at: src/cxa_exception.cpp:127 @@ +126,3 @@ +// on 32 bit targets. +ptr = std::malloc(size); +#endif -

Re: [PATCH] D21145: [Sema] Fix crash on valid where instantiation of lambda cannot access type of 'this'

erik.pilkington added a comment. Ping! https://reviews.llvm.org/D21145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22577: Include unreferenced nested types in member list only for CodeView

amccarth created this revision. amccarth added reviewers: rnk, dblaikie. amccarth added a subscriber: cfe-commits. Unreferenced nested structs and classes were omitted from the debug info. In DWARF, this was intentional, to avoid bloat. But, for CodeView, we want this information to be consist

Re: [PATCH] D22577: Include unreferenced nested types in member list only for CodeView

rnk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1096 @@ +1095,3 @@ + QualType Ty = CGM.getContext().getTypeDeclType(RD); + llvm::DIType *nestedType = getOrCreateType(Ty, getOrCreateMainFile()); + elements.push_back(nestedType); Is getOrCreate

r276152 - Fix modules self-host: add missing include and forward-decl.

Author: rsmith Date: Wed Jul 20 13:28:19 2016 New Revision: 276152 URL: http://llvm.org/viewvc/llvm-project?rev=276152&view=rev Log: Fix modules self-host: add missing include and forward-decl. Modified: cfe/trunk/include/clang/Lex/PTHManager.h Modified: cfe/trunk/include/clang/Lex/PTHManage

Re: [PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

jfb added a subscriber: jfb. jfb added a comment. Awesome, thanks for doing this! Should this be a warning or an error? Comment at: include/atomic:581 @@ +580,3 @@ + || __f == memory_order_acq_rel, ""))) \ +__attribute__ ((__unavailabl

Re: [PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

bcraig added a subscriber: bcraig. Comment at: include/atomic:569 @@ +568,3 @@ +__attribute__ ((__enable_if__(__m == memory_order_release \ + || __m == memory_order_acq_rel, ""))) \ +__attribute__ ((__unavailable__("me

r276159 - [modules] Don't emit initializers for VarDecls within a module eagerly whenever

Author: rsmith Date: Wed Jul 20 14:10:16 2016 New Revision: 276159 URL: http://llvm.org/viewvc/llvm-project?rev=276159&view=rev Log: [modules] Don't emit initializers for VarDecls within a module eagerly whenever we first touch any part of that module. Instead, defer them until the first time that

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl updated this revision to Diff 64724. yaxunl added a comment. Added more diagnostic tests. https://reviews.llvm.org/D21567 Files: include/clang/AST/OperationKinds.def include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/AST/ASTContext.cpp lib/AS

r276161 - [OpenCL] AMDGCN target will generate images in constant address space

Author: yaxunl Date: Wed Jul 20 14:21:11 2016 New Revision: 276161 URL: http://llvm.org/viewvc/llvm-project?rev=276161&view=rev Log: [OpenCL] AMDGCN target will generate images in constant address space Allows AMDGCN target to generate images (such as %opencl.image2d_t) in constant address space

Re: [PATCH] D22523: [OpenCL] AMDGCN target will generate images in constant address space

This revision was automatically updated to reflect the committed changes. Closed by commit rL276161: [OpenCL] AMDGCN target will generate images in constant address space (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D22523?vs=64706&id=64729#toc Repository: rL LLVM

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper added a comment. PING Comment at: lib/Format/WhitespaceManager.cpp:95 @@ -97,2 +94,3 @@ std::sort(Changes.begin(), Changes.end(), Change::IsBeforeInFile(SourceMgr)); + calculateScopeLevel(); calculateLineBreakInformation(); berenm wrote: > Maybe

r276167 - [OpenMP] Ignore parens in atomic capture

Author: kli Date: Wed Jul 20 14:41:17 2016 New Revision: 276167 URL: http://llvm.org/viewvc/llvm-project?rev=276167&view=rev Log: [OpenMP] Ignore parens in atomic capture Clang misdiagnoses atomic captures cases that contains parens. i.e. int v, int *p; #pragma omp atomic capture { v = (*p); (

Re: [PATCH] D22487: [OpenMP] Ignore parens in atomic capture

This revision was automatically updated to reflect the committed changes. Closed by commit rL276167: [OpenMP] Ignore parens in atomic capture (authored by kli). Changed prior to commit: https://reviews.llvm.org/D22487?vs=64416&id=64732#toc Repository: rL LLVM https://reviews.llvm.org/D22487

Re: [PATCH] D22439: Add missing includes.

rsmith added a comment. ManagedStatic.h already includes , so the additional includes of don't seem appropriate to me. Looks like this may have hit a bug in enum merging? https://reviews.llvm.org/D22439 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D22587: [ASTContext] Fix part of DR224 for nontype template arguments

mgehre created this revision. mgehre added reviewers: klimek, aaron.ballman, rsmith. mgehre added a subscriber: cfe-commits. Look through expressions to determine if a nontype template argument has been given the value of the template parameter. https://reviews.llvm.org/D22587 Files: lib/AST/

r276177 - [OpenMP] Allow negative lower bound in array sections based on pointers

Author: kli Date: Wed Jul 20 15:45:29 2016 New Revision: 276177 URL: http://llvm.org/viewvc/llvm-project?rev=276177&view=rev Log: [OpenMP] Allow negative lower bound in array sections based on pointers OpenMP 4.5 removed the restriction that array section lower bound must be non negative. This c

Re: [PATCH] D22481: [OpenMP] Allow negative lower bound in array sections based on pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rL276177: [OpenMP] Allow negative lower bound in array sections based on pointers (authored by kli). Changed prior to commit: https://reviews.llvm.org/D22481?vs=64389&id=64754#toc Repository: rL LLVM

r276180 - When copying an array into a lambda, destroy temporaries from

Author: rjmccall Date: Wed Jul 20 16:02:43 2016 New Revision: 276180 URL: http://llvm.org/viewvc/llvm-project?rev=276180&view=rev Log: When copying an array into a lambda, destroy temporaries from the copy-constructor immediately and enter a partial array cleanup for previously-copied elements. F

[PATCH] D22593: [Profile] document %h and %m

davidxl created this revision. davidxl added reviewers: vsk, silvas. davidxl added a subscriber: cfe-commits. Added documentation for %h and %m specifiers. %m specifier which specifies the number of copies is not documented yet (treated as internal for now) https://reviews.llvm.org/D22593 File

Re: [PATCH] D22593: [Profile] document %h and %m

davidxl updated this revision to Diff 64759. davidxl added a comment. Fixed a typo https://reviews.llvm.org/D22593 Files: docs/UsersManual.rst Index: docs/UsersManual.rst === --- docs/UsersManual.rst +++ docs/UsersManual.rst @@

Re: [PATCH] D22577: Include unreferenced nested types in member list only for CodeView

amccarth updated this revision to Diff 64761. amccarth added a comment. Addressed feedback. https://reviews.llvm.org/D22577 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-dup-fwd-decl.cpp test/CodeGenCXX/debug-info-ms-abi.cpp test/Modules/Modul

Re: [PATCH] D22577: Include unreferenced nested types in member list only for CodeView

amccarth marked 2 inline comments as done. amccarth added a comment. https://reviews.llvm.org/D22577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r276092 - Unbreak is_constructible tests for Clang <= 3.7.

Hi Eric, I'm seeing failures on the builders that look like they're related to this - http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-expensive/359/ Could you look in to what's going on here? - Lang. On Tue, Jul 19, 2016 at 11:36 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.l

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

emaste added a comment. As it happens on FreeBSD/i386 malloc returns a 16-byte-aligned pointer for allocations with size >= 16 so will not be affected by this issue. https://reviews.llvm.org/D12512 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

emaste added inline comments. Comment at: test/test_cxa_allocate_exception.pass.cpp:34 @@ +33,3 @@ +const std::size_t required_alignment = alignof(__cxa_exception); +const bool requires_over_alignment = max_alignment < required_alignment; + `requires_over_alignmen

Re: [PATCH] D22577: Include unreferenced nested types in member list only for CodeView

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D22577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22596: Retry: [Driver] Compute effective target triples once per job (NFCI)

vsk created this revision. vsk added reviewers: echristo, dexonsmith. vsk added a subscriber: cfe-commits. Herald added subscribers: mehdi_amini, aemerson. Compute an effective triple once per job. Cache the triple in the prevailing ToolChain for the duration of the job. Clients which need effect

r276188 - Fix memory leak introduced in r276159.

Author: rsmith Date: Wed Jul 20 16:38:26 2016 New Revision: 276188 URL: http://llvm.org/viewvc/llvm-project?rev=276188&view=rev Log: Fix memory leak introduced in r276159. Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/AST/ASTContext.cpp URL: http://llvm.org/viewvc/llvm-

Re: r275895 - [Driver] Compute effective target triples once per job (NFCI)

> On Jul 19, 2016, at 3:53 PM, Eric Christopher wrote: > > > > On Tue, Jul 19, 2016 at 3:51 PM Vedant Kumar wrote: > > > On Jul 19, 2016, at 3:38 PM, Eric Christopher wrote: > > > > > > > > On Tue, Jul 19, 2016 at 3:24 PM Vedant Kumar wrote: > > > > > On Jul 19, 2016, at 3:02 PM, Eric Chri

Re: [PATCH] D22596: Retry: [Driver] Compute effective target triples once per job (NFCI)

mehdi_amini added inline comments. Comment at: include/clang/Driver/ToolChain.h:71 @@ -70,2 +70,3 @@ const llvm::Triple Triple; + mutable llvm::Triple EffectiveTriple; const llvm::opt::ArgList &Args; Documentation would be appreciated, a mutable field is ne

Re: [PATCH] D22476: [AST] Make MemberExpr non-dependent according to core issue 224

mgehre updated this revision to Diff 64777. mgehre added a comment. - Properly check for being member of current instantiation. - Add new testcase test/CXX/temp/temp.res/temp.dep/temp.dep.expr/p5.cpp - Added assert() according to review comment https://reviews.llvm.org/D22476 Files: lib/AST/E

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

LokiAstari added a comment. @djasper@klimek Is that a sufficient example? Or do I need to do some more exhaustive search of github for projects? https://reviews.llvm.org/D22505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

Re: [PATCH] D22426: Fix automatic detection of ARM MSVC toolset in clang.exe

DaveBartolomeo added a comment. Just to make sure I'm clear on the consensus, the new plan is: If clang.exe is x64-hosted and an x64-hosted MSVC toolchain is available, use the x64-hosted MSVC toolchain. Otherwise, use the x86-hosted MSVC toolchain. Right? https://reviews.llvm.org/D22426 _

Re: [PATCH] D22593: [Profile] document %h and %m

silvas added a comment. LGTM with some small wording nits. We may want to extend this to mention number modifier to `%m` (e.g. `%4m`). Perhaps it is better to leave that to more advanced documentation -- your experiments showed that even just 1 merge pool is quite scalable IIRC. =

Re: [libcxx] r276092 - Unbreak is_constructible tests for Clang <= 3.7.

Hi Lang, Sorry about the breakage. I always forget __clang_major__ and __clang_minor__ are useless when dealing with apple-clang. Who can I complain to about that? I'll check in a fix shortly. /Eric On Wed, Jul 20, 2016 at 3:32 PM, Lang Hames wrote: > Hi Eric, > > I'm seeing failures on the b

Re: [PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

jfb added inline comments. Comment at: include/atomic:569 @@ +568,3 @@ +__attribute__ ((__enable_if__(__m == memory_order_release \ + || __m == memory_order_acq_rel, ""))) \ +__attribute__ ((__unavailable__("memory ord

[libcxx] r276200 - Unbreak traits tests by handling differences between version macros in clang/apple-clang.

Author: ericwf Date: Wed Jul 20 17:53:21 2016 New Revision: 276200 URL: http://llvm.org/viewvc/llvm-project?rev=276200&view=rev Log: Unbreak traits tests by handling differences between version macros in clang/apple-clang. Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary

Re: [libcxx] r276092 - Unbreak is_constructible tests for Clang <= 3.7.

I think it should be fixed in r276200. I'll watch the bots. On Wed, Jul 20, 2016 at 4:39 PM, Eric Fiselier wrote: > Hi Lang, > > Sorry about the breakage. I always forget __clang_major__ and > __clang_minor__ are useless when dealing with apple-clang. > Who can I complain to about that? > > I'll

Re: [PATCH] D22593: [Profile] document %h and %m

vsk added a comment. In https://reviews.llvm.org/D22593#490490, @silvas wrote: > LGTM with some small wording nits. > > We may want to extend this to mention number modifier to `%m` (e.g. `%4m`). > Perhaps it is better to leave that to more advanced documentation -- your > experiments showed th

Re: [PATCH] D22596: Retry: [Driver] Compute effective target triples once per job (NFCI)

vsk updated this revision to Diff 64792. vsk added a comment. - Address Mehdi's comments (drop \brief, document a field). - Make ToolChain::setEffectiveTriple() private. https://reviews.llvm.org/D22596 Files: include/clang/Driver/ToolChain.h lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp

Re: [PATCH] D22596: Retry: [Driver] Compute effective target triples once per job (NFCI)

vsk marked 2 inline comments as done. vsk added a comment. https://reviews.llvm.org/D22596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22593: [Profile] document %h and %m

davidxl added inline comments. Comment at: docs/UsersManual.rst:1500 @@ +1499,3 @@ + name. When this specifier is used, the profiler runtime will substitute ``%m`` + with a unique integer identifier associated with the instrumented binary. Multiple + profiles dumped from

Re: [PATCH] D22593: [Profile] document %h and %m

davidxl updated this revision to Diff 64793. davidxl added a comment. Addressed review comments. I still think %4m etc is an advanced feature that needs more explanation. We can delay that to a later time. https://reviews.llvm.org/D22593 Files: docs/UsersManual.rst Index: docs/UsersManual.

Re: [PATCH] D22593: [Profile] document %h and %m

silvas accepted this revision. silvas added a comment. This revision is now accepted and ready to land. LGTM (also, another small suggestion). Comment at: docs/UsersManual.rst:1502 @@ +1501,3 @@ + multiple raw profiles dumped from different processes (running on the same or +

Re: [PATCH] D22593: [Profile] document %h and %m

This revision was automatically updated to reflect the committed changes. Closed by commit rL276207: [Profile] Document new profile file name modifiers (authored by davidxl). Changed prior to commit: https://reviews.llvm.org/D22593?vs=64793&id=64794#toc Repository: rL LLVM https://reviews.l

r276207 - [Profile] Document new profile file name modifiers

Author: davidxl Date: Wed Jul 20 18:32:50 2016 New Revision: 276207 URL: http://llvm.org/viewvc/llvm-project?rev=276207&view=rev Log: [Profile] Document new profile file name modifiers Differential Revision: http://reviews.llvm.org/D22593 Modified: cfe/trunk/docs/UsersManual.rst Modified:

[libcxx] r276208 - Disable warning flags when running .fail.cpp tests.

Author: ericwf Date: Wed Jul 20 18:37:28 2016 New Revision: 276208 URL: http://llvm.org/viewvc/llvm-project?rev=276208&view=rev Log: Disable warning flags when running .fail.cpp tests. Increasingly the .fail.cpp tests are written using -verify, making them sensitive to the exact diagnostics gener

Re: [PATCH] D22593: [Profile] document %h and %m

ok David On Wed, Jul 20, 2016 at 4:32 PM, Sean Silva wrote: > silvas accepted this revision. > silvas added a comment. > This revision is now accepted and ready to land. > > LGTM (also, another small suggestion). > > > > Comment at: docs/UsersManual.rst:1502 > @@ +1501,3 @@ > +

[libcxx] r276212 - Merging r276003:

Author: ericwf Date: Wed Jul 20 18:53:44 2016 New Revision: 276212 URL: http://llvm.org/viewvc/llvm-project?rev=276212&view=rev Log: Merging r276003: r276003 | ericwf | 2016-07-19 11:56:20 -0600 (Tue, 19 Jul 2016) | 35 lines

[libunwind] r276214 - Update .arcconfig

Author: ericwf Date: Wed Jul 20 18:56:17 2016 New Revision: 276214 URL: http://llvm.org/viewvc/llvm-project?rev=276214&view=rev Log: Update .arcconfig Modified: libunwind/trunk/.arcconfig Modified: libunwind/trunk/.arcconfig URL: http://llvm.org/viewvc/llvm-project/libunwind/trunk/.arcconfi

[libunwind] r276215 - [libunwind] Properly align _Unwind_Exception.

Author: ericwf Date: Wed Jul 20 18:56:42 2016 New Revision: 276215 URL: http://llvm.org/viewvc/llvm-project?rev=276215&view=rev Log: [libunwind] Properly align _Unwind_Exception. Summary: _Unwind_Exception is required to be double word aligned. Currently the struct is under aligned. Reviewers:

Re: [libunwind] r276215 - [libunwind] Properly align _Unwind_Exception.

@Hans This should be merged into 3.9. Can a code owner give this the thumbs up? /Eric On Wed, Jul 20, 2016 at 5:56 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Wed Jul 20 18:56:42 2016 > New Revision: 276215 > > URL: http://llvm.org/viewvc/llvm

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

EricWF added a comment. FYI this patch adds 6 new symbols to the dylib: Symbol added: _ZNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEE7replaceEmmNS_17basic_string_viewIcS2_EEmm {'type': 'FUNC', 'name': '_ZNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEE7repla

  1   2   >