On Mon, Jul 18, 2016 at 5:01 PM, Samuel Antao via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: sfantao
> Date: Mon Jul 18 19:01:12 2016
> New Revision: 275931
>
> URL: http://llvm.org/viewvc/llvm-project?rev=275931&view=rev
> Log:
> Append clang system include path for offloading too
compnerd added inline comments.
Comment at: src/UnwindRegistersRestore.S:331
@@ +330,3 @@
+ ldr r4, [r0, #0x2c]
+ ldr r5, [r0, #0x30]
+ mov r8, r1
Is there a benefit to doing the explicit loading rather than a add + ldm?
Comment at: src/Unwind
rsmith added inline comments.
Comment at: include/clang/AST/Decl.h:1602
@@ -1601,2 +1601,3 @@
unsigned IsConstexpr : 1;
+ unsigned IsMarkedForPendingInstantiation : 1;
Drop the `MarkedFor` here. This flag *is* the mark from the point of view of a
user of th
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.
@rnk, okay, that seems reasonable enough. Although, we should check to ensure
that the x64 toolchain is available and make a decision on that.
BTW, seems that I had missed the p
pcc added a comment.
> An amendment to the Itanium ABI requiring that a conforming program may not
> adjust a virtual table pointer loaded from an object to another virtual table
> in the same virtual table group would seem to be all that would be required
> to guarantee that this scheme wil
mehdi_amini added inline comments.
Comment at: docs/Proposals/GitHub.rst:209
@@ +208,3 @@
+ well as a webhook to update the umbrella project (see below).
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (history,
jyknight added a subscriber: jyknight.
Comment at: docs/Proposals/GitHub.rst:209
@@ +208,3 @@
+ well as a webhook to update the umbrella project (see below).
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (hist
ayartsev created this revision.
ayartsev added reviewers: zaks.anna, dcoughlin.
ayartsev added a subscriber: cfe-commits.
Hi all,
Currently if the path diagnostic consumer (e.g HTMLDiagnostics and
PlistDiagnostics) do not support cross file diagnostics then the path
diagnostic report is just si
Author: compnerd
Date: Mon Jul 18 21:13:08 2016
New Revision: 275943
URL: http://llvm.org/viewvc/llvm-project?rev=275943&view=rev
Log:
clang-rename: fix referenced variable in vim-script
Modified:
clang-tools-extra/trunk/clang-rename/tool/clang-rename.py
Modified: clang-tools-extra/trunk/cla
Hey Hans,
I think that we should get this merged into 3.9. Its a trivial fix and
makes the script usable if you set g:clang_rename_path.
Thanks!
On Mon, Jul 18, 2016 at 7:13 PM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Mon Jul 18 21:13:
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
dberris added a subscriber: dberris.
dberris added a comment.
Mostly wording comments, thank you for writing this up!
Comment at: docs/Proposals/GitHub.rst:78
@@ +77,3 @@
+
+GitHub, like GitLab and BitBucket, provide FREE code hosting for open source
+projects. Essentially, they
vsk added subscribers: friss, vsk.
vsk added a comment.
@rengolin thanks for putting this together! I chimed in with some comments
in-line.
Comment at: docs/Proposals/GitHub.rst:68
@@ +67,3 @@
+ * Collaborate with peers directly, even without access to the Internet
+ * Have mul
>> Can't handle the update of the umbrella *because of GitHub*, this could be
>> possible with our own hosting of git for instance.
>>
> Pre-commit hooks are not designed to update the umbrella. Webhooks will be
> able to update the umbrella with a small external service, as proposed in the
> IR
friss added inline comments.
Comment at: docs/Proposals/GitHub.rst:220
@@ +219,3 @@
+8. Tell people living downstream to pick up commits from the official git
+ repository.
+9. Give things time to settle. We could play some games like disabling the SVN
vsk wrote
> On Jul 18, 2016, at 8:23 PM, Tim Northover via cfe-commits
> wrote:
>
>>> Can't handle the update of the umbrella *because of GitHub*, this could be
>>> possible with our own hosting of git for instance.
>>>
>> Pre-commit hooks are not designed to update the umbrella. Webhooks will be
>> a
Author: abataev
Date: Mon Jul 18 23:21:09 2016
New Revision: 275945
URL: http://llvm.org/viewvc/llvm-project?rev=275945&view=rev
Log:
[OPENMP] Improved processing of 'priority' clause, NFC.
Removed some old comments + improved handling of 'priority' clause value
during codegen after comments from
Author: abataev
Date: Tue Jul 19 00:06:39 2016
New Revision: 275947
URL: http://llvm.org/viewvc/llvm-project?rev=275947&view=rev
Log:
[OPENMP] Removed loop statement as its body executes at most once, NFC.
Removed not required loop statement, addressing comments from Richard
Smith.
Modified:
Hahnfeld added a subscriber: Hahnfeld.
Comment at:
test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:113-119
@@ -80,1 +112,9 @@
+}
+if (ec) {
+assert(new_write_time == old_write_time);
+return false;
+} else {
Hahnfeld added inline comments.
Comment at:
test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:89-95
@@ +88,9 @@
+}
+if (ec) {
+assert(old_write_time == new_write_time);
+return false;
+} else {
+assert(
On Sun, Jul 17, 2016 at 1:54 PM Arthur O'Dwyer
wrote:
> Given that this patch is basically Chandler's talk from CppCon 2015 (
> https://www.youtube.com/watch?v=nXaxk27zwlk), I'm surprised that the
> commit message isn't explicitly mentioning that; and surprised that
> Chandler himself isn't weigh
klimek added inline comments.
Comment at: clang-rename/USRFindingAction.cpp:12
@@ -12,1 +11,3 @@
+/// \brief Provides an action to find USR for the symbol at and all
+/// relevant USRs aswell.
///
... at , as well as all relevant USRs.
Comment
Any feedback?
Thanks,
--Serge
2016-06-20 1:52 GMT+06:00 Serge Pavlov :
> sepavloff updated this revision to Diff 61220.
> sepavloff added a comment.
>
> Updated patch
>
> Added handling of FunctionTemplateDecl to
> shouldLinkDependentDeclWithPrevious. It is not
> used now but is required for sub
omtcyfz updated this revision to Diff 64285.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
replaced RecursiveASTVisitor with ASTMatcher
https://reviews.llvm.org/D22408
Files:
clang-rename/USRFindingAction.cpp
test/clang-rename/VirtualFunctionFindInBaseClass.cpp
test/c
omtcyfz marked an inline comment as done.
Comment at: clang-rename/USRFindingAction.cpp:48
@@ +47,3 @@
+//
+// FIXME: It's better to match ctors/dtors via typeLoc's instead of adding
+// their USRs to the storage, because we can also match CXXConversionDecl's by
T
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm now
https://reviews.llvm.org/D22351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
https://reviews.llvm.org/D22408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin added inline comments.
Comment at: test/Analysis/ctor.mm:177
@@ -176,3 +176,3 @@
Inner(const Inner &Other)
-: x(Other.x), y(Other.y) // expected-warning {{undefined}}
+: x(Other.x), y(Other.y) // no-warning
{
Seems like we m
Author: hokein
Date: Mon Jul 18 05:04:45 2016
New Revision: 275781
URL: http://llvm.org/viewvc/llvm-project?rev=275781&view=rev
Log:
[include-fixer] Add an options allow moving the cursor to #include line in vim
after inserting a missing header.
Summary:
A small improvement: Don't print newline
klimek added inline comments.
Comment at: clang-rename/USRFindingAction.cpp:45
@@ +44,3 @@
+namespace {
+// \brief NamedDeclFindingConsumer should delegate finding USRs relevant to
+// given Decl to RelevantUSRFinder.
Still pondering whether 'relevant' is a good n
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275781: [include-fixer] Add an options allow moving the
cursor to #include line in vim (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D22351?vs=64110&id=64291#toc
Repository:
a.sidorin added a comment.
> I don't think this small improvement in Importer is worth invasive changes in
> other components.
Thanks, Serge. Is it OK to commit?
https://reviews.llvm.org/D14326
___
cfe-commits mailing list
cfe-commits@lists.llvm.
omtcyfz updated this revision to Diff 64293.
omtcyfz marked 3 inline comments as done.
omtcyfz added a comment.
Addressed Manuel's comments.
https://reviews.llvm.org/D22408
Files:
clang-rename/USRFindingAction.cpp
test/clang-rename/VirtualFunctionFindInBaseClass.cpp
test/clang-rename/Virt
baloghadamsoftware added inline comments.
Comment at: test/Analysis/ctor.mm:177
@@ -176,3 +176,3 @@
Inner(const Inner &Other)
-: x(Other.x), y(Other.y) // expected-warning {{undefined}}
+: x(Other.x), y(Other.y) // no-warning
{
a.sido
On Sun, Jul 17, 2016 at 01:54:57PM -0700, Arthur O'Dwyer via cfe-commits wrote:
> IMHO, if replacing "%" with "fastmod" in general-purpose code like this
> were a good idea,
> (A) libc++ should introduce a helper function __fastmod(m,n) for the
> purpose, not repeat the same patch everywhere there'
courbet updated this revision to Diff 64302.
courbet marked 3 inline comments as done.
courbet added a comment.
Cosmetics.
https://reviews.llvm.org/D21992
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguid
elram added a comment.
I don't have commit access.
Can someone do it for me please?
https://reviews.llvm.org/D21637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zizhar added a comment.
Hello Hans,
Regarding the changes in intrin.h,
You're the last to change/add these lines, I found out that there is a conflict
between the clobber list and input or output lists.
Can you review this change?
Thanks,
Ziv Izhar
https://reviews.llvm.org/D15075
__
vbyakovl added a comment.
Ping!
https://reviews.llvm.org/D21678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Mon Jul 18 08:19:00 2016
New Revision: 275787
URL: http://llvm.org/viewvc/llvm-project?rev=275787&view=rev
Log:
Change a couple ifdefs from '#if __cplusplus >= 2011xxx' to '#ifndef
_LIBCPP_CXX03_LANG'. No functionality change.
Modified:
libcxx/trunk/include/iterator
a.makarov added a comment.
Friendly ping!
https://reviews.llvm.org/D21228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper added inline comments.
Comment at: lib/Format/FormatTokenLexer.cpp:231
@@ -230,3 +230,3 @@
void FormatTokenLexer::tryParseTemplateString() {
FormatToken *BacktickToken = Tokens.back();
I think, this could now use an elaborate comment on what it is ac
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
I'm not really happy with this situation, but I don't see how to improve this
patch.
https://reviews.llvm.org/D20786
___
cfe-commits m
jroelofs added inline comments.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can still be
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can still be
rengolin created this revision.
rengolin added reviewers: lattner, chandlerc, jyknight, mehdi_amini, MatzeB,
probinson, t.p.northover, chapuni, delcypher, dberlin, rsmith, beanz,
cmatthews, asl, aaron.ballman, bcraig, Bigcheese, jroelofs, theraven, greened,
hong.gyu.kim, rafael, AlexDenisov, sil
olista01 updated this revision to Diff 64318.
https://reviews.llvm.org/D22292
Files:
src/UnwindRegistersRestore.S
src/UnwindRegistersSave.S
Index: src/UnwindRegistersSave.S
===
--- src/UnwindRegistersSave.S
+++ src/UnwindRegiste
compnerd added inline comments.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can still be
zizhar added a comment.
Akira,
You've mentioned a good point, this X86 logic should indeed be moved to
X86TargetInfo.
The current convertConstraint() implementation is not doing what I need – it
doesn’t handle all the input/output constraints I need, and it returns the
constraint in a different
rogfer01 added a comment.
I plan to commit this today. It only diagnoses address-taking of packed fields.
Reference binding to packed fields will be addressed in another change as
proper support may involve codegen changes which are out of the scope of this
work.
Any further comments are welco
omtcyfz created this revision.
omtcyfz added reviewers: klimek, bkramer, alexfh.
omtcyfz added a subscriber: cfe-commits.
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDe
apaprocki updated this revision to Diff 64328.
apaprocki added a comment.
Fixed `wchar_t` type.
https://reviews.llvm.org/D18360
Files:
lib/Basic/Targets.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
lib/Driver/Tools.h
tools/libcla
omtcyfz updated this revision to Diff 64327.
omtcyfz added a comment.
add XFAIL to currently unsupported test
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDefenition.c
apaprocki added a comment.
(I also re-based the patch on top of `trunk`)
https://reviews.llvm.org/D18360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
In https://reviews.llvm.org/D20561#486994, @rogfer01 wrote:
> I plan to commit this today. It only diagnoses address-taking of packed
> fields.
Please wait until someone has had the chance to review before committing (the
fix does not appear trivial and the orig
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:129
@@ +128,3 @@
+* The linear history can still be accessed in the (RO) submodule meta project,
+ Which will continue to have SVN access.
+
compnerd wrote:
> "Which will continue to have SVN a
rogfer01 added a comment.
> Please wait until someone has had the chance to review before committing (the
> fix does not appear trivial and the original code broke code). I'm on
> vacation today (in theory), but perhaps @rsmith will have a chance to review.
Sure. Thanks.
https://reviews.llvm
compnerd added inline comments.
Comment at: docs/Proposals/GitHub.rst:167
@@ +166,3 @@
+with the limited number of developers whose job will be to mainly merge
+thousands of patches a day.
+
rengolin wrote:
> compnerd wrote:
> > I don't fully understand how this i
jroelofs added a subscriber: jroelofs.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can s
rengolin removed rL LLVM as the repository for this revision.
rengolin updated this revision to Diff 64334.
rengolin added a comment.
First round of changes reflecting reviews.
https://reviews.llvm.org/D22463
Files:
docs/Proposals/GitHub.rst
Index: docs/Proposals/GitHub.rst
=
Prazek added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D22208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer added a subscriber: majnemer.
Comment at: lib/Headers/Intrin.h:841-874
@@ -840,44 +840,36 @@
#if defined(__i386__) || defined(__x86_64__)
static __inline__ void __DEFAULT_FN_ATTRS
__movsb(unsigned char *__dst, unsigned char const *__src, size_t __n) {
- __asm__("rep m
Author: kli
Date: Mon Jul 18 11:09:53 2016
New Revision: 275805
URL: http://llvm.org/viewvc/llvm-project?rev=275805&view=rev
Log:
[OpenMP] update test cases for -std=c++11 compile
target_parallel_for_simd_collapse_messages.cpp and
target_parallel_for_simd_ordered_messages.cpp give different diag
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275805: [OpenMP] update test cases for -std=c++11 compile
(authored by kli).
Changed prior to commit:
https://reviews.llvm.org/D22417?vs=64270&id=64336#toc
Repository:
rL LLVM
https://reviews.llvm.o
majnemer added a subscriber: majnemer.
Comment at: lib/Basic/Targets.cpp:718
@@ +717,3 @@
+Builder.defineMacro("_LONG_LONG");
+Builder.defineMacro("_ALL_SOURCE");
+Builder.defineMacro("_REENTRANT");
Are we really supposed to define this macro? Does GC
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm, and feel free to move to before the "no longer passes --build-id" item
above.
https://reviews.llvm.org/D21970
___
cfe-commits mailing list
cfe
Author: arsenm
Date: Mon Jul 18 11:42:50 2016
New Revision: 275813
URL: http://llvm.org/viewvc/llvm-project?rev=275813&view=rev
Log:
Replace llvm.AMDGPU.ldexp with llvm.amdgcn.ldexp
It didn't really work on r600 to begin with, which should
get its own intrinsic.
Added:
libclc/trunk/amdgcn/li
Sunil_Srivastava added a comment.
Ping.
https://reviews.llvm.org/D22057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: probinson
Date: Mon Jul 18 12:19:12 2016
New Revision: 275817
URL: http://llvm.org/viewvc/llvm-project?rev=275817&view=rev
Log:
Release note for 'nodebug' on variables
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewvc/llv
Author: marshall
Date: Mon Jul 18 12:23:06 2016
New Revision: 275819
URL: http://llvm.org/viewvc/llvm-project?rev=275819&view=rev
Log:
Don't use pthread initializers in constexpr constructors. Patch by elram.
Reviewed at https://reviews.llvm.org/D21637.
Modified:
libcxx/trunk/include/__mutex
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275820: [analyzer] Add checker modeling potential C++
self-assignment (authored by dcoughlin).
Changed prior to commit:
https://reviews.llvm.org/D19311?vs=64135&id=64346#toc
Repository:
rL LLVM
http
Author: dcoughlin
Date: Mon Jul 18 12:23:30 2016
New Revision: 275820
URL: http://llvm.org/viewvc/llvm-project?rev=275820&view=rev
Log:
[analyzer] Add checker modeling potential C++ self-assignment
This checker checks copy and move assignment operators whether they are
protected against self-assi
mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 275819.
https://reviews.llvm.org/D21637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
filcab added a subscriber: filcab.
filcab added a comment.
What about branches? I'm guessing we should expect the usual release branches.
But will any person be able to create a branch? Will there be a policy, if this
is the case? Is the policy enforceable?
Comment at: docs/Pr
> On 2016-Jul-17, at 13:11, Eric Fiselier wrote:
>
> Hi Duncan,
>
> It's possibly expected. It depends on what operation it's performing. I
> expected a bit of a performance drop in some cases but I have a plan to fix
> those.
> Do you have a link to LNT?
LNT is documented here:
http://llv
> On 2016-Jul-18, at 10:43, Duncan P. N. Exon Smith
> wrote:
>
>
>> On 2016-Jul-17, at 13:11, Eric Fiselier wrote:
>>
>> Hi Duncan,
>>
>> It's possibly expected. It depends on what operation it's performing. I
>> expected a bit of a performance drop in some cases but I have a plan to fix
It seems to have broken this buildbot:
http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/40225/
I'm just about to create the 3.9 release branch, so it would be great
if this could fixed/figured out soon.
Thanks,
Hans
On Mon, Jul 18, 2016 at 10:23 AM, Devin Coughlin via cfe-commits
wrote:
101 - 179 of 179 matches
Mail list logo
