Re: [PATCH] D22048: [analyzer] Suppress false positives in std::shared_ptr

NoQ accepted this revision. NoQ added a comment. LGTM, all clear to me now :) http://reviews.llvm.org/D22048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r274706 - Revert "Retry "Include debug info for nested structs and classes""

Author: amccarth Date: Wed Jul 6 18:28:34 2016 New Revision: 274706 URL: http://llvm.org/viewvc/llvm-project?rev=274706&view=rev Log: Revert "Retry "Include debug info for nested structs and classes"" Reverting because it causes a test failure on build bots (Modules/ModuleDebugInfo.cpp). Failu

[PATCH] D22073: libc++: test lock-free atomic alignment

jfb created this revision. jfb added a reviewer: cfe-commits. libc++ implements std::atomic<_Tp> using __atomic_base<_Tp> with `mutable _Atomic(_Tp) __a_`. That member must be suitably aligned on relevant ISAs for instructions such as cmpxchg to work properly, but this alignment isn't checked anyw

[PATCH] D22075: [OpenMP] Fix incorrect diagnostics in map clause

davidsh created this revision. davidsh added reviewers: carlo.bertolli, arpith-jacob, sfantao, ABataev, kkwli0. davidsh added a subscriber: cfe-commits. Having the following code pattern will result in incorrect diagnostic int main() { int arr[10]; #pragma omp target data map(arr[:]) #pragma omp t

Re: [PATCH] D21978: [analyzer] Add LocationContext to SymbolMetadata

NoQ added a comment. I also never noticed that the block count gets reset on every stack frame, that's pretty unobvious. Uhm, and it's already there in SymbolConjured. Anyway, fixing the block count itself seems to be pretty complicated. Also, maybe once the ScopeContext thing is ready, we'd be

Re: [PATCH] D22075: [OpenMP] Fix incorrect diagnostics in map clause

sfantao added a comment. Hi David, Thanks for the fix! Comment at: lib/Sema/SemaOpenMP.cpp:10639 @@ -10638,2 +10638,3 @@ break; } +while(SI != SE) { You have to document what you are trying to accomplish here, something like `"Che

Re: [PATCH] D21869: [CUDA] Check that our CUDA install supports the requested architectures.

jlebar added a comment. Friendly ping. http://reviews.llvm.org/D21869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r274713 - [CUDA] Fix "control reaches end of non-void function" warnings in Cuda.cpp.

Author: jlebar Date: Wed Jul 6 20:06:59 2016 New Revision: 274713 URL: http://llvm.org/viewvc/llvm-project?rev=274713&view=rev Log: [CUDA] Fix "control reaches end of non-void function" warnings in Cuda.cpp. Some compilers are too dumb to realize that the switch statement covers all cases. (Don

Re: [PATCH] D21753: Comprehensive Static Instrumentation (2/2): Clang flag

mehdi_amini added inline comments. Comment at: docs/CSI.rst:46 @@ +45,3 @@ +allows the LTO to later elide hooks irrelevant to the tool entirely from the +program-under-test. + The long thread on llvm-dev went to conclude that LTO should not be needed. ===

Re: [PATCH] D21991: [libunwind][ARM] Improve unwinder stack usage - Make WMMX support optional

compnerd accepted this revision. This revision is now accepted and ready to land. Comment at: src/Registers.hpp:1497 @@ -1479,3 +1496,3 @@ _LIBUNWIND_ABORT("unsupported arm register"); } Early returns would be nicer imo. Comment at: src/R

Re: [PATCH] D21392: [clang-tidy] Enhance redundant-expression check

etienneb updated this revision to Diff 63020. etienneb marked 2 inline comments as done. etienneb added a comment. nits http://reviews.llvm.org/D21392 Files: clang-tidy/misc/RedundantExpressionCheck.cpp clang-tidy/misc/RedundantExpressionCheck.h test/clang-tidy/misc-redundant-expression.c

Re: [PATCH] D21753: Comprehensive Static Instrumentation (2/2): Clang flag

bruening added inline comments. Comment at: docs/CSI.rst:78 @@ +77,3 @@ +Notice that in the final stage of linking, the tool user also needs to link in +the static library of the CSI runtime to produce the final TIX. The runtime +archive is distributed under the ``build/lib/clang

Re: [PATCH] D21753: Comprehensive Static Instrumentation (2/2): Clang flag

mehdi_amini added inline comments. Comment at: docs/CSI.rst:78 @@ +77,3 @@ +Notice that in the final stage of linking, the tool user also needs to link in +the static library of the CSI runtime to produce the final TIX. The runtime +archive is distributed under the ``build/lib/cl

[clang-tools-extra] r274731 - [clang-tidy] Enhance redundant-expression check

Author: etienneb Date: Wed Jul 6 23:03:05 2016 New Revision: 274731 URL: http://llvm.org/viewvc/llvm-project?rev=274731&view=rev Log: [clang-tidy] Enhance redundant-expression check Summary: This patch is adding support to recognize more complex redundant expressions. Reviewers: alexfh Subscr

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

hfinkel updated this revision to Diff 63029. hfinkel added a comment. Thanks everyone. I've rebased this and changed the name to __libcpp_*. Marshall, how do you recommend rewriting the functions to reduce the boilerplate? http://reviews.llvm.org/D18639 Files: include/cmath include/comple

r274733 - [AST] Tighten up the bitfield in TemplateSpecializationType

Author: majnemer Date: Wed Jul 6 23:43:11 2016 New Revision: 274733 URL: http://llvm.org/viewvc/llvm-project?rev=274733&view=rev Log: [AST] Tighten up the bitfield in TemplateSpecializationType Optimize the bitfield types to conserve space for the MSVC ABI. Modified: cfe/trunk/include/clang

r274732 - [AST] Use ArrayRef in more interfaces

Author: majnemer Date: Wed Jul 6 23:43:07 2016 New Revision: 274732 URL: http://llvm.org/viewvc/llvm-project?rev=274732&view=rev Log: [AST] Use ArrayRef in more interfaces ArrayRef is a little better than passing around a pointer/length pair. No functional change is intended. Modified: cfe

<    1   2