Re: r264008 - [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl.

I think this code is accidentally OK, because the list of overloads that callers pass in in should have at most two elements. A given overload set may have both a __host__ and a __device__ function, or alternatively it may have a __host__ __device__ function, but you can't have all three. There i

[libcxx] r274286 - Replace __make_tuple_indices implementation with superior implementation.

Author: ericwf Date: Thu Jun 30 17:34:43 2016 New Revision: 274286 URL: http://llvm.org/viewvc/llvm-project?rev=274286&view=rev Log: Replace __make_tuple_indices implementation with superior implementation. The previous __make_tuple_indices implementation caused O(N) instantiations and was pretty

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

Ilod added a subscriber: Ilod. Ilod added a comment. Hello, When I tried your patch and added LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON, I had multiple errors on your python scripts, like: File "utils/extract_symbols.py", line 399, in calling_convention_decoration = is_32bit_windows(libs[0]

RE: r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"

> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Sean Silva via cfe-commits > Sent: Tuesday, June 28, 2016 5:29 PM > To: cfe-commits@lists.llvm.org > Subject: r274084 - Revert "[PS4] Tighten up a test (noticed in passing)" > > Author: si

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

sfantao updated this revision to Diff 62435. sfantao marked 5 inline comments as done. sfantao added a comment. - Mark classes with final and fix comments. http://reviews.llvm.org/D18171 Files: include/clang/Driver/Action.h include/clang/Driver/Compilation.h include/clang/Driver/Driver.h

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

EricWF added a subscriber: EricWF. EricWF added a comment. Ping? Is there a reason this hasn't been committed? http://reviews.llvm.org/D15421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"

On Thu, Jun 30, 2016 at 3:52 PM, Robinson, Paul wrote: > > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of > > Sean Silva via cfe-commits > > Sent: Tuesday, June 28, 2016 5:29 PM > > To: cfe-commits@lists.llvm.org > > Subject: r27408

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

sfantao added a comment. Hi Alexey, Thanks for the review! I addressed your comments in the last diff. In http://reviews.llvm.org/D18171#471044, @ABataev wrote: > No '\brief's When you say "no \brief" do you mean I am using that where I shouldn't or the other way around. I am only adding th

r274291 - [Sema] Implement C++14's DR1579: Prefer returning by converting move constructor

Author: epilk Date: Thu Jun 30 18:09:13 2016 New Revision: 274291 URL: http://llvm.org/viewvc/llvm-project?rev=274291&view=rev Log: [Sema] Implement C++14's DR1579: Prefer returning by converting move constructor Fixes PR28096. Differential Revision: http://reviews.llvm.org/D21619 Modified:

Re: [PATCH] D21619: [Sema] Implement C++14's DR1579: Prefer moving id-expression out of functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL274291: [Sema] Implement C++14's DR1579: Prefer returning by converting move constructor (authored by epilk). Changed prior to commit: http://reviews.llvm.org/D21619?vs=62405&id=62437#toc Repository:

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao updated this revision to Diff 62438. sfantao marked 3 inline comments as done. sfantao added a comment. - Fix comments, annotate classes with final, and add default initializers. http://reviews.llvm.org/D18172 Files: include/clang/Driver/Compilation.h lib/Driver/Driver.cpp Index: l

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao added a comment. Hi Alexey, Thanks for the review! Addressed your comments in the new diff. I'll wait for your response on my question in http://reviews.llvm.org/D18172 to address the issue with \brief properly. Thanks again, Samuel http://reviews.llvm.org/D18172 _

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Please reformat with clang-format and then OK. -eric http://reviews.llvm.org/D21334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

jlebar added a comment. Alexey, it seems that you're asking for "final" on all classes that are not inherited from. Forgive my ignorance, but would you mind pointing me to the document that talks about our position on "final" in LLVM source? I don't see it in the style guide, but I may be mis

LLVM buildmaster will be restarted around 5 PM today

Hello everyone, LLVM buildmaster will be restarted around 5 PM Pacific time today. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21912: [CUDA] Don't assume that destructors can't be overloaded.

jlebar created this revision. jlebar added a reviewer: rsmith. jlebar added subscribers: tra, cfe-commits. You can overload a destructor in CUDA, and SemaOverload needs to be tweaked not to crash when it sees an explicit call to an overloaded destructor. http://reviews.llvm.org/D21912 Files: l

[PATCH] D21914: [CUDA] Use the multi-element remove function in EraseUnwantedCUDAMatches.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: bkramer, cfe-commits. Bug pointed out by Benjamin Kramer in r264008. I think the bug is benign because by the time this is called, we should only have at most two overloads to consider (either a host and a devic

[PATCH] D21913: [CUDA] Add additional testcases for EraseUnwantedCUDAMatches.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. Specifically, this patch adds testcases for all three calls to EraseUnwantedCUDAMatches. The addr-of-overloaded-fn test I accidentally neutered in r264207, which moved much of CodeGenCUDA/function-

RE: r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"

Okay, that is peculiar. But I can repro it. If I put either orbis-ld or orbis-ld.exe co-located with clang.exe, it builds a command line without the .exe suffix (but using the directory where clang.exe lives). I do think a bug report would have been appropriate, rather than just munging the t

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

hfinkel added a comment. ping http://reviews.llvm.org/D18639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r274314 - [CodeCompletion] Allow system headers providing private symbols with a single underscore.

Author: akirtzidis Date: Thu Jun 30 20:17:02 2016 New Revision: 274314 URL: http://llvm.org/viewvc/llvm-project?rev=274314&view=rev Log: [CodeCompletion] Allow system headers providing private symbols with a single underscore. rdar://24677150 Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cp

r274316 - [Feature] Add a builtin for indexing into parameter packs. Patch by Louis Dionne.

Author: ericwf Date: Thu Jun 30 20:24:09 2016 New Revision: 274316 URL: http://llvm.org/viewvc/llvm-project?rev=274316&view=rev Log: [Feature] Add a builtin for indexing into parameter packs. Patch by Louis Dionne. This patch adds a __nth_element builtin that allows fetching the n-th type of a p

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

EricWF closed this revision. EricWF added a comment. Committed in r274316. http://reviews.llvm.org/D15421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

The rationale is no different for DWARF than for CodeView, there's no other way to get the fully qualified name of an inlined function. Unless you want to connect this up to the existing DWARF hook for putting linkage names on inlined subprograms? The downside there is that linkage names are p

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

arsenm added a comment. ping http://reviews.llvm.org/D5896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21918: Make the tuple_element and __make_tuple_types implementations flat.

EricWF created this revision. EricWF added a subscriber: cfe-commits. http://reviews.llvm.org/D21918 Files: include/__tuple Index: include/__tuple === --- include/__tuple +++ include/__tuple @@ -228,68 +228,141 @@ template str

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

hfinkel accepted this revision. hfinkel added a reviewer: hfinkel. hfinkel added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D5896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

chandlerc added a reviewer: scanon. chandlerc added a comment. I'm fine with this change, but we should also get Steve to comment on it, and make sure we have a good way of explaining this to users. In particular, we probably need some documentation around these fast routines that clearly indic

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

hfinkel added a comment. In http://reviews.llvm.org/D18639#472010, @chandlerc wrote: > I'm fine with this change, but we should also get Steve to comment on it, and > make sure we have a good way of explaining this to users. > > In particular, we probably need some documentation around these fas

r274326 - [DebugInfo] Set DISubprogram ThisAdjustment in the MS ABI

Author: rnk Date: Thu Jun 30 21:41:25 2016 New Revision: 274326 URL: http://llvm.org/viewvc/llvm-project?rev=274326&view=rev Log: [DebugInfo] Set DISubprogram ThisAdjustment in the MS ABI Modified: cfe/trunk/lib/CodeGen/CGCXXABI.h cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/Co

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

ABataev added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8318 @@ -8317,1 +8317,3 @@ +def err_omp_usedeviceptr_not_a_pointer : Error< + "item used in 'use_device_pointer' clause is not a pointer">; } // end of OpenMP category It's be

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

sfantao added a comment. In http://reviews.llvm.org/D18171#471824, @sfantao wrote: > Hi Alexey, > > Thanks for the review! I addressed your comments in the last diff. > > In http://reviews.llvm.org/D18171#471044, @ABataev wrote: > > > No '\brief's > > > When you say "no \brief" do you mean I am

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

sfantao added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:11377 @@ +11376,3 @@ +// item should be a pointer or array +if (!Type.getNonReferenceType()->isPointerType()) { + Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer) ABataev wrote: >

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

mclow.lists added a comment. Hal and I talked about this in Oulu. In general, I'm good with this approach. However, I think that the code could be made much clearer. (some naming changes, some code rearrangement) First off, I think the name `__fast_isinf` is a poor name. I think something like

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

sfantao updated this revision to Diff 62460. sfantao added a comment. - Remove \brief. http://reviews.llvm.org/D18171 Files: include/clang/Driver/Action.h include/clang/Driver/Compilation.h include/clang/Driver/Driver.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/ToolChai

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:11377 @@ +11376,3 @@ +// item should be a pointer or array +if (!Type.getNonReferenceType()->isPointerType()) { + Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer) sfantao wrote: >

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

sfantao added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:11377 @@ +11376,3 @@ +// item should be a pointer or array +if (!Type.getNonReferenceType()->isPointerType()) { + Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer) ABataev wrote: >

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao updated this revision to Diff 62462. sfantao added a comment. - Remove \brief. http://reviews.llvm.org/D18172 Files: include/clang/Driver/Compilation.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Dri

[libcxx] r274330 - Flatten the tuple_element and __make_tuple_types implementations.

Author: ericwf Date: Thu Jun 30 22:54:54 2016 New Revision: 274330 URL: http://llvm.org/viewvc/llvm-project?rev=274330&view=rev Log: Flatten the tuple_element and __make_tuple_types implementations. This patch attempts to improve the QoI of std::tuples tuple_element and __make_tuple_types helpers

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

ABataev added a comment. In http://reviews.llvm.org/D18172#471861, @jlebar wrote: > Alexey, it seems that you're asking for "final" on all classes that are not > inherited from. Forgive my ignorance, but would you mind pointing me to the > document that talks about our position on "final" in L

[libcxx] r274331 - Flatten tuple_constructible, tuple_convertible and tuple_assignable.

Author: ericwf Date: Thu Jun 30 23:07:39 2016 New Revision: 274331 URL: http://llvm.org/viewvc/llvm-project?rev=274331&view=rev Log: Flatten tuple_constructible, tuple_convertible and tuple_assignable. This patch is the last in a series that replaces recursive meta-programming in std::tuple with

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao added a comment. In http://reviews.llvm.org/D18172#471861, @jlebar wrote: > Alexey, it seems that you're asking for "final" on all classes that are not > inherited from. Forgive my ignorance, but would you mind pointing me to the > document that talks about our position on "final" in L

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

kkwli0 added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:11377 @@ +11376,3 @@ +// item should be a pointer or array +if (!Type.getNonReferenceType()->isPointerType()) { + Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer) sfantao wrote: > A

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

carlo.bertolli added a comment. I think that Kelvin is right. This is what that sentence refers to: int * bla = ..; #pragma omp target data use_device_ptr(bla) { .. bla .. // <-- this is the 'reference' that sentence is about } What puzzles me about that sentence is that it seems it is asking

Re: [PATCH] D21918: Make the tuple_element and __make_tuple_types implementations flat.

EricWF abandoned this revision. EricWF added a comment. Committed in rr274330 http://reviews.llvm.org/D21918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

ABataev added a comment. In http://reviews.llvm.org/D21904#472074, @carlo.bertolli wrote: > I think that Kelvin is right. This is what that sentence refers to: > int * bla = ..; > #pragma omp target data use_device_ptr(bla) > { > > .. bla .. // <-- this is the 'reference' that sentence is ab

Re: [PATCH] D21706: [libcxx] refactor for throw

weimingz retitled this revision from "[libcxx] refactor for throw or assert" to "[libcxx] refactor for throw". weimingz updated the summary for this revision. weimingz updated this revision to Diff 62470. http://reviews.llvm.org/D21706 Files: include/__functional_03 include/__locale includ

<    1   2