[PATCH] D21706: [libcxx] refactor for throw or assert

2016-06-24 Thread Weiming Zhao via cfe-commits
weimingz created this revision. weimingz added reviewers: rmaprath, grandinj. weimingz added a subscriber: cfe-commits. Add macros to wrapper for throw or assert. http://reviews.llvm.org/D21706 Files: include/__config include/__locale include/array include/experimental/optional include

Re: [PATCH] D21706: [libcxx] refactor for throw or assert

2016-06-24 Thread Weiming Zhao via cfe-commits
weimingz added a comment. Before replacing all throw/assert to macros, let's first check if we're on the right path. http://reviews.llvm.org/D21706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D21706: [libcxx] refactor for throw or assert

2016-06-24 Thread Eric Fiselier via cfe-commits
EricWF added a subscriber: EricWF. EricWF added reviewers: mclow.lists, EricWF. EricWF added a comment. We actually have a non-macro that does this. It's called `__libcpp_throw` and it lives in ``. Please use that instead. http://reviews.llvm.org/D21706 __

r273754 - Implement C++17 P0386R2, inline variables. (The 'inline' specifier gives a

2016-06-24 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jun 24 19:15:56 2016 New Revision: 273754 URL: http://llvm.org/viewvc/llvm-project?rev=273754&view=rev Log: Implement C++17 P0386R2, inline variables. (The 'inline' specifier gives a variable weak discardable linkage and partially-ordered initialization, and is implied for

[PATCH] D21708: [libcxx] fix compiler warning of autological-constant-out-of-range-compare

2016-06-24 Thread Weiming Zhao via cfe-commits
weimingz created this revision. weimingz added a subscriber: cfe-commits. warning: comparison of constant -2147483648 with expression of type 'long' (range [-2147483648, 2147483647]) is always false [-Wtautological-constant-out-of-range-compare] As int and long maybe the same size on most archi

Re: [PATCH] D21122: CodeGen: Start emitting checked loads when both trapping CFI and -fwhole-program-vtables are enabled.

2016-06-24 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273757: CodeGen: Start emitting checked loads when both trapping CFI and -fwhole… (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D21122?vs=60006&id=61864#toc Repository: rL LLVM

r273757 - CodeGen: Start emitting checked loads when both trapping CFI and -fwhole-program-vtables are enabled.

2016-06-24 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Fri Jun 24 19:24:06 2016 New Revision: 273757 URL: http://llvm.org/viewvc/llvm-project?rev=273757&view=rev Log: CodeGen: Start emitting checked loads when both trapping CFI and -fwhole-program-vtables are enabled. Differential Revision: http://reviews.llvm.org/D21122 Modified:

r273760 - Fix bad test expectation.

2016-06-24 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Fri Jun 24 19:37:14 2016 New Revision: 273760 URL: http://llvm.org/viewvc/llvm-project?rev=273760&view=rev Log: Fix bad test expectation. Modified: cfe/trunk/test/CodeGenCXX/type-metadata.cpp Modified: cfe/trunk/test/CodeGenCXX/type-metadata.cpp URL: http://llvm.org/viewvc

[PATCH] D21712: [libcxx] [test] Avoid narrowing conversions in quoted.pass.cpp.

2016-06-24 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Avoid narrowing conversions in quoted.pass.cpp. According to the Standard, when char has a signed range and wchar_t has an unsigned range, brace-init has to reject the potenti

[PATCH] D21713: [libcxx] [test] Use L"cat" L"dog" when concatenating string literals.

2016-06-24 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Use L"cat" L"dog" when concatenating string literals. MSVC dislikes seeing L"23" "\x65F6". It's actually unclear to me what the Standard says here - I suspect that MSVC is cor

[PATCH] D21714: [libcxx] [test] In atomics.types.generic/address.pass.cpp, use T(0) for consistency.

2016-06-24 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. In atomics.types.generic/address.pass.cpp, use T(0) for consistency. Fixes MSVC "error C2593: 'operator ==' is ambiguous". There is almost certainly an MSVC compiler bug invol

[PATCH] D21715: [libcxx] [test] Make default_noexcept.pass.cpp tests more portable.

2016-06-24 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make default_noexcept.pass.cpp tests more portable. They were static_asserting that the following things are nothrow-default-constructible: ordered/unordered associative cont

[PATCH] D21716: [libcxx] [test] Make move_noexcept.pass.cpp tests more portable.

2016-06-24 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make move_noexcept.pass.cpp tests more portable. They were static_asserting that the following things are nothrow-move-constructible: ordered/unordered associative containers

[PATCH] D21717: [libcxx] [test] Make dtor_noexcept.pass.cpp tests more portable.

2016-06-24 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make dtor_noexcept.pass.cpp tests more portable. They were static_asserting that in certain situations, the following things have throwing destructors: ordered/unordered asso

[PATCH] D21718: [libcxx] [test] Make move_assign_noexcept.pass.cpp tests more portable.

2016-06-24 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make move_assign_noexcept.pass.cpp tests more portable. Note that the relevant wording here was modified by C++17 N4258 "Cleaning-up noexcept in the Library (Rev 3)", which MS

Re: [PATCH] D21659: AMDGPU: Add builtin to read exec mask

2016-06-24 Thread Tom Stellard via cfe-commits
tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D21659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D21367: AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

2016-06-24 Thread Tom Stellard via cfe-commits
tstellarAMD added a comment. This seems OK to me. http://reviews.llvm.org/D21367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

2016-06-24 Thread Lei Zhang via cfe-commits
2016-06-24 16:02 GMT+08:00 Peter Smith : > Hello Lei, > > They look good enough for me. Unless anyone else has any objections I > think you are good to go. I just see them committed by r273735 in clang and r273726 in LLVM. Peter, thank you for the comments; and Rafael, thank you for committing th

[PATCH] D21724: [RFC] Enhance synchscope representation (clang)

2016-06-24 Thread Konstantin Zhuravlyov via cfe-commits
kzhuravl created this revision. kzhuravl added reviewers: tstellarAMD, arsenm, rampitec. kzhuravl added subscribers: cfe-commits, llvm-commits, resistor. As described in this proposal: https://groups.google.com/forum/#!topic/llvm-dev/GtWfCc5j-4U http://reviews.llvm.org/D21724 Files: lib/CodeG

<    1   2