Hi,
On Mon, Jun 20, 2016 at 10:26 PM, Yaxun Liu via cfe-commits
wrote:
> Author: yaxunl
> Date: Mon Jun 20 14:26:00 2016
> New Revision: 273191
>
> URL: http://llvm.org/viewvc/llvm-project?rev=273191&view=rev
> Log:
> [OpenCL] Include opencl-c.h by default as a clang module
>
> Include opencl-c.h
Author: ericwf
Date: Wed Jun 22 02:09:59 2016
New Revision: 273390
URL: http://llvm.org/viewvc/llvm-project?rev=273390&view=rev
Log:
Disable ccache usage for .fail.cpp tests. It causes bugs.
Modified:
libcxx/trunk/test/libcxx/compiler.py
libcxx/trunk/test/libcxx/test/format.py
Modified:
Author: ericwf
Date: Wed Jun 22 02:24:00 2016
New Revision: 273391
URL: http://llvm.org/viewvc/llvm-project?rev=273391&view=rev
Log:
Avoid unnecessary stat call in filesystem::permissions implementation.
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:480
@@ -471,1 +479,3 @@
+ void parseJSTypeDefinition() {
+// `type Name = Type Expression;`
Why is this necessary?
http://reviews.llvm.org/D21597
_
2016-06-21 23:07 GMT+08:00 Peter Smith :
> Hello Lei,
>
> The changes to llvm and clang look ok to me. I've got some suggestions
> for testing.
>
> For the clang patch, it looks like there isn't a test to check that
> musleabihf implies hard floating point. It looks like
> Driver/arm-mfpu.c CHECK-H
Author: ericwf
Date: Wed Jun 22 02:57:38 2016
New Revision: 273392
URL: http://llvm.org/viewvc/llvm-project?rev=273392&view=rev
Log:
Cleanup filesystem::permissions ever more.
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk/src/experimental/filesystem
Author: ericwf
Date: Wed Jun 22 03:01:27 2016
New Revision: 273393
URL: http://llvm.org/viewvc/llvm-project?rev=273393&view=rev
Log:
Cleanup _LIBCPP_DEBUG tests in std::list. More to come.
Added:
libcxx/trunk/test/libcxx/containers/sequences/list/db_back.pass.cpp
libcxx/trunk/test/libcxx/
*even more. Not "ever more".
On Wed, Jun 22, 2016 at 1:57 AM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Wed Jun 22 02:57:38 2016
> New Revision: 273392
>
> URL: http://llvm.org/viewvc/llvm-project?rev=273392&view=rev
> Log:
> Cleanup filesystem::p
Author: ericwf
Date: Wed Jun 22 03:47:43 2016
New Revision: 273394
URL: http://llvm.org/viewvc/llvm-project?rev=273394&view=rev
Log:
Finish converting list _LIBCPP_DEBUG tests.
Added:
libcxx/trunk/test/libcxx/containers/sequences/list/list.cons/
libcxx/trunk/test/libcxx/containers/sequen
Hello Lei,
Thanks for all the updates. That looks good to me from an ARM perspective.
Peter
On 22 June 2016 at 09:03, Lei Zhang wrote:
> 2016-06-21 23:07 GMT+08:00 Peter Smith :
>> Hello Lei,
>>
>> The changes to llvm and clang look ok to me. I've got some suggestions
>> for testing.
>>
>> For
nitesh.jain created this revision.
nitesh.jain added reviewers: dsanders, vkalintiris, joerg, jroelofs, EricWF,
mclow.lists.
nitesh.jain added subscribers: jaydeep, bhushan, slthakur, mohit.bhakkad,
zturner, cfe-commits.
nitesh.jain set the repository for this revision to rL LLVM.
The patch http
Author: ericwf
Date: Wed Jun 22 03:57:33 2016
New Revision: 273395
URL: http://llvm.org/viewvc/llvm-project?rev=273395&view=rev
Log:
Run list debug copy test in C++03.
Modified:
libcxx/trunk/test/libcxx/containers/sequences/list/list.cons/db_copy.pass.cpp
Modified:
libcxx/trunk/test/libcxx
ioeric created this revision.
ioeric added reviewers: klimek, djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
return llvm::Expected<> to carry error status and error information.
This is the first step towards introducing "Error" into tooling::Replacements.
htt
ioeric created this revision.
ioeric added reviewers: klimek, djasper.
ioeric added a subscriber: cfe-commits.
this patch contains changes related to the interface change from
http://reviews.llvm.org/D21601. Only submit this patch after D21601 is
submitted.
http://reviews.llvm.org/D21602
Files:
hokein created this revision.
hokein added a subscriber: cfe-commits.
This is an initial version of fixing namespace issues by adding a missing
namespace prefix to an unidentified symbol.
This version only fixes the first discovered unidentified symbol
In the long run, include-fixer should fix al
hokein updated this revision to Diff 61524.
hokein added a comment.
Fix a typo.
http://reviews.llvm.org/D21603
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/SymbolIndexManager.cpp
include-fixer/SymbolIndexManager.h
include-fixer/find-all-symbo
On 21 June 2016 at 19:04, Joerg Sonnenberger via cfe-commits
wrote:
> On Tue, Jun 21, 2016 at 06:53:03PM -0400, Rafael Espíndola via cfe-commits
> wrote:
>> diff --git a/lib/Frontend/InitPreprocessor.cpp
>> b/lib/Frontend/InitPreprocessor.cpp
>> index 27ef59a..6b93c69 100644
>> --- a/lib/Fronten
Author: mzuckerm
Date: Wed Jun 22 07:32:43 2016
New Revision: 273401
URL: http://llvm.org/viewvc/llvm-project?rev=273401&view=rev
Log:
[Clang][bmi][intrinsics] Adding _mm_tzcnt_64 _mm_tzcnt_32 intrinsics to clang.
Differential Revision: http://reviews.llvm.org/D21373
Modified:
cfe/trunk/lib/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273401: [Clang][bmi][intrinsics] Adding _mm_tzcnt_64
_mm_tzcnt_32 intrinsics to clang. (authored by mzuckerm).
Changed prior to commit:
http://reviews.llvm.org/D21373?vs=61351&id=61536#toc
Repository:
bmharper added a subscriber: bmharper.
bmharper added a comment.
Hi Daniel,
Is there anything else that I need to do here?
Regards,
Ben
Repository:
rL LLVM
http://reviews.llvm.org/D21279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:431
@@ +430,3 @@
+ CXX11<"clang", "xray_always_instrument">];
+ let Subjects = SubjectList<[CXXMethod, Function], WarnDiag,
+ "ExpectedFunctionOrMethod">;
-
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:27
@@ -25,1 +26,3 @@
+static bool incrementWithoutOverflow(const llvm::APSInt &Value,
+ llvm::APSInt &Result) {
I think this could b
aaron.ballman added inline comments.
Comment at: clang-tidy/performance/EmplaceCheck.cpp:26
@@ +25,3 @@
+ on(expr(hasType(cxxRecordDecl(hasName("std::vector"),
+ callee(functionDecl(hasName("push_back"))),
+ hasArgument(0, cxxConstructExpr().bind("co
pgousseau added a comment.
Ping!
http://reviews.llvm.org/D20867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: tstellar
Date: Wed Jun 22 08:22:30 2016
New Revision: 273416
URL: http://llvm.org/viewvc/llvm-project?rev=273416&view=rev
Log:
Creating release candidate final from release_381 branch
Added:
libunwind/tags/RELEASE_381/final/
- copied from r273415, libunwind/branches/release_38/
Author: tstellar
Date: Wed Jun 22 08:22:18 2016
New Revision: 273409
URL: http://llvm.org/viewvc/llvm-project?rev=273409&view=rev
Log:
Creating release candidate final from release_381 branch
Added:
libcxx/tags/RELEASE_381/final/ (props changed)
- copied from r273408, libcxx/branches/
Author: tstellar
Date: Wed Jun 22 08:22:19 2016
New Revision: 273410
URL: http://llvm.org/viewvc/llvm-project?rev=273410&view=rev
Log:
Creating release candidate final from release_381 branch
Added:
libcxxabi/tags/RELEASE_381/final/ (props changed)
- copied from r273409, libcxxabi/bra
aaron.ballman added inline comments.
Comment at: clang-tidy/performance/ReturnValueCopyCheck.cpp:53
@@ +52,3 @@
+/// matches the given matcher.
+AST_MATCHER_P(QualType, ignoringRefsAndConsts,
+ ast_matchers::internal::Matcher, InnerMatcher) {
Prazek w
On Wed, Jun 22, 2016 at 08:06:06AM -0400, Rafael Espíndola wrote:
> On 21 June 2016 at 19:04, Joerg Sonnenberger via cfe-commits
> wrote:
> > On Tue, Jun 21, 2016 at 06:53:03PM -0400, Rafael Espíndola via cfe-commits
> > wrote:
> >> diff --git a/lib/Frontend/InitPreprocessor.cpp
> >> b/lib/Front
aaron.ballman added inline comments.
Comment at: include/llvm/Support/TrailingObjects.h:353
@@ +352,3 @@
+ ///
+ /// \code{.cpp}
+ ///
That's novel (we use it in two other places from what I can tell).
Comment at: include/llvm/Support/Trailing
Eugene.Zelenko added a comment.
Since http://reviews.llvm.org/D20964 was committed, I think we should close
this.
http://reviews.llvm.org/D21185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
hubert.reinterpretcast added inline comments.
Comment at: include/llvm/Support/TrailingObjects.h:353
@@ +352,3 @@
+ ///
+ /// \code{.cpp}
+ ///
aaron.ballman wrote:
> That's novel (we use it in two other places from what I can tell).
This is a documented Doxyge
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I think this LGTM (with the const overload), but you should poke Richard to see
what his thoughts are before committing.
Comment at: include/llvm/Support/Traili
Author: mprobst
Date: Wed Jun 22 09:35:14 2016
New Revision: 273422
URL: http://llvm.org/viewvc/llvm-project?rev=273422&view=rev
Log:
clang-format: [JS] Do not break before 'as'.
Summary:
'as' is a pseudo operator, so automatic semicolon insertion kicks in and the
code fails to part.
Reviewers:
mprobst updated this revision to Diff 61548.
mprobst added a comment.
- Remove parseJSTypeDefinition
http://reviews.llvm.org/D21597
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
mprobst added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:480
@@ -471,1 +479,3 @@
+ void parseJSTypeDefinition() {
+// `type Name = Type Expression;`
djasper wrote:
> Why is this necessary?
It is not, actually. I was chasing a wrong path here
carlo.bertolli marked 2 inline comments as done.
carlo.bertolli added a comment.
Thanks very much for the quick review. I am about to update the patch
reflecting your comments and to the latest trunk.
Comment at: include/clang/AST/StmtOpenMP.h:2884-2896
@@ +2883,15 @@
+
+ ///
$ "chmod" "u-w"
"C:\cygwin64\home\ismail\src\llvm\dist\tools\clang\test\Headers\Output\opencl-c-header.cl.tmp/*"
# command stderr:
r.cl.tmp/*: invalid mode: 'mp/*'
the error msg is strange. On my Cygwin I got different error:
chmod: cannot access
'C:\cygwin64\home\ismail\src\llvm\dist\tools\clang
Anastasia added a comment.
Alexey, do you have any additional comments?
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273425: [OpenCL] Use function metadata to represent kernel
attributes (authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D20979?vs=60545&id=61555#toc
Repository:
rL LLVM
http://r
Ilod added a comment.
Thanks.
I will let you submit it for me if everything seems ok.
http://reviews.llvm.org/D20647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1673
@@ +1672,3 @@
+ // this option was added for compatibility with OpenCL 1.0.
+ if (const Arg *A = Args.getLastArg(OPT_cl_strict_aliasing)) {
+const int OpenCLVer = Opts.OpenCLVersion;
--
kmensah added a subscriber: kmensah.
kmensah added a comment.
Friendly Ping about this
Repository:
rL LLVM
http://reviews.llvm.org/D21510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: yaxunl
Date: Wed Jun 22 09:56:35 2016
New Revision: 273425
URL: http://llvm.org/viewvc/llvm-project?rev=273425&view=rev
Log:
[OpenCL] Use function metadata to represent kernel attributes
This patch uses function metadata to represent reqd_work_group_size,
work_group_size_hint and vector_
rjmccall added a comment.
Yeah, 2048 is clearly too few. The other changes aren't necessary; if we're
going to try to be that generous, there's a lot of places in the AST that need
to be updated.
Comment at: lib/CodeGen/CGCleanup.h:61
@@ -60,3 +60,3 @@
-unsigned NumHand
hans updated this revision to Diff 61560.
hans marked 3 inline comments as done.
hans added a comment.
Addressing comments.
http://reviews.llvm.org/D21566
Files:
lib/CodeGen/CGCleanup.h
test/CodeGen/fixup-depth-overflow.c
Index: test/CodeGen/fixup-depth-overflow.c
=
hans added a comment.
Thanks for the review! Please take another look.
Comment at: lib/CodeGen/CGCleanup.h:93
@@ -92,3 +92,3 @@
/// from this index onwards belong to this scope.
-unsigned FixupDepth : 32 - 18 - NumCommonBits; // currently 12
+unsigned FixupDepth;
rjmccall added a comment.
That looks great, thanks.
http://reviews.llvm.org/D21566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added a subscriber: Prazek.
Prazek added a comment.
In http://reviews.llvm.org/D21185#464517, @Eugene.Zelenko wrote:
> Since http://reviews.llvm.org/D20964 was committed, I think we should close
> this.
Yep, I think the best idea is to take all the goodies from this check and add
it to
Author: hans
Date: Wed Jun 22 11:21:14 2016
New Revision: 273434
URL: http://llvm.org/viewvc/llvm-project?rev=273434&view=rev
Log:
Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490)
It currently only takes 2048 gotos to overflow the FixupDepth bitfield,
causing silent mi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273434: Widen EHScope::ClenupBitFields::FixupDepth to avoid
overflowing it (PR23490) (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D21566?vs=61560&id=61563#toc
Repository:
rL L
spetrovic created this revision.
spetrovic added reviewers: rjmccall, john.brawn, dsanders, petarj.
spetrovic added subscribers: cfe-commits, rankov, ivanbaev.
Herald added a reviewer: vkalintiris.
Herald added a subscriber: aemerson.
This patch fixes problem with passing structures and unions sma
On Wed, Jun 22, 2016 at 5:45 PM, Liu, Yaxun (Sam) wrote:
> $ "chmod" "u-w"
> "C:\cygwin64\home\ismail\src\llvm\dist\tools\clang\test\Headers\Output\opencl-c-header.cl.tmp/*"
> # command stderr:
> r.cl.tmp/*: invalid mode: 'mp/*'
>
> the error msg is strange. On my Cygwin I got different error:
> c
vsk abandoned this revision.
vsk added a comment.
Thanks for the valuable feedback! I'll keep all of it in mind when writing
checks in the future.
I'm closing this revision since http://reviews.llvm.org/D20964 is in.
http://reviews.llvm.org/D21185
___
The cmake of Cygwin itself does not support llvm. Which cmake did you use on
Cygwin? Thanks.
Sam
-Original Message-
From: Ismail Donmez [mailto:ism...@i10z.com]
Sent: Wednesday, June 22, 2016 12:37 PM
To: Liu, Yaxun (Sam)
Cc: cfe-commits
Subject: Re: r273191 - [OpenCL] Include opencl-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273440: Add support for /Ob1 and -finline-hint-functions
flags (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D20647?vs=61418&id=61565#toc
Repository:
rL LLVM
http://reviews.ll
Author: hans
Date: Wed Jun 22 11:56:16 2016
New Revision: 273440
URL: http://llvm.org/viewvc/llvm-project?rev=273440&view=rev
Log:
Add support for /Ob1 and -finline-hint-functions flags
Add support for /Ob1 (and equivalent -finline-hint-functions), which enable
inlining only for functions marked
Author: dcoughlin
Date: Wed Jun 22 12:03:10 2016
New Revision: 273441
URL: http://llvm.org/viewvc/llvm-project?rev=273441&view=rev
Log:
[analyzer] Teach ObjCDeallocChecker about XCTestCase
Like with SenTestCase, subclasses of XCTestCase follow a "tear down" idiom to
release instance variables and
dberris updated this revision to Diff 61567.
dberris added a comment.
- Merge branch 'master' of http://llvm.org/git/clang into xray
- Merge branch 'master' of http://llvm.org/git/clang into xray
- Add runtime support for XRay
http://reviews.llvm.org/D20352
Files:
include/clang/Basic/Attr.td
Hi,
On Wed, Jun 22, 2016 at 7:55 PM, Liu, Yaxun (Sam) wrote:
> The cmake of Cygwin itself does not support llvm. Which cmake did you use on
> Cygwin? Thanks.
I use native windows cmake and this is the only test that ever failed
with this setup. chmod is from native cygwin which seems to be the
ashi1 updated this revision to Diff 61574.
ashi1 marked 4 inline comments as done.
ashi1 added a comment.
Revised to Anastasia's comments.
http://reviews.llvm.org/D21031
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.t
vsk added a subscriber: vsk.
vsk added a comment.
Neat! It would help to upload a git-clang-format'd. Fwiw I only managed to look
over the changes in lib/{ARCMigrate,AST,Analysis}.
Have you run check-all and the full test-suite?
Repository:
rL LLVM
http://reviews.llvm.org/D21507
Author: rafael
Date: Wed Jun 22 13:04:52 2016
New Revision: 273450
URL: http://llvm.org/viewvc/llvm-project?rev=273450&view=rev
Log:
Make this test a bit more strict and fix it.
We do pass -pic-level to cc1 when targeting darwin. Given that codegen
itself doesn't use it, the only difference is wh
rjmccall added a comment.
Hmm. On MIPS64, a slot is 64 bits, right? How is a float passed?
http://reviews.llvm.org/D21611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Wed Jun 22 13:34:45 2016
New Revision: 273454
URL: http://llvm.org/viewvc/llvm-project?rev=273454&view=rev
Log:
[codeview] Set the new IntroducedVirtual debug info flag
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
cfe/trunk/test/CodeGenCXX/debug-info-ms-abi.cpp
Modif
davidsh created this revision.
davidsh added reviewers: kkwli0, hubert.reinterpretcast.
davidsh added a subscriber: cfe-commits.
Clang fails to diagnose cases such as
#pragma omp target
while(0) {
#pragma omp teams
{}
}
http://reviews.llvm.org/D21617
Files:
lib/Sema/SemaOpenMP.cp
Author: vedantk
Date: Wed Jun 22 14:57:58 2016
New Revision: 273463
URL: http://llvm.org/viewvc/llvm-project?rev=273463&view=rev
Log:
[Coverage] Push a new region when handling CXXTryStmts
Push a new region for the try block and propagate execution counts
through it. This ensures that catch state
vsk abandoned this revision.
vsk added a comment.
This change is probably too minor for pre-commit review. I rebased the patch
and committed r273463: I'd be happy to make any changes to it if requested.
http://reviews.llvm.org/D20880
___
cfe-commit
Author: atanasyan
Date: Wed Jun 22 15:00:50 2016
New Revision: 273465
URL: http://llvm.org/viewvc/llvm-project?rev=273465&view=rev
Log:
[driver][mips] Factor out findMIPSMultilibs code into separate functions. NFC
The findMIPSMultilibs is too long. One more reason for splitting is to
escape redun
jordan_rose added a comment.
*ping*
I'm happy to have someone else review this (or "LGTM" this), but it's so small
that I'm not sure who else to ask. I'd rather not just commit it cause it's
been a while since I've touched Clang.
Repository:
rL LLVM
http://reviews.llvm.org/D2
__
erik.pilkington created this revision.
erik.pilkington added reviewers: rsmith, faisalv.
erik.pilkington added a subscriber: cfe-commits.
DR1579 says that when returning a id-expression from a function, we should
attempt to return said expression by move first, then fallback to copy.
This patch
Author: atanasyan
Date: Wed Jun 22 15:20:51 2016
New Revision: 273468
URL: http://llvm.org/viewvc/llvm-project?rev=273468&view=rev
Log:
[driver] Remove empty folders from the Inputs folder for the driver's tests. NFC
Removed:
cfe/trunk/test/Driver/Inputs/android_triple_version/
cfe/trunk
Author: atanasyan
Date: Wed Jun 22 15:30:26 2016
New Revision: 273471
URL: http://llvm.org/viewvc/llvm-project?rev=273471&view=rev
Log:
[driver] Remove one more bunch of empty 'test inputs' folders. NFC
Removed:
cfe/trunk/test/Driver/Inputs/basic_nacl_tree/
cfe/trunk/test/Driver/Inputs/m
rjmccall added a comment.
Oh, floats are promoted to doubles in varargs, of course, which neatly makes
that an impossible situation.
My inclination is that the right condition here is that only integer types
should be right-justified in their slot, but I'll admit to not having an easy
example
sfantao added a comment.
Hi David,
This fix looks good but you have to add a regression test for it.
Thanks,
Samuel
http://reviews.llvm.org/D21617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
davidsh updated this revision to Diff 61612.
http://reviews.llvm.org/D21617
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/nesting_of_regions.cpp
Index: test/OpenMP/nesting_of_regions.cpp
===
--- test/OpenMP/nesting_of_regions.cpp
+
kkwli0 added a comment.
The changes look fine to me. Thanks.
http://reviews.llvm.org/D21617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Thanks David,
Let's wait for Alexey to see if he has any concerns related to this patch.
Thanks again,
Samuel
http://reviews.llvm.org/D21617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
RKSimon added inline comments.
Comment at: tools/clang/test/CodeGen/sse2-builtins.c:1526
@@ +1525,3 @@
+ // CHECK-LABEL: test_mm_loadu_si64
+ // CHECK: load i64, i64* %__u
+ // CHECK: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0
Please can add the alignmen
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Mark throw_bad_alloc_helper() as [[noreturn]].
This avoids MSVC /analyze warnings about new returning null, since [[noreturn]]
allows the analyzer to see what's happening.
ht
tigerleapgorge created this revision.
tigerleapgorge added a reviewer: rsmith.
tigerleapgorge added a subscriber: cfe-commits.
Hi Everyone,
I am continuing with updating the Lit tests for C++11 compatibility.
11 tests this time.
test/Modules/Inputs/merge-using-decls/a.h
test/Modules/Inputs/merg
ariccio added a comment.
Bump?
http://reviews.llvm.org/D18073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Add assertions to quiet analysis warnings about array bounds.
In the partial_sort tests, the N >= M assertion is just a good sanity check, to
detect bogus testcases. MSVC's /a
Author: majnemer
Date: Wed Jun 22 19:15:04 2016
New Revision: 273522
URL: http://llvm.org/viewvc/llvm-project?rev=273522&view=rev
Log:
Use ranges to concisely express iteration
No functional change is intended, this should just clean things up a
little.
Modified:
cfe/trunk/include/clang/AST/
-def fpie : Flag<["-"], "fpie">, Group;
+def fpie : Flag<["-"], "fpie">, Group, Flags<[CC1Option]>;
I don't think this is the right solution as "-fpie" doesn't mean the same
thing to the driver and CC1 is sort of confusing (in CC1 it doesn't mean
anything by itself). Can you change the existing `
jvesely added a subscriber: jvesely.
jvesely added a comment.
Why couldn't this be declared in CLC header? There are multiple instances of
declaring functions for all available types in libclc (see for example convert
functions in convert.h).
Repository:
rL LLVM
http://reviews.llvm.org/D199
ABataev requested changes to this revision.
This revision now requires changes to proceed.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:1868-1871
@@ -1867,1 +1867,6 @@
+void CodeGenFunction::EmitOMPDistributeParallelForDirective(
+const OMPDistributeParallelForDirective &S) {
+
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG with a small nit
Comment at: lib/Sema/SemaOpenMP.cpp:6384-6386
@@ -6383,1 +6383,5 @@
+} else {
+ auto *OED = dyn_cast(S);
+ if (!OED || !isOpenMPTeamsDirect
Author: ctopper
Date: Thu Jun 23 01:36:42 2016
New Revision: 273533
URL: http://llvm.org/viewvc/llvm-project?rev=273533&view=rev
Log:
[AVX512] Replace masked unpack builtins with shufflevector and selects.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cfe/trunk/lib/Headers/avx51
89 matches
Mail list logo
