Re: [PATCH] D21419: [CUDA] Don't pass top-level -march down to device cc1 or ptxas.

2016-06-15 Thread Justin Lebar via cfe-commits
jlebar updated this revision to Diff 60931. jlebar added a comment. Remove redundant test. http://reviews.llvm.org/D21419 Files: lib/Driver/ToolChains.cpp test/Driver/cuda-march.cu Index: test/Driver/cuda-march.cu === --- /dev

Re: [PATCH] D21419: [CUDA] Don't pass top-level -march down to device cc1 or ptxas.

2016-06-15 Thread Justin Lebar via cfe-commits
jlebar added inline comments. Comment at: test/Driver/cuda-march.cu:15-16 @@ +14,4 @@ + +// RUN: %clang -### -target x86_64-linux-gnu -c -march=skylake --cuda-gpu-arch=sm_30 %s 2>&1 | \ +// RUN: FileCheck -check-prefix SKYLAKE -check-prefix SM30 %s + tra wrote: >

Re: [PATCH] D19754: Allow 'nodebug' on local variables

2016-06-15 Thread David Blaikie via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. Sure, looks good - thanks. Will discuss the broader test issues later/separately. http://reviews.llvm.org/D19754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D21419: [CUDA] Don't pass top-level -march down to device cc1 or ptxas.

2016-06-15 Thread Artem Belevich via cfe-commits
tra added inline comments. Comment at: test/Driver/cuda-march.cu:22-28 @@ +21,9 @@ + +// SM30:clang +// SM30: "-cc1" +// SM30-SAME: "-triple" "nvptx +// SM30-SAME: "-target-cpu" "sm_30" +// SM30: ptxas +// SM30-SAME: "--gpu-name" "sm_30" + +// HASWELL:clang You do

Re: [PATCH] D21419: [CUDA] Don't pass top-level -march down to device cc1 or ptxas.

2016-06-15 Thread Justin Lebar via cfe-commits
jlebar updated this revision to Diff 60932. jlebar added a comment. Fix tests for real this time. http://reviews.llvm.org/D21419 Files: lib/Driver/ToolChains.cpp test/Driver/cuda-march.cu Index: test/Driver/cuda-march.cu === -

Re: [PATCH] D21419: [CUDA] Don't pass top-level -march down to device cc1 or ptxas.

2016-06-15 Thread Artem Belevich via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D21419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272857 - [CUDA] Don't pass top-level -march down to device cc1 or ptxas.

2016-06-15 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Wed Jun 15 18:46:11 2016 New Revision: 272857 URL: http://llvm.org/viewvc/llvm-project?rev=272857&view=rev Log: [CUDA] Don't pass top-level -march down to device cc1 or ptxas. Summary: Previously if you did e.g. $ clang -march=haswell -x cuda foo.cu we would pass "-march=

Re: [PATCH] D21419: [CUDA] Don't pass top-level -march down to device cc1 or ptxas.

2016-06-15 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272857: [CUDA] Don't pass top-level -march down to device cc1 or ptxas. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D21419?vs=60932&id=60935#toc Repository: rL LLVM http:/

[PATCH] clang: ignore -maccumulate_outgoing_args option

2016-06-15 Thread Austin English via cfe-commits
Hi, This fixes https://llvm.org/bugs/show_bug.cgi?id=28145 Please let me know if something needs to changed for inclusion. -- -Austin GPG: 14FB D7EA A041 937B From fd4aa56c027d8ccc38ffb7484b19194804982cbe Mon Sep 17 00:00:00 2001 From: Austin English Date: Wed, 15 Jun 2016 18:40:51 -0500 Subje

Re: [PATCH] D19754: Allow 'nodebug' on local variables

2016-06-15 Thread Paul Robinson via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272859: Allow 'nodebug' on local variables. (authored by probinson). Changed prior to commit: http://reviews.llvm.org/D19754?vs=60930&id=60940#toc Repository: rL LLVM http://reviews.llvm.org/D19754

r272859 - Allow 'nodebug' on local variables.

2016-06-15 Thread Paul Robinson via cfe-commits
Author: probinson Date: Wed Jun 15 19:42:36 2016 New Revision: 272859 URL: http://llvm.org/viewvc/llvm-project?rev=272859&view=rev Log: Allow 'nodebug' on local variables. Parameters and non-static members of aggregates are still excluded, and probably should remain that way. Differential Revisio

Re: [PATCH] clang: ignore -maccumulate_outgoing_args option

2016-06-15 Thread Reid Kleckner via cfe-commits
Actually, in the last three months we've recently added support for pushing arguments in a call sequence. I think we should wire this up to an LLVM function attribute. It should be a tiny bit of work in llvm/lib/Target/X86/X86FrameLowering.cpp and clang/lib/CodeGen/CodeGenModule.cpp:SetLLVMFunction

r272862 - [DebugInfo] Enable generation of unique identifiers for externally visible MS ABI types

2016-06-15 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Jun 15 20:21:28 2016 New Revision: 272862 URL: http://llvm.org/viewvc/llvm-project?rev=272862&view=rev Log: [DebugInfo] Enable generation of unique identifiers for externally visible MS ABI types We implemented the mangling for this a long time ago. Added: cfe/trunk/te

r272867 - [Lex] Try to fix a 'comparison is always false' warning. NFC.

2016-06-15 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Wed Jun 15 21:30:33 2016 New Revision: 272867 URL: http://llvm.org/viewvc/llvm-project?rev=272867&view=rev Log: [Lex] Try to fix a 'comparison is always false' warning. NFC. Modified: cfe/trunk/lib/Lex/PPDirectives.cpp Modified: cfe/trunk/lib/Lex/PPDirectives.cpp URL: htt

r272874 - clang/test/Driver/cuda-march.cu: Tweak not to match "clang" to other place like "path-to-clang-foo".

2016-06-15 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Thu Jun 16 01:08:09 2016 New Revision: 272874 URL: http://llvm.org/viewvc/llvm-project?rev=272874&view=rev Log: clang/test/Driver/cuda-march.cu: Tweak not to match "clang" to other place like "path-to-clang-foo". Modified: cfe/trunk/test/Driver/cuda-march.cu Modified:

Re: [PATCH] D21407: Enable building and using atomic shared_ptr for GCC.

2016-06-15 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. LGTM. I'll leave you to commit if Marshall has no objection. Thanks! / Asiri http://reviews.llvm.org/D21407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

<    1   2