Re: [PATCH] D21320: Alternative to D1332

EricWF added a comment. If we choose to special case this I think we *need* to do it with a new specialization of `default_delete`, not using the primary template. The primary templates defines `default_delete::pointer` as `T*[N]`, which `T*` will not convert to. That means this patch still rej

Re: [PATCH] D20339: Update clang for D20260

pcc added a comment. Thanks, the patch I committed adds `-cl-opt-disable` to the tests. Repository: rL LLVM http://reviews.llvm.org/D20339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D21346: [libcxx] [test] Improve portability of random_device tests.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Improve portability of random_device tests. These tests were failing for MSVC, because we ignore the token (as permitted by the Standard). Marking the asserts as libcxx-specif

[PATCH] D21347: [libcxx] [test] Improve portability of hash tests.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Improve portability of hash tests. These tests were expecting libcxx's identity-hash behavior, which isn't guaranteed by the Standard and isn't provided by MSVC (we currently

[PATCH] D21348: [libcxx] [test] Improve portability of vector tests.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Improve portability of vector tests. This test was assuming libcxx's 2x growth factor, which isn't guaranteed by the Standard and isn't provided by MSVC (we use 1.5x). As a re

Re: [PATCH] D21345: [libcxx] [test] Avoid huge main() functions and huge arrays.

bcraig added a subscriber: bcraig. bcraig added a comment. > Even though they have artificial blocks in order to keep variables locally > scoped, this gives MSVC's /analyze a headache, because it views main() as > consuming an enormous amount of stack space (it doesn't reuse stack, at least > f

[PATCH] D21349: [libcxx] [test] Fix a typo in commented-out code.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix a typo in commented-out code. http://reviews.llvm.org/D21349 Files: test/std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp Index: test/std/utilit

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM Please also check if the documentation needs to be updated. Repository: rL LLVM http://reviews.llvm.org/D21317 ___ cfe-commits mailing list cfe

Re: [PATCH] D21098: [libcxx] [test] Replace __cplusplus comparisons with TEST_STD_VER and __has_feature with TEST_HAS_FEATURE.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Thank you! I'll commit once my test-suite with -Wundef finishes. http://reviews.llvm.org/D21098 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

rmaprath added a comment. In http://reviews.llvm.org/D16948#457266, @EricWF wrote: > Add `LIBCXX_ENABLE_FILESYSTEM` CMake option to turn off only the filesystem > parts of `libc++experimental.a`. Thanks! http://reviews.llvm.org/D16948 ___ cfe-co

[PATCH] D21350: [libcxx] [test] Avoid C++17 terse static_assert.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. TOTALLY OPTIONAL, feel free to reject this, I won't mind. Newly-added libcxx tests for C++17 features have been using C++17 terse static_asserts occasionally. This is problema

Re: [PATCH] D21345: [libcxx] [test] Avoid huge main() functions and huge arrays.

bcraig added a comment. LGTM. I don't see anything controversial here. If you want to wait for @EricWF or @mclow.lists though, that's fine. http://reviews.llvm.org/D21345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D21345: [libcxx] [test] Avoid huge main() functions and huge arrays.

STL_MSFT added a comment. I gotta wait for them, I don't have commit access. :-> (Nor do I need it at the moment) Haven't encountered problems with those locale tests yet, although I'm still processing 670-ish compiletime and runtime failures. http://reviews.llvm.org/D21345 ___

[PATCH] D21352: Add a "declared 'nonnull' here" note to warnings where an expression is checked against null.

nlewycky created this revision. nlewycky added a subscriber: cfe-commits. Point to the relevant 'nonnull' or 'returns_nonnull' attribute when complaining about 'a == 0' or 'f() == 0' expressions. http://reviews.llvm.org/D21352 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaC

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 8 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

eugenis updated this revision to Diff 60759. eugenis added a comment. + docs Repository: rL LLVM http://reviews.llvm.org/D21317 Files: docs/SanitizerCoverage.rst lib/Driver/SanitizerArgs.cpp test/Driver/fsanitize-coverage.c Index: test/Driver/fsanitize-coverage.c =

r272717 - [sanitizer] Allow sanitize coverage w/o sanitizers.

Author: eugenis Date: Tue Jun 14 16:33:40 2016 New Revision: 272717 URL: http://llvm.org/viewvc/llvm-project?rev=272717&view=rev Log: [sanitizer] Allow sanitize coverage w/o sanitizers. The reason is that this (a) seems to work just fine and (b) useful when building stuff with sanitizer+coverage

Re: [PATCH] D21098: [libcxx] [test] Replace __cplusplus comparisons with TEST_STD_VER and __has_feature with TEST_HAS_FEATURE.

EricWF closed this revision. EricWF added a comment. Only 4 missing `#include "test_macros.h"`, and I'm sure all of them were my fault. Committed as r272716. Thanks again. I owe you a case of your preferred caffeine fix. http://reviews.llvm.org/D21098 __

r272720 - [OpenCL] Enable -fblocks by default for OpenCL 2.0 and above.

Author: yaxunl Date: Tue Jun 14 16:43:01 2016 New Revision: 272720 URL: http://llvm.org/viewvc/llvm-project?rev=272720&view=rev Log: [OpenCL] Enable -fblocks by default for OpenCL 2.0 and above. Reviewed as part of http://reviews.llvm.org/D20444 Added: cfe/trunk/test/Frontend/opencl-blocks.c

[libcxx] r272722 - Fix bad test that was previously getting ifdef-ed away

Author: ericwf Date: Tue Jun 14 16:50:30 2016 New Revision: 272722 URL: http://llvm.org/viewvc/llvm-project?rev=272722&view=rev Log: Fix bad test that was previously getting ifdef-ed away Modified: libcxx/trunk/test/std/utilities/time/time.traits/time.traits.is_fp/treat_as_floating_point.pas

Re: [PATCH] D21241: Add an ASTMatcher for ignoring ExprWithCleanups.

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:629 @@ +628,3 @@ +/// \brief Matches expressions that match InnerMatcher after ExprWithCleanups +/// are stripped off. +AST_MATCHER_P(Expr, ignoringExprWithCleanups, internal::Matcher, ---

[libcxx] r272723 - Automatically detect export lists for OS X.

Author: ericwf Date: Tue Jun 14 16:55:14 2016 New Revision: 272723 URL: http://llvm.org/viewvc/llvm-project?rev=272723&view=rev Log: Automatically detect export lists for OS X. Summary: Libc++ reexports symbols from the system libc++abi using -reexport_symbols_list. This can cause a linker failu

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Prazek accepted this revision. Prazek added a comment. This revision is now accepted and ready to land. shipit LGTM Comment at: clang-tidy/modernize/UseUsingCheck.cpp:71 @@ +70,3 @@ + const auto *MatchedDecl = Result.Nodes.get

Re: [llvm-dev] [RFC] Embedded bitcode and related upstream (Part II)

On Mon, Jun 13, 2016 at 9:37 AM Steven Wu wrote: > Thanks for the feedback! Replies inline. > > On Jun 12, 2016, at 11:44 PM, Eric Christopher wrote: > > Hi Steven, > > Great to see the commentary and updates here. I've got a few questions > about some of this work. It might be nice to see some

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

howard.hinnant added a comment. I created a top-level `gcd` which did nothing but make everything unsigned and do the abs once, and then called a `__gcd` specialized for unsigned and only one kind of unsigned, and got measurably faster results (about 10%). template constexpr std::enable_i

Buildbot numbers for the last week of 6/05/2016 - 6/11/2016

Hello everyone, Below are some buildbot numbers for the last week of 6/05/2016 - 6/11/2016. Thanks Galina buildername | was_red ---+--- sanitizer-x86_64-linux-bootstrap

r272735 - Fix sanitizer coverage support in the win32 driver.

Author: eugenis Date: Tue Jun 14 18:21:19 2016 New Revision: 272735 URL: http://llvm.org/viewvc/llvm-project?rev=272735&view=rev Log: Fix sanitizer coverage support in the win32 driver. --dependent-lib arguments for the sanitizer libraries must be emitted when coverage is enabled w/o any sanitize

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

EricWF added inline comments. Comment at: include/experimental/numeric:44 @@ +43,3 @@ + +_LIBCPP_BEGIN_NAMESPACE_EXPERIMENTAL + This should be `_LIBCPP_BEGIN_NAMESPACE_LFTS`. Comment at: include/experimental/numeric:46 @@ +45,3 @@ + +template ::v

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

howard.hinnant added a comment. Can't call `std::abs` as it isn't `constexpr`. You'll have to roll your own. http://reviews.llvm.org/D21343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

EricWF added a comment. Gosh darn it Howard. Your like 10 minutes ahead of me. Here is a constexpr gcd test. https://gist.github.com/EricWF/46ea4489f405ec9f83325a278fe99535 Comment at: include/experimental/numeric:50 @@ +49,3 @@ +struct __abs<_Tp, true> { + _LIBCPP_INLINE

r272741 - Headers: tweak for MSVC[<1800]

Author: compnerd Date: Tue Jun 14 19:28:15 2016 New Revision: 272741 URL: http://llvm.org/viewvc/llvm-project?rev=272741&view=rev Log: Headers: tweak for MSVC[<1800] Earlier versions of MSVC did not include inttypes.h. Ensure that we dont try to include_next on those releases. Modified: cfe

Re: [PATCH] D21352: Add a "declared 'nonnull' here" note to warnings where an expression is checked against null.

george.burgess.iv added a subscriber: george.burgess.iv. george.burgess.iv accepted this revision. george.burgess.iv added a reviewer: george.burgess.iv. george.burgess.iv added a comment. This revision is now accepted and ready to land. LGTM, thanks for the patch! http://reviews.llvm.org/D21352

Re: [llvm-dev] [RFC] Embedded bitcode and related upstream (Part II)

> On Jun 13, 2016, at 9:37 AM, Steven Wu wrote: > > Thanks for the feedback! Replies inline. > >> On Jun 12, 2016, at 11:44 PM, Eric Christopher > > wrote: >> >> Hi Steven, >> >> Great to see the commentary and updates here. I've got a few questions about >> some

Re: [llvm-dev] [RFC] Embedded bitcode and related upstream (Part II)

On Tue, Jun 14, 2016 at 6:09 PM Adrian Prantl wrote: > On Jun 13, 2016, at 9:37 AM, Steven Wu wrote: > > Thanks for the feedback! Replies inline. > > On Jun 12, 2016, at 11:44 PM, Eric Christopher wrote: > > Hi Steven, > > Great to see the commentary and updates here. I've got a few questions >

Re: [libcxx] r272634 - Implement variadic lock_guard.

Update on the bot failures: I've spoken to the owner of the bots and they are planning to upgrade their Clang versions. This will get the bots green again. /Eric On Mon, Jun 13, 2016 at 11:49 PM, Eric Fiselier wrote: > This is causing some of the libc++ bots to go red. > `variadic_copy.fail.cp

Re: [PATCH] D21349: [libcxx] [test] Fix a typo in commented-out code.

EricWF added a comment. Deferring this to @mclow.lists because he commented out those tests and hopefully its' time they get uncommented. http://reviews.llvm.org/D21349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[libcxx] r272744 - Improve portability of hash tests. Patch from s...@microsoft.com

Author: ericwf Date: Tue Jun 14 20:42:35 2016 New Revision: 272744 URL: http://llvm.org/viewvc/llvm-project?rev=272744&view=rev Log: Improve portability of hash tests. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/diagnostics/syserr/syserr.hash/error_code.pass.cpp libcxx/t

Re: [PATCH] D21347: [libcxx] [test] Improve portability of hash tests.

EricWF closed this revision. EricWF added a comment. r272744. http://reviews.llvm.org/D21347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272745 - Improve portability of vector tests. Patch from s...@microsoft.com

Author: ericwf Date: Tue Jun 14 20:44:22 2016 New Revision: 272745 URL: http://llvm.org/viewvc/llvm-project?rev=272745&view=rev Log: Improve portability of vector tests. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/containers/sequences/vector/vector.capacity/shrink_to_fit.pa

Re: [PATCH] D21348: [libcxx] [test] Improve portability of vector tests.

EricWF closed this revision. EricWF added a comment. r272745. http://reviews.llvm.org/D21348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272746 - Improve portability of random_device tests. Patch from s...@microsoft.com

Author: ericwf Date: Tue Jun 14 20:50:31 2016 New Revision: 272746 URL: http://llvm.org/viewvc/llvm-project?rev=272746&view=rev Log: Improve portability of random_device tests. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/numerics/rand/rand.device/ctor.pass.cpp libcxx/tru

Re: [PATCH] D21346: [libcxx] [test] Improve portability of random_device tests.

EricWF closed this revision. EricWF added a comment. r272746. http://reviews.llvm.org/D21346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Buildbot numbers for the last week of 6/05/2016 - 6/11/2016

Some of these tables are getting quite mangled somewhere along the line (email client? mailing list handling? idk). Could you re-send with the tables also attached or something else that avoids that problem? -- Sean Silva On Tue, Jun 14, 2016 at 4:23 PM, Galina Kistanova via cfe-commits < cfe-co

[libcxx] r272747 - [libcxx] [test] In test/support/test_allocator.h, fix construct() to avoid moving immovable types.

Author: ericwf Date: Tue Jun 14 20:53:32 2016 New Revision: 272747 URL: http://llvm.org/viewvc/llvm-project?rev=272747&view=rev Log: [libcxx] [test] In test/support/test_allocator.h, fix construct() to avoid moving immovable types. Summary: In test/support/test_allocator.h, fix construct() to av

Re: [PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

bryanpkc added a comment. Ping? http://reviews.llvm.org/D14727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r272604 - [docs] Coverage: Document the profile merge pool specifier

Thanks! On Tue, Jun 14, 2016 at 10:30 AM, Vedant Kumar wrote: > I think David got rid of that limitation. > > The related warning in compiler-rt does not reflect this: > > PROF_WARN("%%m specifier can only be specified once at the end of > %s.\n", ...); > > Fixed the warning in r272685. > > th

Re: [PATCH] D21030: [Sema] Fix rejects-valid where parameter pack was not expanded in type alias

faisalv added a comment. Thanks for working on this bug too! Comment at: lib/Sema/TreeTransform.h:4784 @@ +4783,3 @@ +NewType = getDerived().RebuildPackExpansionType( +NewType, SourceRange(), Loc, NumExpansions); +if (NewType.isNull()) ---

r272755 - Add a "declared 'nonnull' here" note to warnings where an expression is checked against null.

Author: nicholas Date: Wed Jun 15 00:18:39 2016 New Revision: 272755 URL: http://llvm.org/viewvc/llvm-project?rev=272755&view=rev Log: Add a "declared 'nonnull' here" note to warnings where an expression is checked against null. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D21352: Add a "declared 'nonnull' here" note to warnings where an expression is checked against null.

nlewycky closed this revision. nlewycky added a comment. Closed by r272755. http://reviews.llvm.org/D21352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

berenm added a comment. It looks like it doesn't like the `operator[]` either: struct test { long long int foo(); int operator[](int a); double bar(); long long int foo(); int operator()(int a); double bar(); }; becomes: struct test { long long int foo();

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper added a comment. Interesting. Working on it! http://reviews.llvm.org/D21279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2