Re: [PATCH] D20909: [clang-tidy] Ignore function context in misc-unused-using-decls.

hokein updated this revision to Diff 59492. hokein added a comment. Address code comments. http://reviews.llvm.org/D20909 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp clang-tidy/misc/UnusedUsingDeclsCheck.h test/clang-tidy/misc-unused-using-decls.cpp Index: test/clang-tidy/misc-unuse

[clang-tools-extra] r271632 - [clang-tidy] Ignore function context in misc-unused-using-decls.

Author: hokein Date: Fri Jun 3 03:05:11 2016 New Revision: 271632 URL: http://llvm.org/viewvc/llvm-project?rev=271632&view=rev Log: [clang-tidy] Ignore function context in misc-unused-using-decls. Summary: Make the check's behavior more correct when handling using-decls in multiple scopes. Rev

Re: [PATCH] D20909: [clang-tidy] Ignore function context in misc-unused-using-decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271632: [clang-tidy] Ignore function context in misc-unused-using-decls. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20909?vs=59492&id=59494#toc Repository: rL LLVM http:

Re: [PATCH] D20902: [include-fixer] added GNU symbols hardcoded header mapping.

bkramer added a comment. There are still headers in this list that aren't part of glibc, like curses. I'd rather have those not in the list right now and add stuff as-needed later. I hope that other packages usually found in /usr/include are saner so we don't need to add a header map for them.

[PATCH] D20950: [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. The further solution is to add the missing header to the file where the symbol comes from. http://reviews.llvm.org/D20950 Files: include-fixer/IncludeFixer.cpp unittests/include-fixer/Incl

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

ioeric updated this revision to Diff 59497. ioeric added a comment. - Use FormatTokenLexer to skip comments. http://reviews.llvm.org/D20898 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp

Re: [PATCH] D20902: [include-fixer] added GNU symbols hardcoded header mapping.

ioeric updated this revision to Diff 59499. ioeric added a comment. - Removed non glibc header mapping. http://reviews.llvm.org/D20902 Files: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp Index: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp =

[libcxx] r271634 - [libcxx] Fix thread join.pass.cpp segfault after r271475

Author: asiri Date: Fri Jun 3 03:45:26 2016 New Revision: 271634 URL: http://llvm.org/viewvc/llvm-project?rev=271634&view=rev Log: [libcxx] Fix thread join.pass.cpp segfault after r271475 Some pthread implementations do not like being called pthead_join() with the pthread_t argument set to 0, an

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

djasper added inline comments. Comment at: lib/Format/Format.cpp:1484 @@ +1483,3 @@ + Environment::CreateVirtualEnvironment(Code, FileName, /*Ranges=*/{}); + FormatTokenLexer Lexer(Env->getSourceManager(), Env->getFileID(), Style, + encoding::detectEn

Re: [PATCH] D20908: Add a few missing Clang regression tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL271636: Add a few missing Clang regression tests for Cortex-A53, Cortex-A57, Cortex-A72 (authored by SjoerdMeijer). Changed prior to commit: http://reviews.llvm.org/D20908?vs=59371&id=59500#toc Reposit

r271636 - Add a few missing Clang regression tests for Cortex-A53, Cortex-A57, Cortex-A72

Author: sjoerdmeijer Date: Fri Jun 3 03:47:56 2016 New Revision: 271636 URL: http://llvm.org/viewvc/llvm-project?rev=271636&view=rev Log: Add a few missing Clang regression tests for Cortex-A53, Cortex-A57, Cortex-A72 Differential Revision: http://reviews.llvm.org/D20908 Modified: cfe/trunk

Re: [PATCH] D20929: [libcxx] Fix join.pass.cpp segfault after r271475

rmaprath closed this revision. rmaprath added a comment. Thanks. Fixed in r271634. http://reviews.llvm.org/D20929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet updated this revision to Diff 59502. courbet added a comment. Rebase on origin/master http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTContext.c

Re: [PATCH] D20874: [libcxx] Two more threading dependencies

rmaprath updated this revision to Diff 59507. rmaprath added a comment. Added a comment about `~std::thread()` hook. @EricWF: Gentle ping. http://reviews.llvm.org/D20874 Files: include/__threading_support src/thread.cpp Index: src/thread.cpp ===

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

ioeric updated this revision to Diff 59508. ioeric added a comment. - Use regular Lexer instead of FormatTokenLexer. http://reviews.llvm.org/D20898 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

ioeric updated this revision to Diff 59510. ioeric marked an inline comment as done. ioeric added a comment. - Switch back to range-base looping for Lines. http://reviews.llvm.org/D20898 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp =

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

ioeric updated this revision to Diff 59511. ioeric added a comment. - Nits fixed. http://reviews.llvm.org/D20898 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp === --- uni

Re: [PATCH] D20902: [include-fixer] added GNU symbols hardcoded header mapping.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg, thanks! http://reviews.llvm.org/D20902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet added a comment. @sbenza @aaron.ballman I don't have write access. Can one of you submit this on my behalf ? Thanks ! http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[clang-tools-extra] r271637 - [include-fixer] added GNU symbols hardcoded header mapping.

Author: ioeric Date: Fri Jun 3 04:25:03 2016 New Revision: 271637 URL: http://llvm.org/viewvc/llvm-project?rev=271637&view=rev Log: [include-fixer] added GNU symbols hardcoded header mapping. Summary: [include-fixer] added GNU symbols hardcoded header mapping. Reviewers: klimek, bkramer Subscr

Re: [PATCH] D20902: [include-fixer] added GNU symbols hardcoded header mapping.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271637: [include-fixer] added GNU symbols hardcoded header mapping. (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D20902?vs=59499&id=59513#toc Repository: rL LLVM http://rev

[clang-tools-extra] r271638 - [include-fixer] fixed a wrong header mapping.

Author: ioeric Date: Fri Jun 3 04:33:22 2016 New Revision: 271638 URL: http://llvm.org/viewvc/llvm-project?rev=271638&view=rev Log: [include-fixer] fixed a wrong header mapping. Modified: clang-tools-extra/trunk/include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp Modified: clang-tools-

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath updated this revision to Diff 59519. rmaprath added a comment. Added a comment about `__static_threading` and `__dynamic_threading` header includes. @EricWF: Ping (sorry). http://reviews.llvm.org/D20328 Files: CMakeLists.txt include/__config include/__config_site.in include/_

r271647 - [mips] Slightly simplify MipsTargetInfo::setDataLayout(). NFC.

Author: dsanders Date: Fri Jun 3 05:11:01 2016 New Revision: 271647 URL: http://llvm.org/viewvc/llvm-project?rev=271647&view=rev Log: [mips] Slightly simplify MipsTargetInfo::setDataLayout(). NFC. Summary: Reviewers: atanasyan Subscribers: atanasyan, cfe-commits Differential Revision: http://

Re: [PATCH] D20950: [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. LG. It's a bit sad but I guess the cases where that legitimately can happen due to template weirdness are far outweighed by the cases where we have a non-self contained header. The cases I'v

[clang-tools-extra] r271660 - [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file.

Author: hokein Date: Fri Jun 3 06:26:02 2016 New Revision: 271660 URL: http://llvm.org/viewvc/llvm-project?rev=271660&view=rev Log: [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file. Summary: The further solution is to add the missing header to the fi

Re: [PATCH] D20950: [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271660: [include-fixer] Don't add missing header if the unindentified symbol isn't… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20950?vs=59496&id=59529#toc Repository: rL

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

sepavloff updated this revision to Diff 59532. sepavloff added a comment. Fixed test for friend functions. http://reviews.llvm.org/D16989 Files: include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp test/SemaCXX/PR25848.cpp test/SemaCXX/friend2.cpp Index: test/SemaCXX/friend2.cpp ===

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D20898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet added a comment. That could work :) I'm not sure my commit history is considered a "track record of submitting high quality patches" but I'll give it a try. http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D20133: [OpenCL] Fix __builtin_astype for vec3 types.

Anastasia added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:3394 @@ +3393,3 @@ + if (NumElementsDst == 4) +Args.push_back(llvm::UndefValue::get(CGF.Int32Ty)); + llvm::Constant *Mask = llvm::ConstantVector::get(Args); should this be 3 unstead of

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

Just ask Chris for the access :) 03.06.2016 11:26 AM "Clement Courbet via cfe-commits" < cfe-commits@lists.llvm.org> napisał(a): > courbet added a comment. > > @sbenza @aaron.ballman I don't have write access. Can one of you submit > this on my behalf ? Thanks ! > > > http://reviews.llvm.org/D1932

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

DmitryPolukhin added a comment. In http://reviews.llvm.org/D18035#447473, @hfinkel wrote: > FYI: There is now a specification, see: > http://sourcerytools.com/pipermail/cxx-abi-dev/2016-June/002919.html For the records, this patch implements GCC 6 abi_tag semantic and to the best of my knowle

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

hfinkel added a comment. In http://reviews.llvm.org/D18035#448002, @DmitryPolukhin wrote: > In http://reviews.llvm.org/D18035#447473, @hfinkel wrote: > > > FYI: There is now a specification, see: > > http://sourcerytools.com/pipermail/cxx-abi-dev/2016-June/002919.html > > > ... > But as far a

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

murrayc updated this revision to Diff 59537. murrayc added a comment. Combined into one check. Also specifies C++11 for the test. http://reviews.llvm.org/D20857 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ExplicitOperatorBoolCheck.cpp clang-tidy/modernize/ExplicitOpera

Re: [PATCH] D20732: Don't use static variables in LambdaCapture

john.brawn added a comment. Ping Repository: rL LLVM http://reviews.llvm.org/D20732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271664 - [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

Author: ioeric Date: Fri Jun 3 07:52:59 2016 New Revision: 271664 URL: http://llvm.org/viewvc/llvm-project?rev=271664&view=rev Log: [clang-format] skip empty lines and comments in the top of the code when inserting new headers. Summary: [clang-format] skip empty lines and comments in the top of

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271664: [clang-format] skip empty lines and comments in the top of the code when… (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D20898?vs=59511&id=59538#toc Repository: rL LL

Re: [PATCH] D20858: [clang-format] make header guard identification stricter in header insertion.

ioeric abandoned this revision. ioeric added a comment. Abandon this patch in favor of http://reviews.llvm.org/D20959 http://reviews.llvm.org/D20858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

bcraig added a comment. In http://reviews.llvm.org/D20933#447608, @zaks.anna wrote: > Does FoldingSet already have reserve? (I do not see it.) The reserve call would be new. I'm attempting to add it in this llvm review: http://reviews.llvm.org/D20930 > My understanding is that you propose to

[PATCH] D20959: [clang-format] make header guard identification stricter (with Lexer).

ioeric created this revision. ioeric added a reviewer: djasper. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. make header guard identification stricter with Lexer. http://reviews.llvm.org/D20959 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index

Re: [PATCH] D20959: [clang-format] make header guard identification stricter (with Lexer).

djasper added inline comments. Comment at: lib/Format/Format.cpp:1441 @@ +1440,3 @@ +void skipComments(Lexer &Lex, Token &Tok) { + while (!Lex.LexFromRawLexer(Tok)) +if (Tok.isNot(tok::comment)) I'd modify this to: while (Tok.is(comment)) if (Lex.LexFr

[PATCH] D20960: [include-fixer] Be smarter about inserting symbols for a prefix.

bkramer created this revision. bkramer added reviewers: hokein, ioeric. bkramer added a subscriber: cfe-commits. If prefix search finds something where nothing can be nested under (e.g. a variable or macro) don't add it to the result. This is for cases like: header.h: extern int a; file.cc: na

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

teemperor added a comment. Size changes to clang's binary (build with clang): Release: 63367728 Byte -> 6326141 Byte (0.2% less, -106kB) Debug: 1239669408 Byte -> 1264216256 Byte (2% increase, +24.5 MB) http://reviews.llvm.org/D20382 ___ cfe-commi

Re: [PATCH] D20959: [clang-format] make header guard identification stricter (with Lexer).

ioeric updated this revision to Diff 59549. ioeric marked 3 inline comments as done. ioeric added a comment. - Addressed reviewer's comments. http://reviews.llvm.org/D20959 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp ===

Re: [PATCH] D20960: [include-fixer] Be smarter about inserting symbols for a prefix.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. LG. http://reviews.llvm.org/D20960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D20960: [include-fixer] Be smarter about inserting symbols for a prefix.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271671: [include-fixer] Be smarter about inserting symbols for a prefix. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D20960?vs=59545&id=59550#toc Repository: rL LLVM http://r

[clang-tools-extra] r271671 - [include-fixer] Be smarter about inserting symbols for a prefix.

Author: d0k Date: Fri Jun 3 09:07:38 2016 New Revision: 271671 URL: http://llvm.org/viewvc/llvm-project?rev=271671&view=rev Log: [include-fixer] Be smarter about inserting symbols for a prefix. If prefix search finds something where nothing can be nested under (e.g. a variable or macro) don't ad

r271672 - RAS extensions are part of ARMv8.2.

Author: sjoerdmeijer Date: Fri Jun 3 09:08:20 2016 New Revision: 271672 URL: http://llvm.org/viewvc/llvm-project?rev=271672&view=rev Log: RAS extensions are part of ARMv8.2. This patch enables +ras +noras to AArch64 in clang. Patch by: Roger Ferrer Ibanez and Oliver Stannard Differential Revis

Re: [PATCH] D20283: Add ras/noras flag to enable/disable RAS in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL271672: RAS extensions are part of ARMv8.2. (authored by SjoerdMeijer). Changed prior to commit: http://reviews.llvm.org/D20283?vs=57451&id=59551#toc Repository: rL LLVM http://reviews.llvm.org/D202

[PATCH] D20961: [mips] Replace almost all Arch checks in MipsTargetInfo with ABI checks. NFC.

dsanders created this revision. dsanders added a reviewer: atanasyan. dsanders added a subscriber: cfe-commits. setABI() is still tied to the Arch component of the Triple to preserve existing behaviour. http://reviews.llvm.org/D20961 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp =

[PATCH] D20963: [mips] The P5600 does not support N32/N64 since it's a 32-bit CPU.

dsanders created this revision. dsanders added a reviewer: atanasyan. dsanders added a subscriber: cfe-commits. dsanders added a dependency: D20961: [mips] Replace almost all Arch checks in MipsTargetInfo with ABI checks. NFC.. Herald added a subscriber: sdardis. Depends on D20961 http://reviews

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59558. Prazek added a comment. - Fix http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceCheck.h docs/Release

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:57 @@ +56,3 @@ + + auto functionNameSourceRange = CharSourceRange::getCharRange( + PushBackExpr->getExprLoc(), Call->getArg(0)->getExprLoc()); capital letter? ===

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:28 @@ +27,3 @@ + + auto callPushBack = + cxxMemberCallExpr(hasDeclaration(functionDecl(hasName(PushBackName))), Shouldn't it start with an uppercase letter? =

[PATCH] D20966: [include-fixer] Add the missing header to the file where the unidentified symbol comes from.

hokein created this revision. hokein added reviewers: bkramer, ioeric. hokein added a subscriber: cfe-commits. http://reviews.llvm.org/D20966 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp include-fixer/tool/clang-include

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 4 inline comments as done. Comment at: docs/clang-tidy/checks/modernize-use-emplace.rst:6 @@ +5,3 @@ + +This check would look for cases when inserting new element into an STL +container, but the element is constructed temporarily or is constructed just --

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59561. Prazek marked an inline comment as done. Prazek added a comment. Fixed stuff http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/UseEmplaceCheck.cpp docs/ReleaseNotes.rst docs/clang-tidy/checks/modernize-use-emplace.rst Index: docs/clang

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59562. Prazek added a comment. Learning how to use arc http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceChec

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 4 inline comments as done. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:29 @@ +28,3 @@ + auto callPushBack = + cxxMemberCallExpr(hasDeclaration(functionDecl(hasName(PushBackName))), +on(hasType(cxxRecordDecl(hasName(VectorName)))

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 2 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D20964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

dblaikie added a subscriber: dblaikie. dblaikie added a comment. Could you describe in more detail (ideally in the original patch review summary/description) what this transformation does? Under what conditions does it suggest emplace, etc. http://reviews.llvm.org/D20964 ___

Re: [PATCH] D20961: [mips] Replace almost all Arch checks in MipsTargetInfo with ABI checks. NFC.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D20963: [mips] The P5600 does not support N32/N64 since it's a 32-bit CPU.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:30 @@ +29,3 @@ + cxxMemberCallExpr(hasDeclaration(functionDecl(hasName(PushBackName))), +on(hasType(cxxRecordDecl(hasName(VectorName) + .bind("call"); -

Re: [PATCH] D20053: [clang-tidy] Add misc-unnecessary-mutable check.

etienneb added inline comments. Comment at: clang-tidy/misc/UnnecessaryMutableCheck.cpp:23 @@ +22,3 @@ + +// Matcher checking if the declaration is non-macro existent mutable which is +// not dependent on context. add an anonymous namespace around this declaration

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:31 @@ +30,3 @@ +on(hasType(cxxRecordDecl(hasName(VectorName) + .bind("call"); + ok, std::list works for me. I just don't want to spend much time

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59568. Prazek added a comment. - Post review fix http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceCheck.h

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:40 @@ +39,3 @@ + // passed pointer because smart pointer won't be constructed + // (and destructed) as in push_back case. + auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl(

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7347 @@ -7346,3 +7346,3 @@ def err_blocks_disable : Error<"blocks support disabled - compile with -fblocks" - " or pick a deployment target that supports them">; + " or %select{pick a deplo

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! http://reviews.llvm.org/D20090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 2 inline comments as done. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:40 @@ +39,3 @@ + // passed pointer because smart pointer won't be constructed + // (and destructed) as in push_back case. + auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl( -

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:40 @@ +39,3 @@ + // passed pointer because smart pointer won't be constructed + // (and destructed) as in push_back case. + auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl(

r271688 - Obj-C: Fix assert-on-invalid (PR27822)

Author: hans Date: Fri Jun 3 11:59:13 2016 New Revision: 271688 URL: http://llvm.org/viewvc/llvm-project?rev=271688&view=rev Log: Obj-C: Fix assert-on-invalid (PR27822) Clang would assert when isObjCInstancetype() was called on a tok::annot_cxxscope token. Modified: cfe/trunk/include/clang/

Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

Anastasia added a comment. Do you think we could add any test for this change? Comment at: lib/CodeGen/BackendUtil.cpp:657 @@ -627,2 +656,3 @@ + bool EmitAssemblyHelper::AddEmitPasses(BackendAction Action, Remove the empty line please Commen

r271689 - Fix test for LLVM_LIBDIR_SUFFIX=64 case.

Author: ismail Date: Fri Jun 3 12:06:52 2016 New Revision: 271689 URL: http://llvm.org/viewvc/llvm-project?rev=271689&view=rev Log: Fix test for LLVM_LIBDIR_SUFFIX=64 case. Modified: cfe/trunk/test/Driver/android-ndk-standalone.cpp Modified: cfe/trunk/test/Driver/android-ndk-standalone.cpp

Re: r271427 - [driver][arm] add armv7 and thumb include and lib paths

Fixed in r271689. On Fri, Jun 3, 2016 at 9:55 AM, Ismail Donmez wrote: > This is due to lib vs lib64. Will fix. Sorry for the wrong diagnosis :) > > On Thu, Jun 2, 2016 at 8:24 PM, Chih-hung Hsieh wrote: >> Ismail, >> I saw that android-ndk-standalone.cpp has already -stdlib=libstdc++. >> Could

RE: r271413 - Fixup list of available extensions

Hi Jan, In the future could you please keep "[OpenCL]" prefix for all commit messages related to OpenCL. :) Thanks, Anastasia -Original Message- From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Jan Vesely via cfe-commits Sent: 01 June 2016 19:05 To: cfe-commi

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think will be good idea to try this check with LLVM STL too. Comment at: docs/clang-tidy/checks/modernize-use-emplace.rst:47 @@ +46,3 @@ + +In this case the calls of push_back won't be replaced.

Re: Don't pass --build-id by default.

On 2 June 2016 at 21:19, Hal Finkel via cfe-commits wrote: > - Original Message - >> From: "Rafael Espíndola" >> To: "Hal Finkel" >> Cc: "cfe-commits cfe" >> Sent: Thursday, June 2, 2016 7:06:26 PM >> Subject: Re: Don't pass --build-id by default. >> >> > This is going to break a lot of

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

cameron314 updated the summary for this revision. cameron314 removed rL LLVM as the repository for this revision. cameron314 updated this revision to Diff 59577. cameron314 added a comment. It took some modifications to the ASTUnit to support a virtual file system with a PCH parse/reparse (prelim

r271692 - Don't pass --build-id to ld by default.

Author: rafael Date: Fri Jun 3 12:26:16 2016 New Revision: 271692 URL: http://llvm.org/viewvc/llvm-project?rev=271692&view=rev Log: Don't pass --build-id to ld by default. We now have a cmake option to change the default: ENABLE_LINKER_BUILD_ID. The reason is that build-id is fairly expensive,

Re: Don't pass --build-id by default.

r271692, thanks. Cheers, Rafael On 3 June 2016 at 10:19, Ed Maste wrote: > On 2 June 2016 at 21:19, Hal Finkel via cfe-commits > wrote: >> - Original Message - >>> From: "Rafael Espíndola" >>> To: "Hal Finkel" >>> Cc: "cfe-commits cfe" >>> Sent: Thursday, June 2, 2016 7:06:26 PM >>>

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Hi Jeroen, I am not quite sure what your question is about in (a). Regarding (b) please see example in test/SemaOpenCL/extensions.cl from the commit r269670. Please note that SPIR target supports all extensions but disables them by default (see commit r269670). The latter logic hasn't been mod

Re: r271413 - Fixup list of available extensions

of course. sorry about that. I didn't realize the patches had different title from phabricator. Jan On Fri, 2016-06-03 at 17:14 +, Anastasia Stulova wrote: > Hi Jan, > > In the future could you please keep "[OpenCL]" prefix for all commit > messages related to OpenCL. :) > > Thanks, > Anast

RE: r271413 - Fixup list of available extensions

No worries! Thanks! Anastasia -Original Message- From: Jan Vesely [mailto:jv...@scarletmail.rutgers.edu] On Behalf Of Jan Vesely Sent: 03 June 2016 18:35 To: Anastasia Stulova; cfe-commits@lists.llvm.org Cc: nd Subject: Re: r271413 - Fixup list of available extensions of course. sorry ab

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59580. Prazek marked 4 inline comments as done. Prazek added a comment. - Review fixes http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp cla

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added a comment. In http://reviews.llvm.org/D20964#448455, @Eugene.Zelenko wrote: > I think will be good idea to try this check with LLVM STL too. You mean llvm::SmallVector stuff? http://reviews.llvm.org/D20964 ___ cfe-commits mailing lis

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D20964#448525, @Prazek wrote: > In http://reviews.llvm.org/D20964#448455, @Eugene.Zelenko wrote: > > > I think will be good idea to try this check with LLVM STL too. > > > You mean llvm::SmallVector stuff? No, I meant to build example w

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added a comment. Friendly ping... http://reviews.llvm.org/D20602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271701 - Test commit

Author: twoh Date: Fri Jun 3 13:27:39 2016 New Revision: 271701 URL: http://llvm.org/viewvc/llvm-project?rev=271701&view=rev Log: Test commit Modified: cfe/trunk/include/clang/Basic/Builtins.def Modified: cfe/trunk/include/clang/Basic/Builtins.def URL: http://llvm.org/viewvc/llvm-project

[RFC] Embedded bitcode and related upstream (Part II)

Hi everyone I am still in the process of upstreaming some improvements to the embed bitcode option. If you want more background, you can read the previous RFC (http://lists.llvm.org/pipermail/llvm-dev/2016-February/094851.html

r271702 - [Title] Revert test commit

Author: twoh Date: Fri Jun 3 13:30:12 2016 New Revision: 271702 URL: http://llvm.org/viewvc/llvm-project?rev=271702&view=rev Log: [Title] Revert test commit Summary: Revert test commit Trac Bug: # Blame Rev: Reviewed By: Test Plan: Revert Plan: Database Impact: Memcache Impact: Other Not

[PATCH] D20979: [OpenCL] Use function attribute/metadata to represent kernel attributes

yaxunl created this revision. yaxunl added reviewers: Anastasia, bader, pxli168. yaxunl added subscribers: cfe-commits, tstellarAMD. This patch attempts to use target-dependent function attribute to represent reqd_work_group_size, work_group_size_hint and vector_type_hint kernel attributes and u

r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

Author: twoh Date: Fri Jun 3 13:52:51 2016 New Revision: 271708 URL: http://llvm.org/viewvc/llvm-project?rev=271708&view=rev Log: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths. Differential Revision: http://reviews.llvm.org/D19843 Corre

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

twoh added a subscriber: twoh. twoh closed this revision. twoh added a comment. I have commit in r271708: http://reviews.llvm.org/rL271708 http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

alexfh added a comment. In http://reviews.llvm.org/D20917#447046, @sbenza wrote: > Is it a typo in the description when it says that when RemoveStar is on we > will write 'auto*' instead if 'auto'? Yep, the whole patch description is a typo, fixed ;) http://reviews.llvm.org/D20917 ___

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

alexfh updated this revision to Diff 59599. alexfh marked an inline comment as done. alexfh added a comment. - Updated formatting in the doc. http://reviews.llvm.org/D20917 Files: clang-tidy/modernize/UseAutoCheck.cpp clang-tidy/modernize/UseAutoCheck.h docs/clang-tidy/checks/modernize-us

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

Prazek added a subscriber: Prazek. Prazek added a comment. besides it lgtm Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration list.

Re: r271692 - Don't pass --build-id to ld by default.

Can you add this to the release notes? It'll for example break chromium's crash server (we can fix this on our end by explicitly passing -Wl,--build-id for release builds, but we only saw this commit fly by by chance.) On Fri, Jun 3, 2016 at 1:26 PM, Rafael Espindola via cfe-commits < cfe-commits@

  1   2   >