jvesely marked 2 inline comments as done.
jvesely added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D20388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I think is just the usual "llvm.org is crazy slow". I am trying to commit.
Cheers,
Rafael
On 31 May 2016 at 08:54, Piotr Padlewski wrote:
> dunno why but I can't fetch from upstream
>
> Can you push this change?
>
> - include/clang/CMakeLists.txt
> --
Author: ehsan
Date: Tue May 31 10:55:51 2016
New Revision: 271292
URL: http://llvm.org/viewvc/llvm-project?rev=271292&view=rev
Log:
clang-c: Add the clang_getCursorVisibility() API
This patch adds an API for querying the visibility of the entity
referred to by a cursor.
Patch by Michael Wu .
Ad
Of course, apologies for this. Reverted in r271291 and recommitted in
r271292.
On Tue, May 31, 2016 at 10:18 AM, David Blaikie wrote:
> Burt Wesarg points out on cfe-dev that this commit message doesn't match
> the patch (nor the description provided in the code review thread that lead
> to thi
Author: prazek
Date: Tue May 31 10:56:26 2016
New Revision: 271293
URL: http://llvm.org/viewvc/llvm-project?rev=271293&view=rev
Log:
Fixed bug
Modified:
cfe/trunk/include/clang/CMakeLists.txt
Modified: cfe/trunk/include/clang/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk
vsk updated this revision to Diff 59078.
vsk marked an inline comment as done.
vsk added a comment.
- Actually link in the new document into Index.rst.
http://reviews.llvm.org/D20715
Files:
docs/SourceBasedCodeCoverage.rst
docs/index.rst
Index: docs/index.rst
==
Already commited. It should work right now.
2016-05-31 18:00 GMT+02:00 Rafael Espíndola :
> I think is just the usual "llvm.org is crazy slow". I am trying to commit.
>
> Cheers,
> Rafael
>
>
> On 31 May 2016 at 08:54, Piotr Padlewski
> wrote:
> > dunno why but I can't fetch from upstream
> >
>
bkramer added a comment.
Adding Manuel as a second opinion. I think this is fine but paths are a messy
problem, in particular removing .. can break symlinked directories.
http://reviews.llvm.org/D20819
___
cfe-commits mailing list
cfe-commits@lists
Author: ioeric
Date: Tue May 31 11:03:09 2016
New Revision: 271294
URL: http://llvm.org/viewvc/llvm-project?rev=271294&view=rev
Log:
[include-fixer] removed unused forward declaration.
Modified:
clang-tools-extra/trunk/include-fixer/IncludeFixer.cpp
Modified: clang-tools-extra/trunk/include-
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
I think this is ok, mainly because the clean paths are explicitly for user
code, where users usually like to have, well, clean paths.
http://reviews.llvm.org/D20819
___
Thanks for the patch and report!
Can this check be defeated with mutually recursive class template
inheritance? I was thinking something like this:
...
template
struct FooWrapper : FooTemplated { };
// Full template spec
template
class FooTemplated : public FooWrapper {
...
Maybe we should us
mehdi_amini added a comment.
In http://reviews.llvm.org/D20423#440539, @bunty2020 wrote:
> Clang's help shows the following description:
> **-mllvm Additional arguments to forward to LLVM's option
> processing**
>
> If -mllvm sets some internal option for cc1 then its strange
> for
Author: chapuni
Date: Tue May 31 11:41:39 2016
New Revision: 271295
URL: http://llvm.org/viewvc/llvm-project?rev=271295&view=rev
Log:
IncludeFixerTests: Update libdeps.
Modified:
clang-tools-extra/trunk/unittests/include-fixer/CMakeLists.txt
Modified: clang-tools-extra/trunk/unittests/includ
Thanks for the patch!
On Tue, May 31, 2016 at 6:48 PM NAKAMURA Takumi via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chapuni
> Date: Tue May 31 11:41:39 2016
> New Revision: 271295
>
> URL: http://llvm.org/viewvc/llvm-project?rev=271295&view=rev
> Log:
> IncludeFixerTests: Update
ogoffart created this revision.
ogoffart added reviewers: cfe-commits, rsmith, akyrtzi.
Herald added a subscriber: klimek.
Fix a few issues while skipping function bodies
- In functions with try { } catch { }, only the try block would be
skipped, not the catch blocks
- The template
Author: arsenm
Date: Tue May 31 11:58:18 2016
New Revision: 271297
URL: http://llvm.org/viewvc/llvm-project?rev=271297&view=rev
Log:
AMDGPU: Update datalayout string
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/CodeGen/target-data.c
Modified: cfe/trunk/lib/Basic/Targets.cpp
U
arsenm added inline comments.
Comment at: lib/Basic/Targets.cpp:2024-2025
@@ -2023,2 +2023,4 @@
Builder.defineMacro("__HAS_LDEXPF__");
+if (hasFP64)
+ Builder.defineMacro("__HAS_FP64__");
}
I don't think we need this. I want device macros for ot
pcc added a comment.
Ping.
http://reviews.llvm.org/D20415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:1989
@@ +1988,3 @@
+if (Tok.is(tok::colon)) {
+ // skip constructor initializer list
+ SkipUntil(tok::l_brace, StopAtSemi | StopBeforeMatch);
Comments should start with a capital lette
Author: ioeric
Date: Tue May 31 12:37:38 2016
New Revision: 271302
URL: http://llvm.org/viewvc/llvm-project?rev=271302&view=rev
Log:
[find-all-symbols] remove dots in SymbolInfo file paths.
Summary: remove dots in SymbolInfo file paths.
Reviewers: bkramer, klimek
Subscribers: cfe-commits
Diffe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271302: [find-all-symbols] remove dots in SymbolInfo file
paths. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D20819?vs=59075&id=59091#toc
Repository:
rL LLVM
http://review
Author: rnk
Date: Tue May 31 12:42:56 2016
New Revision: 271305
URL: http://llvm.org/viewvc/llvm-project?rev=271305&view=rev
Log:
Work around MinGW's macro definition of 'interface' to 'struct'
Previous attempts to rename the IBOutletCollection argument to something
other than "Interface" were un
manmanren added a comment.
In http://reviews.llvm.org/D20383#443613, @doug.gregor wrote:
> Yeah, this looks like the right approach. PCH follows the same rules as
> modules when it comes to newer information shadowing imported information.
Hi Doug,
Thanks for reviewing the patch! Can I take t
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
Yes, that's a LGTM, sorry for being unclear.
http://reviews.llvm.org/D20383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
rsmith accepted this revision.
rsmith added a comment.
Looks good to me, too.
http://reviews.llvm.org/D20383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz created this revision.
beanz added a subscriber: cfe-commits.
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html
http://lists.llvm.org/pipermail/llvm-dev/2016-May/100058.html
http://reviews.llvm.org/D20823
Files:
CMakeLists
Author: vedantk
Date: Tue May 31 13:06:19 2016
New Revision: 271308
URL: http://llvm.org/viewvc/llvm-project?rev=271308&view=rev
Log:
[Coverage] Fix crash on a switch partially covered by a macro (PR27948)
We have to handle file exits before and after visiting regions in the
switch body. Fixes PR
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
And some improvements:
* Show better error messages on unfound symbols.
* Fix a typo.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext
eric_niebler updated this revision to Diff 59098.
eric_niebler added a comment.
Remove stale comment, tweak for diagnostic wording.
http://reviews.llvm.org/D19843
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticLexKinds.td
include/clang/Basic/FileManager.h
i
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
LGTM with small changes.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3427
@@ -3425,3 +3426,3 @@
DContext, DeclName, LinkageName, Unit, LineNo, getOrCreateType(T,
Unit)
beanz created this revision.
beanz added a subscriber: cfe-commits.
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html
http://lists.llvm.org/pipermail/llvm-dev/2016-May/100058.html
http://reviews.llvm.org/D20828
Files:
CMakeLists
hokein updated this revision to Diff 59100.
hokein added a comment.
Remove unused code.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-include-fixer.py
test/incl
hokein abandoned this revision.
hokein added a comment.
Abandon this in favor of http://reviews.llvm.org/D20827.
http://reviews.llvm.org/D20809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
beanz created this revision.
beanz added a subscriber: cfe-commits.
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html
http://lists.llvm.org/pipermail/llvm-dev/2016-May/100058.html
http://reviews.llvm.org/D20829
Files:
CMakeLists
Author: mren
Date: Tue May 31 13:19:32 2016
New Revision: 271310
URL: http://llvm.org/viewvc/llvm-project?rev=271310&view=rev
Log:
PCH + module: make sure we write out macros associated with builtin identifiers.
When we import a module that defines a builtin identifier from prefix header and
prec
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271310: PCH + module: make sure we write out macros
associated with builtin identifiers. (authored by mren).
Changed prior to commit:
http://reviews.llvm.org/D20383?vs=57673&id=59103#toc
Repository:
thakis added a subscriber: thakis.
thakis accepted this revision.
thakis added a reviewer: thakis.
thakis added a comment.
This revision is now accepted and ready to land.
s/retiring/requiring/, right?
http://reviews.llvm.org/D20828
___
cfe-commits
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3427
@@ -3425,3 +3426,3 @@
DContext, DeclName, LinkageName, Unit, LineNo, getOrCreateType(T,
Unit),
-Var->hasInternalLinkage(), Var,
+Var->hasInternalLinkage(), nullptr,
getOr
bkramer added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:80
@@ +79,3 @@
+cl::desc("Print the symbol being queried and all its relevant headers in\n"
+ "the YAML format to stdout:\n"
+ " ---\n"
drop 'the'
===
jvesely added inline comments.
Comment at: lib/Basic/Targets.cpp:2024-2025
@@ -2023,2 +2023,4 @@
Builder.defineMacro("__HAS_LDEXPF__");
+if (hasFP64)
+ Builder.defineMacro("__HAS_FP64__");
}
arsenm wrote:
> I don't think we need this. I want dev
Author: bruno
Date: Tue May 31 13:46:31 2016
New Revision: 271314
URL: http://llvm.org/viewvc/llvm-project?rev=271314&view=rev
Log:
[Parser] Fix look ahead after EOF while parsing objc message and lambdas
If a closing ')' isn't found for a macro instantiation inside a '[',
the next token is EOF,
bruno closed this revision.
bruno added a comment.
Thanks Doug!
Committed r271314
http://reviews.llvm.org/D20451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Committed in r264971
http://reviews.llvm.org/D18585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Committed in r269661
http://reviews.llvm.org/D20266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Committed in r271042
http://reviews.llvm.org/D20404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Tue May 31 14:22:01 2016
New Revision: 271321
URL: http://llvm.org/viewvc/llvm-project?rev=271321&view=rev
Log:
[include-fixer] disable path cleaning test for windows and mingw.
Modified:
clang-tools-extra/trunk/unittests/include-fixer/find-all-symbols/FindAllSymbolsTest
Eugene.Zelenko added a comment.
Point of Include What You Use suggestions to rely on explicit dependencies, not
implicit ones.
Comment at: clang-tidy/utils/OptionsUtils.cpp:1
@@ -1,2 +1,2 @@
//===--- DanglingHandleCheck.cpp -
clang-tidy--===//
//
Author: cbieneman
Date: Tue May 31 15:21:52 2016
New Revision: 271329
URL: http://llvm.org/viewvc/llvm-project?rev=271329&view=rev
Log:
[CMake] Update to requiring CMake 3.4.3
Summary:
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.h
Author: cbieneman
Date: Tue May 31 15:21:53 2016
New Revision: 271330
URL: http://llvm.org/viewvc/llvm-project?rev=271330&view=rev
Log:
[CMake] Update to requiring CMake 3.4.3
Summary:
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.h
Author: cbieneman
Date: Tue May 31 15:21:38 2016
New Revision: 271326
URL: http://llvm.org/viewvc/llvm-project?rev=271326&view=rev
Log:
[CMake] Update to requiring CMake 3.4.3
Summary:
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271326: [CMake] Update to requiring CMake 3.4.3 (authored by
cbieneman).
Changed prior to commit:
http://reviews.llvm.org/D20823?vs=59094&id=59122#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20
Hi Jeroen,
OpenCL spec v1.1 s9.1 says
Every extension which affects the OpenCL language semantics, syntax or adds
built-in functions
to the language must create a preprocessor #define that matches the extension
name string.
This #define would be available in the language if and only if the exte
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271329: [CMake] Update to requiring CMake 3.4.3 (authored by
cbieneman).
Changed prior to commit:
http://reviews.llvm.org/D20828?vs=59099&id=59125#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271330: [CMake] Update to requiring CMake 3.4.3 (authored by
cbieneman).
Changed prior to commit:
http://reviews.llvm.org/D20829?vs=59101&id=59126#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20
Author: vedantk
Date: Tue May 31 15:35:12 2016
New Revision: 271331
URL: http://llvm.org/viewvc/llvm-project?rev=271331&view=rev
Log:
[Coverage] Remove redundant handleFileExit() call (NFC)
I added this call in r271308. It's redundant because it's dominated by a
call to extendRegion().
Thanks to
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D20757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:10527
@@ +10526,3 @@
+if (RD->hasAttr() ||
+ME->getMemberDecl()->hasAttr()) {
+ Diag(OpLoc, diag::warn_taking_address_of_packed_member)
rogfer01 wrote:
> aaron.ballman wrote:
>
rmaprath added a subscriber: rmaprath.
rmaprath added a comment.
Hmmm, it looks like part of this patch didn't go in? I cannot see the changes
in the `libcxxab/CMakeLists.txt` file in the repo.
I was hoping this would enable me to run the `libc++abi` tests on in-tree
static builds, but I still
bcraig added a comment.
In http://reviews.llvm.org/D16545#444854, @rmaprath wrote:
> Hmmm, it looks like part of this patch didn't go in? I cannot see the changes
> in the `libcxxabi/CMakeLists.txt` file in the repo.
>
> I was hoping this would enable me to run the `libc++abi` tests on in-tree
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
This is particularly important because a some convergent CUDA intrinsics
(e.g. __shfl_down) are implemented in terms of inline asm.
http://reviews.llvm.org/D20836
Files:
lib/CodeGen/CGStmt.cpp
Hi Sam,
Fair enough. However, if I read your quote correctly, then there is absolutely
no need to define a cl_khr_icd, pragma, as ICD in no way affects the language.
Why do you define one anyway?
The following also hasn’t been cleared up yet:
* If I understand the patch correctly, it allows
pirama added a comment.
I looked at how LangOpts and TargetInfo are handled and found a way we can
achieve 64-bit longs without a Target feature (and restrict it just to
RenderScript!). This would be via TargetInfo::adjust(). I'll abandon the
sibling patch to LLVM as we should be able to do t
probinson added a subscriber: probinson.
probinson added a comment.
Do I remember that somebody was working on a more generic expression-like
syntax for REQUIRES? If that's been abandoned, then Never Mind.
Repository:
rL LLVM
http://reviews.llvm.org/D20757
___
Author: jlebar
Date: Tue May 31 16:27:13 2016
New Revision: 271336
URL: http://llvm.org/viewvc/llvm-project?rev=271336&view=rev
Log:
[CUDA] Conservatively mark inline asm as convergent.
Summary:
This is particularly important because a some convergent CUDA intrinsics
(e.g. __shfl_down) are imple
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271336: [CUDA] Conservatively mark inline asm as convergent.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D20836?vs=59130&id=59133#toc
Repository:
rL LLVM
http://reviews.ll
jlebar added a comment.
In http://reviews.llvm.org/D20836#444911, @tra wrote:
> I guess we would not be able to remove convergent from inline asm
> automatically. Do we need a way to explicitly remove convergent from inline
> asm?
We can think about it. I'm not sure it will make a big differ
By the way, are you accidentally violating:
The initial state of the compiler is as if the directive
#pragma OPENCL EXTENSION all : disable
was issued, telling the compiler that all error and warning reporting must be
done according to this specification, ignoring any extensions.
That from ju
tra added a comment.
I guess we would not be able to remove convergent from inline asm
automatically. Do we need a way to explicitly remove convergent from inline asm?
http://reviews.llvm.org/D20836
___
cfe-commits mailing list
cfe-commits@lists.ll
Hi Jeroen,
I added all extensions since it may be useful for users to know that certain
extensions are supported by a platform. The spec does not specify those options
which do not affect language semantics should or should not be defined. I am
considering removing them since they may encourage
Hi Sam,
> This commit does not change the initial state of the extensions. An extension
> is supported is not the same as enabled. At the beginning all extensions are
> disabled.
I do not see this reflected in the code at all. Could you please:
a. Point me to the location where this distinctio
Author: kzhuravl
Date: Tue May 31 17:47:11 2016
New Revision: 271347
URL: http://llvm.org/viewvc/llvm-project?rev=271347&view=rev
Log:
[AMDGPU] Set default dwarf version to 2
Differential Revision: http://reviews.llvm.org/D20640
Modified:
cfe/trunk/lib/Driver/ToolChains.h
cfe/trunk/test/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271347: [AMDGPU] Set default dwarf version to 2 (authored by
kzhuravl).
Changed prior to commit:
http://reviews.llvm.org/D20640?vs=58481&id=59144#toc
Repository:
rL LLVM
http://reviews.llvm.org/D206
ahatanak added a subscriber: ahatanak.
Comment at: test/std/utilities/meta/meta.rel/is_nothrow_callable.pass.cpp:57
@@ -56,3 +56,3 @@
struct Dummy { void foo() noexcept {} static void bar() noexcept {} };
-#if !defined(__cpp_noexcept_function_type)
+#if !defined(__cpp_noexcep
I believe you are thinking of: http://reviews.llvm.org/D18185
On Tue, May 31, 2016 at 2:32 PM, Paul Robinson
wrote:
> probinson added a subscriber: probinson.
> probinson added a comment.
>
> Do I remember that somebody was working on a more generic expression-like
> syntax for REQUIRES? If th
Author: mren
Date: Tue May 31 18:22:04 2016
New Revision: 271351
URL: http://llvm.org/viewvc/llvm-project?rev=271351&view=rev
Log:
Indexer: add CXObjCPropertyAttr_class for class properties.
rdar://25963227
Modified:
cfe/trunk/include/clang-c/Index.h
cfe/trunk/test/Index/c-index-api-load
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
Below are some buildbot numbers for the last week of 5/22/2016 - 5/28/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
manmanren created this revision.
manmanren added a reviewer: rjmccall.
manmanren added a subscriber: cfe-commits.
It's possible to have multiple local ObjCLifetime qualifiers. When there is
a conflict, we can't stop after we reach a type that is directly qualified.
We need to keep pulling sugar of
manmanren created this revision.
manmanren added a reviewer: rjmccall.
manmanren added a subscriber: cfe-commits.
Before this fix, both the start and the end point to the same location, and we
will add the FixIt before the type name:
^(NSView view) to ^(*NSView view)
After this commit, fixit wil
flx added inline comments.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:34
@@ -29,1 +33,3 @@
+template bool isSetDifferenceEmpty(const S &S1, const S &S2) {
+ for (const auto &E : S1)
sbenza wrote:
> isSubset?
In the caller code it seems t
flx updated this revision to Diff 59157.
flx marked 2 inline comments as done.
http://reviews.llvm.org/D20277
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
clang-tidy/performance/UnnecessaryValueParamCheck.h
clang-tidy/utils/DeclRefExprUtils.cpp
clang-tidy/utils/DeclRefExpr
etienneb added a comment.
In http://reviews.llvm.org/D20714#444802, @Eugene.Zelenko wrote:
> Point of Include What You Use suggestions to rely on explicit dependencies,
> not implicit ones.
It's true most of the time.
In some case, splitting the header file is for maintainability and includin
flx updated this revision to Diff 59167.
http://reviews.llvm.org/D20277
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
clang-tidy/performance/UnnecessaryValueParamCheck.h
clang-tidy/utils/DeclRefExprUtils.cpp
clang-tidy/utils/DeclRefExprUtils.h
clang-tidy/utils/Matchers.h
Author: compnerd
Date: Tue May 31 23:22:24 2016
New Revision: 271361
URL: http://llvm.org/viewvc/llvm-project?rev=271361&view=rev
Log:
CodeGen: tweak CFString emission for COFF targets
The `isa' member was previously not given the correct DLL Storage. Ensure that
we give the `isa' constant `__CF
djasper accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Format/SortJavaScriptImports.cpp:248
@@ +247,3 @@
+// ... then the references in order ...
+for (JsImportedSymbol *I = Symbols.begin(), *E = Symbols.end(); I != E;) {
+ Bu
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D20817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
101 - 186 of 186 matches
Mail list logo
