Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

Prazek updated this revision to Diff 58313. Prazek added a comment. Herald added a reviewer: deadalnix. Fixed many stuff. Note that I won't push this patch mainly because of LLVMBool stuff and some other small issues. I don't think there can be done anything more for this check. http://review

Re: [PATCH] D20563: Add load/store co-processor intrinsics

rs updated this revision to Diff 58314. http://reviews.llvm.org/D20563 Files: include/clang/Basic/BuiltinsARM.def test/CodeGen/builtins-arm.c test/Sema/builtins-arm.c Index: test/Sema/builtins-arm.c === --- test/Sema/builtins-

Re: [PATCH] D20500: [ms] Allow more unqualified lookup of types in dependent base classes

rnk marked 4 inline comments as done. Comment at: lib/Sema/SemaDecl.cpp:559-562 @@ -521,6 +558,6 @@ } } return DeclSpec::TST_unspecified; } rsmith wrote: > Doesn't seem to be done? I can easily believe there's a good reason why we > want two d

Re: [PATCH] D20500: [ms] Allow more unqualified lookup of types in dependent base classes

rnk updated this revision to Diff 58315. rnk added a comment. Herald added a subscriber: jyknight. - nits http://reviews.llvm.org/D20500 Files: include/clang-c/Index.h include/clang/AST/RecordLayout.h include/clang/Basic/BuiltinsX86.def include/clang/Driver/CLCompatOptions.td include/

Re: [PATCH] D20563: Add load/store co-processor intrinsics

rs marked an inline comment as done. rs added a comment. Tim thanks for reviewing this patch. I've uploaded a new one with your suggested change. If I don't respond to any further comments after today it'll be because I'm on holiday and won't be back till next week. http://reviews.llvm.org/D20

Re: [PATCH] D20574: [libcxxabi] Allow explicit pthread opt-in

bcraig updated this revision to Diff 58317. http://reviews.llvm.org/D20574 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -113,6 +113,7 @@ option(LIBCXXABI_ENABLE_WERROR "Fail and stop if

Re: [PATCH] D20574: [libcxxabi] Allow explicit pthread opt-in

bcraig marked an inline comment as done. bcraig added a comment. http://reviews.llvm.org/D20574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20500: [ms] Allow more unqualified lookup of types in dependent base classes

rnk updated this revision to Diff 58316. rnk added a comment. - fix the diff http://reviews.llvm.org/D20500 Files: include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Sema/SemaDecl.cpp test/SemaTemplate/ms-delayed-default-template-args.cpp test/SemaTemplate/ms-lookup-template-base-c

r270614 - clang-cl: Bake /Ob0 and /Ob2 into the general /O option handling

Author: hans Date: Tue May 24 16:23:29 2016 New Revision: 270614 URL: http://llvm.org/viewvc/llvm-project?rev=270614&view=rev Log: clang-cl: Bake /Ob0 and /Ob2 into the general /O option handling This is a follow-up to r270609, wherein I forgot that /O options can be combined, and e.g. /Odb2 is a

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

EricWF added a comment. For reference here's the current test coverage: http://efcs.ca/filesystem-coverage/ http://reviews.llvm.org/D16948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r270615 - [ms] Allow more unqualified lookup of types in dependent base classes

Author: rnk Date: Tue May 24 16:23:54 2016 New Revision: 270615 URL: http://llvm.org/viewvc/llvm-project?rev=270615&view=rev Log: [ms] Allow more unqualified lookup of types in dependent base classes Summary: In dependent contexts where we know a type name is required, such as a new expression, w

Re: [PATCH] D20500: [ms] Allow more unqualified lookup of types in dependent base classes

This revision was automatically updated to reflect the committed changes. Closed by commit rL270615: [ms] Allow more unqualified lookup of types in dependent base classes (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D20500?vs=58316&id=58319#toc Repository: rL LLVM htt

Re: [PATCH] D20576: [Driver] Add support for -finline-functions and /Ob2 flags

hans added a subscriber: majnemer. hans added a comment. majnemer reminded me that /O options can be combined, so e.g. /Odb2 would be a valid combination. I've followed up with r270614 to move the /Ob flags into that mechanism. Repository: rL LLVM http://reviews.llvm.org/D20576 _

Re: [PATCH] D20573: [libcxx] Allow explicit pthread opt-in

bcraig updated this revision to Diff 58320. http://reviews.llvm.org/D20573 Files: CMakeLists.txt include/__config include/__config_site.in include/__threading_support Index: include/__threading_support === --- include/__thre

Re: [PATCH] D20573: [libcxx] Allow explicit pthread opt-in

bcraig marked 2 inline comments as done. bcraig added a comment. http://reviews.llvm.org/D20573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama created this revision. pirama added subscribers: cfe-commits, srhines. This patch enables .rgba accessors to ext_vector_type types and adds tests for syntax validation and code generation. 'a' and 'b' can appear either in the point access mode or the numeric access mode (for indices 10 and

r270625 - Make the altivec intrinsics that require immediate constant propagation

Author: echristo Date: Tue May 24 17:25:06 2016 New Revision: 270625 URL: http://llvm.org/viewvc/llvm-project?rev=270625&view=rev Log: Make the altivec intrinsics that require immediate constant propagation macros rather than functions. Unfortunately couldn't come up with a simple testcase that d

Re: [PATCH] D20563: Add load/store co-processor intrinsics

t.p.northover accepted this revision. t.p.northover added a reviewer: t.p.northover. t.p.northover added a comment. This revision is now accepted and ready to land. Thanks Ranjeet. LGTM! Tim. http://reviews.llvm.org/D20563 ___ cfe-commits mailing l

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

rsmith added a comment. Looks like this extension was added at some point between 1.1 and 2.1. It would make sense to produce an `ExtWarn` for it if the OpenCL standard version is less than the one that introduced it (whenever that was) -- that would match what we do for extensions in other lan

Re: [PATCH] D20423: [Clang][LLVMGold] Passing LLVM arguments to gold plugin

llvm-commits added a subscriber: llvm-commits. llvm-commits added a comment. This seems strange to me. For example, it breaks the otherwise very convenient: $ clang -flto t.c -mllvm -some-internal-option-for-cc1 ---

Re: [PATCH] D20597: Speed up check by using a recursive visitor.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:25 @@ +24,3 @@ + bool TraverseStmt(Stmt* Node) { +if (!Node) return Base::TraverseStmt(Node); + --

Re: [PATCH] D20576: [Driver] Add support for -finline-functions and /Ob2 flags

Ilod added a comment. Hello, It seems the new test was commited as .cc instead of .c, which changes the name mangling, making // NOINLINE-LABEL: @foo fail. Either the file should be renamed, or -x c should be added to clang invocation, or LABEL check updated. Repository: rL LLVM http://rev

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

yaxunl added inline comments. Comment at: lib/Headers/opencl-c.h:143 @@ +142,3 @@ +#if __OPENCL_C_VERSION__ >= CL_VERSION_2_0 +#define NULL ((void*)0) +#endif Anastasia wrote: > indentation seems wrong! fixed. Comment

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

alexfh added inline comments. Comment at: clang-tidy/llvm/HeaderGuardCheck.cpp:18 @@ +17,3 @@ + const std::string RawStringHeaderFileExtensions( + Options.getLocalOrGlobal("HeaderFileExtensions", ",h,hh,hpp,hxx")); + utils::parseHeaderFileExtensions(RawStringHeader

Re: [PATCH] D20510: [PATCH] Fix for bug 27802 misc-macro-parentheses breaks variadic macros

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D20510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

r270633 - Rename test/CodeGen/inline-optim.cc to .c and provide a triple

Author: hans Date: Tue May 24 18:37:56 2016 New Revision: 270633 URL: http://llvm.org/viewvc/llvm-project?rev=270633&view=rev Log: Rename test/CodeGen/inline-optim.cc to .c and provide a triple Added: cfe/trunk/test/CodeGen/inline-optim.c - copied, changed from r270615, cfe/trunk/test/C

r270634 - docs: Document how safestack handles setjmp and exceptions.

Author: pcc Date: Tue May 24 18:38:02 2016 New Revision: 270634 URL: http://llvm.org/viewvc/llvm-project?rev=270634&view=rev Log: docs: Document how safestack handles setjmp and exceptions. Modified: cfe/trunk/docs/SafeStack.rst Modified: cfe/trunk/docs/SafeStack.rst URL: http://llvm.org/vi

Re: [PATCH] D20576: [Driver] Add support for -finline-functions and /Ob2 flags

hans added a comment. In http://reviews.llvm.org/D20576#438581, @Ilod wrote: > It seems the new test was commited as .cc instead of .c, which changes the > name mangling, making // NOINLINE-LABEL: @foo fail. > Either the file should be renamed, or -x c should be added to clang > invocation, or

Re: [PATCH] D20519: [clang-tidy] Ignore ADL-style using decls in unused-using-decls check.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:47 @@ +46,3 @@ + return; +// Ignores using-declarations defined in function definitions to avoid +// arguement-dependent loo

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

srhines added a comment. In http://reviews.llvm.org/D20602#438528, @rsmith wrote: > Looks like this extension was added at some point between 1.1 and 2.1. It > would make sense to produce an `ExtWarn` for it if the OpenCL standard > version is less than the one that introduced it (whenever that

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

rsmith added a comment. In http://reviews.llvm.org/D20602#438643, @srhines wrote: > In http://reviews.llvm.org/D20602#438528, @rsmith wrote: > > > Looks like this extension was added at some point between 1.1 and 2.1. It > > would make sense to produce an `ExtWarn` for it if the OpenCL standard

r270641 - [esan|wset] Add working set tool driver flags

Author: bruening Date: Tue May 24 19:41:24 2016 New Revision: 270641 URL: http://llvm.org/viewvc/llvm-project?rev=270641&view=rev Log: [esan|wset] Add working set tool driver flags Summary: Adds a new -fsanitize=efficiency-working-set flag to enable esan's working set tool. Adds appropriate test

r270642 - clang-cl: Fix unused argument warning when combining /O2 and /Ob2

Author: hans Date: Tue May 24 19:43:45 2016 New Revision: 270642 URL: http://llvm.org/viewvc/llvm-project?rev=270642&view=rev Log: clang-cl: Fix unused argument warning when combining /O2 and /Ob2 Modified: cfe/trunk/lib/Driver/MSVCToolChain.cpp cfe/trunk/test/Driver/cl-options.c Modifie

[PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

hans created this revision. hans added reviewers: rnk, thakis. hans added a subscriber: cfe-commits. This matches what MSVC does, and should make compiles faster by avoiding to unnecessarily emit a lot of code. http://reviews.llvm.org/D20608 Files: lib/Sema/SemaTemplate.cpp test/CodeGenCXX/

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

sfantao updated this revision to Diff 58368. sfantao added a comment. Add parsing and sema support only for target update and already existing clauses (if and device). http://reviews.llvm.org/D15944 Files: include/clang-c/Index.h include/clang/AST/RecursiveASTVisitor.h include/clang/AST/

Re: [PATCH] D18597: [OpenMP] Parsing and sema support for the to clause

sfantao updated this revision to Diff 58370. sfantao added a comment. Add implementation and tests only for the `to` clause. The implementation is based on the existing infrastructure used by the `map` clause already available upstream. http://reviews.llvm.org/D18597 Files: include/clang/AS

Re: [PATCH] D18488: [OpenMP] Parsing and sema support for the from clause

sfantao updated this revision to Diff 58371. sfantao added a comment. Implementation and tests only for the `from` clause. Similarly to the `to` clause, the implementation is based on the infrastructure contributed before for the `map` clause. http://reviews.llvm.org/D18488 Files: include/c

Re: [PATCH] D18540: [Sema] Note when we've actually encountered a failure in ExprConstant, and take that into account when looking up objects.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM with or without the `SpeculativeEvaluationRAII` refactor (which is ultimately pre-existing duplication). Please commit the rename of `keepEvaluatingAfterFailure` -> `noteFailure` separat

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

majnemer added a subscriber: majnemer. majnemer added a comment. Does this change our behavior for mingw? http://reviews.llvm.org/D20608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D20111: [OpenMP] Adjust map type bits according to latest spec and use zero size array sections for pointers.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4874-4878 @@ -4881,1 +4873,7 @@ +OMP_MAP_IS_PTR = 0x10, +/// \brief This flags signals that an argument is the first one relating to +/// a map/private clause expression. For some cases a single

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5630-5639 @@ -5599,6 +5629,12 @@ // type, the default is 'tofrom'. CurMapTypes.push_back(ElementType->isAggregateType() ? (MappableExprsHandler::OM

Re: [PATCH] D20089: Adding a TargetParser for AArch64

jojo updated this revision to Diff 58381. jojo added a comment. 1.include/llvm/Support/TargetParser.h Move move the declaration of getArchFeatures to a more reasonable place. Remove unnecessary parameter for getDefaultCPU. 2.lib/Support/TargetParser.cpp Make adjustments according to Targe

Re: [PATCH] D20089: Adding a TargetParser for AArch64

jojo added inline comments. Comment at: include/llvm/Support/TargetParser.h:173 @@ +172,3 @@ +StringRef getArchName(unsigned ArchKind); +bool getArchFeatures(unsigned ArchKind, std::vector &Features); +unsigned getArchAttr(unsigned ArchKind); rengolin wrote: > Nit

Re: [PATCH] D18597: [OpenMP] Parsing and sema support for the to clause

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:10218-10220 @@ +10217,5 @@ +Sema &SemaRef, DSAStackTy *DSAS, OpenMPClauseKind CKind, +ArrayRef VarList, SmallVector &Vars, +OMPClauseMappableExprCommon::MappableExprComponentLists &ClauseComponents, +

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

ABataev added a comment. Add a test for nesting of regions here Comment at: lib/Parse/ParseOpenMP.cpp:42 @@ -42,1 +41,3 @@ + OMPD_target_exit, + OMPD_update }; Please, add a comma after 'OMPD_update' to reduce number of changes in the next modification of th

Re: [PATCH] D18488: [OpenMP] Parsing and sema support for the from clause

ABataev added a comment. Missed a test for printing and serialization/deserialization Comment at: test/OpenMP/nesting_of_regions.cpp:1832 @@ -1831,3 +1831,3 @@ for (int i = 0; i < 10; ++i) { -#pragma omp target update to(a) +#pragma omp target update from(a) }

r270664 - [X86] Update test cases to make sure storeu builtins use the storeu instrinsics. We were previously matching on other stores in the IR from this being an -O0 test.

Author: ctopper Date: Wed May 25 00:26:23 2016 New Revision: 270664 URL: http://llvm.org/viewvc/llvm-project?rev=270664&view=rev Log: [X86] Update test cases to make sure storeu builtins use the storeu instrinsics. We were previously matching on other stores in the IR from this being an -O0 test

Re: [PATCH] D20510: [PATCH] Fix for bug 27802 misc-macro-parentheses breaks variadic macros

madsravn closed this revision. madsravn added a comment. Code committed. http://reviews.llvm.org/D20510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r270666 - Rename a variable to avoid shadowing function parameter. NFC.

Author: bwilson Date: Wed May 25 00:42:00 2016 New Revision: 270666 URL: http://llvm.org/viewvc/llvm-project?rev=270666&view=rev Log: Rename a variable to avoid shadowing function parameter. NFC. Modified: cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp Modified: cfe/trunk/lib/Sema/AnalysisBase

r270665 - arc-repeated-use-of-weak should not warn about IBOutlet properties

Author: bwilson Date: Wed May 25 00:41:57 2016 New Revision: 270665 URL: http://llvm.org/viewvc/llvm-project?rev=270665&view=rev Log: arc-repeated-use-of-weak should not warn about IBOutlet properties Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for Objective-C properties m

Re: [PATCH] arc-repeated-use-of-weak should not warn about IBOutlet properties

> On May 24, 2016, at 11:46 AM, Manman Ren wrote: > >> >> On May 24, 2016, at 11:42 AM, Bob Wilson > > wrote: >> >>> >>> On May 24, 2016, at 11:21 AM, Manman >> > wrote: >>> >>> On May 23, 2016, at 8:15 PM, Bob Wilson >>>

Re: [PATCH] D20573: [libcxx] Allow explicit pthread opt-in

rmaprath accepted this revision. rmaprath added a comment. This revision is now accepted and ready to land. LGTM. (I don't have powers to accept libcxx patches in general, but this patch is quite small and related to something I plugged in, so, I think it's OK in this instance) http://reviews

Re: [PATCH] D20574: [libcxxabi] Allow explicit pthread opt-in

rmaprath accepted this revision. rmaprath added a comment. This revision is now accepted and ready to land. LGTM. (I don't have powers to accept libcxx patches in general, but this patch is quite small and related to something I plugged in, so, I think it's OK in this instance) http://reviews

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

rmaprath added a subscriber: rmaprath. rmaprath added a comment. Looks like I've completely missed this patch somehow. Will try to find some time (or someone) to have a look at it from an embedded-systems / ARM point of view asap. Great work!!! http://reviews.llvm.org/D16948 __

Re: r270373 - [driver][mips] Support new versions of MIPS CodeScape toolchains

On Tue, May 24, 2016 at 4:18 PM, Simon Atanasyan wrote: > /home/abuild/rpmbuild/BUILD/llvm/stage2/bin/clang -no-canonical-prefixes \ > /home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/Driver/mips-img-v2.cpp \ > -### -o > /home/abuild/rpmbuild/BUILD/llvm/stage2/tools/clang/test/Driver/Output/

<    1   2