vsk added a comment.
I discussed this bug with Argyrios off-list, who lgtm'd on the condition that
it doesn't introduce a performance regression. He suggested preprocessing
Cocoa.h to stress the patch. After running a stabilization script, I used this
command to stress RelNoAsserts builds of cl
cdavis5x created this revision.
cdavis5x added a reviewer: rsmith.
cdavis5x added a subscriber: cfe-commits.
This is a very strange target. Sema thinks it's targeting a Darwin-esque
system, while IRGen thinks it's targeting a Windows'ish system. The result
is that Clang can no longer compile `__bu
The modules buildbot has been broken since this commit landed:
http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/15761/steps/compile.llvm.stage2/logs/stdio
Please fix or revert.
On Wed, May 18, 2016 at 4:56 AM, Ashutosh Nema via cfe-commits <
cfe-commits@lists.llvm.org
Could you also check performance of creating a PCH file out of Cocoa.h ?
> On May 19, 2016, at 1:47 PM, Vedant Kumar wrote:
>
> vsk added a comment.
>
> I discussed this bug with Argyrios off-list, who lgtm'd on the condition that
> it doesn't introduce a performance regression. He suggested p
Author: d0k
Date: Thu May 19 16:53:33 2016
New Revision: 270144
URL: http://llvm.org/viewvc/llvm-project?rev=270144&view=rev
Log:
[Sema] Fix use after move. Found by ubsan.
Modified:
cfe/trunk/include/clang/Sema/SemaInternal.h
cfe/trunk/lib/Sema/SemaLookup.cpp
Modified: cfe/trunk/include
r270144 should fix that failure.
On Thu, May 19, 2016 at 10:17 PM, Evgenii Stepanov
wrote:
> Looks like this commit broke the bot:
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-
> bootstrap/builds/11738/steps/check-clang%20ubsan/logs/stdio
>
> On Thu, May 19, 2016 at 3:52 AM, Benjami
Yes, here are the results from the unpatched compiler:
Avg. wall time (s): 0.73241
Std. deviation: 0.05850
And here are the results from the patched compiler:
Avg. wall time (s): 0.75554
Std. deviation: 0.07492
The testing methodology was the same (100 trials), except I used `clang -x
objectiv
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
After offline discussion: we don't know for sure whether we're going to hit the
combinatorial explosion in future or not. Let's go ahead with this as-is for
now, then, with the explicit acknow
bruno created this revision.
bruno added reviewers: doug.gregor, rsmith.
bruno added a subscriber: cfe-commits.
If a closing ')' isn't found for a macro instantiation inside a '[',
the next token is EOF, this leads to crashes if we try to look ahead of
that. This could be triggered whenever trying
Author: jlebar
Date: Thu May 19 17:49:13 2016
New Revision: 270150
URL: http://llvm.org/viewvc/llvm-project?rev=270150&view=rev
Log:
[CUDA] Implement __ldg using intrinsics.
Summary:
Previously it was implemented as inline asm in the CUDA headers.
This change allows us to use the [addr+imm] addr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270150: [CUDA] Implement __ldg using intrinsics. (authored
by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D19990?vs=56603&id=57873#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1999
amccarth created this revision.
amccarth added a reviewer: majnemer.
amccarth added a subscriber: cfe-commits.
This fixes the problem where the driver will look for cl.exe.exe while walking
the PATH.
I looked into changing the Windows implementation of
llvm::sys::fs::can_execute(), but there wa
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: ayartsev
Date: Thu May 19 18:03:49 2016
New Revision: 270154
URL: http://llvm.org/viewvc/llvm-project?rev=270154&view=rev
Log:
[analyzer] Fix for PR23790 : constrain return value of strcmp() rather than
returning a concrete value.
The function strcmp() can return any value, not just {-1,
Author: vedantk
Date: Thu May 19 18:44:02 2016
New Revision: 270160
URL: http://llvm.org/viewvc/llvm-project?rev=270160&view=rev
Log:
[Lexer] Don't merge macro args from different macro files
The lexer sets the end location of macro arguments incorrectly *if*,
while merging consecutive args to fi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270160: [Lexer] Don't merge macro args from different macro
files (authored by vedantk).
Changed prior to commit:
http://reviews.llvm.org/D20401?vs=57810&id=57880#toc
Repository:
rL LLVM
http://revi
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a couple of nits.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:22
@@ +21,3 @@
+// A function that helps to tell whether a TargetDecl will be checked.
+// We o
rsmith added a subscriber: rsmith.
rsmith added a comment.
Thanks for this! Sorry for the delay on the review side. Generally, the
approach here looks fine, and I don't have any high-level concerns beyond a
performance concern over whatever dark magic you're doing on the LLVM side to
get this f
Author: rnk
Date: Thu May 19 19:38:25 2016
New Revision: 270164
URL: http://llvm.org/viewvc/llvm-project?rev=270164&view=rev
Log:
Avoid depending on test inputes that aren't in Inputs
Some people have weird CI systems that run each test subdirectory
independently without access to other parallel
jlebar created this revision.
jlebar added a reviewer: rsmith.
jlebar added a subscriber: cfe-commits.
http://reviews.llvm.org/D20457
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/Options.td
Index: include/clang/Driver/Options.td
Fixed in r270169.
On Thu, May 19, 2016 at 2:13 PM, Richard Smith
wrote:
> The modules buildbot has been broken since this commit landed:
>
>
> http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/15761/steps/compile.llvm.stage2/logs/stdio
>
> Please fix or revert.
>
> On
Author: rsmith
Date: Thu May 19 20:06:47 2016
New Revision: 270169
URL: http://llvm.org/viewvc/llvm-project?rev=270169&view=rev
Log:
Revert incorrect module map changes in r269907 and replace them with the
appropriate changes.
Modified:
cfe/trunk/lib/Headers/module.modulemap
Modified: cfe/tr
Author: rsmith
Date: Thu May 19 20:07:10 2016
New Revision: 270170
URL: http://llvm.org/viewvc/llvm-project?rev=270170&view=rev
Log:
Re-alphabetize this file list.
Modified:
cfe/trunk/lib/Headers/CMakeLists.txt
Modified: cfe/trunk/lib/Headers/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-
On Thu, May 19, 2016 at 6:11 PM, Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> jlebar created this revision.
> jlebar added a reviewer: rsmith.
> jlebar added a subscriber: cfe-commits.
>
> http://reviews.llvm.org/D20457
>
> Files:
> include/clang/Basic/LangOptions.def
>
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Sorry for the delay, this all LGTM. Do you need someone to commit it for you?
Comment at: lib/Sema/SemaTemplate.cpp:2082-2085
@@ +2081,6 @@
+// If the Index is out of boun
ahatanak added a comment.
In http://reviews.llvm.org/D20407#433915, @rjmccall wrote:
> _Atomic is functionally a type qualifier and should be removed in Sema when
> computing the result type of the getter and the parameter type of the setter.
> That is, if the user declares a property of type
On Thu, May 19, 2016 at 11:15 AM, David Majnemer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: majnemer
> Date: Thu May 19 13:15:53 2016
> New Revision: 270089
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270089&view=rev
> Log:
> [MS ABI] Ignore transparent contexts when deter
Author: compnerd
Date: Thu May 19 22:58:12 2016
New Revision: 270180
URL: http://llvm.org/viewvc/llvm-project?rev=270180&view=rev
Log:
CodeGen: address -Wcast-qual warning
Add a const_cast rather than the C-style cast. NFC.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trun
On Thu, May 19, 2016 at 12:13 PM, Serge Pavlov wrote:
> In this case moving implementation of `Singleton::getInstance()` into a
> .cpp file would prevent compiler from instantiation of the method body when
> it sees `Singleton::getInstance()`. In this case
> `Singleton::getInstance()` must be ins
pxli168 accepted this revision.
pxli168 added a comment.
LGTM!
I think we may add optimization on this base later.
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
pxli168 accepted this revision.
pxli168 added a comment.
Sorry about late reply.
LGTM!
http://reviews.llvm.org/D17578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bittnerbarni updated this revision to Diff 57894.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringAdditionCheck.cpp
clang-tidy/performance/InefficientStringAdditionCheck.h
clang-tidy/performance/PerformanceTidyModule.cpp
DmitryPolukhin updated this revision to Diff 57896.
DmitryPolukhin marked 2 inline comments as done.
DmitryPolukhin added a comment.
Comments resolved, PTAL.
http://reviews.llvm.org/D20422
Files:
lib/Sema/SemaDeclCXX.cpp
test/CodeGenCXX/dllexport-members.cpp
test/CodeGenCXX/dllexport.cpp
DmitryPolukhin added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:13111
@@ -13090,3 +13110,3 @@
llvm_unreachable("Invalid special member.");
}
} else {
rnk wrote:
> Can we add `if (InClassDef) ActOnFinishInlineFunctionDef(MD);` here instead
Author: djasper
Date: Fri May 20 01:16:01 2016
New Revision: 270188
URL: http://llvm.org/viewvc/llvm-project?rev=270188&view=rev
Log:
clang-format: [JS] Treat "for" as a reserved word after a ".".
Otherwise, clang-format can get confused with statements like:
x.for = 1;
Modified:
cfe/trun
twoh added a comment.
@faisalv, thank you for the update. I wonder if getCurrentThisType() is the
best place to call adjustCVQualifiersForCXXThisWithinLambda(). It seems that
getCurrentThisType() does more than its name suggests. Is there any other place
that the adjustment function can be call
101 - 136 of 136 matches
Mail list logo
