Here's an istream_iterator test for this change:
#include
#include
#include
struct evil_traits : std::char_traits {
template friend void operator&(T) = delete;
};
struct pointless_derived_class
: std::num_get> {};
int main() {
std::basic_stringstream ss("1 2 3");
ss.imbue(std::loca
So, why are you doing this for more than just the avx512 headers? I
understand that you're unhappy with all of the intrinsics, but you've added
an incompatibility here for MS mode. Does MS use header guards locking off
particular intrinsics?
What "better intrinsic story" are you looking for? This
Thanks Richard, I wouldn't have gotten that. One day I'll understand
locales.
On May 17, 2016 3:22 PM, "Richard Smith" wrote:
> Here's an istream_iterator test for this change:
>
> #include
> #include
> #include
>
> struct evil_traits : std::char_traits {
> template friend void operator&(T)
bcraig updated this revision to Diff 57520.
http://reviews.llvm.org/D17416
Files:
include/support/android/locale_bionic.h
include/support/newlib/xlocale.h
include/support/xlocale/__posix_l_fallback.h
include/support/xlocale/__strtonum_fallback.h
include/support/xlocale/xlocale.h
Index:
What you are describing is what testing literature refers to as criteria
for equivalence classes. There is some level of judgment to that, yes.
Yep yep, to be sure. I'm just generally trying to encourage the community
behavior towards being both selective & thorough about testing.
I have notice
bcraig updated this revision to Diff 57521.
bcraig marked 2 inline comments as done.
http://reviews.llvm.org/D17416
Files:
include/support/android/locale_bionic.h
include/support/newlib/xlocale.h
include/support/xlocale/__posix_l_fallback.h
include/support/xlocale/__strtonum_fallback.h
bcraig added a comment.
I'll be submitting this Friday morning, barring any objections (I'm out of the
office the next couple of days).
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:22
@@ +21,3 @@
+namespace {
+
+StringRef makeDynamicExceptionString(const SourceManager &SM,
It's much more common for LLVM code to use static functions:
http://llvm.org/docs/Codi
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:39
@@ +38,3 @@
+
+ // FIXME: Add paren matching so we can parse more complex throw statements,
+ // e.g., (examples provided by Aaron Ballman):
alexfh wrote:
> hintonda wr
cameron314 created this revision.
cameron314 added a reviewer: rsmith.
cameron314 added a subscriber: cfe-commits.
cameron314 set the repository for this revision to rL LLVM.
Remapped files would always cause the preamble's PCH to be invalidated (even if
they hadn't changed) because the file mana
Author: rsmith
Date: Tue May 17 16:48:41 2016
New Revision: 269849
URL: http://llvm.org/viewvc/llvm-project?rev=269849&view=rev
Log:
Revert r269717. That change alone did not provide the intended benefit (which
would come from changing the type of ASTContext::DeclAttrs from
DenseMap to DenseMap),
pcc created this revision.
pcc added reviewers: rafael, majnemer.
pcc added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
http://reviews.llvm.org/D20339
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen
ping
On Mon, May 2, 2016 at 11:51 AM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> dblaikie added a comment.
>
> In http://reviews.llvm.org/D19567#414906, @probinson wrote:
>
> > Huh. There are strange interactions here, which makes me even more
> nervous about testing fe
On Tue, May 17, 2016 at 2:30 PM, Robinson, Paul
wrote:
> What you are describing is what testing literature refers to as criteria
> for equivalence classes. There is some level of judgment to that, yes.
>
>
>
> Yep yep, to be sure. I'm just generally trying to encourage the community
> behavior
On Tue, May 17, 2016 at 7:07 AM, Filipe Cabecinhas via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: filcab
> Date: Tue May 17 09:07:43 2016
> New Revision: 269765
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269765&view=rev
> Log:
> Revert "[X86] Add immediate range checks for ma
Author: rksimon
Date: Tue May 17 17:03:31 2016
New Revision: 269852
URL: http://llvm.org/viewvc/llvm-project?rev=269852&view=rev
Log:
[X86][SSE] Tidied up MMX/SSE/SSE2 builtin tests to the correct test file
Modified:
cfe/trunk/test/CodeGen/mmx-builtins.c
cfe/trunk/test/CodeGen/sse-builtin
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:39
@@ +38,3 @@
+
+ // FIXME: Add paren matching so we can parse more complex throw statements,
+ // e.g., (examples provided by Aaron Ballman):
aaron.ballman wrote:
> alexfh wrot
There was an off list mail to me on this.
The 0-255 checks don't work for the builtins that take a char immediate and
char is signed. In that case the range change needs to be -128 to 127
instead of 0 to 255.
On Tue, May 17, 2016 at 3:09 PM, Sean Silva via cfe-commits <
cfe-commits@lists.llvm.org
tra created this revision.
tra added reviewers: jlebar, jingyue.
tra added a subscriber: cfe-commits.
This matches default nvcc behavior and gives substantial performance boost on
GPU where fmad is much cheaper compared to add+mul.
http://reviews.llvm.org/D20341
Files:
lib/Frontend/Compiler
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:39
@@ +38,3 @@
+
+ // FIXME: Add paren matching so we can parse more complex throw statements,
+ // e.g., (examples provided by Aaron Ballman):
alexfh wrote:
> aaron.ballm
Author: rsmith
Date: Tue May 17 17:44:15 2016
New Revision: 269858
URL: http://llvm.org/viewvc/llvm-project?rev=269858&view=rev
Log:
PR27754: CXXRecordDecl::data() needs to perform an update even if it's called
on a declaration that already knows the location of the DefinitionData object.
Added:
jlebar added a comment.
I am not sure we want this? Although it matches nvcc, it does not match our
floating-point behavior for C++ in general -- it makes us non-IEEE-whatever
compliant by default.
Although I agree that if we don't do this, lots of people are not going to pass
-fp-contract=fa
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:39
@@ +38,3 @@
+
+ // FIXME: Add paren matching so we can parse more complex throw statements,
+ // e.g., (examples provided by Aaron Ballman):
aaron.ballman wrote:
> alexfh wrot
Forgot to mention in the commit message: this patch was collaboratively
produced by Vassil Vassilev and myself.
On Tue, May 17, 2016 at 3:44 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue May 17 17:44:15 2016
> New Revision: 269858
>
> URL: htt
hfinkel added a subscriber: hfinkel.
hfinkel added a comment.
In http://reviews.llvm.org/D20341#432461, @jlebar wrote:
> I am not sure we want this? Although it matches nvcc, it does not match our
> floating-point behavior for C++ in general -- it makes us non-IEEE-whatever
> compliant by defa
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Review comments resolved and committed as r269858.
Repository:
rL LLVM
http://reviews.llvm.org/D20302
___
cfe-commits mailing list
cfe-commits
rsmith added a subscriber: rsmith.
Comment at: test/CodeGenOpenCL/constant-addr-space-globals.cl:3
@@ -2,3 +2,3 @@
-// CHECK: @array = addrspace({{[0-9]+}}) constant
+// CHECK: @array = local_unnamed_addr addrspace({{[0-9]+}}) constant
__constant float array[2] = {0.0f, 1.0f};
tra added a subscriber: scanon.
tra added a comment.
Things are even more interesting. -ffp-contract=fast is *not* what this change
does. :-)
We have two places where we can fuse FP instructions -- in clang and in LLVM
back-end.
Clang fuses add+mul into llvm.fmuladd intrinsic if -ffp-contract=o
tra added a comment.
In http://reviews.llvm.org/D20341#432494, @hfinkel wrote:
>
> That having been said, is this change the equivalent of -ffp-contract=fast or
> -ffp-contract=on? I think it is the latter and we want the former (i.e. where
> we let the backend be as aggressive as possible
pcc added inline comments.
Comment at: test/CodeGenOpenCL/constant-addr-space-globals.cl:3
@@ -2,3 +2,3 @@
-// CHECK: @array = addrspace({{[0-9]+}}) constant
+// CHECK: @array = local_unnamed_addr addrspace({{[0-9]+}}) constant
__constant float array[2] = {0.0f, 1.0f};
scanon added a comment.
`-ffp-contract=on` obeys the semantics of C's FP_CONTRACT pragma. In
particular, it will not fuse:
float m = x*y;
float a = m + z;
Whereas you probably want that to fuse for your purposes. `-ffp-contract=fast`
seems more in line with your needs.
http://reviews.l
hfinkel added a comment.
In http://reviews.llvm.org/D20341#432525, @tra wrote:
> In http://reviews.llvm.org/D20341#432494, @hfinkel wrote:
>
> >
>
>
>
>
> > That having been said, is this change the equivalent of -ffp-contract=fast
> > or -ffp-contract=on? I think it is the latter and we want
tra added a comment.
OK. Consensus seems to be that -ffp-contract=fast is the way to go. I'll update
the patch.
I've just checked Steve's example with nvcc and indeed it fused mul+add.
http://reviews.llvm.org/D20341
___
cfe-commits mailing list
cfe
tra updated this revision to Diff 57540.
tra added a comment.
Changed default to -ffp-contract=fast.
http://reviews.llvm.org/D20341
Files:
lib/Frontend/CompilerInvocation.cpp
Index: lib/Frontend/CompilerInvocation.cpp
===
--- li
tra updated this revision to Diff 57541.
tra added a comment.
Added test case.
Is there a better way to test that correct options are passed to back-end?
This test resorts to checking assembly generated by back-end which is way too
far away from what actually needs testing.
http://reviews.llvm
Author: rsmith
Date: Tue May 17 19:16:51 2016
New Revision: 269869
URL: http://llvm.org/viewvc/llvm-project?rev=269869&view=rev
Log:
Fix use-after-free ASan failures for modules / PCH files that deserialize
abi_tag or no_sanitize attributes.
Modified:
cfe/trunk/test/PCH/attrs.c
cfe/trunk
Author: chapuni
Date: Tue May 17 19:20:46 2016
New Revision: 269870
URL: http://llvm.org/viewvc/llvm-project?rev=269870&view=rev
Log:
IncludeFixerTest.cpp: Add explicit triple for some tests. They are failing for
targeting *-win32.
Modified:
clang-tools-extra/trunk/unittests/include-fixer/In
petarj created this revision.
petarj added a reviewer: atanasyan.
petarj added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
MIPS32 Android defaults to FPXX ("-fpxx").
MIPS32R6 Android defaults to FP64A ("-mfp64 -mno-odd-spreg").
http://reviews.llvm.org/D20
Author: chapuni
Date: Tue May 17 19:49:16 2016
New Revision: 269873
URL: http://llvm.org/viewvc/llvm-project?rev=269873&view=rev
Log:
include-fixer: They require clangLex.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/CMakeLists.txt
clang-tools-extra/trunk/include-fixer
Author: chapuni
Date: Tue May 17 19:53:27 2016
New Revision: 269874
URL: http://llvm.org/viewvc/llvm-project?rev=269874&view=rev
Log:
FindAllSymbolsTests doesn't require clangToolingCore.
Modified:
clang-tools-extra/trunk/unittests/include-fixer/find-all-symbols/CMakeLists.txt
Modified:
cl
Author: chapuni
Date: Tue May 17 19:53:31 2016
New Revision: 269875
URL: http://llvm.org/viewvc/llvm-project?rev=269875&view=rev
Log:
findAllSymbols: Prune unused libdeps.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/CMakeLists.txt
Modified: clang-tools-extra/trunk/includ
jlebar added a comment.
> But people also don't expect IEEE compliance on GPUs
Is that true? You have a lot more experience with this than I do, but my
observation of nvidia's hardware is that it's moved to add *more* IEEE
compliance as it's matured. For example, older hardware didn't suppor
About to be away for a week, but I will take this up (and the other one) when I
get back.
--paulr
From: David Blaikie [mailto:dblai...@gmail.com]
Sent: Tuesday, May 17, 2016 3:05 PM
To: reviews+d19567+public+1ee0c82c0824b...@reviews.llvm.org; David Blaikie
Cc: Robinson, Paul; Aaron Ballman; Adria
hintonda updated this revision to Diff 57547.
hintonda added a comment.
- First cut on a simple parser for decls.
Successfully parses all the examples I've been given so far. Please
help me break it.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/mode
t.p.northover added a subscriber: t.p.northover.
t.p.northover accepted this revision.
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks pretty straightforward, go for it.
Tim.
http://reviews.llvm.org/D20283
_
hintonda updated this revision to Diff 57555.
hintonda added a comment.
- Added another test.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseNoexcept
On 17 May 2016 at 10:32, Renato Golin wrote:
> I don't think a small future ACLE builtin is on the same league as a whole
> new back-end. :)
Well yes, it's probably got orders of magnitude less bugs than the
backend for a start.
> Nor I think that having this when the docs are public, rather th
Author: ctopper
Date: Tue May 17 22:18:12 2016
New Revision: 269878
URL: http://llvm.org/viewvc/llvm-project?rev=269878&view=rev
Log:
[X86] Add immediate range checks for many of the builtins.
This time allow -128 to 255 for builtins that use a char type immediate."
Modified:
cfe/trunk/inclu
Author: ctopper
Date: Tue May 17 23:11:25 2016
New Revision: 269879
URL: http://llvm.org/viewvc/llvm-project?rev=269879&view=rev
Log:
[Sema,CodeGen] Remove comment from SemaChecking about a builtin_shufflevector
form that it doesn't support. Remove CodeGen support for the same form since it
coul
twoh created this revision.
twoh added reviewers: faisalv, rsmith.
twoh added a subscriber: cfe-commits.
(This is a fix for Bug 27797 https://llvm.org/bugs/show_bug.cgi?id=27797).
Currently when RebuildLambdaScopeInfo() function in lib/Sema/SemaDecl.cpp
observes lambda capturing 'this', it calls
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
apelete updated this revision to Diff 57560.
apelete added a comment.
[scan-build] fix dead store warnings emitted on clang code base
Changes since last revision:
- lib/Sema/SemaLookup.cpp: remove changes since they were already applied
upstream,
- lib/Sema/SemaExpr.cpp: move 'IsDereference' an
Author: rjmccall
Date: Wed May 18 00:21:18 2016
New Revision: 269880
URL: http://llvm.org/viewvc/llvm-project?rev=269880&view=rev
Log:
Various improvements to the public IRGen interface.
Modified:
cfe/trunk/include/clang/CodeGen/CodeGenABITypes.h
cfe/trunk/include/clang/CodeGen/ModuleBuil
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good :-).
http://reviews.llvm.org/D19804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
The patch'll need a test case (in clang/tests) - I've not looked at the
change/have much opinion there, just suggesting adding a test at minimum so
when someone does come to review it it's more complete/closer to/ready to
commit.
On Tue, May 17, 2016 at 9:23 PM, Taewook Oh via cfe-commits <
cfe-co
101 - 155 of 155 matches
Mail list logo
