alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG.
http://reviews.llvm.org/D19865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: etienneb
Date: Wed May 11 12:32:12 2016
New Revision: 269208
URL: http://llvm.org/viewvc/llvm-project?rev=269208&view=rev
Log:
[clang-tidy] Add FixIt for swapping arguments in string-constructor-checker.
Summary:
Arguments can be swapped using fixit when they are not in macros.
This is th
Author: etienneb
Date: Wed May 11 12:38:22 2016
New Revision: 269210
URL: http://llvm.org/viewvc/llvm-project?rev=269210&view=rev
Log:
[clang-tidy] Refactoring of FixHintUtils
Summary:
Refactor some checkers to use the tooling re-writing API.
see: http://reviews.llvm.org/D19941
Reviewers: klimek
Hi Alexey,
I'm a bit confused regarding what this patch does, in part because the test
case does not test any of the function argument or return types. Does it
generate these "simd" functions taking scalar arguments? I'd expect that what
this does is that it generates functions taking vector ar
> I'm glad to help, but it makes me uneasy to have somebody working on a
> filesystem abstraction that does not have ready access to test and debug
> their changes across the major host platforms that LLVM supports (linux,
> mac, windows). Is there any way you can get access? I don't think that
> w
alexfh added a subscriber: alexfh.
Comment at: docs/clang-tidy/checks/misc-unnecessary-mutable.rst:9
@@ +8,3 @@
+
+.. code-block:: c++
+ class SomeClass {
Please verify the documentation can be built without errors. On Ubuntu this
boils down to:
Install sphinx:
Author: rnk
Date: Wed May 11 12:43:13 2016
New Revision: 269214
URL: http://llvm.org/viewvc/llvm-project?rev=269214&view=rev
Log:
Relax -Wcalling-convention-cast when casting to the default convention (cdecl)
Modified:
cfe/trunk/lib/Sema/SemaCast.cpp
cfe/trunk/test/Sema/callingconv-cast.c
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
How many more (in relative numbers) results does this check generate now?
Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:45
@@ -44,7 +44,3 @@
etienneb updated this revision to Diff 56942.
etienneb added a comment.
re-generating doc
http://reviews.llvm.org/D19876
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal.h
unittests/ASTMatchers/ASTMatchersTest
hintonda added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3229
@@ +3228,3 @@
+/// matches the declarations of j, k, and l, but not f, g, h, or i.
+AST_MATCHER(FunctionDecl, hasDynamicExceptionSpec) {
+ if (const auto *FnTy = Node.getType()->getAs())
--
Author: asbokhan
Date: Wed May 11 13:38:21 2016
New Revision: 269220
URL: http://llvm.org/viewvc/llvm-project?rev=269220&view=rev
Log:
[MSVC] Implementation of __unaligned as a proper type qualifier
This patch implements __unaligned (MS extension) as a proper type qualifier
(before that, it was i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269220: [MSVC] Implementation of __unaligned as a proper
type qualifier (authored by asbokhan).
Changed prior to commit:
http://reviews.llvm.org/D20103?vs=56874&id=56945#toc
Repository:
rL LLVM
http
Anastasia added a comment.
Sure! Will do! Thanks!
I am thinking to factor out the version computation string into a common
function, because we might use it in the other places too.
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-c
Anastasia added inline comments.
Comment at: test/SemaOpenCL/to_addr_builtin.cl:26
@@ +25,3 @@
+#if __OPENCL_C_VERSION__ < CL_VERSION_2_0
+ // expected-error@-2{{'to_global' needs OpenCL version 2.0 or above}}
+#else
@Xiuli, I think Sam is right. Passing constant
rjmccall added a comment.
In http://reviews.llvm.org/D20113#426884, @sdefresne wrote:
> In http://reviews.llvm.org/D20113#425984, @rjmccall wrote:
>
> > This is a good catch, thanks!
>
>
> Thank you for the quick reply.
>
> Please excuse me if I misunderstood you or if my remark appear off the ma
etienneb created this revision.
etienneb added a reviewer: rnk.
etienneb added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The missing keyword "inline" is causing some buildbot to fail.
The symbol is not available.
see:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-mult
rivanvx added a comment.
Could we solve that at a later point? There is one more place where such code
is already used, but this would enlarge the scope of this patch.
If yes, I am wiling to factor it out after this is merged.
http://reviews.llvm.org/D19780
_
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
I don't see how this could be causing the problem, but it's worth a try. They
should be marked inline anyway.
http://reviews.llvm.org/D20180
___
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3229
@@ +3228,3 @@
+/// matches the declarations of j, k, and l, but not f, g, h, or i.
+AST_MATCHER(
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for this!
http://reviews.llvm.org/D19876
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
On Wed, May 11, 2016 at 3:58 PM, don hinton wrote:
> hintonda added a comment.
>
> Great, thanks. Btw, I don't have commit access, so could you land it for me?
Normally, yes, but I'm traveling this week and don't have a computer
that has the source code on it right now. If someone other than me
hintonda added a comment.
Great, thanks. Btw, I don't have commit access, so could you land it for me?
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a comment.
One quick thought: we should probably have a test that includes a macro to make
sure nothing explodes. e.g.,
#define FIELD(T, N) mutable T N
class C {
FIELD(int, RemoveMutable);
FIELD(int, KeepMutable)
Hello all,
According to that Windows mangler takes data type into account. Reference
of std::cin would be translated into ?cin@__1@std@@3V?$basic_istream@DU
?$char_traits@D@__1@std@@@12@A (class std::__1::basic_istream > std::__1::cin). Definition of std::cin, in
contrast, would be translated into
Author: etienneb
Date: Wed May 11 15:09:17 2016
New Revision: 269224
URL: http://llvm.org/viewvc/llvm-project?rev=269224&view=rev
Log:
[tooling] Fix missing inline keyworkd, breaking build bot.
Summary:
The missing keyword "inline" is causing some buildbot to fail.
The symbol is not available.
s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269224: [tooling] Fix missing inline keyworkd, breaking
build bot. (authored by etienneb).
Changed prior to commit:
http://reviews.llvm.org/D20180?vs=56949&id=56954#toc
Repository:
rL LLVM
http://re
On Wed, May 11, 2016 at 1:09 PM, Etienne Bergeron via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: etienneb
> Date: Wed May 11 15:09:17 2016
> New Revision: 269224
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269224&view=rev
> Log:
> [tooling] Fix missing inline keyworkd, breakin
Author: dcoughlin
Date: Wed May 11 15:28:41 2016
New Revision: 269227
URL: http://llvm.org/viewvc/llvm-project?rev=269227&view=rev
Log:
[analyzer] Fix crash in ObjCGenericsChecker
Fix a crash in the generics checker where DynamicTypePropagation tries
to get the superclass of a root class.
This i
Author: eugenezelenko
Date: Wed May 11 15:31:50 2016
New Revision: 269229
URL: http://llvm.org/viewvc/llvm-project?rev=269229&view=rev
Log:
[Clang-tidy] modernize-use-bool-literals: documentation style.
Fix readability-redundant-control-flow warnings in regression test.
Modified:
clang-tools
Author: rsmith
Date: Wed May 11 15:37:46 2016
New Revision: 269231
URL: http://llvm.org/viewvc/llvm-project?rev=269231&view=rev
Log:
Preserve the FoundDecl when performing overload resolution for constructors.
This is in preparation for C++ P0136R1, which switches the model for inheriting
construc
cameron314 added a comment.
I fixed this last July so the details are a little hazy, but fortunately it
turns out I documented what I had found:
> It seems when clang parses an enum declaration, it first parses the
> declaration specifiers, then stops if a semicolon is present.
> The trouble
Author: bruno
Date: Wed May 11 15:58:47 2016
New Revision: 269234
URL: http://llvm.org/viewvc/llvm-project?rev=269234&view=rev
Log:
[VFS][Unittests] Make dir iteration tests depend only on content
Do not rely on any specific order while comparing the results of
directory iteration.
Modified:
rsmith added a comment.
In http://reviews.llvm.org/D20131#427717, @cameron314 wrote:
> I have no way to distinguish between a crash and the normal errors (with
> hidden completions). Is there any other way to test this?
If you use `// RUN: not %clang_cc1 -code-completion-at=[...]`, the test sh
amccarth added inline comments.
Comment at: lib/Driver/MSVCToolChain.cpp:478
@@ +477,3 @@
+
+ const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(),
+ nullptr);
amccarth wrote:
> thakis wrote:
>
cameron314 updated this revision to Diff 56961.
cameron314 added a comment.
Ah, perfect, thanks.
Behold, a test that fails without the patch and passes with it :-)
http://reviews.llvm.org/D20131
Files:
lib/Lex/PPLexerChange.cpp
test/CodeCompletion/include-within-declaration.c
Index: test/C
cameron314 added inline comments.
Comment at: lib/Lex/PPLexerChange.cpp:380-383
@@ -379,4 +379,6 @@
CurLexer->FormTokenWithChars(Result, CurLexer->BufferEnd, tok::eof);
CurLexer.reset();
+if (CurLexerKind == CLK_Lexer)
+ CurLexerKind = CLK_Cachin
etienneb created this revision.
etienneb added reviewers: alexfh, rnk.
etienneb added a subscriber: cfe-commits.
The new API for fixit is in libtooling and the library misc in clang-tidy
didn't had the appropriate dependency.
This commit was breaking some build bots:
http://reviews.llvm.org/D1954
thakis added a comment.
Ok, that seems fine then. Thanks much for checking!
http://reviews.llvm.org/D20136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cameron314 updated this revision to Diff 56964.
cameron314 added a comment.
Here's a test!
http://reviews.llvm.org/D20132
Files:
include/clang-c/Index.h
tools/libclang/CIndex.cpp
unittests/libclang/LibclangTest.cpp
Index: unittests/libclang/LibclangTest.cpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269240: [clang-tidy] Add missing dependency of libtooling to
misc module (authored by etienneb).
Changed prior to commit:
http://reviews.llvm.org/D20182?vs=56963&id=56966#toc
Repository:
rL LLVM
htt
Author: etienneb
Date: Wed May 11 16:32:29 2016
New Revision: 269240
URL: http://llvm.org/viewvc/llvm-project?rev=269240&view=rev
Log:
[clang-tidy] Add missing dependency of libtooling to misc module
Summary:
The new API for fixit is in libtooling and the library misc in clang-tidy
didn't had the
Hi,
Thanks for the patch!
This patch is missing a small, lit-style test case. You can find examples of
test cases here:
extra/test/clang-tidy/
Apart from that, my only other nit-pick is that llvm uses 2-space indents, and
spaces between "if" and "(".
If you reply to this list with an updat
Author: rksimon
Date: Wed May 11 16:55:37 2016
New Revision: 269242
URL: http://llvm.org/viewvc/llvm-project?rev=269242&view=rev
Log:
Fixed msvc warnings
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp
URL:
http://llvm.org/viewvc/llvm-project/
Eugene.Zelenko updated this revision to Diff 56959.
Eugene.Zelenko added a comment.
Herald added subscribers: dschuff, jfb.
Updated from trunk. More Include What You Use warnings fixes.
Repository:
rL LLVM
http://reviews.llvm.org/D18424
Files:
include/clang-c/Index.h
include/clang/Analys
alexfh added a comment.
LG. Thanks for fixing.
Repository:
rL LLVM
http://reviews.llvm.org/D20182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a subscriber: alexfh.
alexfh added a comment.
`inline` seems to be completely redundant here. Can you try removing it and
running whatever build configurations were failing without
http://reviews.llvm.org/D20182?
Repository:
rL LLVM
http://reviews.llvm.org/D20180
___
etienneb added a comment.
I'm sure you're right: they are redundant keywords.
I'm preparing the revert patch, and I'm running tests over multiple build types.
Repository:
rL LLVM
http://reviews.llvm.org/D20180
___
cfe-commits mailing list
cfe-com
hintonda updated this revision to Diff 56984.
hintonda added a comment.
Created helper function and moved most logic there. Also address a
few comments.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/moder
rnk added a comment.
In http://reviews.llvm.org/D20180#427840, @alexfh wrote:
> `inline` seems to be completely redundant here. Can you try removing it and
> running whatever build configurations were failing without
> http://reviews.llvm.org/D20182?
My bad, it's explicit function template sp
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The inline keywords are redundant.
Introduce by this commit to try to fix broken build bots:
http://reviews.llvm.org/D20180
Tested on Debug and Release
Author: compnerd
Date: Wed May 11 18:56:37 2016
New Revision: 269255
URL: http://llvm.org/viewvc/llvm-project?rev=269255&view=rev
Log:
libc++abi: make __cxa_call_unexpected visible
This may be invoked by the compiler, and needs to be made available so that the
users can reference it.
Modified:
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:36
@@ +35,3 @@
+
+bool UseNoexceptCheck::helper(const MatchFinder::MatchResult &Result,
+ const SourceRange
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20189
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
etienneb added a comment.
In http://reviews.llvm.org/D20180#427893, @rnk wrote:
> In http://reviews.llvm.org/D20180#427840, @alexfh wrote:
>
> > `inline` seems to be completely redundant here. Can you try removing it and
> > running whatever build configurations were failing without
> > http://
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:36
@@ +35,3 @@
+
+bool UseNoexceptCheck::helper(const MatchFinder::MatchResult &Result,
+ const SourceRange &Range,
alexfh wrote:
> The name "helper"
Author: etienneb
Date: Wed May 11 19:22:28 2016
New Revision: 269257
URL: http://llvm.org/viewvc/llvm-project?rev=269257&view=rev
Log:
[tooling] Remove redundant inline keyword
Summary:
The inline keywords are redundant.
Introduce by this commit to try to fix broken build bots:
http://reviews.l
erik.pilkington created this revision.
erik.pilkington added a reviewer: rsmith.
erik.pilkington added a subscriber: cfe-commits.
Clang erroneously rejects the following code because it does not find the
default argument for `makeType` :
```
namespace n {
template struct Type {
template
On Wed, May 11, 2016 at 10:46 AM, Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
> > I'm glad to help, but it makes me uneasy to have somebody working on a
> > filesystem abstraction that does not have ready access to test and debug
> > their changes across the major host platforms that LLV
bruno created this revision.
bruno added a reviewer: benlangmuir.
bruno added a subscriber: cfe-commits.
(1) Collect headers under inner frameworks (frameworks inside other
other frameworks).
(2) Make sure we also collect the right header files inside them.
More info on (2):
Consider a dummy fra
Hal,
According to Xinmin's RFC the codegen for 'declare simd' in clang
includes only generation of special (Vector ABI) mangled names for
future vectorized versions of elemental functions. Actual vector
versions must be generated by a backend. Xinmin and his team are working
on this.
The mang
Hi Alexey,
As I recall, Xinmin's RFC discussed encoding the various possible manglings for
vector functions in some attribute. Is that what this does? It is difficult to
tell from the test case what's actually happing here.
-Hal
- Original Message -
> From: "Alexey Bataev"
> To: "Hal
Yes, mangled names for vector versions are added as attributes to the
original function.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
12.05.2016 6:00, Hal Finkel пишет:
> Hi Alexey,
>
> As I recall, Xinmin's RFC discussed encoding the various possible manglings
> What are the platform-specifics for crash reproducing? Shouldn't it
> basically be saving some files and storing some data for reconstructing?
Feature-wise the crash reproducer for modules could "just" work for
windows, there should not be anything platform-specific, I never
tested it on windows
Author: bruno
Date: Wed May 11 22:23:36 2016
New Revision: 269270
URL: http://llvm.org/viewvc/llvm-project?rev=269270&view=rev
Log:
[VFS] Reapply r269100: Reconstruct the VFS overlay tree for more accurate lookup
The way we currently build the internal VFS overlay representation leads
to ineffici
Author: majnemer
Date: Wed May 11 22:51:52 2016
New Revision: 269271
URL: http://llvm.org/viewvc/llvm-project?rev=269271&view=rev
Log:
[MS ABI] Don't crash when zero-initializing a vbase which contains a vbase
Bases can be zero-initialized: the storage is zero-initialized before
the base construc
Author: etienneb
Date: Wed May 11 23:20:04 2016
New Revision: 269274
URL: http://llvm.org/viewvc/llvm-project?rev=269274&view=rev
Log:
Add an AST matcher for string-literal length
Summary:
This patch is adding support for a matcher to check string literal length.
This matcher is used in clang-ti
Bruno, it still fails. See;
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/12119
http://bb.pgr.jp/builders/ninja-clang-i686-msc19-R/builds/2847
On Thu, May 12, 2016 at 12:29 PM Bruno Cardoso Lopes via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bruno
> Date: Wed May
Author: etienneb
Date: Wed May 11 23:32:47 2016
New Revision: 269275
URL: http://llvm.org/viewvc/llvm-project?rev=269275&view=rev
Log:
[clang-tidy] Improve misc-redundant-expression and decrease false-positive
Summary:
This patch is adding support for conditional expression and overloaded
operat
Author: bruno
Date: Wed May 11 23:43:27 2016
New Revision: 269276
URL: http://llvm.org/viewvc/llvm-project?rev=269276&view=rev
Log:
Revert "[VFS] Reapply r269100: Reconstruct the VFS overlay tree for more
accurate lookup"
Reverts r269270, buildbots still failing:
http://lab.llvm.org:8011/builder
Thanks,
Reverted r269276
On Wed, May 11, 2016 at 9:38 PM, NAKAMURA Takumi wrote:
> Bruno, it still fails. See;
> http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/12119
> http://bb.pgr.jp/builders/ninja-clang-i686-msc19-R/builds/2847
>
> On Thu, May 12, 2016 at 12:29 PM Bruno Cardoso
john.tornblom added a comment.
Any suggestions on how to test this? Just check for non-empty string?
http://reviews.llvm.org/D18478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 171 of 171 matches
Mail list logo
