Re: [PATCH] D16797: Update clang support on recent Haiku

korli added a comment. Ping? Repository: rL LLVM http://reviews.llvm.org/D16797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. The last check failed as Cla::Cla() was rewritten to Cla::hector(). http://reviews.llvm.org/D20150 Files: clang-rename/USRLocFinder.cpp test/clang-rename/CtorInitializerTest.cpp Index: test/clang-rename/CtorInitial

Re: [PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Comment at: clang-rename/USRLocFinder.cpp:64 @@ +63,3 @@ + if (Initializer->getSourceOrder() == -1) { +// Ignore implicit initializers. +continue;

Re: [PATCH] D20094: [include-fixer] Add basic documentation.

bkramer marked 2 inline comments as done. Comment at: docs/include-fixer.rst:48 @@ +47,3 @@ +... wait as clang indexes the code base ... + $ ln -s $PWD/find_all_symbols_db.yaml path/to/llvm/source/ # Link database into the source tree. + $ cd path/to/llvm/source ---

Re: [PATCH] D20094: [include-fixer] Add basic documentation.

bkramer updated this revision to Diff 56856. bkramer added a comment. Address review comments. http://reviews.llvm.org/D20094 Files: docs/include-fixer.rst docs/index.rst Index: docs/index.rst === --- docs/index.rst +++ docs/i

[clang-tools-extra] r269161 - clang-rename: fix renaming of field with implicit initializers

Author: vmiklos Date: Wed May 11 03:08:07 2016 New Revision: 269161 URL: http://llvm.org/viewvc/llvm-project?rev=269161&view=rev Log: clang-rename: fix renaming of field with implicit initializers The last check failed as Cla::Cla() was rewritten to Cla::hector(). Reviewers: cfe-commits, klimek

Re: [PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rL269161: clang-rename: fix renaming of field with implicit initializers (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20150?vs=56854&id=56859#toc Repository: rL LLVM http:/

Re: [PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

vmiklos added inline comments. Comment at: clang-rename/USRLocFinder.cpp:64 @@ +63,3 @@ + if (Initializer->getSourceOrder() == -1) { +// Ignore implicit initializers. +continue; klimek wrote: > Add a comment like: > // The source location of i

Re: [PATCH] D19941: [tooling] FixItHint Tooling refactoring

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! Comment at: unittests/Tooling/FixItTest.cpp:37 @@ +36,3 @@ +EXPECT_EQ("foo(x, y)", + tooling::fixit::getText(CE->getSourceRange(), *Context)); + -

Re: [PATCH] D19703: [clang-tidy] Improve misc-redundant-expression and decrease false-positive

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:27 @@ +26,3 @@ + +static void ParseMacroNames(StringRef Option, +std::vector *Result) { N

Re: [PATCH] D20095: [find-all-symbols] Slim SymbolInfo.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D20095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated this revision to Diff 56860. a.sidorin added a comment. Add error checks; replace `NULL` with `nullptr`. http://reviews.llvm.org/D14326 Files: include/clang/AST/ASTImporter.h include/clang/AST/DeclFriend.h lib/AST/ASTImporter.cpp test/ASTMerge/Inputs/class3.cpp test/

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin marked 4 inline comments as done. Comment at: lib/AST/ASTImporter.cpp:5527 @@ -5353,3 +5526,3 @@ FoundD, - /*FIXME:TemplateArgs=*/nullptr); + /*Templ

Re: [PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

joey accepted this revision. joey added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D17578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D20095: [find-all-symbols] Slim SymbolInfo.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269162: [find-all-symbols] Slim SymbolInfo. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20095?vs=56725&id=56862#toc Repository: rL LLVM http://reviews.llvm.org/D20095 Fi

[clang-tools-extra] r269162 - [find-all-symbols] Slim SymbolInfo.

Author: hokein Date: Wed May 11 03:38:21 2016 New Revision: 269162 URL: http://llvm.org/viewvc/llvm-project?rev=269162&view=rev Log: [find-all-symbols] Slim SymbolInfo. Summary: SymbolInfo has some optional fields, which is a bad-smell implementation. For now, we * remove the optional field sinc

Re: [PATCH] D20110: [include-fixer] Improve include paths' minimization.

bkramer added a comment. Making one path relative to another part is a hard problem. We'd need to make this work on windows and possibly also have it working in presence of symlinks. I'd much prefer to make paths in the YAML file relative to the "directory" in the compilation database, which is

Re: [PATCH] D20113: Fix mangled name of method with ns_consumed parameters.

sdefresne added a comment. In http://reviews.llvm.org/D20113#425984, @rjmccall wrote: > This is a good catch, thanks! Thank you for the quick reply. Please excuse me if I misunderstood you or if my remark appear off the mark, this is my first time sending patches to clang. I'm not yet complet

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

alexfh added a comment. Too much noise here as well. Particularly, `someBool == true` should not be changed to `someBool == 1`. Please fix the check and update the results. Comment at: clang-tidy/readability/ImplicitBoolCastCheck.cpp:253 @@ -252,3 +252,3 @@ DestinationT

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. The bottom line is that the fixit in its current form is not particularly useful in most cases. We should try to detect some cases where the replacement is unlikely to be useful, e.g

Re: [PATCH] D20094: [include-fixer] Add basic documentation.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: docs/include-fixer.rst:16 @@ +15,3 @@ + +To use :program:`clang-include-fixer` two databases are required, both can be +generated with existing tools. -

[clang-tools-extra] r269167 - [include-fixer] Add basic documentation.

Author: d0k Date: Wed May 11 04:44:10 2016 New Revision: 269167 URL: http://llvm.org/viewvc/llvm-project?rev=269167&view=rev Log: [include-fixer] Add basic documentation. Differential Revision: http://reviews.llvm.org/D20094 Added: clang-tools-extra/trunk/docs/include-fixer.rst Modified:

Re: [PATCH] D20094: [include-fixer] Add basic documentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269167: [include-fixer] Add basic documentation. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D20094?vs=56856&id=56867#toc Repository: rL LLVM http://reviews.llvm.org/D20094

Re: [PATCH] D19816: [find-all-symbols] Add IWYU private pragma support.

hokein updated this revision to Diff 56872. hokein marked an inline comment as done. hokein added a comment. Rebase to master. http://reviews.llvm.org/D19816 Files: include-fixer/find-all-symbols/CMakeLists.txt include-fixer/find-all-symbols/FindAllSymbols.cpp include-fixer/find-all-symbo

Re: [PATCH] D19816: [find-all-symbols] Add IWYU private pragma support.

hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D19816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20157: Add test for D20156

rovka created this revision. rovka added reviewers: rengolin, resistor, mcrosier, echristo, qcolombet, bogner. rovka added subscribers: llvm-commits, cfe-commits. Herald added a subscriber: joker.eph. This adds a test for PR24071. Its purpose is to make sure that we do not assert after identifyi

Re: [PATCH] D20103: PR27132: Proper mangling for __unaligned qualifier (now with both PR27367 and PR27666 fixed)

andreybokhanko updated this revision to Diff 56874. andreybokhanko added a comment. Patch updated to address David's comments. Yours, Andrey http://reviews.llvm.org/D20103 Files: include/clang/AST/Type.h include/clang/Basic/AddressSpaces.h include/clang/Basic/Attr.td include/clang/Basi

Re: [PATCH] D20103: PR27132: Proper mangling for __unaligned qualifier (now with both PR27367 and PR27666 fixed)

andreybokhanko marked 3 inline comments as done. andreybokhanko added a comment. In http://reviews.llvm.org/D20103#425855, @majnemer wrote: > Can we test pointers to data members? Is it possible to have `__unaligned int > *S::*` or `int *S::* __unaligned` or even `__unaligned int *S::* __unalign

r269170 - [clang][AVX512] completing missing intrinsics for [vpermt2d|vptestm] instruction set.

Author: mzuckerm Date: Wed May 11 06:21:18 2016 New Revision: 269170 URL: http://llvm.org/viewvc/llvm-project?rev=269170&view=rev Log: [clang][AVX512] completing missing intrinsics for [vpermt2d|vptestm] instruction set. Differential Revision: http://reviews.llvm.org/D20096 Modified: cfe/t

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

a.sidorin added a comment. I' d like to have some tests for this. CXXCtorInitializers can be tested with D14224 -like stuff or with ASTMatchers (ASTImporterTest.cpp). Some code samples may be found in CXX/Sema tests, you just need to port/simplify them. ===

Re: [PATCH] D20110: [include-fixer] Improve include paths' minimization.

hokein abandoned this revision. hokein added a comment. Abandon this, in favor of http://reviews.llvm.org/D20158. Repository: rL LLVM http://reviews.llvm.org/D20110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D20158: [find-all-symbols] Save relative file path for each symbol.

hokein added inline comments. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:81 @@ -81,1 +80,3 @@ + /// \brief The file path where the symbol comes from. It's a relative file + /// path based on the build directory. std::string FilePath; One question

Re: [PATCH] D20158: [find-all-symbols] Save relative file path for each symbol.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. LG! Repository: rL LLVM http://reviews.llvm.org/D20158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [PATCH] D20158: [find-all-symbols] Save relative file path for each symbol.

bkramer added inline comments. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:81 @@ -81,1 +80,3 @@ + /// \brief The file path where the symbol comes from. It's a relative file + /// path based on the build directory. std::string FilePath; hokein wrot

r269172 - [clang][AVX512] completing missing set intrinsics

Author: mzuckerm Date: Wed May 11 06:41:29 2016 New Revision: 269172 URL: http://llvm.org/viewvc/llvm-project?rev=269172&view=rev Log: [clang][AVX512] completing missing set intrinsics Differential Revision: http://reviews.llvm.org/D20099 Modified: cfe/trunk/lib/Headers/avx512fintrin.h

Re: [PATCH] D20158: [find-all-symbols] Save relative file path for each symbol.

hokein added inline comments. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:81 @@ -81,1 +80,3 @@ + /// \brief The file path where the symbol comes from. It's a relative file + /// path based on the build directory. std::string FilePath; bkramer wrot

Re: [PATCH] D20158: [find-all-symbols] Save relative file path for each symbol.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269173: [find-all-symbols] Save relative file path for each symbol. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20158?vs=56879&id=56881#toc Repository: rL LLVM http://rev

[clang-tools-extra] r269173 - [find-all-symbols] Save relative file path for each symbol.

Author: hokein Date: Wed May 11 06:50:08 2016 New Revision: 269173 URL: http://llvm.org/viewvc/llvm-project?rev=269173&view=rev Log: [find-all-symbols] Save relative file path for each symbol. Summary: The HeaderSearch::suggestPathToFileForDiagnostics used in include-fixer doesn't work well with

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

Prazek added a comment. In http://reviews.llvm.org/D19105#426903, @alexfh wrote: > returning a bool from a function that is declared to return a typedef to an > integral type that contains `bool` in its name (e.g. `LLVMBool`), and maybe > some other cases. Isn't it LLVMBool issue? I won't ha

Re: [PATCH] D20159: [include-fixer] Add lit-test for relative include path.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Make sure to watch the buildbots when this goes in, there's a lot of potentially system-dependent shell complexity in the test. Repository: rL LLVM http://reviews.llvm.org/D20159

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

thakis added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:478 @@ +477,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(), + nullptr); amccarth wrote: > Yes, it looks in

Re: [PATCH] D20159: [include-fixer] Add lit-test for relative include path.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269177: [include-fixer] Add lit-test for relative include path. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20159?vs=56884&id=56886#toc Repository: rL LLVM http://reviews

[clang-tools-extra] r269177 - [include-fixer] Add lit-test for relative include path.

Author: hokein Date: Wed May 11 07:30:45 2016 New Revision: 269177 URL: http://llvm.org/viewvc/llvm-project?rev=269177&view=rev Log: [include-fixer] Add lit-test for relative include path. Reviewers: bkramer Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D20159 Added:

[clang-tools-extra] r269171 - [clang-tidy] Adds modernize-use-bool-literals check.

Author: staronj Date: Wed May 11 06:33:16 2016 New Revision: 269171 URL: http://llvm.org/viewvc/llvm-project?rev=269171&view=rev Log: [clang-tidy] Adds modernize-use-bool-literals check. Review link: http://reviews.llvm.org/D18745 Added: clang-tools-extra/trunk/clang-tidy/modernize/UseBoolLi

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

TheOneRing added a subscriber: TheOneRing. TheOneRing added a comment. Hi is there any update on this issue, which is blocking https://llvm.org/bugs/show_bug.cgi?id=11446 ? http://reviews.llvm.org/D17983 ___ cfe-commits mailing list cfe-commits@lis

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

On Wed, May 11, 2016 at 8:29 AM, Nico Weber via cfe-commits wrote: > thakis added inline comments. > > > Comment at: lib/Driver/MSVCToolChain.cpp:478 > @@ +477,3 @@ > + > + const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(), > +

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

rivanvx added a comment. Please, can anyone push this? http://reviews.llvm.org/D19780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

cameron314 added a comment. Ah, I was wondering where the tests were. I found this in the CMake file: # FIXME: libclang unit tests are disabled on Windows due # to failures, mostly in libclang.VirtualFileOverlay_*. if(NOT WIN32 AND CLANG_TOOL_LIBCLANG_BUILD) add_subdirectory(libclang)

[PATCH] D20168: [CodeGen] Handle structs directly in AMDGPUABIInfo

rivanvx created this revision. rivanvx added reviewers: arsenm, tstellarAMD. rivanvx added a subscriber: cfe-commits. Herald added a subscriber: kzhuravl. Structs are currently handled as pointer + byval, which makes AMDGPU LLVM backend generate incorrect code when structs are used. This patch ch

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

aturetsk added a comment. Ping. http://reviews.llvm.org/D19274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19941: [tooling] FixItHint Tooling refactoring

etienneb updated this revision to Diff 56907. etienneb marked an inline comment as done. etienneb added a comment. fix nits http://reviews.llvm.org/D19941 Files: include/clang/Tooling/FixIt.h lib/Tooling/CMakeLists.txt lib/Tooling/FixIt.cpp unittests/Tooling/CMakeLists.txt unittests/T

Re: [PATCH] D19941: [tooling] FixItHint Tooling refactoring

etienneb added a comment. I added the "using statements". landing. Comment at: include/clang/Tooling/Fixit.h:35 @@ +34,3 @@ +///used by the following template abstractions. +inline SourceRange getSourceRange(const SourceRange &Range) { return Range; } +

Re: [PATCH] D19703: [clang-tidy] Improve misc-redundant-expression and decrease false-positive

etienneb updated this revision to Diff 56911. etienneb marked an inline comment as done. etienneb added a comment. Herald added a subscriber: klimek. use new API http://reviews.llvm.org/D19703 Files: include/clang/Tooling/FixIt.h lib/Tooling/CMakeLists.txt lib/Tooling/FixIt.cpp unittest

Re: [PATCH] D19703: [clang-tidy] Improve misc-redundant-expression and decrease false-positive

etienneb updated this revision to Diff 56912. etienneb added a comment. fix bad upload http://reviews.llvm.org/D19703 Files: clang-tidy/misc/RedundantExpressionCheck.cpp docs/clang-tidy/checks/misc-redundant-expression.rst test/clang-tidy/misc-redundant-expression.cpp Index: test/clang-t

r269188 - [tooling] FixItHint Tooling refactoring

Author: etienneb Date: Wed May 11 09:31:39 2016 New Revision: 269188 URL: http://llvm.org/viewvc/llvm-project?rev=269188&view=rev Log: [tooling] FixItHint Tooling refactoring Summary: This is the refactoring to lift some FixItHint into tooling. used by: http://reviews.llvm.org/D19807 Reviewers:

[PATCH] D20170: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

flx created this revision. flx added reviewers: alexfh, sbenza. flx added a subscriber: cfe-commits. flx set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D20170 Files: clang-tidy/utils/TypeTraits.cpp test/clang-tidy/performance-unnecessary-value-

Re: [PATCH] D19932: [OpenCL] Add to_{global|local|private} builtin functions.

yaxunl marked 8 inline comments as done. Comment at: lib/Sema/SemaChecking.cpp:480 @@ +479,3 @@ + .getQualifiers().getAddressSpace() == LangAS::opencl_constant) { +S.Diag(Call->getLocStart(), diag::err_opencl_builtin_to_addr_invalid_arg) +<< Call->getArg(0) << Cal

Re: [PATCH] D19932: [OpenCL] Add to_{global|local|private} builtin functions.

yaxunl updated the summary for this revision. yaxunl updated this revision to Diff 56915. yaxunl marked an inline comment as done. yaxunl added a comment. Removed dynamic generation of builtin decl. Added a test for mismatched returned pointee types. http://reviews.llvm.org/D19932 Files: inc

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:478 @@ +477,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(), + nullptr); thakis wrote: > amccarth wrote: >

Re: [PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks! http://reviews.llvm.org/D17578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

cameron314 updated this revision to Diff 56916. cameron314 added a comment. I've added a unit test. http://reviews.llvm.org/D20125 Files: include/clang-c/Index.h tools/libclang/CXSourceLocation.cpp unittests/libclang/LibclangTest.cpp Index: unittests/libclang/LibclangTest.cpp ===

Re: [PATCH] D20170: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

aaron.ballman added a subscriber: aaron.ballman. Comment at: clang-tidy/utils/TypeTraits.cpp:20 @@ -18,1 +19,3 @@ +using namespace ::clang::ast_matchers; + I would prefer this be used locally instead of at namespace scope to avoid potential name collisions. ==

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

On Wed, May 11, 2016 at 11:00 AM, Adrian McCarthy via cfe-commits wrote: > amccarth added inline comments. > > > Comment at: lib/Driver/MSVCToolChain.cpp:478 > @@ +477,3 @@ > + > + const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(), > +

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:478 @@ +477,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(), + nullptr); amccarth wrote: > thakis wrote: >

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

Prazek added inline comments. Comment at: lib/Target/Hexagon/MCTargetDesc/HexagonMCShuffler.cpp:194 @@ -193,3 +193,3 @@ - if (doneShuffling == false) { + if (doneShuffling == 0) { HexagonMCShuffler MCS(MCII, STI, MCB); alexfh wrote: > This is wrong. Of co

Re: [PATCH] D19156: [ms][dll] #27212: Generating of implicit special members should take into account MSVC compatibility version

rnk added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4813 @@ +4812,3 @@ +// and move constructor, so don't attempt to import/export them if +// we have a definition. +auto *CXXC = dyn_cast(MD); Oh, so we were already doing this c

Re: [PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

cameron314 updated this revision to Diff 56917. http://reviews.llvm.org/D20125 Files: include/clang-c/Index.h tools/libclang/CXSourceLocation.cpp unittests/libclang/LibclangTest.cpp Index: unittests/libclang/LibclangTest.cpp =

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

thakis added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:478 @@ +477,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(), + nullptr); amccarth wrote: > amccarth wrote: >

[clang-tools-extra] r269195 - [include-fixer] Always ignore SFINAE contexts.

Author: d0k Date: Wed May 11 10:33:30 2016 New Revision: 269195 URL: http://llvm.org/viewvc/llvm-project?rev=269195&view=rev Log: [include-fixer] Always ignore SFINAE contexts. This could lead to spurious includes being added for identifiers that are supposed to be not available. Modified: c

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

Prazek closed this revision. Prazek added a comment. gg for your first check :) http://reviews.llvm.org/D18745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20171: Support for MSVS default calling convention options (/Gd, /Gz, /Gv, /Gr)

a.makarov created this revision. a.makarov added a reviewer: rnk. a.makarov added a subscriber: cfe-commits. Patch for bug #27711 http://reviews.llvm.org/D20171 Files: include/clang/Basic/LangOptions.def include/clang/Basic/LangOptions.h include/clang/Driver/CC1Options.td include/clang/D

Re: [PATCH] D19547: [clang-tidy] Add FixIt for swapping arguments in string-constructor-checker.

etienneb updated this revision to Diff 56919. etienneb marked an inline comment as done. etienneb added a comment. use new API. code simplification http://reviews.llvm.org/D19547 Files: clang-tidy/misc/StringConstructorCheck.cpp test/clang-tidy/misc-string-constructor.cpp Index: test/clang

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:478 @@ +477,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(), + nullptr); thakis wrote: > amccarth wrote: >

[clang-tools-extra] r269194 - [include-fixer] Also output the location where we found an unknown identifier.

Author: d0k Date: Wed May 11 10:33:28 2016 New Revision: 269194 URL: http://llvm.org/viewvc/llvm-project?rev=269194&view=rev Log: [include-fixer] Also output the location where we found an unknown identifier. For debugging only, makes it a bit easier when there are queries coming out of headers.

Re: [PATCH] D20171: Support for MSVS default calling convention options (/Gd, /Gz, /Gv, /Gr)

rnk added inline comments. Comment at: include/clang/Basic/LangOptions.def:220 @@ -218,3 +219,3 @@ LANGOPT(MRTD , 1, 0, "-mrtd calling convention") BENIGN_LANGOPT(DelayedTemplateParsing , 1, 0, "delayed template parsing") Let's get rid of this and have it use

Re: [PATCH] D19156: [ms][dll] #27212: Generating of implicit special members should take into account MSVC compatibility version

rnk added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4816 @@ -4815,1 +4815,3 @@ +if ((MD->isMoveAssignmentOperator() || + (CXXC && CXXC->isMoveConstructor())) && !getLangOpts().isCompatibleWithMSVC(LangOptions::MSVC2015)) ---

Re: [PATCH] D20171: Support for MSVS default calling convention options (/Gd, /Gz, /Gv, /Gr)

majnemer added a subscriber: majnemer. Comment at: lib/AST/ASTContext.cpp:8604-8606 @@ -8603,5 +8603,5 @@ bool IsCXXMethod) const { // Pass through to the C++ ABI object if (IsCXXMethod) return ABI->getDefaultMethodCa

Re: [PATCH] D20103: PR27132: Proper mangling for __unaligned qualifier (now with both PR27367 and PR27666 fixed)

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D20103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [PATCH] D20171: Support for MSVS default calling convention options (/Gd, /Gz, /Gv, /Gr)

rnk added inline comments. Comment at: lib/AST/ASTContext.cpp:8604-8606 @@ -8603,5 +8603,5 @@ bool IsCXXMethod) const { // Pass through to the C++ ABI object if (IsCXXMethod) return ABI->getDefaultMethodCallConv(IsVar

Re: [PATCH] D20171: Support for MSVS default calling convention options (/Gd, /Gz, /Gv, /Gr)

majnemer added inline comments. Comment at: lib/AST/ASTContext.cpp:8604-8606 @@ -8603,5 +8603,5 @@ bool IsCXXMethod) const { // Pass through to the C++ ABI object if (IsCXXMethod) return ABI->getDefaultMethodCallConv(

Re: [Clang] Convergent Attribute

Hello, >> CUDA? In any case, I don't see how the restriction helps users, and the >> attribute at the IR level has a well-defined meaning regardless. If a user >> were to have a use case, they'd simply find the restriction arbitrary and >> frustrating. > > Yes, CUDA was already considered as w

r269200 - [Hexagon] Avoid spurious failures in test/Driver/hexagon-toolchain-elf.c

Author: kparzysz Date: Wed May 11 11:11:22 2016 New Revision: 269200 URL: http://llvm.org/viewvc/llvm-project?rev=269200&view=rev Log: [Hexagon] Avoid spurious failures in test/Driver/hexagon-toolchain-elf.c Modified: cfe/trunk/test/Driver/hexagon-toolchain-elf.c Modified: cfe/trunk/test/Dri

Re: [PATCH] D20168: [CodeGen] Handle structs directly in AMDGPUABIInfo

arsenm added a comment. Needs tests http://reviews.llvm.org/D20168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r269201 - Update clang support on recent Haiku

Author: rnk Date: Wed May 11 11:19:05 2016 New Revision: 269201 URL: http://llvm.org/viewvc/llvm-project?rev=269201&view=rev Log: Update clang support on recent Haiku [ Copied from https://llvm.org/bugs/show_bug.cgi?id=26404 ] clang support on Haiku is lagging a bit, and missing on x86_64. This

Re: [PATCH] D16797: Update clang support on recent Haiku

This revision was automatically updated to reflect the committed changes. Closed by commit rL269201: Update clang support on recent Haiku (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D16797?vs=53464&id=56929#toc Repository: rL LLVM http://reviews.llvm.org/D16797 File

Re: [PATCH] D19703: [clang-tidy] Improve misc-redundant-expression and decrease false-positive

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:140 @@ +139,3 @@ + const LangOptions &LO = Finder->getASTContext().getLangOpts(); + std::set Names(NameRefs.begi

r269202 - Embed bitcode in object file (clang cc1 part)

Author: steven_wu Date: Wed May 11 11:26:03 2016 New Revision: 269202 URL: http://llvm.org/viewvc/llvm-project?rev=269202&view=rev Log: Embed bitcode in object file (clang cc1 part) Summary: Teach clang to embed bitcode inside bitcode. When -fembed-bitcode cc1 option is used, clang will embed bot

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

This revision was automatically updated to reflect the committed changes. Closed by commit rL269202: Embed bitcode in object file (clang cc1 part) (authored by steven_wu). Changed prior to commit: http://reviews.llvm.org/D17392?vs=56371&id=56930#toc Repository: rL LLVM http://reviews.llvm.o

Re: [PATCH] D19804: Make clang-format cleaner remove redundant commas in list and redundant colon in constructor initializer.

ioeric added a comment. PING http://reviews.llvm.org/D19804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r269116 - Add -Wcast-calling-convention to warn when casting away calling conventions

On Tue, May 10, 2016 at 5:55 PM, Hans Wennborg wrote: >> This warning is currently off by default while we study its usefulness. > > Turns out this wasn't true :-) For example, it's firing here: > https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%28dbg%29/builds/5569/steps/compile/log

Re: [PATCH] D20170: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

alexfh added inline comments. Comment at: clang-tidy/utils/TypeTraits.cpp:20 @@ -18,1 +19,3 @@ +using namespace ::clang::ast_matchers; + aaron.ballman wrote: > I would prefer this be used locally instead of at namespace scope to avoid > potential name collision

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno added a comment. Hi, Comment at: include/clang/Basic/DiagnosticDriverKinds.td:154 @@ -153,1 +153,3 @@ +def err_drv_cxx_not_supported : Error< + "C++ is not supported for target '%0'">; Are you sure there's no equivalente for this already? I'm surprised!

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:39 @@ +38,3 @@ + + const FunctionDecl *FuncDecl = + Result.Nodes.getNodeAs("functionDecl"); s/FunctionDecl/auto/

Re: [PATCH] D19703: [clang-tidy] Improve misc-redundant-expression and decrease false-positive

etienneb added a comment. > We should add a hasAnyOverloadedOperatorName matcher at some point. I proposed it to sbenza@ and he told me that the reason he did HasAnyName was for speed issue. I can't tell if that one has speed issue too. But, otherwise, I agree... for code readability... we s

Re: [PATCH] D19547: [clang-tidy] Add FixIt for swapping arguments in string-constructor-checker.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. http://reviews.llvm.org/D19547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D19703: [clang-tidy] Improve misc-redundant-expression and decrease false-positive

etienneb updated this revision to Diff 56935. etienneb marked an inline comment as done. etienneb added a comment. remove useless set creation http://reviews.llvm.org/D19703 Files: clang-tidy/misc/RedundantExpressionCheck.cpp docs/clang-tidy/checks/misc-redundant-expression.rst test/clang

Patch submission for bug 27400

Hi, I would like to submit a patch for https://llvm.org/bugs/show_bug.cgi?id=27400 . Beside attaching the patch, is there anything I should be aware of? I have not submitted a patch before. You can find the patch attached to this mail. Kind regards, Mads Ravn Index: clang-tidy/misc/MacroParenth

Re: [PATCH] D19703: [clang-tidy] Improve misc-redundant-expression and decrease false-positive

etienneb updated this revision to Diff 56937. etienneb added a comment. fix naming nits http://reviews.llvm.org/D19703 Files: clang-tidy/misc/RedundantExpressionCheck.cpp docs/clang-tidy/checks/misc-redundant-expression.rst test/clang-tidy/misc-redundant-expression.cpp Index: test/clang-

Re: [PATCH] D19703: [clang-tidy] Improve misc-redundant-expression and decrease false-positive

etienneb added a comment. + Removed copy of a vector to a set + Fixed some minor coding-style issues Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:140 @@ +139,3 @@ + const LangOptions &LO = Finder->getASTContext().getLangOpts(); + std::set Names(NameRefs.begin(), Na

Re: [PATCH] D16962: clang-tidy: avoid std::bind

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/AvoidBindCheck.cpp:27 @@ +26,3 @@ + StringRef Tokens; + BindArgumentKind Kind = BK_Other; + size_t PlaceHolderIndex = 0; I wonder whether

  1   2   >