pxli168 added a comment.
You can update the SUMMARY of this diff as we are now using generic codegen
output.
And there are some inline comments about spec.
Comment at: test/SemaOpenCL/to_addr_builtin.cl:25
@@ +24,3 @@
+ glob = to_global(con);
+#if __OPENCL_C_VERSION__ < CL_VER
Author: mzuckerm
Date: Tue May 10 02:30:58 2016
New Revision: 269022
URL: http://llvm.org/viewvc/llvm-project?rev=269022&view=rev
Log:
[Clang][AVX512] completing missing intrinsics [roundscale, ceil, floor]
Differential Revision: http://reviews.llvm.org/D20070
Modified:
cfe/trunk/lib/Heade
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269024: Fixed cppcoreguidelines-pro-type-member-init when
checking records with… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19993?vs=56439&id=56668#toc
Repository:
rL LLV
Author: hokein
Date: Tue May 10 02:42:19 2016
New Revision: 269024
URL: http://llvm.org/viewvc/llvm-project?rev=269024&view=rev
Log:
Fixed cppcoreguidelines-pro-type-member-init when checking records with
indirect fields
Summary:
Fixed a crash in cppcoreguidelines-pro-type-member-init when check
Do we also handle ':'? The corresponding behavior in the linker is in:
http://llvm.org/klaus/lld/blob/master/ELF/DriverUtils.cpp#L-232
-- Sean Silva
On Fri, May 6, 2016 at 12:13 PM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Fri May 6 14:1
pxli168 created this revision.
pxli168 added reviewers: Anastasia, yaxunl.
pxli168 added subscribers: cfe-commits, bader.
OpenCL should support array with const value size length, those const varibale
in global and constant address space and variable in constant address space.
http://reviews.ll
If this is something that GCC doesn't have, it would be nice if we put
something in our own docs about it (something like docs/UsersManual.rst).
On Thu, May 5, 2016 at 2:34 PM, Sriraman Tallam via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, May 5, 2016 at 2:31 PM, Rafael Espíndola
Author: d0k
Date: Tue May 10 03:25:28 2016
New Revision: 269028
URL: http://llvm.org/viewvc/llvm-project?rev=269028&view=rev
Log:
[include-fixer] For now, only add the first suggested include.
We used a std::set which made the picked include somewhat random (well,
lexicographically sorted). Make
Author: d0k
Date: Tue May 10 03:25:31 2016
New Revision: 269029
URL: http://llvm.org/viewvc/llvm-project?rev=269029&view=rev
Log:
[include-fixer] Work around partial names in both directions.
We already handled the case where we had a nested name specifier where
parts from the beginning don't get
Author: d0k
Date: Tue May 10 03:36:56 2016
New Revision: 269030
URL: http://llvm.org/viewvc/llvm-project?rev=269030&view=rev
Log:
[include-fixer] Emit some terminal output so users can see that the tool is
working.
Modified:
clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer.cpp
M
espositofulvio added a comment.
In http://reviews.llvm.org/D11781#423520, @rmaprath wrote:
> @espositofulvio: Thanks for the patch! :)
>
> Committed as r268734.
Glad to see you land the patch! Great work :)
Repository:
rL LLVM
http://reviews.llvm.org/D11781
_
bsmith added a comment.
There is an awful lot of duplication/passing through to another class in this,
it strikes me that this whole thing could benefit from some level of
inheritance. I think it would be good to have a base class that defines the
interface and have both ARM/AArch64 (and any ot
bsmith added inline comments.
Comment at: lib/Driver/Tools.cpp:707
@@ -696,3 +706,3 @@
std::string MArch = arm::getARMArch(ArchName, Triple);
- if (llvm::ARM::parseArch(MArch) == llvm::ARM::AK_INVALID ||
+ if (!checkARMArchValid(MArch) || llvm::ARM::parseArch(MArch) ==
llvm:
rengolin added a comment.
In http://reviews.llvm.org/D20089#425525, @bsmith wrote:
> There is an awful lot of duplication/passing through to another class in
> this, it strikes me that this whole thing could benefit from some level of
> inheritance. I think it would be good to have a base class
bsmith added a comment.
In http://reviews.llvm.org/D20089#425541, @rengolin wrote:
> http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150824/296862.html
>
> One option is to add the duplication, solve all the platform problems first,
> then move to a class based design.
>
> Another is
DmitryPolukhin added a comment.
Richard, friendly ping. It seems that your counterexample cause no issue with
this patch. I added tests to prove it. Could you please take another look?
http://reviews.llvm.org/D18035
___
cfe-commits mailing list
cfe
rengolin added a comment.
In http://reviews.llvm.org/D20089#425542, @bsmith wrote:
> I think that made sense when we only had ARM using this, but not so much now
> since we essentially have two implementations of the same thing.
What about the argument of doing slow and steady changes instead
Author: abataev
Date: Tue May 10 04:57:36 2016
New Revision: 269035
URL: http://llvm.org/viewvc/llvm-project?rev=269035&view=rev
Log:
[OPENMP 4.5] Add codegen support in runtime for '[non]monotonic'
schedule modifiers.
Runtime library expects some additional data in schedule argument for
loop-bas
rengolin added a comment.
Jojo,
Thanks for putting this forward. Regarding Bradley's point, it may be clearer
if we go directly with a class based design, but if it changes the ARM part at
the same time (especially testing), than I'd prefer to avoid it. Can you try
this different approach whil
Author: d0k
Date: Tue May 10 05:12:00 2016
New Revision: 269036
URL: http://llvm.org/viewvc/llvm-project?rev=269036&view=rev
Log:
[include-fixer] Remove unused includes and accessor.
Modified:
clang-tools-extra/trunk/include-fixer/IncludeFixer.cpp
Modified: clang-tools-extra/trunk/include-fi
Author: mzuckerm
Date: Tue May 10 05:14:50 2016
New Revision: 269037
URL: http://llvm.org/viewvc/llvm-project?rev=269037&view=rev
Log:
[Clang][AVX512] completing missing intrinsics [vextractf].
Differential Revision: http://reviews.llvm.org/D20061
Modified:
cfe/trunk/lib/Headers/avx512fintr
bkramer created this revision.
bkramer added reviewers: hokein, djasper, klimek.
bkramer added a subscriber: cfe-commits.
http://reviews.llvm.org/D20094
Files:
docs/include-fixer.rst
docs/index.rst
Index: docs/index.rst
===
---
a.sidorin updated the summary for this revision.
a.sidorin added a reviewer: spyffe.
a.sidorin removed rL LLVM as the repository for this revision.
a.sidorin updated this revision to Diff 56682.
a.sidorin added a comment.
- Some code cleanup
- Add tests not present in http://reviews.llvm.org/D1428
ikudrin added a comment.
Ping...
http://reviews.llvm.org/D17815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin marked 7 inline comments as done.
Comment at: lib/AST/ASTImporter.cpp:5859
@@ +5858,3 @@
+ Expr *ToQueried = Importer.Import(E->getQueriedExpression());
+ if (!ToQueried)
+return nullptr;
I usually prefer allocation with required size at the start
bkramer updated this revision to Diff 56687.
bkramer added a comment.
de-freud
http://reviews.llvm.org/D20094
Files:
docs/include-fixer.rst
docs/index.rst
Index: docs/index.rst
===
--- docs/index.rst
+++ docs/index.rst
@@ -21,
rengolin added a comment.
Bradley, Jojo,
I'm a bit rusty in that part of the code, but that's not really what I was
thinking either.
The way we started this was to have the TargetParser have *all* parsing. So
both check*ArchValid, if necessary, will have to use the TargetParser to parse
the s
Author: abataev
Date: Tue May 10 05:36:51 2016
New Revision: 269039
URL: http://llvm.org/viewvc/llvm-project?rev=269039&view=rev
Log:
[OPENMP 4.0] Fixed codegen for destructors in task-based directives.
If private variables require destructors call at the deletion of the
task, additional flag in
rengolin added a comment.
In http://reviews.llvm.org/D20088#425589, @rengolin wrote:
> In this case, it may be simpler to just rely on the Triple object that
> already exists in the driver, or just the fact that this is in
> getAArch64ArchFeaturesFromMarch() and pass an extra flag to parseArch(
Author: mzuckerm
Date: Tue May 10 06:34:19 2016
New Revision: 269042
URL: http://llvm.org/viewvc/llvm-project?rev=269042&view=rev
Log:
[Clang][AVX512] completing missing intrinsics [vmin/vmax]{sd|sq|uq|ud}.
Differential Revision: http://reviews.llvm.org/D20064
Modified:
cfe/trunk/lib/Header
Author: d0k
Date: Tue May 10 06:35:47 2016
New Revision: 269043
URL: http://llvm.org/viewvc/llvm-project?rev=269043&view=rev
Log:
[include-fixer] Default to YAML db, it's much more useful than the fixed dummy
db.
Modified:
clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer.cpp
Author: abataev
Date: Tue May 10 07:21:02 2016
New Revision: 269050
URL: http://llvm.org/viewvc/llvm-project?rev=269050&view=rev
Log:
[OPENMP 4.5] Initial codegen for 'priority' clause in task-based
directives.
OpenMP 4.5 supports clause 'priority' in task-based directives. Patch
adds initial cod
ioeric updated this revision to Diff 56696.
ioeric added a comment.
- Extended redundant comma cleanup to general lists, and change the way
constructor initializer list is handled. Removed comments cleanup, leave it for
a future patch.
http://reviews.llvm.org/D19804
Files:
lib/Format/Format
Author: mzuckerm
Date: Tue May 10 08:13:54 2016
New Revision: 269056
URL: http://llvm.org/viewvc/llvm-project?rev=269056&view=rev
Log:
[Clang][AVX512] completing missing intrinsics [load/store]
Differential Revision: http://reviews.llvm.org/D20063
Modified:
cfe/trunk/lib/Headers/avx512fintr
bkramer added a subscriber: bkramer.
bkramer added a comment.
Was this change created by a tool?
http://reviews.llvm.org/D20100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with one nit. Thank you!
Comment at: clang-tidy/utils/OptionsUtils.h:21
@@ +20,3 @@
+/// \brief Parse a semicolon separated list of strings.
+std::vector parseStrin
bkramer added inline comments.
Comment at: include-fixer/find-all-symbols/SymbolInfo.cpp:95
@@ -98,1 +94,3 @@
+ auto RHS = std::tie(Symbol.Name, Symbol.FilePath, Symbol.LineNumber);
+ return LHS != RHS ? LHS < RHS : Contexts < Symbol.Contexts;
}
Does folding Co
Author: d0k
Date: Tue May 10 09:04:34 2016
New Revision: 269063
URL: http://llvm.org/viewvc/llvm-project?rev=269063&view=rev
Log:
Remove unused diagnostic. NFC.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL:
ashi1 marked 5 inline comments as done.
ashi1 added a comment.
http://reviews.llvm.org/D17578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kerberizer added a comment.
@DmitryPolukhin: Dmitry, all tests now pass fine on my setup, both on i686 and
x86_64. Thanks for taking care of this issue!
http://reviews.llvm.org/D18035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
ashi1 updated this revision to Diff 56615.
ashi1 added a comment.
Modified the testcase. Tested this diff on clang-test and it passes.
http://reviews.llvm.org/D17578
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCast.cpp
test/CodeGenOpenCL/event_t.cl
test/SemaOpenCL/eve
ashi1 updated this revision to Diff 56599.
ashi1 added a comment.
Added changes for comments from majnemer.
http://reviews.llvm.org/D17578
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCast.cpp
test/CodeGenOpenCL/event_t.cl
test/SemaOpenCL/event_t.cl
Index: test/SemaOp
jojo created this revision.
jojo added reviewers: bsmith, jmolloy, rengolin.
jojo added subscribers: llvm-commits, cfe-commits.
jojo set the repository for this revision to rL LLVM.
jojo changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
Herald a
FlameTop added a comment.
Thank you for the acceptance.
May I please ask you to commit the change for me as I do not have commit access?
cheers
Phil Camp
http://reviews.llvm.org/D19866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
yaxunl marked an inline comment as done.
yaxunl added a comment.
Updated summary.
Comment at: test/SemaOpenCL/to_addr_builtin.cl:25
@@ +24,3 @@
+ glob = to_global(con);
+#if __OPENCL_C_VERSION__ < CL_VERSION_2_0
+ // expected-error@-2{{'to_global' needs OpenCL version 2.0 or a
andreybokhanko created this revision.
andreybokhanko added reviewers: rnk, majnemer, thakis.
andreybokhanko added a subscriber: cfe-commits.
This is exactly same patch as http://reviews.llvm.org/D19654 (already reviewed
and LGTMed by majnemer), with a couple of changes to fix PR27666:
* __unalig
aaron.ballman added a comment.
In http://reviews.llvm.org/D19876#423582, @etienneb wrote:
> Aaron? minus re-generation of the doc.
> Is that what you want to see?
Yes, this is the direction I was hoping for, thank you!
> note: returned types for both getLength are not the same (APInt vs unsig
etienneb updated this revision to Diff 56723.
etienneb added a comment.
fix alexfh comments (renaming)
http://reviews.llvm.org/D19846
Files:
clang-tidy/misc/DanglingHandleCheck.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
clang-tidy/performance/FasterStringFindCheck.cpp
clang-ti
etienneb marked an inline comment as done.
etienneb added a comment.
renaming done, landing.
http://reviews.llvm.org/D19846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: etienneb
Date: Tue May 10 10:31:15 2016
New Revision: 269065
URL: http://llvm.org/viewvc/llvm-project?rev=269065&view=rev
Log:
[clang-tidy] Lift parsing of sequence of names functions to utils.
Summary:
Lift some common code used by multiple checkers.
This function is also used by checke
On Wed, May 4, 2016 at 6:58 PM, Etienne Bergeron wrote:
> etienneb added inline comments.
>
>
> Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:102
> @@ +101,3 @@
> + static clang::CastKind getCastKind(llvm::StringRef AttrKind) {
> +return llvm::StringSwitch(AttrKind)
> +
hokein updated this revision to Diff 56725.
hokein marked an inline comment as done.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D20095
Files:
include-fixer/InMemoryXrefsDB.cpp
include-fixer/XrefsDBManager.cpp
include-fixer/YamlXrefsDB.cpp
include-fixer/find-all-sy
majnemer added a comment.
Can we test pointers to data members? Is it possible to have `__unaligned int
*S::*` or `int *S::* __unaligned` or even `__unaligned int *S::* __unaligned` ?
Comment at: include/clang/AST/Type.h:446
@@ -437,1 +445,3 @@
+ // U qualifier may su
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3229
@@ +3228,3 @@
+/// matches the declarations of j, k, and l, but not f, g, h, or i.
+AST_MATCHER(FunctionDecl, hasDynamicExcept
kevgs added a comment.
Sadly, I dont know such a tool. I was using a simple script to find unused
headers ack --cpp -l 'SmallString\.h"' | xargs grep -L 'SmallString[ (http://reviews.llvm.org/D20100
___
cfe-commits mailing list
cfe-commits@lists.llvm
hokein added inline comments.
Comment at: docs/include-fixer.rst:36
@@ +35,3 @@
+
+The include fixer contains :program:`find-all-symbols`, a tool to create a
+symbol database in YAML format from a compilation database by parsing all
A extra space before a.
=
yaxunl added a comment.
LGTM. Thanks.
http://reviews.llvm.org/D20090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dschuff added a comment.
Ping?
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader accepted this revision.
bader added a reviewer: bader.
bader added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
manmanren added a comment.
After r231508 made changes to promote constant temporaries to globals, the
assert fires when a std::initializer_list is constructed using Objective-C
string literals.
--> Can you explain the code path after r231508 for your example? Will r231508
change the code path
Author: cbieneman
Date: Tue May 10 11:10:22 2016
New Revision: 269069
URL: http://llvm.org/viewvc/llvm-project?rev=269069&view=rev
Log:
[CMake] Pass LLVM_LIBDIR_SUFFIX into Compiler-RT
Not passing this causes Compiler-RT to fail to configure on multi-lib systems.
Modified:
cfe/trunk/runtime/
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch changes the bits used to specify the map types according to the
latest version of the libomptarget document and add the suppo
Author: ericwf
Date: Tue May 10 11:17:43 2016
New Revision: 269070
URL: http://llvm.org/viewvc/llvm-project?rev=269070&view=rev
Log:
[libcxx] Prefer C++14 over C++11 when building libc++experimental.
Summary:
Currently libc++experimental builds with C++11. This patch changes that to
C++14 when s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269070: [libcxx] Prefer C++14 over C++11 when building
libc++experimental. (authored by EricWF).
Changed prior to commit:
http://reviews.llvm.org/D19992?vs=56333&id=56732#toc
Repository:
rL LLVM
htt
jfb accepted this revision.
jfb added a reviewer: jfb.
jfb added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
If a variable is implicitly mapped (doesn't show in a map clause), the runtime
library has to be informed if the corresponding capture s
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
lgtm
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
This is a good catch, thanks!
As a slight adjustment, It's probably better to just ignore this attribute when
mangling the function type of an entity, the same way that we generally don't
mangle return types because they don't affect overloading. That will require
an
Author: chapuni
Date: Tue May 10 12:16:12 2016
New Revision: 269079
URL: http://llvm.org/viewvc/llvm-project?rev=269079&view=rev
Log:
clang/test/CodeGen/avx512f-builtins.c: Fix for -Asserts.
Modified:
cfe/trunk/test/CodeGen/avx512f-builtins.c
Modified: cfe/trunk/test/CodeGen/avx512f-builtins
sdefresne created this revision.
sdefresne added a reviewer: rjmccall.
sdefresne added a subscriber: cfe-commits.
When a function/method use a parameter with "ns_consumed" attribute,
ensure that the mangled name is the same whether -fobjc-arc is used
or not.
Since "ns_consumed" attribute is gener
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
Overall I'm very enthusiastic about this and only have a few nitpicks. Thanks
for the hard work!
Comment at: lib/AST/ASTImporter.cpp:2364
@@ +2363,3 @@
+ if (Arg.
Author: dschuff
Date: Tue May 10 12:44:50 2016
New Revision: 269087
URL: http://llvm.org/viewvc/llvm-project?rev=269087&view=rev
Log:
Clarify condition, remove redundant check
Modified:
cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
URL:
http://llvm.org/vi
Author: dschuff
Date: Tue May 10 12:44:48 2016
New Revision: 269086
URL: http://llvm.org/viewvc/llvm-project?rev=269086&view=rev
Log:
Clean up condition, add ARM to test
Modified:
cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
cfe/trunk/test/CodeGenCXX/static-destructor.cpp
Modified: cfe/trunk/lib/
Author: dschuff
Date: Tue May 10 12:44:46 2016
New Revision: 269085
URL: http://llvm.org/viewvc/llvm-project?rev=269085&view=rev
Log:
Do not register incompatible C++ destructors with __cxa_atexit
Summary:
For a static object with a nontrivial destructor, clang generates an
initializer function (
Author: dschuff
Date: Tue May 10 12:44:52 2016
New Revision: 269088
URL: http://llvm.org/viewvc/llvm-project?rev=269088&view=rev
Log:
more cleanup
Modified:
cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/l
Author: dschuff
Date: Tue May 10 12:44:55 2016
New Revision: 269089
URL: http://llvm.org/viewvc/llvm-project?rev=269089&view=rev
Log:
Introduce CGCXXABI::canCallMismatchedFunctionType
Modified:
cfe/trunk/lib/CodeGen/CGCXXABI.h
cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
cfe/trunk/lib/CodeGen/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269085: Do not register incompatible C++ destructors with
__cxa_atexit (authored by dschuff).
Changed prior to commit:
http://reviews.llvm.org/D19275?vs=56218&id=56751#toc
Repository:
rL LLVM
http:/
dschuff added a comment.
Well, I forgot to squash my local commits before landing, so this is r269085
thru r269089 :(
Repository:
rL LLVM
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
spyffe created this revision.
spyffe added reviewers: sepavloff, a.sidorin.
spyffe added a subscriber: cfe-commits.
spyffe set the repository for this revision to rL LLVM.
spyffe added a project: clang-c.
The AST importer currently does not handle injected class names properly (it
does not bind t
rmaprath created this revision.
rmaprath added reviewers: jroelofs, bcraig.
rmaprath added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This patch is generalization of D19920.
A new native-only libunwind variant (selectable through the
`-DLIBUNWIND_ENABLE_CROSS_UNWINDING=OFF`
Anastasia added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:480
@@ +479,3 @@
+ .getQualifiers().getAddressSpace() == LangAS::opencl_constant) {
+S.Diag(Call->getLocStart(), diag::err_opencl_builtin_to_addr_invalid_arg)
+<< Call->getArg(0) << Call->getDi
rengolin added a subscriber: rengolin.
Comment at: include/libunwind.h:49
@@ -48,1 +48,3 @@
struct unw_context_t {
+#if defined(_LIBUNWIND_NATIVE_I386)
+ uint64_t data[8];
Wouldn't it be a lot simpler to just define a macro _LIBUNWIND_DATA_SIZE or
something and
vsk abandoned this revision.
vsk added a comment.
I haven't measured the performance overhead of this patch. The failure case
it's supposed to protect against is exceptionally rare: we haven't seen it
happen again. In light of that, and considering that it clutters up the code, I
think it'd be
vsk accepted this revision.
vsk added a reviewer: vsk.
vsk added a comment.
This revision is now accepted and ready to land.
Closing old review.
http://reviews.llvm.org/D15674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
rmaprath abandoned this revision.
rmaprath added a comment.
Superseded by http://reviews.llvm.org/D20119.
http://reviews.llvm.org/D19920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Anastasia added inline comments.
Comment at: lib/Sema/SemaType.cpp:2055
@@ -2054,3 +2054,3 @@
- return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser,
- S.LangOpts.GNUMode).isInvalid();
+ return S
+ .VerifyIntege
> CUDA? In any case, I don't see how the restriction helps users, and the
> attribute at the IR level has a well-defined meaning regardless. If a user
> were to have a use case, they'd simply find the restriction arbitrary and
> frustrating.
Yes, CUDA was already considered as well. I just thin
Author: dschuff
Date: Tue May 10 13:35:31 2016
New Revision: 269099
URL: http://llvm.org/viewvc/llvm-project?rev=269099&view=rev
Log:
[WebAssembly] Reduce strictness of static destructor test
It didn't work on non-asserts builds
Modified:
cfe/trunk/test/CodeGenCXX/static-destructor.cpp
Modi
Author: bruno
Date: Tue May 10 13:43:00 2016
New Revision: 269100
URL: http://llvm.org/viewvc/llvm-project?rev=269100&view=rev
Log:
[VFS] Reconstruct the VFS overlay tree for more accurate lookup
The way we currently build the internal VFS overlay representation leads
to inefficient path search a
rmaprath added inline comments.
Comment at: include/libunwind.h:49
@@ -48,1 +48,3 @@
struct unw_context_t {
+#if defined(_LIBUNWIND_NATIVE_I386)
+ uint64_t data[8];
rengolin wrote:
> Wouldn't it be a lot simpler to just define a macro _LIBUNWIND_DATA_SIZE or
>
rmaprath updated this revision to Diff 56779.
rmaprath added a comment.
Address review comments by @rengolin:
- Define and use `_LIBUNWIND_CONTEXT_SIZE` and `_LIBUNWIND_CURSOR_SIZE` macros
http://reviews.llvm.org/D20119
Files:
CMakeLists.txt
include/__libunwind_config.h
include/libunwind
rmaprath marked an inline comment as done.
rmaprath added a comment.
http://reviews.llvm.org/D20119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
etienneb updated this revision to Diff 56781.
etienneb marked 3 inline comments as done.
etienneb added a comment.
add unittests
http://reviews.llvm.org/D19941
Files:
include/clang/Tooling/Fixit.h
lib/Tooling/CMakeLists.txt
lib/Tooling/Fixit.cpp
unittests/Tooling/CMakeLists.txt
unitte
cameron314 created this revision.
cameron314 added a reviewer: rsmith.
cameron314 added a subscriber: cfe-commits.
cameron314 set the repository for this revision to rL LLVM.
This fixes, for example, libclang's `clang_getAllSkippedRanges` returning zero
ranges after reparsing a translation unit.
cameron314 created this revision.
cameron314 added a reviewer: rsmith.
cameron314 added a subscriber: cfe-commits.
All the libclang functions for expanding a location, namely
`clang_getExpansionLocation`, `clang_getPresumedLocation`,
`clang_getInstantiationLocation`, and most surprisingly
`clan
etienneb updated this revision to Diff 56790.
etienneb added a comment.
more unittests
http://reviews.llvm.org/D19941
Files:
include/clang/Tooling/Fixit.h
lib/Tooling/CMakeLists.txt
lib/Tooling/Fixit.cpp
unittests/Tooling/CMakeLists.txt
unittests/Tooling/FixitTest.cpp
Index: unittest
cameron314 created this revision.
cameron314 added a reviewer: rsmith.
cameron314 added a subscriber: cfe-commits.
This patch introduces `CXCursor_AliasAttr`/`CXCursor_WeakAttr` and
`clang_getAliasTargetSpelling()` for inspecting alias attributes via libclang.
http://reviews.llvm.org/D20127
Fil
cameron314 created this revision.
cameron314 added a reviewer: rsmith.
cameron314 added a subscriber: cfe-commits.
All the groundwork for `CXCursor_LinkageSpec` already existed, but because of a
missing case in a switch, cursors of that type were never actually created for
linkage specifications
Author: bruno
Date: Tue May 10 15:20:55 2016
New Revision: 269108
URL: http://llvm.org/viewvc/llvm-project?rev=269108&view=rev
Log:
[VFS] Change unittest to try appeasing win10 buildbot
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/5103
Follow up from r
Author: pcc
Date: Tue May 10 15:23:29 2016
New Revision: 269111
URL: http://llvm.org/viewvc/llvm-project?rev=269111&view=rev
Log:
Update clang for LLVM API change.
Modified:
cfe/trunk/lib/CodeGen/CGVTables.cpp
Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp
URL:
http://llvm.org/viewvc/llvm-pr
1 - 100 of 163 matches
Mail list logo
