yaxunl updated this revision to Diff 56194.
yaxunl added a comment.
Update the test.
http://reviews.llvm.org/D19932
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/Decl.cpp
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaChecking.cpp
lib/Sema/SemaEx
jbcoe added a comment.
After some pondering I think I **will**extend move this check to
cppcoreguidelines and call it rule-of-five.
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c21-if-you-define-or-delete-any-default-operation-define-or-delete-them-all
http://r
jbcoe added inline comments.
Comment at: clang-tidy/readability/ReadabilityTidyModule.cpp:17
@@ -15,2 +16,2 @@
#include "ContainerSizeEmptyCheck.h"
#include "DeletedDefaultCheck.h"
aaron.ballman wrote:
> I believe we use "modernize" to really mean "migrate from
erik.pilkington created this revision.
erik.pilkington added a reviewer: rsmith.
erik.pilkington added a subscriber: cfe-commits.
Previously, `clang::VersionTuple`'s fields were laid out in an unfortunate way
that made the object larger than it ought to have been. This patch just
reorders the fi
twoh updated this revision to Diff 56198.
twoh added a comment.
Rebased on ToT. Thanks @aaron.ballman!
http://reviews.llvm.org/D19062
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
lib/Sema/SemaDecl.cpp
test/FixIt/typo.m
test/Sema/enable_if.c
test/Sema/libbui
Author: kcc
Date: Wed May 4 15:21:47 2016
New Revision: 268540
URL: http://llvm.org/viewvc/llvm-project?rev=268540&view=rev
Log:
document -f[no-]sanitize-recover=all and mention it in warning messages
Modified:
cfe/trunk/docs/UsersManual.rst
cfe/trunk/lib/Driver/SanitizerArgs.cpp
cfe
Author: kcc
Date: Wed May 4 15:24:54 2016
New Revision: 268541
URL: http://llvm.org/viewvc/llvm-project?rev=268541&view=rev
Log:
fix docs
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/UsersManual.rs
Author: ericwf
Date: Wed May 4 15:29:19 2016
New Revision: 268543
URL: http://llvm.org/viewvc/llvm-project?rev=268543&view=rev
Log:
Removing some trailing whitespace
Modified:
libcxx/trunk/test/std/utilities/utility/pairs/pairs.pair/swap.pass.cpp
libcxx/trunk/test/std/utilities/utility/p
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/ReadabilityTidyModule.cpp:17
@@ -15,2 +16,2 @@
#include "ContainerSizeEmptyCheck.h"
#include "DeletedDefaultCheck.h"
jbcoe wrote:
> aaron.ballman wrote:
> > I believe we use "modernize" to r
Author: sbenza
Date: Wed May 4 15:45:00 2016
New Revision: 268548
URL: http://llvm.org/viewvc/llvm-project?rev=268548&view=rev
Log:
Fix the doc extraction script to work with hasAnyName and with equalsNode.
The change from llvm::VariadicFunction to internal::VariadicFunction
broke the extraction
Sounds great. Thanks!
-eric
On Wed, May 4, 2016 at 4:36 AM Andrey Turetskiy
wrote:
> aturetsk added a comment.
>
> Hi,
> Thanks for the review.
>
> Committed:
>
> 1. Add a test for driver options from m_x86_Features_Group (
> http://reviews.llvm.org/rL268487)
> 2. Add missing -mno-cx16 driver o
bcraig created this revision.
bcraig added reviewers: olista01, t.p.northover.
bcraig added a subscriber: cfe-commits.
note_fe_backend_invalid_loc expects three arguments (file, line, column), and
will assert when only given two. The other two places in this file that use
note_fe_backend_invali
Author: aaronballman
Date: Wed May 4 16:08:13 2016
New Revision: 268553
URL: http://llvm.org/viewvc/llvm-project?rev=268553&view=rev
Log:
Add the Pure attribute to C99 builtin functions from ctype.h. This is a
corrected version of r266199 with test case fixes.
Patch by Taewook Oh.
Added:
c
aaron.ballman closed this revision.
aaron.ballman added a comment.
I have commit in r268553
http://reviews.llvm.org/D19062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Wed May 4 16:18:31 2016
New Revision: 268555
URL: http://llvm.org/viewvc/llvm-project?rev=268555&view=rev
Log:
[clang-tidy] Apply NOLINT filtering to Clang warnings.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tools-extra/trunk/
On Wed, May 4, 2016 at 1:43 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> jbcoe wrote:
> > aaron.ballman wrote:
> > > I believe we use "modernize" to really mean "migrate from the old way
> to the new way", which this definitely fits into since I think the point to
> thi
On Tue, May 3, 2016 at 4:38 PM, Paul Robinson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> probinson marked 2 inline comments as done.
>
>
> Comment at: include/clang/Basic/Attr.td:86-88
> @@ -85,1 +85,5 @@
> +def NonParmVar : SubsetSubject +
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D17462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584
@@ -1579,2 +1582,4 @@
case QMM_Result:
+// Presence of __unaligned qualifier shouldn't affect mangling here.
+Quals.removeUnaligned();
if ((!IsPointer && Quals) || isa(T)) {
-
rnk added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584
@@ -1579,2 +1582,4 @@
case QMM_Result:
+// Presence of __unaligned qualifier shouldn't affect mangling here.
+Quals.removeUnaligned();
if ((!IsPointer && Quals) || isa(T)) {
--
etienneb added a comment.
Other opinions?
I'll proceed to the cleanup if no one else has comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1575
@@ +1574,3 @@
+/// \code
+/// char *s = "abcd"; wchar_t *ws = L"abcd";
+/// char *t = "a";
aaron.ballm
What Reid said...
Yours,
Andrey
> 5 мая 2016 г., в 1:48, Reid Kleckner написал(а):
>
> rnk added inline comments.
>
>
> Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584
> @@ -1579,2 +1582,4 @@
> case QMM_Result:
> +// Presence of __unaligned qualifier shouldn't affect m
etienneb added inline comments.
Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:102
@@ +101,3 @@
+ static clang::CastKind getCastKind(llvm::StringRef AttrKind) {
+return llvm::StringSwitch(AttrKind)
+ .Case("CK_Dependent", CK_Dependent)
aaron.ballman w
uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D19891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
dschuff added a comment.
Thanks for the feedback, PTAL
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dschuff updated this revision to Diff 56218.
dschuff added a comment.
- Introduce CGCXXABI::canCallMismatchedFunctionType
http://reviews.llvm.org/D19275
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGDeclCXX.cpp
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/static-destructor.cpp
Index: te
Author: koriakin
Date: Wed May 4 18:37:40 2016
New Revision: 268575
URL: http://llvm.org/viewvc/llvm-project?rev=268575&view=rev
Log:
[SystemZ] Add -mbackchain option.
This option, like the corresponding gcc option, is SystemZ-specific and
enables storing frame backchain links, as specified in t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268575: [SystemZ] Add -mbackchain option. (authored by
koriakin).
Changed prior to commit:
http://reviews.llvm.org/D19891?vs=56072&id=56223#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19891
Fi
Author: alexfh
Date: Wed May 4 19:09:29 2016
New Revision: 268579
URL: http://llvm.org/viewvc/llvm-project?rev=268579&view=rev
Log:
[clang-tidy] Improve -warnings-as-errors tests.
Added:
clang-tools-extra/trunk/test/clang-tidy/werrors-diagnostics.cpp
Modified:
clang-tools-extra/trunk/tes
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6. Regressions were OK.
Repository:
rL LLVM
ht
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584
@@ -1579,2 +1582,4 @@
case QMM_Result:
+// Presence of __unaligned qualifier shouldn't affect mangling here.
+Quals.removeUnaligned();
if ((!IsPointer && Quals) || isa(T)) {
-
Hello,
> I would appreciate a bit more background on this attribute's
> semantics. How would a user know when to add this attribute to their
> function definition? Are there other attributes that cannot be used in
> conjunction with this one? Should this apply to member functions? What
> about Obj
Author: rsmith
Date: Wed May 4 19:56:12 2016
New Revision: 268585
URL: http://llvm.org/viewvc/llvm-project?rev=268585&view=rev
Log:
[modules] Enforce the rules that an explicit or partial specialization must be
declared before it is used. Because we don't use normal name lookup to find
these, the
Author: ahatanak
Date: Wed May 4 20:41:07 2016
New Revision: 268589
URL: http://llvm.org/viewvc/llvm-project?rev=268589&view=rev
Log:
Do not add uwtable attribute by default for MachO targets.
r217178 changed clang to add function attribute uwtable by default on
Win64, which caused the __eh_fram
Author: rsmith
Date: Wed May 4 21:13:49 2016
New Revision: 268594
URL: http://llvm.org/viewvc/llvm-project?rev=268594&view=rev
Log:
Fix implementation of C++'s restrictions on using-declarations referring to
enumerators:
* an unscoped enumerator whose enumeration is a class member is itself a
Author: rsmith
Date: Wed May 4 21:14:06 2016
New Revision: 268595
URL: http://llvm.org/viewvc/llvm-project?rev=268595&view=rev
Log:
Update FIXME.
Modified:
cfe/trunk/lib/Sema/SemaLookup.cpp
Modified: cfe/trunk/lib/Sema/SemaLookup.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/S
etienneb requested changes to this revision.
etienneb added a comment.
This revision now requires changes to proceed.
If the 'original' size is available, the checkers should by-pass the heuristic.
Can you check if there is a way to get the original size.
Comment at: clang-tidy/
rsmith added a comment.
In http://reviews.llvm.org/D19851#420762, @nicholas wrote:
> I did not expand this to SK_BindReferenceToTemporary, please review this
> decision. It's also missing missing bit-field and vector element checks that
> SK_BindReference has.
That's fine. SK_BindReferenceToT
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584
@@ -1579,2 +1582,4 @@
case QMM_Result:
+// Presence of __unaligned qualifier shouldn't affect mangling here.
+Quals.removeUnaligned();
if ((!IsPointer && Quals) || isa(T)) {
-
Author: rsmith
Date: Wed May 4 21:53:55 2016
New Revision: 268600
URL: http://llvm.org/viewvc/llvm-project?rev=268600&view=rev
Log:
Documentation updates for recent changes to VLAs and default-initialization of
const-qualified class objects.
Modified:
cfe/trunk/www/compatibility.html
Modif
nicholas marked 2 inline comments as done.
Comment at: lib/Sema/SemaInit.cpp:3514-3518
@@ +3513,7 @@
+static void CheckForNullPointerDereference(Sema &S, const Expr *E) {
+ // Check to see if we are dereferencing a null pointer. If so,
+ // and if not volatile-qualified, this i
nicholas updated this revision to Diff 56235.
nicholas marked an inline comment as done.
http://reviews.llvm.org/D19851
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaInit.cpp
test/CXX/expr/expr.prim/expr.prim.lambda/p5.cpp
test/Parser/cxx-casting.cpp
test/SemaCXX/cstyle
nicholas updated this revision to Diff 56236.
nicholas added a comment.
(Whoops, forgot to generate diff with full context for phab.)
http://reviews.llvm.org/D19851
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaInit.cpp
test/CXX/expr/expr.prim/expr.prim.lambda/p5.cpp
te
pxli168 added a comment.
Could we output a generic function in CodeGen?
This seems to have no big difference to have a lot of declaration in an opencl
c header file.
http://reviews.llvm.org/D19932
___
cfe-commits mailing list
cfe-commits@lists.llvm
pxli168 added a comment.
If we want to save some space, could we use some macro to expand the gentype or
some script to expand the gentype into each types when the clang is build?
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-comm
Author: ericwf
Date: Thu May 5 01:30:05 2016
New Revision: 268613
URL: http://llvm.org/viewvc/llvm-project?rev=268613&view=rev
Log:
Try and fix sphinx build
Modified:
libcxx/trunk/docs/TestingLibcxx.rst
Modified: libcxx/trunk/docs/TestingLibcxx.rst
URL:
http://llvm.org/viewvc/llvm-project/
101 - 146 of 146 matches
Mail list logo
