davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/CodeGen/CoverageMappingGen.cpp:468
@@ +467,3 @@
+MostRecentLocation == getEndOfFileOrMacro(MostRecentLocation) &&
+isRegionAlreadyAdded(
szdominik added inline comments.
Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:92
@@ +91,3 @@
+ has(expr(ignoringImpCasts(ConcatenatedStringLiteral))),
+ hasParent(varDecl(allOf(hasType(arrayType()), isDefinition()))
+.bind("varDecl")));
szdominik updated this revision to Diff 55741.
szdominik added a comment.
Implement the heuristic in a different (and simpler) way.
Based on the array fillers.
http://reviews.llvm.org/D19769
Files:
clang-tidy/misc/SuspiciousMissingCommaCheck.cpp
docs/clang-tidy/checks/misc-suspicious-missin
faisalv added a comment.
Thanks for running with this! =)
Comment at: include/llvm/Support/TrailingObjects.h:352
@@ +351,3 @@
+template
+using _ =
+llvm::AlignedCharArray::Alignment,
FWIW - while I see your point - the 'underscore' as a name see
Author: mzuckerm
Date: Sun May 1 09:43:43 2016
New Revision: 268196
URL: http://llvm.org/viewvc/llvm-project?rev=268196&view=rev
Log:
[clang][Builtin][AVX512] Adding intrinsics for vmovshdup and vmovsldup
instruction set
Differential Revision: http://reviews.llvm.org/D19595
Modified:
cfe/
apelete updated this revision to Diff 55746.
apelete added a comment.
[clang-analyzer] fix warnings emitted on clang code base
Changes since last revision:
- fast forward rebase on git master branch.
http://reviews.llvm.org/D19084
Files:
lib/AST/ASTDiagnostic.cpp
lib/AST/NestedNameSpecifi
apelete updated this revision to Diff 55747.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Changes since last revision:
- fast forward rebase on git master branch.
http://reviews.llvm.org/D19278
Files:
lib/AST/ExprConstant.cpp
lib/CodeGen/CGDebu
apelete updated this revision to Diff 55748.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Changes since last revision:
- fast forward rebase on git master branch.
http://reviews.llvm.org/D19385
Files:
lib/AST/DeclObjC.cpp
lib/Format/AffectedRan
apelete added a reviewer: rjmccall.
apelete added a comment.
Waiting for review, could someone please have a look at this one ?
http://reviews.llvm.org/D19084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
apelete added a reviewer: pcc.
apelete added a comment.
Waiting for review, could someone please have a look at this one ?
http://reviews.llvm.org/D19278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
apelete added a comment.
Waiting for review, could someone please have a look at this one ?
http://reviews.llvm.org/D19385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hubert.reinterpretcast planned changes to this revision.
hubert.reinterpretcast added a comment.
The alias template hit a build-compiler bug: the substitution of the pack
expansion of `Counts` does not work properly. I am investigating a replacement
with a templated struct with a typedef member.
On Mon, Mar 07, 2016 at 06:30:52PM +0100, Joerg Sonnenberger via cfe-commits
wrote:
> On Mon, Mar 07, 2016 at 05:19:16PM -, Joerg Sonnenberger via cfe-commits
> wrote:
> > Author: joerg
> > Date: Mon Mar 7 11:19:15 2016
> > New Revision: 262838
> >
> > URL: http://llvm.org/viewvc/llvm-proje
On Wed, Feb 24, 2016 at 08:38:24AM -0800, Hans Wennborg via cfe-commits wrote:
> On Wed, Feb 24, 2016 at 5:11 AM, Joerg Sonnenberger via cfe-commits
> wrote:
> > On Wed, Feb 24, 2016 at 03:03:32AM -, James Y Knight via cfe-commits
> > wrote:
> >> Author: jyknight
> >> Date: Tue Feb 23 20:59:3
apelete updated this revision to Diff 55757.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Changes since last revision:
- lib/Format/AffectedRangeManager.cpp: fix typo in class name.
http://reviews.llvm.org/D19385
Files:
lib/AST/DeclObjC.cpp
lib
faisalv added a comment.
Thanks for your response. I don't feel strongly about either of those issues -
especially since it seems you considered the options - and have good reasons
for choosing the alternative.
I would also favor adding in a comment an example of how users are expected to
use
etienneb added a comment.
this is cool :)
It's a simple and precise rule to avoid using the probabilistic heuristic.
Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:94
@@ -93,3 +93,3 @@
Finder->addMatcher(StringsInitializerList.bind("list"), this);
}
--
faisalv added a comment.
*ping*
http://reviews.llvm.org/D18510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
faisalv added a comment.
*ping*
http://reviews.llvm.org/D18495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Igor Kudrin writes:
> ikudrin created this revision.
> ikudrin added reviewers: bogner, davidxl, vsk.
> ikudrin added a subscriber: cfe-commits.
>
> The situation happened when a macro contained a full loop statement,
> which body ended at the end of the macro.
A comment and a nitpick, then LGTM.
Vedant Kumar writes:
> vsk created this revision.
> vsk added a reviewer: bogner.
> vsk added a subscriber: cfe-commits.
>
> Cons: 1 extra malloc per CodeGenFunction instantiation.
>
> Pros: This makes incremental builds noticeably faster, especially on
> my laptop. E.g with this patch there's no
vsk abandoned this revision.
vsk added a comment.
It is a bit messy.
(Aside: I don't think the size of CodeGenPGO is visible with this change, so
unique_ptr/default_delete wouldn't work?)
http://reviews.llvm.org/D19243
___
cfe-commits mailing list
faisalv created this revision.
faisalv added reviewers: rsmith, hubert.reinterpretcast.
faisalv added subscribers: cfe-commits, gnzlbg.
The bug report by Gonzalo (https://llvm.org/bugs/show_bug.cgi?id=27507 -- which
results in clang crashing when generic lambdas that capture 'this' are
instantia
faisalv added a comment.
Is it too soon for a *ping* ;)
p.s. just added some comments.
Comment at: lib/Sema/SemaExprCXX.cpp:904
@@ +903,3 @@
+ for (int I = FunctionScopes.size();
+ I-- && dyn_cast(FunctionScopes[I]);
+ IsFirstIteration = false,
Tha
ariccio updated this revision to Diff 55774.
ariccio added a comment.
Only check for MSVC-specific functions when actually building FOR MSVC (i.e.
`isWindowsMSVCEnvironment`).
Sidenote: is there any reason why none of the `ASTContext&`s are `const`ified
in this file?
http://reviews.llvm.org/D
echristo added a comment.
Hi,
Couple of inline comments. The direction is getting there, but there's some
overall architecture issues to sort out I think.
Thanks!
-eric
Comment at: include/clang/AST/Stmt.h:1555
@@ +1554,3 @@
+ // target feature (by attribute or invocation o
26 matches
Mail list logo
