hokein added a subscriber: hokein.
hokein added a comment.
In http://reviews.llvm.org/D18584#404192, @michael_miller wrote:
> In http://reviews.llvm.org/D18584#403872, @alexfh wrote:
>
> > FYI, the check has started crashing after this patch. I'll try to provide a
> > minimal test case soon. The
hokein updated this revision to Diff 54168.
hokein added a comment.
Address code review comments.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-config/.clang-tidy
tes
hokein marked 5 inline comments as done.
Comment at: clang-tidy/ClangTidyOptions.cpp:163
@@ +162,3 @@
+DefaultOptionsProvider::getRawOptions(llvm::StringRef FileName) {
+ std::vector Result;
+ Result.emplace_back(DefaultOptions, OptionsSourceTypeDefaultBinary);
Author: abataev
Date: Tue Apr 19 04:10:27 2016
New Revision: 266722
URL: http://llvm.org/viewvc/llvm-project?rev=266722&view=rev
Log:
[OPENMP] Codegen for untied tasks.
If the untied clause is present on a task construct, any thread in the team can
resume the task region after a suspension. Patc
Author: abataev
Date: Tue Apr 19 04:27:38 2016
New Revision: 266724
URL: http://llvm.org/viewvc/llvm-project?rev=266724&view=rev
Log:
Revert "[OPENMP] Codegen for untied tasks."
This reverts commit 266722.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
cfe/trunk/lib/CodeGen/CGOpenMP
Prazek added a comment.
ping
Repository:
rL LLVM
http://reviews.llvm.org/D19183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
d.zobnin.bugzilla marked an inline comment as done.
d.zobnin.bugzilla added a comment.
Friendly ping, please take a look.
Thank you,
Denis Zobnin
http://reviews.llvm.org/D18700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
d.zobnin.bugzilla added a comment.
Friendly ping, please take a look.
Thank you,
Denis Zobnin
http://reviews.llvm.org/D18657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rizsotto
Date: Tue Apr 19 07:03:03 2016
New Revision: 266726
URL: http://llvm.org/viewvc/llvm-project?rev=266726&view=rev
Log:
D17487: [analyzer][scan-build-py] flag filter modification for compilation
database creation
Added:
cfe/trunk/tools/scan-build-py/libscanbuild/compilation.py
staronj marked 5 inline comments as done.
staronj added a comment.
http://reviews.llvm.org/D18745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper created this revision.
djasper added a reviewer: alexfh.
djasper added a subscriber: cfe-commits.
http://reviews.llvm.org/D19259
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: lib/Format/UnwrappedLineParser.cpp:1900
@@ +1899,3 @@
+ // to the terminating `;`. For everything else, just return and continue
+ // parsing the s
djasper added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:1016
@@ +1015,3 @@
+ unsigned StoredPosition = Tokens->getPosition();
+ FormatToken *Next = Tokens->getNextToken();
+ FormatTok = Tokens->setPosition(StoredPosition);
-
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D19206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
rizsotto.mailinglist created this revision.
rizsotto.mailinglist added reviewers: zaks.anna, dcoughlin.
rizsotto.mailinglist added a subscriber: cfe-commits.
In python subprocess.check_output is an easy way to collect child process
output. Current implementation does deal with Popen class, which
djasper added inline comments.
Comment at: unittests/Format/FormatTestJS.cpp:339
@@ +338,3 @@
+ "}");
+ verifyFormat("async function* f() {\n"
+ " yield fetch(x);\n"
What does the star mean here? Should we actually introduce a token t
Author: bcraig
Date: Tue Apr 19 07:47:38 2016
New Revision: 266729
URL: http://llvm.org/viewvc/llvm-project?rev=266729&view=rev
Log:
Enable testing for static libc++abi
This change leverages framework changes made in libcxx. See those changes for
more details. (http://reviews.llvm.org/D16544)
So
Author: bcraig
Date: Tue Apr 19 07:49:05 2016
New Revision: 266730
URL: http://llvm.org/viewvc/llvm-project?rev=266730&view=rev
Log:
Framework to allow testing of static libc++abi
These changes make linking against static libraries more explicit. Instead
of using -lc++ and -lc++abi in the tests,
bcraig closed this revision.
bcraig added a comment.
r266730
Comment at: test/libcxx/test/config.py:454
@@ -464,1 +453,3 @@
+else:
+self.cxx.link_flags += ['-lc++']
EricWF wrote:
> In this fallback case do we want to explicitly ask
bcraig closed this revision.
bcraig added a comment.
r266729
http://reviews.llvm.org/D16545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
Awesome! Thank you for tackling this! A few comments.
Comment at: clang-tidy/misc/CMakeLists.txt:38
@@ -37,2 +37,3 @@
UnusedRAIICheck.cpp
UniqueptrResetReleaseCheck.cpp
+ UnusedUsingDeclsCheck.cpp
Please fix file sorting around the
xazax.hun created this revision.
xazax.hun added reviewers: hokein, Eugene.Zelenko.
xazax.hun added subscribers: o.gyorgy, cfe-commits.
This patch fixes PR27410 and adds std::basic_string support.
http://reviews.llvm.org/D19262
Files:
clang-tidy/readability/ContainerSizeEmptyCheck.cpp
test/c
djasper marked 3 inline comments as done.
Comment at: clang-tidy/misc/MiscTidyModule.cpp:123
@@ -121,1 +122,3 @@
+CheckFactories.registerCheck(
+"misc-unused-using-decls");
CheckFactories.registerCheck(
alexfh wrote:
> I think, all "misc-unused-"
djasper updated this revision to Diff 54183.
http://reviews.llvm.org/D19259
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/UnusedAliasDeclsCheck.h
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
docs/clang-tid
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM with one nit.
Comment at: test/clang-tidy/readability-container-size-empty.cpp:44
@@ +43,3 @@
+;
+ // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: the 'empty' me
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266734: [clang-tidy] readability-container-size-empty fixes
(authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D19262?vs=54182&id=54187#toc
Repository:
rL LLVM
http://reviews.llvm
Author: xazax
Date: Tue Apr 19 08:29:05 2016
New Revision: 266734
URL: http://llvm.org/viewvc/llvm-project?rev=266734&view=rev
Log:
[clang-tidy] readability-container-size-empty fixes
Summary: This patch fixes PR27410 and adds std::basic_string support.
Reviewers: Eugene.Zelenko, hokein
Subscri
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with one nit.
Thank you!
Comment at: clang-tidy/misc/MiscTidyModule.cpp:123
@@ -121,1 +122,3 @@
+CheckFactories.registerCheck(
+"misc-unused-using-decls");
Author: djasper
Date: Tue Apr 19 08:48:39 2016
New Revision: 266735
URL: http://llvm.org/viewvc/llvm-project?rev=266735&view=rev
Log:
Initial version of misc-unused-using-decl check.
Added:
clang-tools-extra/trunk/clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tools-extra/trunk/clang-tid
Hi Serge,
this complains on this snippet from v8:
template
class LSubKindOperand final : public LOperand {
public:
static LSubKindOperand* Create(int index, Zone* zone) {
if (index < kNumCachedOperands) return &cache[index];
return new(zone) LSubKindOperand(index);
}
private:
sta
(sorry, accidentally sent this mid-mail)
../../v8/src/crankshaft/lithium.h:322:45: error: instantiation of variable
'v8::internal::LSubKindOperand::cache' required here, but no definition is available
[-Werror,-Wundefined-var-template]
if (index < kNumCachedOperands) return &cache[index];
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266743: clang-format: [JS] simplify import/export. (authored
by mprobst).
Changed prior to commit:
http://reviews.llvm.org/D19242?vs=54124&id=54190#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
mprobst marked an inline comment as done.
mprobst added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D19242
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi Nico,
This message indicates that compiler sees a reference to static member
'cache' of some specialization of template 'LSubKindOperand' (namely
'LSubKindOperand').
This is a static member, so compiler needs corresponding template
definition to instantiate it, but there is no such in the file
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266744: Summary: (authored by mprobst).
Changed prior to commit:
http://reviews.llvm.org/D19206?vs=54019&id=54192#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19206
Files:
cfe/trunk/unittests/
Author: mprobst
Date: Tue Apr 19 09:59:16 2016
New Revision: 266744
URL: http://llvm.org/viewvc/llvm-project?rev=266744&view=rev
Log:
Summary:
clang-format: [JS] unit tests for type aliases.
Also adds a test for "foo as bar" casts.
Spec:
https://github.com/Microsoft/TypeScript/blob/master/doc/sp
Author: mprobst
Date: Tue Apr 19 09:55:37 2016
New Revision: 266743
URL: http://llvm.org/viewvc/llvm-project?rev=266743&view=rev
Log:
clang-format: [JS] simplify import/export.
Summary:
Change `import` and `export` parsing to special case the renaming
syntax (`import x, {y as bar} ...`, `export {
mprobst updated this revision to Diff 54195.
mprobst added a comment.
- test for wrapping
http://reviews.llvm.org/D19204
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestJS.c
mprobst marked an inline comment as done.
Comment at: unittests/Format/FormatTestJS.cpp:339
@@ +338,3 @@
+ "}");
+ verifyFormat("async function* f() {\n"
+ " yield fetch(x);\n"
djasper wrote:
> What does the star mean here? Should we
ikudrin updated this revision to Diff 54189.
ikudrin added a comment.
- Moved the content of `fallback_malloc.ipp` into `falback_malloc.cpp`.
- Removed `fallback_malloc.ipp`.
- Added `pragma GCC visibility push(hidden)` for the function's definitions.
- Added a check that the overwritten `calloc`
Author: mzuckerm
Date: Tue Apr 19 10:18:23 2016
New Revision: 266745
URL: http://llvm.org/viewvc/llvm-project?rev=266745&view=rev
Log:
[Clang][AVX512][BUILTIN] Adding intrinsics support to VEXTRACT{I|F} and
VINSERT{I|F} instruction set
Differential Revision: http://reviews.llvm.org/D19097
Modif
aaron.ballman updated this revision to Diff 54201.
aaron.ballman added a comment.
Addressed review comments:
- Allow the register keyword for C++ code
- Reword the diagnostic to be a bit more clear
- Moved the varargs.cpp test case from Sema to SemaCXX
http://reviews.llvm.org/D19244
Files:
i
aaron.ballman marked 6 inline comments as done.
Comment at: lib/Sema/SemaChecking.cpp:2722
@@ -2720,1 +2721,3 @@
ParamLoc = PV->getLocation();
+ IsCRegister =
+ PV->getStorageClass() == SC_Register && !getLangOpts().CPlusPlus;
That makes sense
Author: aturetsk
Date: Tue Apr 19 10:50:57 2016
New Revision: 266747
URL: http://llvm.org/viewvc/llvm-project?rev=266747&view=rev
Log:
Compilation for Intel MCU (Part 1/3)
Add -miamcu option which:
* Sets IAMCU triple
* Sets IAMCU ABI
* Enforces static compilation
Differential Revision: ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266747: Compilation for Intel MCU (Part 1/3) (authored by
aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D18398?vs=52789&id=54205#toc
Repository:
rL LLVM
http://reviews.llvm.org/D18398
Author: sbenza
Date: Tue Apr 19 10:52:56 2016
New Revision: 266748
URL: http://llvm.org/viewvc/llvm-project?rev=266748&view=rev
Log:
[ASTMatchers] Do not try to memoize nodes we can't compare.
Summary:
Prevent hasAncestor from comparing nodes that are not supported.
hasDescendant was fixed some t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266748: [ASTMatchers] Do not try to memoize nodes we can't
compare. (authored by sbenza).
Changed prior to commit:
http://reviews.llvm.org/D19231?vs=54089&id=54207#toc
Repository:
rL LLVM
http://rev
rnk updated this revision to Diff 54206.
rnk added a comment.
- Address review comments
- Add -Wshadow-all and -Wshadow-field-in-constructor, also address review
comments
- Warn twice under -Wshadow-all if a shadowing parameter is modified
http://reviews.llvm.org/D18271
Files:
include/clang/
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks good to me. I love seeing the death of a target-specific intrinsic!
Tim.
Repository:
rL LLVM
http://reviews.llvm.org/D19099
_
Author: aturetsk
Date: Tue Apr 19 11:25:30 2016
New Revision: 266753
URL: http://llvm.org/viewvc/llvm-project?rev=266753&view=rev
Log:
Revert r266747 (Compilation for Intel MCU (Part 1/3)) since it breaks a few
buildbots.
Removed:
cfe/trunk/test/Driver/miamcu-opt.c
Modified:
cfe/trunk/in
michael_miller created this revision.
michael_miller added reviewers: alexfh, aaron.ballman, hokein.
michael_miller added a subscriber: cfe-commits.
Fixes a crash in cppcoreguidelines-pro-type-member-init when checking some
record types with a constructor without a body. We now check to make sure
Author: abataev
Date: Tue Apr 19 11:27:55 2016
New Revision: 266754
URL: http://llvm.org/viewvc/llvm-project?rev=266754&view=rev
Log:
[OPENMP] Codegen for untied tasks.
If the untied clause is present on a task construct, any thread in the
team can resume the task region after a suspension. Patch
michael_miller added a comment.
In http://reviews.llvm.org/D18584#404901, @hokein wrote:
> In http://reviews.llvm.org/D18584#404192, @michael_miller wrote:
>
> > In http://reviews.llvm.org/D18584#403872, @alexfh wrote:
> >
> > > FYI, the check has started crashing after this patch. I'll try to pr
anemet added a comment.
As discussed under http://reviews.llvm.org/D17864, I did a run with this and I
don't get the indirect call promoted that calls static functions in povray. I
will dig more but do I need to pass some extra flag?
http://reviews.llvm.org/D18624
Author: abataev
Date: Tue Apr 19 11:36:01 2016
New Revision: 266755
URL: http://llvm.org/viewvc/llvm-project?rev=266755&view=rev
Log:
Revert "[OPENMP] Codegen for untied tasks."
This reverts commit r266754.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
cfe/trunk/lib/CodeGen/CGOpenM
Anastasia added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:439
@@ +438,3 @@
+if (LangOpts.OpenCLVersion >= 110)
+ Builder.defineMacro("CL_VERSION_1_1", "110");
+if (LangOpts.OpenCLVersion >= 120)
yaxunl wrote:
> yaxunl wrote:
> > p
xur added a comment.
I did not test Clang based instrumentation with SPEC. I will try it with
povray today.
http://reviews.llvm.org/D18624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
I did not test Clang based instrumentation with SPEC. I will try it with
povray today.
On Tue, Apr 19, 2016 at 9:40 AM, Adam Nemet wrote:
> anemet added a comment.
>
> As discussed under http://reviews.llvm.org/D17864, I did a run with this
> and I don't get the indirect call promoted that calls
Can you also try IR based instrumentation? -fprofile-instr-generate
-Xclang=-fprofile-instrument=llvm
David
On Tue, Apr 19, 2016 at 9:40 AM, Adam Nemet wrote:
> anemet added a comment.
>
> As discussed under http://reviews.llvm.org/D17864, I did a run with this
> and I don't get the indirect c
anemet added a comment.
Thanks, the indirect call is via the All_Intersections macro in
All_CSG_Intersect_Intersections and the top targets are:
All_Sphere_Intersections and All_Plane_Intersections.
http://reviews.llvm.org/D18624
___
cfe-commits m
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D19270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
pcc added a comment.
@rsmith Ping.
http://reviews.llvm.org/D18635
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst updated this revision to Diff 54218.
mprobst added a comment.
- reuse mustBeJSIdent for interface detection
http://reviews.llvm.org/D19240
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
==
mprobst marked an inline comment as done.
mprobst added a comment.
http://reviews.llvm.org/D19240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D19240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
sbenza added a comment.
> > We can proceed with this change if you want, but it is not required
> > anymore. I don't know whether we need the extra complexity of
> > `TemplateArgumentLess`.
>
>
> If this patch is not going to help with performance, I'm happy to abandon it.
It might help i
ab added a comment.
Thanks Ulrich. Tim?
http://reviews.llvm.org/D18998
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mzuckerm
Date: Tue Apr 19 12:10:29 2016
New Revision: 266763
URL: http://llvm.org/viewvc/llvm-project?rev=266763&view=rev
Log:
[Clang][Builtin][AVX512] Adding intrinsics for VGETMANT{PD|PS} and
VGETEXP{PD|PS} instruction set
Differential Revision: http://reviews.llvm.org/D19197
Modifie
yaxunl marked 7 inline comments as done.
Comment at: lib/Frontend/InitPreprocessor.cpp:421
@@ +420,3 @@
+switch (LangOpts.OpenCLVersion) {
+case 0:
+case 100:
yaxunl wrote:
> pxli168 wrote:
> > What is 0 stand for as OpenCLVersion, it seems the default
Author: spatel
Date: Tue Apr 19 12:13:14 2016
New Revision: 266765
URL: http://llvm.org/viewvc/llvm-project?rev=266765&view=rev
Log:
reduce indentation; NFCI
Modified:
cfe/trunk/lib/CodeGen/CGStmt.cpp
Modified: cfe/trunk/lib/CodeGen/CGStmt.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
rsmith added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:6437-6445
@@ +6436,11 @@
+ // Warn immediately if -Wshadow-field-in-constructor is set.
+ Diag(R.getNameLoc(), diag::warn_ctor_parm_shadows_field)
+ << D << FD << FD->getParent();
+ Diag(FD->ge
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Sorry, I thought I'd already commented here. It looked good to me too.
Tim.
http://reviews.llvm.org/D18998
___
cfe-commits mailing
Author: eugenezelenko
Date: Tue Apr 19 12:31:58 2016
New Revision: 266770
URL: http://llvm.org/viewvc/llvm-project?rev=266770&view=rev
Log:
[Release Notes] Mention Clang-tidy misc-unused-using-decls check.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/tr
Author: dougk
Date: Tue Apr 19 12:43:54 2016
New Revision: 266775
URL: http://llvm.org/viewvc/llvm-project?rev=266775&view=rev
Log:
Pass dwarf-version to cc1as.
Fix PR26999 - crashing in cc1as with any '*bsd' target.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/save-tem
aturetsk created this revision.
aturetsk added reviewers: rsmith, bruno, bkramer.
aturetsk added subscribers: cfe-commits, DavidKreitzer, zinovy.nis.
This is the second patch required to support compilation for Intel MCU target
(e.g. Intel(R) Quark(TM) micro controller D 2000).
When IAMCU triple
Author: ab
Date: Tue Apr 19 12:54:24 2016
New Revision: 266783
URL: http://llvm.org/viewvc/llvm-project?rev=266783&view=rev
Log:
[CodeGen] Fix whitespace. NFC.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/viewvc/llvm-proj
Author: ab
Date: Tue Apr 19 12:54:29 2016
New Revision: 266784
URL: http://llvm.org/viewvc/llvm-project?rev=266784&view=rev
Log:
[CodeGen] Widen non-power-of-2 vector HFA base types.
Currently, for the ppc64--gnu and aarch64 ABIs, we recognize:
typedef __attribute__((__ext_vector_type__(3))) fl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266784: [CodeGen] Widen non-power-of-2 vector HFA base
types. (authored by ab).
Changed prior to commit:
http://reviews.llvm.org/D18998?vs=53336&id=54224#toc
Repository:
rL LLVM
http://reviews.llvm.
mgrang added a subscriber: mgrang.
Comment at: lib/Driver/Tools.cpp:580
@@ -573,1 +579,3 @@
+ if (IsIAMCU)
+getToolChain().AddIAMCUIncludeArgs(Args, CmdArgs);
}
Is it better to move this above in the else part of the condition "if
(!IsIAMCU)"?
Author: spatel
Date: Tue Apr 19 13:06:33 2016
New Revision: 266787
URL: http://llvm.org/viewvc/llvm-project?rev=266787&view=rev
Log:
reduce indentation; NFCI
Modified:
cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
URL:
http://llvm.org/viewvc/l
dschuff created this revision.
dschuff added a subscriber: cfe-commits.
Herald added subscribers: dschuff, jfb, aemerson.
For a static object with a nontrivial destructor, clang generates an
initializer function (__cxx_global_var_init) which registers that
object's destructor using __cxa_atexit. H
dschuff added a reviewer: sunfish.
dschuff added a comment.
Will want a reviewer who's involved with ARM too, still looking.
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
This commit is missing a test.
On Fri, Apr 15, 2016 at 5:16 PM Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jlebar
> Date: Fri Apr 15 19:11:11 2016
> New Revision: 266496
>
> URL: http://llvm.org/viewvc/llvm-project?rev=266496&view=rev
> Log:
> [CUDA] Raise an error
Author: spatel
Date: Tue Apr 19 13:17:34 2016
New Revision: 266788
URL: http://llvm.org/viewvc/llvm-project?rev=266788&view=rev
Log:
[builtin_expect] tighten checks, add test, add comments
Modified:
cfe/trunk/test/CodeGen/builtin-expect.c
Modified: cfe/trunk/test/CodeGen/builtin-expect.c
URL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266789: clang-format: [JS] support `interface` as a free
standing identifier. (authored by mprobst).
Changed prior to commit:
http://reviews.llvm.org/D19240?vs=54218&id=54232#toc
Repository:
rL LLVM
jfb added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:94
@@ -92,2 +93,3 @@
if (dtorKind == QualType::DK_cxx_destructor &&
- (record = type->getAsCXXRecordDecl())) {
+ (record = type->getAsCXXRecordDecl()) &&
+ (!CGM.getCXXABI().HasThisReturn(
-
djasper added inline comments.
Comment at: unittests/Format/FormatTestJS.cpp:339
@@ +338,3 @@
+TEST_F(FormatTestJS, AsyncFunctions) {
+ verifyFormat("async function f() {\n"
+ " let x = 1;\n"
Fundamentally, I think there is two things we might need
ioeric updated this revision to Diff 54233.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- Rebased
- Make Formatter and Cleaner inherit from TokenAnalyzer (new name for
CodeProcessor).
http://reviews.llvm.org/D18551
Files:
include/clang/Format/Format.h
lib/Format/Affect
Yes, in general our testing story around the CUDA installs needs work.
In particular, our wrapper headers are complicated and fragile, and
have zero coverage at the moment. That's why Art is working on
getting CUDA tests into the test-suite.
It's possible to test this particular change without ac
mprobst marked an inline comment as done.
Comment at: unittests/Format/FormatTestJS.cpp:339
@@ +338,3 @@
+TEST_F(FormatTestJS, AsyncFunctions) {
+ verifyFormat("async function f() {\n"
+ " let x = 1;\n"
djasper wrote:
> Fundamentally, I think there
I don't really understand why having to change the test when we change the
code it test changes...
We have several fake install trees in the driver tests to check pretty much
exactly these kinds of things?
On Tue, Apr 19, 2016 at 11:31 AM Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org>
PING.
On Thu, Apr 14, 2016 at 1:52 PM Eric Liu wrote:
> ioeric updated this revision to Diff 53691.
> ioeric added a comment.
>
> - Addressed reviewer comment.
>
>
> http://reviews.llvm.org/D19106
>
> Files:
> lib/Format/TokenAnnotator.h
>
> Index: lib/Format/TokenAnnotator.h
> ===
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: lib/Format/TokenAnnotator.h:128
@@ +127,3 @@
+ bool startsWithInternal(const FormatToken *Tok, A K1) const {
+// Even though we skip comments in
> I don't really understand why having to change the test when we change the
> code it test changes...
My thought was, this code isn't really testing how we detect a CUDA
installation. That's a separate matter, involving --cuda-path,
various default locations we check, and so on.
Anyway I now s
Author: eugenezelenko
Date: Tue Apr 19 13:49:21 2016
New Revision: 266795
URL: http://llvm.org/viewvc/llvm-project?rev=266795&view=rev
Log:
[Clang-tidy] Fix extra semicolon warning in
cppcoreguidelines/ProTypeMemberInitCheck.cpp.
Modified:
clang-tools-extra/trunk/clang-tidy/cppcoreguideline
Author: jlebar
Date: Tue Apr 19 13:52:28 2016
New Revision: 266796
URL: http://llvm.org/viewvc/llvm-project?rev=266796&view=rev
Log:
[CUDA] Add a test for r266496 (raise an error if a CUDA installation isn't
found)
Added:
cfe/trunk/test/Driver/cuda-not-found.cu
Added: cfe/trunk/test/Driver/
Committed a test in r266796.
On Tue, Apr 19, 2016 at 11:42 AM, Justin Lebar wrote:
>> I don't really understand why having to change the test when we change the
>> code it test changes...
>
> My thought was, this code isn't really testing how we detect a CUDA
> installation. That's a separate m
Author: dougk
Date: Tue Apr 19 13:55:53 2016
New Revision: 266797
URL: http://llvm.org/viewvc/llvm-project?rev=266797&view=rev
Log:
Fix PR26999 better- RenderDebugEnablingArgs() once only
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
http://llvm.org/
Author: mren
Date: Tue Apr 19 14:05:03 2016
New Revision: 266800
URL: http://llvm.org/viewvc/llvm-project?rev=266800&view=rev
Log:
ObjC Class Property: don't emit class properties on old deployment targets.
For old deployment targets, emit nil for all class property lists.
rdar://25616128
Modif
1 - 100 of 160 matches
Mail list logo
